Re: [PATCH 09/18] xstat: Make special system filesystems return FS_SPECIAL_FL [ver #6]

2010-07-19 Thread David Howells
Christoph Hellwig h...@infradead.org wrote: special is not a very useful identifier. Also what you are returning is per-filesystem data, not per-file. This needs to go into statfs, not into stat. We're about to introduce flags for statfs, so try to do it ontop of those. The same thing

Re: [PATCH 02/18] xstat: Add a pair of system calls to make extended file stats available [ver #6]

2010-07-19 Thread Linus Torvalds
On Mon, Jul 19, 2010 at 9:15 AM, David Howells dhowe...@redhat.com wrote: Linus Torvalds torva...@linux-foundation.org wrote:  - that whole xstat buffer handling is just a mess. I think you already fixed the xstat_parameters crud and just made it a simple unsigned long and a direct argument,

Re: [PATCH 02/18] xstat: Add a pair of system calls to make extended file stats available [ver #6]

2010-07-19 Thread Linus Torvalds
On Mon, Jul 19, 2010 at 10:26 AM, David Howells dhowe...@redhat.com wrote: Ask your samba people, for example, if they'd _ever_ do just a xstat()? I suspect they would, though maybe they can say otherwise.  What about SMB directory enumeration?  I believe that is effectively

Re: [PATCH 10/15] fs: cifs: check kmalloc() result

2010-07-19 Thread Jeff Layton
On Fri, 16 Jul 2010 11:35:30 -0500 Dave Kleikamp sha...@linux.vnet.ibm.com wrote: On Fri, 2010-07-16 at 20:15 +0400, Kulikov Vasiliy wrote: If kmalloc() fails exit with -ENOMEM. Looks good to me. Add my ack if you want it. Signed-off-by: Kulikov Vasiliy sego...@gmail.com Acked-by:

Re: [PATCH 10/15] fs: cifs: check kmalloc() result

2010-07-19 Thread Steve French
merged into cifs-2.6.git On Fri, Jul 16, 2010 at 11:15 AM, Kulikov Vasiliy sego...@gmail.com wrote: If kmalloc() fails exit with -ENOMEM. Signed-off-by: Kulikov Vasiliy sego...@gmail.com ---  fs/cifs/readdir.c |    5 +  1 files changed, 5 insertions(+), 0 deletions(-) diff --git