Re: [PATCH 1/6] Add a dentry op to handle automounting rather than abusing follow_link() [ver #2]

2010-07-27 Thread David Howells
Ian Kent ra...@themaw.net wrote: Is this something others need? Not as far as I know... I think autofs is the only one doing out-of-kernel automounting. That doesn't mean it shouldn't be provided, though... Again, the exists vs not yet exists case for paths within indirect autofs mounts.

[PATCH] mount.cifs: handle the mand and nomand mount options (try #2)

2010-07-27 Thread Jeff Layton
These are filesystem-independent mount options that get passed to mount.cifs too. Handle them appropriately by enabling and disabling MS_MANDLOCK and not handing them off to the kernel. Also, don't set MS_MANDLOCK by default. There's no reason to ask the kernel to enforce mandatory locking by

Re: [PATCH 1/6] Add a dentry op to handle automounting rather than abusing follow_link() [ver #2]

2010-07-27 Thread Ian Kent
On Tue, 2010-07-27 at 09:48 +0100, David Howells wrote: Ian Kent ra...@themaw.net wrote: Is this something others need? Not as far as I know... I think autofs is the only one doing out-of-kernel automounting. That doesn't mean it shouldn't be provided, though... Again, the exists

Re: [PATCH] cifs: fsc should not default to on

2010-07-27 Thread Suresh Jayaraman
On 07/26/2010 11:55 PM, Jeff Layton wrote: I'm not sure why this was merged with this flag hardcoded on, but it seems quite dangerous. Turn it off. Mea culpa.. I forgot to remove this during the second post. Also, mount.cifs hands unrecognized options off to the kernel so there should be no

Re: [PATCH 09/18] xstat: Make special system filesystems return FS_SPECIAL_FL [ver #6]

2010-07-27 Thread David Howells
David Howells dhowe...@redhat.com wrote: Also, not all the flags are per-filesystem. The following are: FS_SPECIAL_FL /* Special file as found in procfs/sysfs */ FS_REMOTE_FL/* File is remote */ Actually, that last is not true; FS_REMOTE_FL is per-file,

[PATCH] cifs: document 'fsc' mount option

2010-07-27 Thread Suresh Jayaraman
Document the newly added local caching feature using FS-Cache. This patch could be queued and considered once the local caching patches gets merged upstream. Signed-off-by: Suresh Jayaraman sjayara...@suse.de --- doc/mount.cifs.8.xml | 17 + 1 files changed, 17 insertions(+), 0

[PATCH] cifs: add 'fsc' mount option to the usage help text

2010-07-27 Thread Suresh Jayaraman
Add 'fsc' mount option to the 'Less commonly used options' section of mount.cifs usage help text. As with the previous patch, this one too could be queued and considered once the local caching patches gets merged upstream. Signed-off-by: Suresh Jayaraman sjayara...@suse.de --- mount.cifs.c |

Re: [PATCH] cifs: document 'fsc' mount option

2010-07-27 Thread Jeff Layton
On Tue, 27 Jul 2010 19:20:00 +0530 Suresh Jayaraman sjayara...@suse.de wrote: Document the newly added local caching feature using FS-Cache. This patch could be queued and considered once the local caching patches gets merged upstream. Signed-off-by: Suresh Jayaraman sjayara...@suse.de ---

Re: [PATCH] cifs: document 'fsc' mount option

2010-07-27 Thread Steve French
Yes - I agree with Jeff, need to add the mention of the config option and perhaps how to tell if fsc feature is available in kernel. On Tue, Jul 27, 2010 at 9:33 AM, Jeff Layton jlay...@redhat.com wrote: On Tue, 27 Jul 2010 19:20:00 +0530 Suresh Jayaraman sjayara...@suse.de wrote: Document

Re: [PATCH] cifs: document 'fsc' mount option

2010-07-27 Thread Jeff Layton
On Tue, 27 Jul 2010 10:13:14 -0500 Steve French smfre...@gmail.com wrote: Yes - I agree with Jeff, need to add the mention of the config option and perhaps how to tell if fsc feature is available in kernel. How would one tell? :) On Tue, Jul 27, 2010 at 9:33 AM, Jeff Layton

Re: [PATCH] cifs: document 'fsc' mount option

2010-07-27 Thread Steve French
scripts/extract-ikconfig could be run against the image (or look at /proc/config.gz) - but unless there is an easier way to view kernel config options on particular distros via distro specific tools - probably easier just to note that CONFIG_FSCACHE must be selected in the kernel build (since it

Re: [PATCH] cifs: document 'fsc' mount option

2010-07-27 Thread Jeff Layton
On Tue, 27 Jul 2010 10:21:51 -0500 Steve French smfre...@gmail.com wrote: scripts/extract-ikconfig could be run against the image (or look at /proc/config.gz) - but unless there is an easier way to view kernel config options on particular distros via distro specific tools - probably easier

Re: [PATCH] cifs: document 'fsc' mount option

2010-07-27 Thread Suresh Jayaraman
On 07/27/2010 08:51 PM, Steve French wrote: scripts/extract-ikconfig could be run against the image (or look at /proc/config.gz) - but unless there is an easier way to view kernel config options on particular distros via distro specific tools - probably easier just to note that CONFIG_FSCACHE

Re: [PATCH] cifs: document 'fsc' mount option

2010-07-27 Thread Steve French
On Tue, Jul 27, 2010 at 11:33 AM, Suresh Jayaraman sjayara...@suse.de wrote: On 07/27/2010 08:51 PM, Steve French wrote: scripts/extract-ikconfig could be run against the image (or look at /proc/config.gz) - but unless there is an easier way to view kernel config options on particular distros

Re: [PATCH] cifs: document 'fsc' mount option

2010-07-27 Thread Jeff Layton
On Tue, 27 Jul 2010 19:20:00 +0530 Suresh Jayaraman sjayara...@suse.de wrote: Document the newly added local caching feature using FS-Cache. This patch could be queued and considered once the local caching patches gets merged upstream. Signed-off-by: Suresh Jayaraman sjayara...@suse.de ---

Re: [PATCH] cifs.upcall: require a uid= or creduid= parm

2010-07-27 Thread Jeff Layton
On Mon, 26 Jul 2010 13:05:28 -0400 Jeff Layton jlay...@samba.org wrote: Even though all known kernels send the uid= parm to userspace, cifs.upcall doesn't technically require it. It should though. If one wasn't sent for some reason, then the setuid wouldn't occur. Error out if there is no

Re: [PATCH] cifs: add 'fsc' mount option to the usage help text

2010-07-27 Thread Jeff Layton
On Tue, 27 Jul 2010 19:26:46 +0530 Suresh Jayaraman sjayara...@suse.de wrote: Add 'fsc' mount option to the 'Less commonly used options' section of mount.cifs usage help text. As with the previous patch, this one too could be queued and considered once the local caching patches gets merged

Re: [PATCH] mount.cifs: handle the mand and nomand mount options

2010-07-27 Thread Jeff Layton
On Mon, 26 Jul 2010 13:05:29 -0400 Jeff Layton jlay...@samba.org wrote: These are filesystem-independent mount options that get passed to mount.cifs too. Handle them appropriately by enabling and disabling MS_MANDLOCK and not handing them off to the kernel. Signed-off-by: Jeff Layton

[PATCH] mount.cifs: document 'fsc' mount option

2010-07-27 Thread Suresh Jayaraman
Changes since last post: - added the information about the kernel CONFIG option - also added the information that caching is currently enabled for files opened as read-only Document the newly added local caching feature using FS-Cache. This patch could be queued and considered

Re: [PATCH] mount.cifs: document 'fsc' mount option

2010-07-27 Thread Jeff Layton
On Tue, 27 Jul 2010 22:18:10 +0530 Suresh Jayaraman sjayara...@suse.de wrote: Changes since last post: - added the information about the kernel CONFIG option - also added the information that caching is currently enabled for files opened as read-only Document the newly added

[PATCH 0/4] cifs-utils: add -Wextra to CFLAGS and fix up warnings

2010-07-27 Thread Jeff Layton
This patchset adds the -Wextra flag to CFLAGS and fixes up some of the warnings that that generates. There are still some others that I'm not sure how best to fix yet. Jeff Layton (4): automake: add -Wextra to CFLAGS mtab: add __attribute__((unused)) to unused variables cifs.upcall: swap

[PATCH 1/4] automake: add -Wextra to CFLAGS

2010-07-27 Thread Jeff Layton
...for extra warning goodness. Signed-off-by: Jeff Layton jlay...@samba.org --- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index 1cf7d23..c53c9ec 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,4 +1,4 @@ -AM_CFLAGS = -Wall

[PATCH 2/4] mtab: add __attribute__((unused)) to unused variables

2010-07-27 Thread Jeff Layton
...to silence -Wextra warnings. Signed-off-by: Jeff Layton jlay...@samba.org --- mtab.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mtab.c b/mtab.c index 70789bc..de1aabd 100644 --- a/mtab.c +++ b/mtab.c @@ -51,12 +51,12 @@ static int lockfile_fd = -1; static int

[PATCH 4/4] data_blob: change for loop indices to a unsigned int

2010-07-27 Thread Jeff Layton
To silence these warnings: data_blob.c: In function ‘data_blob_hex_string_lower’: data_blob.c:155:16: warning: comparison between signed and unsigned integer expressions data_blob.c: In function ‘data_blob_hex_string_upper’: data_blob.c:172:16: warning: comparison between signed and unsigned

[PATCH 3/4] cifs.upcall: swap c99 initializers for memset calls

2010-07-27 Thread Jeff Layton
gcc says: cifs.upcall.c: In function ‘cifs_krb5_get_req’: cifs.upcall.c:261:2: warning: missing initializer cifs.upcall.c:261:2: warning: (near initialization for ‘in_creds.client’) cifs.upcall.c: In function ‘main’: cifs.upcall.c:622:9: warning: missing initializer cifs.upcall.c:622:9: warning:

Re: [PATCH] cifs: document 'fsc' mount option

2010-07-27 Thread Randy Dunlap
On Tue, 27 Jul 2010 11:38:20 -0500 Steve French wrote: On Tue, Jul 27, 2010 at 11:33 AM, Suresh Jayaraman sjayara...@suse.de wrote: On 07/27/2010 08:51 PM, Steve French wrote: scripts/extract-ikconfig could be run against the image (or look at /proc/config.gz) - but unless there is an

Re: [PATCH 02/18] xstat: Add a pair of system calls to make extended file stats available [ver #6]

2010-07-27 Thread Neil Brown
On Thu, 22 Jul 2010 10:24:17 -0700 Linus Torvalds torva...@linux-foundation.org wrote: Of people can just use xattrs and do it all entirely in user space. I assume that's what samba does now, even outside of birthtime. Much as I despise xattrs, this would definitely be my preference. ctime