Re: [PATCH 1/8] cifs: add mfsymlinks mount option

On 08/03/2010 08:35 PM, Stefan Metzmacher wrote: This is the start for an implementation of Minshall+French Symlinks (see http://wiki.samba.org/index.php/UNIX_Extensions#Minshall.2BFrench_symlinks). Signed-off-by: Stefan Metzmacher me...@samba.org --- fs/cifs/README |5 +

Re: [PATCH 2/8] cifs: add CIFSCreateMFSymLink() and CIFSQueryMFSymLink() as stubs

On 08/03/2010 08:35 PM, Stefan Metzmacher wrote: Signed-off-by: Stefan Metzmacher me...@samba.org --- fs/cifs/link.c | 34 ++ 1 files changed, 30 insertions(+), 4 deletions(-) diff --git a/fs/cifs/link.c b/fs/cifs/link.c index 473ca80..2358a5f 100644 ---

Re: [PATCH 5/8] cifs: implement CIFSCheckMFSymlink()

On 08/04/2010 07:41 PM, Stefan Metzmacher wrote: Signed-off-by: Stefan Metzmacher me...@samba.org --- fs/cifs/link.c | 65 1 files changed, 65 insertions(+), 0 deletions(-) diff --git a/fs/cifs/link.c b/fs/cifs/link.c index

[PATCH] cifs: update README to include details about 'fsc' option

Signed-off-by: Suresh Jayaraman sjayara...@suse.de --- fs/cifs/README | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/fs/cifs/README b/fs/cifs/README index a7081ee..7099a52 100644 --- a/fs/cifs/README +++ b/fs/cifs/README @@ -301,6 +301,16 @@ A partial list of

[PATCH 2/3] cifs: consolidate error handling in several functions

cifs has a lot of complicated functions that have to clean up things on error, but some of them don't have all of the cleanup code well-consolidated. Clean up and consolidate error handling in several functions. This is in preparation of later patches that will need to put references to the tcon

[PATCH 0/3] cifs: error handling cleanups

This patchset is a set of error handling cleanup patches. They shouldn't make any changes in behavior themselves, but are some prerequisite patches for the multiuser mount patchsets I'm working on. Please consider them for 2.6.36. The patches are all in the cifs-2.6.36 branch of my git tree:

[PATCH 3/3] cifs: eliminate redundant xdev check in cifs_rename

The VFS always checks that the source and target of a rename are on the same vfsmount, and hence have the same superblock. So, this check is redundant. Remove it and simplify the error handling. Signed-off-by: Jeff Layton jlay...@redhat.com --- fs/cifs/inode.c | 30

[PATCH 1/3] cifs: clean up error handling in cifs_mknod

Get rid of some nesting and add a label we can goto on error. Signed-off-by: Jeff Layton jlay...@redhat.com --- fs/cifs/dir.c | 153 - 1 files changed, 76 insertions(+), 77 deletions(-) diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index

Re: Build infrastructure for storing NTLM creds in kernel keyring

First, it looks like there are some problems with newlines. The new files that were added seem to have CR+LF line terminators. There are also quite a few whitespace problems in there -- spaces leading tabs, etc. In general, we follow kernel coding style with cifs-utils, so running your patches

Re: Build infrastructure for storing NTLM creds in kernel keyring

On Thu, 5 Aug 2010 19:43:57 +0400 Igor Druzhinin jaxbr...@gmail.com wrote: First, it looks like there are some problems with newlines. The new files that were added seem to have CR+LF line terminators. There are also quite a few whitespace problems in there -- spaces leading tabs, etc. In

[PATCH 5/7] cifs: implement CIFSCreateMFSymLink()

Signed-off-by: Stefan Metzmacher me...@samba.org --- fs/cifs/link.c | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) diff --git a/fs/cifs/link.c b/fs/cifs/link.c index 500d912..4237901 100644 --- a/fs/cifs/link.c +++ b/fs/cifs/link.c @@

[PATCH 6/7] cifs: use Minshall+French symlink functions

If configured, Minshall+French Symlinks are used against all servers. If the server supports UNIX Extensions, we still create Minshall+French Symlinks on write, but on read we fallback to UNIX Extension symlinks. Signed-off-by: Stefan Metzmacher me...@samba.org --- fs/cifs/cifs_fs_sb.h |1 +