[PATCH] cifs: revert needless change in decode_negTokenInit

2010-08-30 Thread Jeff Layton
9fbc590860e75785bdaf8b83e48fabfe4d4f7d58 needlessly changed some else if statements in decode_negTokenInit to if's. Not only was the change not needed, but it's less efficient than the existing code. When compare_oid returns true, then it's guaranteed to return false in the other cases.

Re: [PATCH] cifs: revert needless change in decode_negTokenInit

2010-08-30 Thread Shirish Pargaonkar
On Mon, Aug 30, 2010 at 8:05 AM, Jeff Layton jlay...@redhat.com wrote: 9fbc590860e75785bdaf8b83e48fabfe4d4f7d58 needlessly changed some else if statements in decode_negTokenInit to if's. Not only was the change not needed, but it's less efficient than the existing code. When compare_oid

cifs: panic in crypto_shash_init

2010-08-30 Thread Jeff Layton
Testing recent kernel based on Steve's current tree (with the multiuser patchset on top). At unmount, I just got this panic. Known bug? fs/cifs/connect.c: CIFS VFS: in cifs_put_tcon as Xid: 29 with uid: 0 fs/cifs/cifssmb.c: In tree disconnect fs/cifs/transport.c: For smb_command 113 general

Re: cifs: panic in crypto_shash_init

2010-08-30 Thread Steve French
On Mon, Aug 30, 2010 at 12:38 PM, Jeff Layton jlay...@samba.org wrote: On Mon, 30 Aug 2010 11:49:04 -0500 Shirish Pargaonkar shirishpargaon...@gmail.com wrote: On Mon, Aug 30, 2010 at 11:35 AM, Jeff Layton jlay...@samba.org wrote: Testing recent kernel based on Steve's current tree (with the

[cifs] cifs: Allow binding to local IP address.

2010-08-30 Thread Ben Greear
When using multi-homed machines, it's nice to be able to specify the local IP to use for outbound connections. This patch gives cifs the ability to bind to a particular IP address. Usage: mount -t cifs -o srcaddr=192.168.1.50,user=foo, ... Usage: mount -t cifs -o

Re: [cifs] cifs: Allow binding to local IP address.

2010-08-30 Thread Ben Greear
On 08/30/2010 10:40 PM, Ben Greear wrote: When using multi-homed machines, it's nice to be able to specify the local IP to use for outbound connections. This patch gives cifs the ability to bind to a particular IP address. Usage: mount -t cifs -o srcaddr=192.168.1.50,user=foo, ...