Re: [PATCH] remove unused function CalcNTLMv2_partial_mac_key

2010-09-07 Thread Jeff Layton
On Mon, 6 Sep 2010 22:32:20 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com --- fs/cifs/cifsencrypt.c | 57 - 1 files changed, 0

Re: [PATCH] do not assume kerberos as default auth mech

2010-09-07 Thread Jeff Layton
On Mon, 6 Sep 2010 22:32:55 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com --- fs/cifs/cifssmb.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff

Re: [PATCH] define, declare, and use crypto sync hash structures

2010-09-07 Thread Jeff Layton
On Mon, 6 Sep 2010 22:34:27 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com --- fs/cifs/cifsencrypt.c | 71 + fs/cifs/cifsglob.h

Re: [PATCH] extract or create av pair blob and free it - during first session setup

2010-09-07 Thread Jeff Layton
On Mon, 6 Sep 2010 22:34:57 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com --- fs/cifs/cifsencrypt.c | 68 +--- fs/cifs/cifspdu.h

Re: [PATCH] remove unused function CalcNTLMv2_partial_mac_key

2010-09-07 Thread Shirish Pargaonkar
This gets removed in one of the patches. On Tue, Sep 7, 2010 at 6:17 AM, Jeff Layton jlay...@samba.org wrote: On Mon,  6 Sep 2010 22:32:20 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar

Re: [PATCH] remove unused function CalcNTLMv2_partial_mac_key

2010-09-07 Thread Jeff Layton
On Tue, 7 Sep 2010 07:12:48 -0500 Shirish Pargaonkar shirishpargaon...@gmail.com wrote: This gets removed in one of the patches. Why do it there and not here? What's the point of a function prototype in a header with no function to back it up? On Tue, Sep 7, 2010 at 6:17 AM, Jeff Layton

Re: [PATCH] ntlmv2 within ntlmssp authenticate

2010-09-07 Thread Jeff Layton
On Mon, 6 Sep 2010 22:35:23 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com --- fs/cifs/cifsencrypt.c | 33 fs/cifs/cifsglob.h|2 +-

Re: [PATCH] define, declare, and use crypto sync hash structures

2010-09-07 Thread Shirish Pargaonkar
On Tue, Sep 7, 2010 at 6:27 AM, Jeff Layton jlay...@samba.org wrote: On Mon,  6 Sep 2010 22:34:27 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com ---  fs/cifs/cifsencrypt.c |   71

Re: [PATCH] generate secondary session key and ciphertext and send it if signing enabled

2010-09-07 Thread Jeff Layton
On Mon, 6 Sep 2010 22:35:57 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com --- fs/cifs/cifsencrypt.c | 41 + fs/cifs/cifsproto.h |1

Re: [PATCH] ntlmssp auth/sign - define data structures

2010-09-07 Thread Shirish Pargaonkar
On Tue, Sep 7, 2010 at 6:15 AM, Jeff Layton jlay...@samba.org wrote: On Mon,  6 Sep 2010 22:31:36 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com A better description would be nice

Re: [PATCH] extract or create av pair blob and free it - during first session setup

2010-09-07 Thread Shirish Pargaonkar
On Tue, Sep 7, 2010 at 6:56 AM, Jeff Layton jlay...@samba.org wrote: On Mon,  6 Sep 2010 22:34:57 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com ---  fs/cifs/cifsencrypt.c |   68

Re: [PATCH 8/8][linux-cifs][ntlmv2 in ntlmssp 8/8] - use-kernel-crpto-apis-instead-of-cifs-crypto-functions

2010-09-07 Thread Shirish Pargaonkar
On Tue, Sep 7, 2010 at 7:51 AM, Jeff Layton jlay...@samba.org wrote: On Mon,  6 Sep 2010 22:36:24 -0500 shirishpargaon...@gmail.com wrote: Use kernel crypto sync hash apis insetead of cifs crypto functions. The calls typically corrospond one to one except that insead of key init, setkey is

Re: [PATCH] extract or create av pair blob and free it - during first session setup

2010-09-07 Thread Jeff Layton
On Tue, 7 Sep 2010 07:52:09 -0500 Shirish Pargaonkar shirishpargaon...@gmail.com wrote: On Tue, Sep 7, 2010 at 6:56 AM, Jeff Layton jlay...@samba.org wrote: On Mon,  6 Sep 2010 22:34:57 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com

Re: [PATCH] extract or create av pair blob and free it - during first session setup

2010-09-07 Thread Shirish Pargaonkar
On Tue, Sep 7, 2010 at 8:16 AM, Jeff Layton jlay...@samba.org wrote: On Tue, 7 Sep 2010 07:52:09 -0500 Shirish Pargaonkar shirishpargaon...@gmail.com wrote: On Tue, Sep 7, 2010 at 6:56 AM, Jeff Layton jlay...@samba.org wrote: On Mon,  6 Sep 2010 22:34:57 -0500 shirishpargaon...@gmail.com

Re: [PATCH][linux-cifs][ntlmv2 in ntlmssp 0/8] - resend in small chunks

2010-09-07 Thread Shirish Pargaonkar
On Tue, Sep 7, 2010 at 8:34 AM, Jeff Layton jlay...@samba.org wrote: On Mon,  6 Sep 2010 22:30:18 -0500 shirishpargaon...@gmail.com wrote: Make NTLMv2 as a default authentication mechanism within NTLMSSP Enable cifs/smb signing Use Crypto sync hash APIs instead of cifs crypto functions to

Re: smb2: Support srcaddr= logic for smb2 protocol.

2010-09-07 Thread Steve French
On Tue, Sep 7, 2010 at 12:21 PM, Ben Greear gree...@candelatech.com wrote: Here's a compile-tested patch to enable srcaddr= for smb2. It converts a bit of smb2 to be more like cifs (seems smb2 was copy and pasted and then cifs moved on). It also seems like much of the common code could move

Re: smb2: Support srcaddr= logic for smb2 protocol.

2010-09-07 Thread Steve French
On Tue, Sep 7, 2010 at 1:08 PM, Steve French smfre...@gmail.com wrote: On Tue, Sep 7, 2010 at 12:21 PM, Ben Greear gree...@candelatech.com wrote: Here's a compile-tested patch to enable srcaddr= for smb2. It converts a bit of smb2 to be more like cifs (seems smb2 was copy and pasted and then

Re: [PATCH] ntlmssp auth/sign - define data structures

2010-09-07 Thread Shirish Pargaonkar
On Tue, Sep 7, 2010 at 6:15 AM, Jeff Layton jlay...@samba.org wrote: On Mon,  6 Sep 2010 22:31:36 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com A better description would be nice

[PATCH 5/8] ntlmv2/ntlmssp functions to either extract or create av pair/ti info blob

2010-09-07 Thread shirishpargaonkar
From: Shirish Pargaonkar shirishpargaon...@gmail.com Attribue Value (AV) pairs or Target Info (TI) pairs are part of ntlmv2 authentication. Structure ntlmv2_resp had only definition for two av pairs. So removed it, and now allocation of av pairs is dynamic. For servers like Windows 7/2008, av

[PATCH 6/8] ntlmv2/ntlmssp authentication code

2010-09-07 Thread shirishpargaonkar
From: Shirish Pargaonkar shirishpargaon...@gmail.com To calculate ntlmv2 response we need ti/av pair blob. For sec mech like ntlmssp, the blob is plucked from type 2 response from the server. From this blob, netbios name of the domain is retrieved, if user has not already provided. For sec

[PATCH 7/8] ntlmv2/ntlmssp generate secondary session key and ciphertext and send it if signing enabled

2010-09-07 Thread shirishpargaonkar
From: Shirish Pargaonkar shirishpargaon...@gmail.com A key is exchanged with the server if client indicates so in flags in type 1 messsage and server agrees in flag in type 2 message of ntlmssp negotiation. If both client and agree, a key sent by client in type 3 message of ntlmssp negotiation

[no subject]

2010-09-07 Thread shirishpargaonkar
Subject: [PATCH 0/8] ntlmv2 within ntlmssp - enable and sign using crypto apis Three major functionality changes Make NTLMv2 as a default authentication mechanism within NTLMSSP Enable cifs/smb signing Use Crypto sync hash APIs instead of cifs crypto functions to genereate various hashes such