s are
> set, and will have permissions set to the default file_mode and dir_mode for
> the mount\&. Attempting to change these values via chmod/chown will return
> success but have no effect\&.
Merged...
Apologies for not spotting this sooner. In the future if you send the
patches
_NOFAIL;
> + if (strncmp(token, "x-", 2) == 0)
> + return OPT_IGNORE;
>
> return OPT_ERROR;
> }
Thanks, looks reasonable -- merged. I'll plan to cut a new cifs-utils
release in the next few weeks. There haven't been many patches over the
last year or
(
Can it still be fixed?
-Yale
Probably. It'd be interesting to see what the other tasks are blocking
on. After firing up the second one can you run:
# cat /proc/pid of second a.out/stack
...and paste the stack trace here? That should tell us what those other
processes are doing.
--
Jeff
:
else if (ses)
cifs_put_smb_ses(ses);
+ cifs_sb-mnt_cifs_flags = ~CIFS_MOUNT_POSIX_PATHS;
+
free_xid(xid);
}
#endif
Acked-by: Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs
at 8:16 AM, Jeff Layton jlay...@samba.org wrote:
On Thu, 9 Apr 2015 17:07:56 +0900
Nakajima Akira nakajima.ak...@nttcom.co.jp wrote:
On 2015/04/07 23:39, Steve French wrote:
On Tue, Apr 7, 2015 at 5:45 AM, Jeff Layton jlay...@samba.org wrote:
On Wed, 24 Dec 2014 11:27:38 +0900
and invalidate the old dentry?
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
(file, flock);
return rc;
}
(cc'ing Pavel since he wrote a lot of this code)
I think your patch looks correct -- if we (for instance) get a memory
allocation failure while trying to set the local lock then I think we
probably don't want to return success. So...
Acked-by: Jeff
;
/*
* If we're generating inode numbers, then we don't
* want to clobber the existing one with the one that
Looks right.
Reviewed-by: Jeff Layton jeff.lay...@primarydata.com
--
To unsubscribe from this list: send the line unsubscribe linux
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Wed, 1 Apr 2015 00:00:57 -0500
Steve French smfre...@gmail.com wrote:
On Tue, Mar 31, 2015 at 7:46 PM, Jeff Layton jlay...@poochiereds.net wrote:
On Fri, 27 Mar 2015 00:28:01 -0500
Steve French smfre...@gmail.com wrote:
null tcon is not likely in these paths in current
code
: %d\n,
+ __func__, rc);
+ cifs_buf_release(smb_buffer);
+ return rc;
+ }
bcc_ptr += CIFS_AUTH_RESP_SIZE;
if (ses-capabilities CAP_UNICODE) {
Acked-by:
--
Jeff Layton jlay
*)(hdr-ProtocolId[0]) + *off;
else
return NULL;
}
Acked-by: Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
);
+ cifs_stats_fail_inc(tcon, SMB2_IOCTL_HE);
goto ioctl_exit;
}
}
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info
;
}
}
Looks right. Probably also a stable candidate?
Reviewed-by: Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
*fl)
{
if (cmd == F_GETLK)
return posix_test_lock(filp, fl);
return posix_lock_file(filp, fl, fl);
}
...untested of course, but you get the idea.
On Thu, Jan 22, 2015 at 9:27 AM, Jeff Layton
jeff.lay...@primarydata.com wrote:
v3:
- break out a ceph locking
From: Jeff Layton jlay...@primarydata.com
There is only a single call site for each of these functions, and the
caller takes the i_lock prior to calling them and drops it just
afterward. Move the spinlocking into the functions instead.
Signed-off-by: Jeff Layton jlay...@primarydata.com
Acked
From: Jeff Layton jlay...@primarydata.com
Nothing uses it anymore. Also add a forward declaration for struct
file_lock to silence some compiler warnings that the removal triggers.
Signed-off-by: Jeff Layton jlay...@primarydata.com
Acked-by: Christoph Hellwig h...@lst.de
---
include/linux/fs.h
From: Jeff Layton jlay...@primarydata.com
The current scheme of using the i_flock list is really difficult to
manage. There is also a legitimate desire for a per-inode spinlock to
manage these lists that isn't the i_lock.
Start conversion to a new scheme to eventually replace the old i_flock
From: Jeff Layton jlay...@primarydata.com
Now that we use standard list_heads for tracking leases, we can have
lm_change take a pointer to the lease to be modified instead of a
double pointer.
Signed-off-by: Jeff Layton jlay...@primarydata.com
Acked-by: Christoph Hellwig h...@lst.de
---
fs
From: Jeff Layton jlay...@primarydata.com
Signed-off-by: Jeff Layton jlay...@primarydata.com
Acked-by: Christoph Hellwig h...@lst.de
---
fs/ceph/locks.c | 23 ---
fs/locks.c | 54 ++---
fs/nfs/delegation.c | 19
From: Jeff Layton jlay...@primarydata.com
...instead of open-coding it and removing flock locks directly. This
helps consolidate the flock lock removal logic into a single spot.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/locks.c | 49
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/locks.c | 2 +-
include/linux/fs.h | 19 ++-
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 2fc36b3772a0..4d0d41163a50 100644
--- a/fs/locks.c
+++ b/fs/locks.c
From: Jeff Layton jlay...@primarydata.com
Signed-off-by: Jeff Layton jlay...@primarydata.com
Acked-by: Christoph Hellwig h...@lst.de
---
fs/ceph/locks.c | 58 +---
fs/cifs/file.c | 26 +
fs/lockd/svcsubs.c | 20 ++
fs/locks.c
with
that for now.
For now, the code is still pretty raw and isn't bisectable. This is
just a RFC for the basic approach. This is probably v3.19 material at
best.
Anyone have thoughts or comments on the basic approach?
Jeff Layton (13):
locks: add new struct list_head to struct file_lock
locks
From: Jeff Layton jlay...@primarydata.com
...that we can use to queue file_locks to per-ctx list_heads. Go ahead
and convert locks_delete_lock and locks_dispose_list to use it instead
of the fl_block list.
Signed-off-by: Jeff Layton jlay...@primarydata.com
Acked-by: Christoph Hellwig h...@lst.de
From: Jeff Layton jlay...@primarydata.com
We can now add a dedicated spinlock without expanding struct inode.
Change to using that to protect the various i_flctx lists.
Signed-off-by: Jeff Layton jlay...@primarydata.com
Acked-by: Christoph Hellwig h...@lst.de
---
fs/ceph/locks.c | 8
From: Jeff Layton jlay...@primarydata.com
This makes things a bit more efficient in the cifs and ceph lock
pushing code.
Signed-off-by: Jeff Layton jlay...@primarydata.com
Acked-by: Christoph Hellwig h...@lst.de
---
fs/ceph/locks.c| 11 ++-
fs/cifs/file.c | 14 --
fs
From: Jeff Layton jlay...@primarydata.com
Signed-off-by: Jeff Layton jlay...@primarydata.com
Acked-by: Christoph Hellwig h...@lst.de
---
fs/locks.c | 252 +
include/linux/fs.h | 5 +-
2 files changed, 102 insertions(+), 155 deletions
testing using ltp's fsstress
command.
Signed-off-by: Sachin Prabhu spra...@redhat.com
Signed-off-by: Jeff Layton jlay...@samba.org
---
fs/cifs/file.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 96b7e9b..74f1287
On Mon, 19 Jan 2015 16:24:52 +
Sachin Prabhu spra...@redhat.com wrote:
On Mon, 2015-01-19 at 07:02 -0500, Jeff Layton wrote:
On Sat, 17 Jan 2015 07:45:13 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Thu, Jan 15, 2015 at 6:22 AM, Sachin Prabhu spra...@redhat.com
On Fri, 9 Jan 2015 06:27:23 -0800
Christoph Hellwig h...@infradead.org wrote:
On Thu, Jan 08, 2015 at 10:34:17AM -0800, Jeff Layton wrote:
...instead of open-coding it and removing flock locks directly. This
simplifies some coming interim changes in the following patches when
we have
that up for the next iteration.
--
Jeff Layton jlay...@primarydata.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
is
added to it, and it's only freed when the inode is freed. Assignment
of the pointer is done without locking using a compare and swap
operation.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/inode.c | 3 ++-
fs/locks.c | 37
Jeff Layton (10):
locks: add new struct list_head to struct file_lock
locks: have locks_release_file use flock_lock_file to release generic
flock locks
locks: add a new struct file_locking_context pointer to struct inode
locks: move flock locks to file_lock_context
locks: convert posix
This makes things a bit more efficient in the cifs and ceph lock
pushing code.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/ceph/locks.c| 11 ++-
fs/cifs/file.c | 14 --
fs/locks.c | 38 ++
include/linux/fs.h
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/ceph/locks.c | 58 +---
fs/cifs/file.c | 26 +
fs/lockd/svcsubs.c | 20 ++
fs/locks.c | 108 +++-
fs/nfs/delegation.c | 27
Nothing uses it anymore. Also add a forward declaration for struct
file_lock to silence some compiler warnings that the removal triggers.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
include/linux/fs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/locks.c | 251 +
include/linux/fs.h | 5 +-
2 files changed, 101 insertions(+), 155 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index fadf50297e5c..acfad02bc136 100644
We can now add a dedicated spinlock without expanding struct inode.
Change to using that to protect the various i_flctx lists. We do still
use the i_lock to protect the i_flctx pointer itself, but once the
context is assigned to the inode we no longer need it.
Signed-off-by: Jeff Layton jlay
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/ceph/locks.c | 28 ---
fs/ceph/mds_client.c | 4
fs/locks.c | 53 +---
fs/nfs/delegation.c | 18 --
fs/nfs/nfs4state.c | 42
...instead of open-coding it and removing flock locks directly. This
simplifies some coming interim changes in the following patches when
we have different file_lock types protected by different spinlocks.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/locks.c | 49
having the error this time).
Thanks
Malte
N_r__yb_Xv_^_)__{.n_+{_r'__{ay_ _,j__f___h___z_ _w___
___j:+v___w_j_mzZ+___j__!
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message
@@
#include mntent.h
#include stdlib.h
#include signal.h
+#include paths.h
#include mount.h
#include config.h
Looks fine. I'll merge that in the next few days.
Thanks!
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
user, then your unprivileged user must also have
read access to read that file. Doing anything else would be tantamount
to giving unprivileged users the ability to access files they wouldn't
otherwise be able to access.
Cheers,
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send
On Tue, 23 Sep 2014 15:09:23 -0400
Joseph Salisbury joseph.salisb...@canonical.com wrote:
Hi Jeff,
A kernel bug report was opened against Ubuntu [0]. It was found that
reverting the following commit resolved this bug:
commit a26054d184763969a411e3939fe243516715ff59
Author: Jeff Layton
and change how
file locks are handled. I'm going to leave this out of this current
patchset, but I'll keep it in mind for a later cleanup.
--
Jeff Layton jlay...@primarydata.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
On Mon, 25 Aug 2014 16:28:52 -0400
J. Bruce Fields bfie...@fieldses.org wrote:
On Sat, Aug 23, 2014 at 10:41:14AM -0400, Jeff Layton wrote:
In later patches, we're going to add a new lock_manager_operation to
finish setting up the lease while still holding the i_lock. To do
this, we'll
On Sat, 23 Aug 2014 18:33:05 -0700
Christoph Hellwig h...@infradead.org wrote:
On Sat, Aug 23, 2014 at 10:41:14AM -0400, Jeff Layton wrote:
In later patches, we're going to add a new lock_manager_operation to
finish setting up the lease while still holding the i_lock. To do
this, we'll
On Sat, 23 Aug 2014 18:27:57 -0700
Christoph Hellwig h...@infradead.org wrote:
On Sat, Aug 23, 2014 at 10:41:11AM -0400, Jeff Layton wrote:
+static int generic_delete_lease(struct file *filp)
{
struct file_lock *fl, **before;
struct dentry *dentry = filp-f_path.dentry
. I'll see what I can do.
Note that the error handling in the existing code looks wrong to me
too. The lease gets added to the list (or updated), the fasync handler
gets set up. Then, if __f_setown returns an error, the code just
returns that error without unwinding anything.
--
Jeff Layton jlay
On Sun, 24 Aug 2014 09:08:04 -0700
Christoph Hellwig h...@infradead.org wrote:
On Sat, Aug 23, 2014 at 10:41:17AM -0400, Jeff Layton wrote:
There was only one place where we still could free a file_lock while
holding the i_lock -- lease_modify. Add a new list_head argument to the
lm_change
those lines.
--
Jeff Layton jlay...@primarydata.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
before trying
to check the lease.
Cc: J. Bruce Fields bfie...@fieldses.org
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/locks.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index d7e15a256f8f..58ce8897f2e4 100644
--- a/fs
be welcome...
Jeff Layton (10):
locks: close potential race in lease_get_mtime
nfsd: fix potential lease memory leak in nfs4_setlease
locks: generic_delete_lease doesn't need a file_lock at all
locks: clean up vfs_setlease kerneldoc comments
nfsd: don't keep a pointer to the lease in nfs4_file
if it occurs.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/locks.c | 25 -
fs/nfsd/nfs4state.c | 2 +-
2 files changed, 9 insertions(+), 18 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 58ce8897f2e4..bedb817a5cc4 100644
--- a/fs/locks.c
+++ b/fs
!) step toward allowing leases to work with
distributed filesystems.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/locks.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index b35b706c05fe..49210d5cbf41 100644
not be freed after the function returns.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/locks.c | 96 +
fs/nfsd/nfs4state.c | 9 ++---
include/linux/fs.h | 1 +
3 files changed, 56 insertions(+), 50 deletions(-)
diff --git a/fs
-by: Jeff Layton jlay...@primarydata.com
---
fs/locks.c | 35 ++-
fs/nfsd/nfs4state.c | 6 +++---
include/linux/fs.h | 7 ---
3 files changed, 29 insertions(+), 19 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 49210d5cbf41..98907cecaa44 100644
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
Documentation/filesystems/Locking | 21 ++---
Documentation/filesystems/vfs.txt | 7 ---
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/Documentation/filesystems/Locking
b/Documentation/filesystems
semantics.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/nfsd/nfs4state.c | 10 --
fs/nfsd/state.h | 1 -
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 0cd252916e1a..d0a6e8e022a2 100644
--- a/fs/nfsd/nfs4state.c
of that.
We declare this pointer as a void ** to make it clear that this is
auxillary info, and that the caller isn't required to set this unless
the lm_setup specifically requires it.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/cifs/cifsfs.c| 7 ---
fs/gfs2/file.c | 3 ++-
fs
.
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
any longer.
Acked-by: Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the rationale for the arbitrary 15 byte limit. At
this point, you've already received the data. If there's extra junk at
the end, do you really care? I'd just ensure that clc_len fits within
the rfc1001 len and leave it at that.
return 1;
}
return 0;
--
Jeff Layton jlay
On Thu, 14 Aug 2014 15:26:41 -0500
Steve French smfre...@gmail.com wrote:
On Thu, Aug 14, 2014 at 2:35 PM, Jeremy Allison j...@samba.org wrote:
On Thu, Aug 14, 2014 at 03:30:15PM -0400, Jeff Layton wrote:
Not directly related to this patch, but...
What's the story behind the check
Currently any F_UNLCK request for a lease just gets back -EAGAIN. Allow
them to go immediately to generic_setlease instead.
Signed-off-by: Jeff Layton jlay...@primarydata.com
---
fs/cifs/cifsfs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/cifsfs.c b/fs/cifs
link to different inodes. As the results the Cthon basic test #7 fails
on nounix Samba mounts.
Fix this by making the client update the creation time on every
query info request.
Cc: Jeff Layton jlay...@samba.org
Signed-off-by: Pavel Shilovsky pshilov...@samba.org
---
fs/cifs/inode.c | 3
On Wed, 6 Aug 2014 15:59:22 +0400
Pavel Shilovsky pshilov...@samba.org wrote:
2014-08-06 15:25 GMT+04:00 Jeff Layton jlay...@samba.org:
On Wed, 6 Aug 2014 15:15:43 +0400
Pavel Shilovsky pshilov...@samba.org wrote:
Samba server can change a creation time of an inode in the default
On Wed, 6 Aug 2014 16:38:32 +0400
Pavel Shilovsky pshilov...@samba.org wrote:
2014-08-06 16:08 GMT+04:00 Jeff Layton jlay...@samba.org:
On Wed, 6 Aug 2014 15:59:22 +0400
Pavel Shilovsky pshilov...@samba.org wrote:
2014-08-06 15:25 GMT+04:00 Jeff Layton jlay...@samba.org:
On Wed, 6
gitweb: http://git.samba.org/?p=cifs-utils.git;a=summary
Detailed list of changes since 6.4 was released:
commit 594f03a5c053d2a539ffb8e2889832829ee542ee
Author: Jeff Layton jlay...@samba.org
Date: Wed Apr 2 10:21:10 2014 -0400
autoconf: set version to 6.3.1 for interim builds
, next, done);
/* nothing to write? */
if (nr_pages == 0) {
Reviewed-by:
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
of cifs_readv_from_socket...
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
- }
+ rc = wdata_send_pages(wdata, nr_pages, mapping, wbc);
kref_put(wdata-refcount, cifs_writedata_release);
wbc-nr_to_write -= nr_pages;
Reviewed-by: Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe
On Fri, 27 Jun 2014 20:06:48 +0400
Pavel Shilovsky pshilov...@samba.org wrote:
2014-06-27 14:52 GMT+04:00 Jeff Layton jlay...@poochiereds.net:
On Fri, 27 Jun 2014 13:57:38 +0400
Pavel Shilovsky pshilov...@samba.org wrote:
If we get into read_into_pages() from cifs_readv_receive
On Thu, 3 Jul 2014 06:45:49 -0400
Jeff Layton jlay...@samba.org wrote:
On Fri, 27 Jun 2014 20:06:48 +0400
Pavel Shilovsky pshilov...@samba.org wrote:
2014-06-27 14:52 GMT+04:00 Jeff Layton jlay...@poochiereds.net:
On Fri, 27 Jun 2014 13:57:38 +0400
Pavel Shilovsky pshilov...@samba.org
On Tue, 01 Jul 2014 19:05:29 +0200
Günter Kukkukk li...@kukkukk.com wrote:
userland mount helper mount.cifs.
Also uppercase the now used (kernel) orig_dev parameter, to get the
mount retry working again.
Cheers, Günter
Patch merged into master.
Thanks!
--
Jeff Layton jlay...@samba.org
the next
few days unless someone objects.
Cheers!
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
are
not what we want to do. In reconnect cases (-EAGAIN) we should not
mask off the error with a short read but should return the error
code instead.
I'm not sure I understand what problem this solves. Why is returning a
short read wrong here?
Cc: Jeff Layton jlay...@poochiereds.net
Signed-off
Before satisfying a read with cache=loose, we should always check
that the pagecache is valid before allowing a read to be satisfied
out of it.
Reported-by: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp
Signed-off-by: Jeff Layton jlay...@poochiereds.net
---
fs/cifs/cifsfs.c | 17
(ses-password,
2234 vol-password ? vol-password : ,
2235 CIFS_MAX_PASSWORD_LEN))
2236 return 0;
...fix this by ensuring that vol-username is not NULL before running
strlen on it.
Signed-off-by: Jeff Layton
On Fri, 23 May 2014 06:50:21 -0400
Jeff Layton jlay...@poochiereds.net wrote:
Before satisfying a read with cache=loose, we should always check
that the pagecache is valid before allowing a read to be satisfied
out of it.
Reported-by: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp
Signed
two branches, one with old and one with new version of the patch since
when I am testing latest cifs patches (and also the proposed SMB3
Posix extensions) don't have Al's series.
On Fri, May 23, 2014 at 9:44 AM, Jeff Layton jlay...@poochiereds.net
wrote:
On Fri, 23 May 2014 06:50:21
RHEL servers that are exporting filesystems via smb2, or are you
trying to mount filesystems from another server (windows?) using smb2?
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More
;
+ if (strtobool(c, bv) == 0) {
+ global_secflags = bv ? CIFSSEC_MAX : CIFSSEC_DEF;
return count;
} else if (!isdigit(c)) {
cifs_dbg(VFS, Invalid SecurityFlags: %s\n,
--
1.9.2
--
Jeff Layton jlay...@poochiereds.net
On Mon, 12 May 2014 16:59:55 +0300
Andy Shevchenko andriy.shevche...@linux.intel.com wrote:
On Mon, 2014-05-12 at 16:22 +0300, Alexander Bokovoy wrote:
On Mon, May 12, 2014 at 06:41:00AM -0400, Jeff Layton wrote:
This changes the returned value of cifs_linux_ext_proc_write() to
-EINVAL
, DUMP_PREFIX_ADDRESS, 16, 4,
+data, length, true);
I'm not sure we want label as the prefix_str as it'll go on every
line. Maybe just use in place of label there?
}
#ifdef CONFIG_CIFS_DEBUG
Otherwise, this looks good.
Acked-by: Jeff Layton jlay...@poochiereds.net
On Mon, 12 May 2014 19:15:09 +0300
Andy Shevchenko andriy.shevche...@linux.intel.com wrote:
On Mon, 2014-05-12 at 11:42 -0400, Jeff Layton wrote:
On Mon, 12 May 2014 18:15:20 +0300
Andy Shevchenko andriy.shevche...@linux.intel.com wrote:
This patch converts custom dumper to use native
On Mon, 5 May 2014 06:53:01 +0200
Fabian Frederick f...@skynet.be wrote:
On Sun, 4 May 2014 18:52:43 -0400
Jeff Layton jlay...@poochiereds.net wrote:
On Sat, May 3, 2014 at 4:15 PM, Fabian Frederick f...@skynet.be wrote:
Replacing all __constant_foo to foo()
except in smb2status.h
On Sat, May 3, 2014 at 4:15 PM, Fabian Frederick f...@skynet.be wrote:
Replacing all __constant_foo to foo()
except in smb2status.h (1700 lines to update).
Cc: linux-cifs@vger.kernel.org
Cc: Steve French sfre...@samba.org
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian
to check the sizeof(ino_t) at runtime so create two
different cifs_uniqueid_to_ino_t functions based on whether
BITS_PER_LONG is 64 for not.
This should fix:
https://bugzilla.kernel.org/show_bug.cgi?id=19282
Reported-by: Eric copet_e...@emc.com
Reported-by: per-...@sadata.se
Signed-off-by: Jeff
:
kfree(ses-ntlmssp);
return rc;
+
+out:
+ rc = sess_data-result;
+ kfree(sess_data);
+ return rc;
}
Aside from the nits above, nice cleanup. It's a definite improvement.
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line
== 0) {
I like it.
Reviewed-by: Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
Reviewed-by: Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
+
+ /* Store result before we free sess_data */
rc = sess_data-result;
+
+out:
kfree(sess_data);
return rc;
}
Still, vast improvement over the old code. I'd be OK with merging it
as-is and just have you do follow-on patches to clean up the nits.
Reviewed-by: Jeff
of the kernel's ring buffer.
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
(remaining, PAGE_SIZE);
+ size_t copy = min_t(size_t, remaining, PAGE_SIZE);
size_t written = copy_page_to_iter(page, 0, copy, iter);
remaining -= written;
if (written copy iov_iter_count(iter) 0)
Reviewed-by: Jeff Layton jlay
existing users of cifs_invalidate_mapping to use a new
cifs_zap_mapping() function that just sets the INVALID_MAPPING bit and
then uses the standard codepath to handle the invalidation.
Signed-off-by: Jeff Layton jlay...@poochiereds.net
---
fs/cifs/cifsfs.h | 1 +
fs/cifs/cifsglob.h | 1 +
fs/cifs
In later patches, we'll need to have a bitlock, so go ahead and convert
these bools to use atomic bitops instead.
Also, clean up the initialization of the flags field. There's no need
to unset each bit individually just after it was zeroed on allocation.
Signed-off-by: Jeff Layton jlay
can tell
this fixes his testcase, assuming that you also ensure that kernel
oplocks are enabled.
Given that we're late in the cycle, I'd like to see these merged for
v3.16 but getting them into -next soon would be good.
Jeff Layton (4):
cifs: convert booleans in cifsInodeInfo to a flags field
Before satisfying a read with cache=loose, we should always check
that the pagecache is valid before allowing a read to be satisfied
out of it.
Reported-by: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp
Signed-off-by: Jeff Layton jlay...@poochiereds.net
---
fs/cifs/cifsfs.c | 18
1 - 100 of 2365 matches
Mail list logo
