Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them

2010-06-27 Thread Christoph Hellwig
On Sun, Jun 27, 2010 at 11:47:21PM +0530, Aneesh Kumar K. V wrote: NFS ganesha pNFS also had a requirement for getting i_generation and inode number in userspace. So may be we should now look at updating stat or add a variant syscall that include i_generation and create time in the return

Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them

2010-06-25 Thread David Howells
Suresh Jayaraman sjayara...@suse.de wrote: I think the creation time is currently being ignored as we won't be able to accomodate in POSIX stat struct. The FS-Cache interface doesn't use the POSIX stat struct, but it could be really useful to save it and use it for cache coherency inside the

Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them

2010-06-25 Thread Jeff Layton
On Fri, 25 Jun 2010 22:46:38 +0100 David Howells dhowe...@redhat.com wrote: Jeff Layton jlay...@samba.org wrote: Looks like it mostly uses the ctime. IMO, the mtime would be a better choice since it changes less frequently, but I don't guess that it matters very much. I'd've thought

Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them

2010-06-25 Thread David Howells
Jeff Layton jlay...@samba.org wrote: IIUC, updating mtime for a write is also an attribute change, and that affects ctime. According to the stat(2) manpage: You're right. Okay, ctime is the more frequently changed. Note that Ext4 appears to have a file creation time field in its inode

Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them

2010-06-25 Thread Steve French
On Fri, Jun 25, 2010 at 5:26 PM, Jeff Layton jlay...@samba.org wrote: On Fri, 25 Jun 2010 22:46:38 +0100 David Howells dhowe...@redhat.com wrote: Jeff Layton jlay...@samba.org wrote: Looks like it mostly uses the ctime. IMO, the mtime would be a better choice since it changes less

Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them

2010-06-23 Thread David Howells
Suresh Jayaraman sjayara...@suse.de wrote: Define inode-level data storage objects (managed by cifsInodeInfo structs). Each inode-level object is created in a super-block level object and is itself a data storage object in to which pages from the inode are stored. The inode object is keyed