Re: [PATCH] Ext4: Make file creation time, i_version and i_generation available by xattrs

On 2010-06-28, at 13:41, Steve French wrote: I think backing them up makes sense, even if they can't easily be restored (ie just for reporting). Right. I think being able to restore the crtime (as root) makes sense, I don't think restoring i_generation and i_version make sense however, given

Re: [PATCH 3/3] Add a pair of system calls to make extended file stats available [ver #2]

On 2010-06-29, at 19:48, Trond Myklebust wrote: When the system call is executed, the struct_version ID and query_flags bitmask are read from the buffer to work out what the user is requesting. Yes, but could we please also add a flag that allows you to specify that the kernel _must_

Re: [PATCH] Add a pair of system calls to make extended file stats available [ver #3]

On 2010-07-01, at 23:36, Michael Kerrisk wrote: * Include information from the inode_info structure, most notably i_flags, but perhaps other info as well. This one is actually pretty interesting, though instead of exporting the i_flags directly (the S_* flags), it would be much better to

Re: [PATCH 00/09] cifs: local caching support using FS-Cache

On 2010-07-22, at 11:40, David Howells wrote: Suresh Jayaraman sjayara...@suse.de wrote: As it can been seen, the performance while reading when data is cache hot (disk) is not great as the network link is a Gigabit ethernet (with server having working set in memory) which is mostly expected.

Re: [PATCH 0/6] Extended file stat system call

On 2012-04-19, at 8:05 AM, David Howells wrote: Implement a pair of new system calls to provide extended and further extensible stat functions. Hallelujah for this. I've been waiting/wanting something like this for ages already. Now if only we can get this landed before it degrades into the

Re: [PATCH 1/6] xstat: Add a pair of system calls to make extended file stats available

On 2012-04-19, at 8:06 AM, David Howells wrote: Add a pair of system calls to make extended file stats available, including file creation time, inode version and data version where available through the underlying filesystem. The idea was initially proposed as a set of xattrs that could be

Re: [PATCH 0/6] Extended file stat system call

On 2012-04-27, at 7:13 AM, Dave Chinner wrote: Have a look at fs/xfs/xfs_dinode.h. There's a bunch of flags defined at the bottom of the file. Stuff like the nodefrag, nodump, and prealloc bits seem fairly generic - they are for indicating that files are to be avoided for defrag or backup

Re: Extended file stat: Splitting file- and fs-specific info?

On 2012-05-08, at 18:24, Dave Chinner da...@fromorbit.com wrote: On Tue, May 08, 2012 at 09:19:42PM +0100, David Howells wrote: Should I split the file-specific info and the fs-specific info and make the second optional? What I'm thinking of is something like this: Have a file information

Re: Extended file stat: Splitting file- and fs-specific info?

On 2012-05-09, at 6:25 AM, Bernd Schubert wrote: On 05/09/2012 02:05 PM, Christoph Hellwig wrote: On Wed, May 09, 2012 at 01:55:16PM +0200, Bernd Schubert wrote: The basic idea of generation numbers is to check if an inode was recycled, so only if the tuple of inode-number and

Re: Extended file stat: Splitting file- and fs-specific info?

On 2012-05-10, at 11:10 AM, Roland McGrath wrote: POSIX specifies st_blksize thusly: A file system-specific preferred I/O block size for this object. In some file system types, this may vary from file to file. Since there is only one available to POSIX applications, it should map to the one

Re: [PATCH 1/3] statxat: Provide IOC flags for Windows fs attributes

On Nov 12, 2013, at 10:35 AM, David Howells dhowe...@redhat.com wrote: Provide IOC flags for Windows fs attributes so that they can be retrieved (or even altered) using the FS_IOC_[GS]ETFLAGS ioctl and read using statxat(). Signed-off-by: David Howells dhowe...@redhat.com ---

Re: [PATCH 2/3] statxat: Add a system call to make extended file stats available [ver #2]

On Nov 12, 2013, at 11:41 AM, David Howells dhowe...@redhat.com wrote: Add a system call to make extended file stats available, including file creation time, inode version and data version where available through the underlying filesystem. [snip] The defined bits in st_ioc_flags are the

Re: [PATCH v13 10/51] vfs: Cache base_acl objects in inodes

On Nov 3, 2015, at 8:16 AM, Andreas Gruenbacher wrote: > > POSIX ACLs and richacls are both objects allocated by kmalloc() with a > reference count which are freed by kfree_rcu(). An inode can either > cache an access and a default POSIX ACL, or a richacl (richacls do not >

Re: [PATCH v14 11/22] vfs: Cache base_acl objects in inodes

d-off-by: Andreas Gruenbacher <agrue...@redhat.com> Reviewed-by: Andreas Dilger <adil...@dilger.ca> > --- > drivers/staging/lustre/lustre/llite/llite_lib.c | 2 +- > fs/f2fs/acl.c | 4 +-- > fs/inode.c

Re: [PATCH v14 22/22] ext4: Add richacl feature flag

, the "acl" and "noacl" mount options > control whether POSIX ACLs are enabled. When it is on, richacls are > automatically enabled and using the "noacl" mount option leads to an error. > > Signed-off-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com

Re: [PATCH v14 02/22] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

On Nov 7, 2015, at 10:44 AM, Andreas Gruenbacher <agrue...@redhat.com> wrote: > > On Fri, Nov 6, 2015 at 9:58 PM, Andreas Dilger <adil...@dilger.ca> wrote: >> I thought you proposed adding an enum for these parameters, and possibly >> making them a single pa

Re: [PATCH v13 21/51] ext4: Add richacl feature flag

> On Nov 3, 2015, at 8:16 AM, Andreas Gruenbacher wrote: > > From: "Aneesh Kumar K.V" > > This feature flag selects richacl instead of posix acl support on the > file system. In addition, the "acl" mount option is needed for enabling >

Re: [PATCH v13 12/51] vfs: Cache richacl in struct inode

On Nov 3, 2015, at 8:16 AM, Andreas Gruenbacher wrote: > > Cache richacls in struct inode so that this doesn't have to be done > individually in each filesystem. This is similar to POSIX ACLs. > > Signed-off-by: Andreas Gruenbacher > --- > fs/inode.c

Re: [PATCH v13 20/51] ext4: Add richacl support

xattrs. Richacls need to be enabled by tune2fs or > at file system create time. Patch looks reasonable. One minor cleanup below that could be fixed when the patch series is refreshed, and you can add: Reviewed-by: Andreas Dilger <adil...@dilger.ca> > > Signed-off-by: Aneesh Kumar

Re: [PATCH v13 02/51] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

On Nov 3, 2015, at 8:16 AM, Andreas Gruenbacher wrote: > > Richacls distinguish between creating non-directories and directories. To > support that, add an isdir parameter to may_create(). When checking > inode_permission() for create permission, pass in an additional >

Re: [PATCH v13 43/51] ext4: Don't allow unmapped identifiers in richacls

> On Nov 3, 2015, at 8:17 AM, Andreas Gruenbacher <agrue...@redhat.com> wrote: > > Don't allow acls which contain unmapped identifiers: they are meaningful > for remote file systems only. Looks fine. Reviewed-by: Andreas Dilger <adil...@dilger.ca> > Signed-off-by:

Re: [PATCH v14 01/22] vfs: Add IS_ACL() and IS_RICHACL() tests

hacls instead. Add a new > MS_RICHACL flag and IS_RICHACL() test for richacls alone. The IS_POSIXACL() > test is still needed by nfsd. > > Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> > Reviewed-by: J. Bruce Fields <bfie...@redhat.com> Looks good to me. R

Re: [PATCH v14 03/22] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags

On Nov 5, 2015, at 4:39 AM, Andreas Gruenbacher wrote: > > Normally, deleting a file requires MAY_WRITE access to the parent > directory. With richacls, a file may be deleted with MAY_DELETE_CHILD access > to the parent directory or with MAY_DELETE_SELF access to the file.

Re: [PATCH v14 02/22] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

On Nov 5, 2015, at 4:39 AM, Andreas Gruenbacher wrote: > > Richacls distinguish between creating non-directories and directories. To > support that, add an isdir parameter to may_create(). When checking > inode_permission() for create permission, pass in an additional >

Re: [PATCH v14 03/22] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags

On Nov 5, 2015, at 4:39 AM, Andreas Gruenbacher wrote: > > Normally, deleting a file requires MAY_WRITE access to the parent > directory. With richacls, a file may be deleted with MAY_DELETE_CHILD access > to the parent directory or with MAY_DELETE_SELF access to the file.

Re: [PATCH v11 21/48] ext4: Add richacl feature flag

On Oct 19, 2015, at 10:19 AM, Austin S Hemmelgarn wrote: > > On 2015-10-19 11:34, Andreas Gruenbacher wrote: >> On Mon, Oct 19, 2015 at 3:16 PM, Austin S Hemmelgarn >> wrote: >>> On 2015-10-16 13:41, Andreas Gruenbacher wrote: On Fri, Oct

Re: [PATCH 02/12] statx: Provide IOC flags for Windows fs attributes

On Nov 26, 2015, at 8:35 AM, David Howells wrote: > > Theodore Ts'o wrote: > >> As a result, I would suggest that we not try to use the >> FS_IOC_[GS]ETFLAGS number scheme for any new interface, so we're at >> least not making a bad situation worse. >> >>

Re: [RFC][PATCH 00/12] Enhanced file stat system call

On Nov 25, 2015, at 10:51 AM, J. Bruce Fields wrote: > > On Fri, Nov 20, 2015 at 04:28:35PM +, David Howells wrote: >> Martin Steigerwald wrote: >> >>> Any plans to add limitations of filesystem to the call like maximum file >>> size? I know its

Re: [PATCH 01/12] Ext4: Fix extended timestamp encoding and decoding

On Nov 20, 2015, at 7:54 AM, David Howells wrote: > > The handling of extended timestamps in Ext4 is broken as can be seen in the > output of the test program attached below: > > time extra bad decodegood decode bad encode good encode > =

Re: [RFC][PATCH 00/12] Enhanced file stat system call

On Nov 20, 2015, at 9:50 AM, Casey Schaufler wrote: > On 11/20/2015 6:54 AM, David Howells wrote: >> Implement new system calls to provide enhanced file stats and enhanced >> filesystem stats. The patches can be found here: >> >> >>