support server inode numbers correctly, which is sort of a requirement
for proper hardlink support. Those were really too invasive for a minor
RHEL release however.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message
years ago the system crashed shortly after
issuing the mount command.
RHEL6 is fairly current with mainline code (at least as of this past
spring or so). If it works OK on Fedora, it should be OK in RHEL6.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line
clientCanCacheAll or
clientCanCacheRead flags. Fix this by passing oplock from the callers to
cifs_new_fileinfo().
This change dates back to commit a6ce4932 (2.6.30-rc3). So, all the affected
versions will need this fix. Please Cc stable once reviewed and accepted.
Cc: Jeff Layton jlay...@redhat.com
On Fri, 17 Sep 2010 19:43:10 +0530
Suresh Jayaraman sjayara...@suse.de wrote:
... and avoid implicit casting from a signed type. Also, pass oplock by value
instead by reference as we don't intend to change the value in
cifs_open_inode_helper().
Thanks to Jeff Layton for spotting
On Fri, 17 Sep 2010 09:46:51 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Fri, Sep 17, 2010 at 9:19 AM, Jeff Layton jlay...@samba.org wrote:
On Thu, 16 Sep 2010 00:47:03 -0500
shirishpargaon...@gmail.com wrote:
From: Shirish Pargaonkar shirishpargaon...@gmail.com
a look?
https://bugzilla.redhat.com/show_bug.cgi?id=617771
I've was able to reproduce it today using the most recent samba version
available in the Fedora repos (3.5.5).
Thanks,
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
On Fri, 17 Sep 2010 13:15:58 -0400
Jeff Layton jlay...@samba.org wrote:
On Fri, 17 Sep 2010 13:00:05 -0400
Jeff Layton jlay...@samba.org wrote:
I recently noticed a regression in samba in the last few weeks. Here's
a simple way to reproduce it:
1) use smbclient to put a file
On Fri, 17 Sep 2010 12:28:52 -0500
Steve French smfre...@gmail.com wrote:
On Fri, Sep 17, 2010 at 12:27 PM, Steve French smfre...@gmail.com wrote:
On Fri, Sep 17, 2010 at 12:15 PM, Jeff Layton jlay...@samba.org wrote:
On Fri, 17 Sep 2010 13:00:05 -0400
Jeff Layton jlay...@samba.org
giving up on the idea for now, but thanks
for your help.
What sort of difficulty is it having?
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
== CIFS_SMALL_BUFFER) {
cFYI(1, ssetup freeing small buf %p, iov[0].iov_base);
cifs_small_buf_release(iov[0].iov_base);
By jove, I think he's got it!
Reviewed-by: Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs
-i_size on the
directory. I *think* that when you do a QPathInfo call to a directory
via cifs the size comes back 0. Setting this to something else probably
means an extra call to the server to get the real size (whatever that
means). The question is, what should this be set to?
--
Jeff Layton jlay
of this
until we have a clear, consistent goal in mind.
That'll also help us to ensure that we don't cause regressions, and to
make sure that we understand what the performance impacts of these
changes will be.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe
On Mon, 20 Sep 2010 09:29:38 +0200
Stef Bon stef...@gmail.com wrote:
2010/9/20 Jeff Layton jlay...@samba.org:
On Sun, 19 Sep 2010 21:28:41 +0200
Stef Bon stef...@gmail.com wrote:
Hello,
It's causing some unwanted behaviour.
How can I change that, or is this not changeable?
Stef
it on LKML,
particularly if there is a way to reproduce it on recent mainline
kernels.
Cheers,
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
changes. Some of the patches touch the same
areas of code as earlier ones. This increases the amount of churn but
I think it makes a more logical sequence of changes.
At this point, I think this code is ready for merge. I'd like to see it
in 2.6.37. Comments and review are welcome.
Jeff Layton (15
Eventually, we'll have more than one tcon per superblock. At that point,
we'll need to know which one is associated with a particular fid. For
now, this is just set from the cifs_sb-tcon pointer, but eventually
the caller of cifs_new_fileinfo will pass a tcon pointer in.
Signed-off-by: Jeff
...where it's available and appropriate.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsfs.c |4 ++--
fs/cifs/file.c| 39 ---
fs/cifs/inode.c | 22 --
fs/cifs/ioctl.c | 17 +++--
fs/cifs
anyway, so maybe a NULL
open_file here ought to be a BUG()?
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/file.c | 82 +++
1 files changed, 40 insertions(+), 42 deletions(-)
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index
When we convert cifs to do multiple sessions per mount, we'll need more
than one tcon per superblock. At that point cifs_sb-tcon will make
no sense. Add a new accessor function that gets a tcon given a cifs_sb.
For now, it just returns cifs_sb-tcon. Later it'll do more.
Signed-off-by: Jeff Layton
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifs_fs_sb.h |2 +-
fs/cifs/cifsglob.h |2 +-
fs/cifs/connect.c|4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/cifs/cifs_fs_sb.h b/fs/cifs/cifs_fs_sb.h
index 7fde529..ba0afd3 100644
--- a/fs
and go ahead and
switch the appropriate places to use it.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsfs.c |6 +++---
fs/cifs/cifsglob.h |7 +++
fs/cifs/connect.c |4 ++--
fs/cifs/dir.c | 10 +-
fs/cifs/fscache.c | 12 ++--
fs/cifs
To minimize calls to cifs_sb_tcon and to allow for a clear error path if
a tcon can't be acquired.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsproto.h |4 ++--
fs/cifs/dir.c | 22 --
fs/cifs/file.c |4 ++--
3 files changed, 16 insertions
cifsFileInfo needs a pointer to a tcon, but it doesn't currently hold a
reference to it. Change it to keep a pointer to a tcon_link instead and
hold a reference to it.
That will keep the tcon from being freed until the file is closed.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs
When we implement multiuser mounts, we'll need to filter filehandles
by fsuid. Add a flag for multiuser mounts and code to filter by
fsuid when it's set.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifs_fs_sb.h |3 ++-
fs/cifs/cifsacl.c|4 ++--
fs/cifs/cifsproto.h
...when unix extensions aren't enabled. This makes everything on
the mount appear to be owned by the current user.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/inode.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
Create a workqueue job that cleans out unused tlinks. For now, it uses
a hardcoded expire time of 10 minutes. When it's done, the work rearms
itself. On umount, the work is cancelled before tearing down the tlink
tree.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifs_fs_sb.h |1
With commit 7332f2a6217ee6925f83ef0e725013067ed316ba, cifsd will no
longer exit when the socket abends and the tcpStatus is CifsNew. With
that change, there's no reason to avoid matching an existing session in
this state.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/connect.c |9
On Tue, 21 Sep 2010 13:26:08 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Tue, Sep 21, 2010 at 12:52 PM, Jeff Layton jlay...@samba.org wrote:
On Sat, 18 Sep 2010 22:02:35 -0500
shirishpargaon...@gmail.com wrote:
From: Shirish Pargaonkar shirishpargaon...@gmail.com
the
first time, it doesn't really cause any problems.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 21 Sep 2010 21:57:44 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Tue, Sep 21, 2010 at 6:42 PM, Jeff Layton jlay...@samba.org wrote:
On Tue, 21 Sep 2010 14:04:24 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
Right. I'm just not sure why we need
On Tue, 21 Sep 2010 22:20:21 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Tue, Sep 21, 2010 at 10:07 PM, Jeff Layton jlay...@samba.org wrote:
On Tue, 21 Sep 2010 21:57:44 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Tue, Sep 21, 2010 at 6:42 PM, Jeff
call.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/file.c | 70 ++-
1 files changed, 38 insertions(+), 32 deletions(-)
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 84979fc..e099b50 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs
in that case (as it was
before)
Good catch. I'll fix, retest and resend...
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 23 Sep 2010 01:08:51 -0500
Steve French smfre...@gmail.com wrote:
On Mon, Sep 20, 2010 at 6:01 PM, Jeff Layton jlay...@redhat.com wrote:
cifsFileInfo needs a pointer to a tcon, but it doesn't currently hold a
reference to it. Change it to keep a pointer to a tcon_link instead
that to ignore the uid passed in or mount.
Does it make sense to present ownership of all files the same as the
uid= option in a multiuser mount scenario? Note that when it's not a
multiuser mount, the current behavior is unchanged.
On Mon, Sep 20, 2010 at 6:01 PM, Jeff Layton jlay
'cifs_sb'
Introduced by commit 9a6124e7e18fa30d8693055e6a4526afb4c3fabc (cifs:
have cifs_new_fileinfo take a tcon arg).
That's fixed in the next patch in the multiuser mount series. It
probably should have been part of the patch above.
--
Jeff Layton jlay...@redhat.com
signature.asc
could replace that with a fake value, but it's not at all clear to
me what that value should be.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
, this will need to be fixed, so we might as well go ahead and
fix it now.
When flushing a writable filp, wait for the writeback to complete before
returning to ensure that the filehandle stays around until the writeback
is complete.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/file.c
On Fri, 24 Sep 2010 08:58:32 -0400
Jeff Layton jlay...@redhat.com wrote:
find_domain_name() uses load_nls_default which takes a module reference
on the appropriate NLS module, but doesn't put it.
Signed-off-by: Jeff Layton jlay...@redhat.com
Cc: Shirish Pargaonkar shirishpargaon
On Fri, 24 Sep 2010 19:44:30 +0200
Stef Bon stef...@gmail.com wrote:
2010/9/24 Jeff Layton jlay...@redhat.com:
how can I fix the directory-size that apache is receiving?
Honestly, that sounds like an apache bug. You may want to report that
to them.
I asked Stef this question
.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/file.c | 17 +++--
1 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 80856f1..8084a8d 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -1737,16 +1737,13
for the flush to complete?
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 24 Sep 2010 14:24:31 -0500
Steve French smfre...@gmail.com wrote:
On Fri, Sep 24, 2010 at 2:08 PM, Jeff Layton jlay...@redhat.com wrote:
On Fri, 24 Sep 2010 13:43:40 -0500
Steve French smfre...@gmail.com wrote:
It don't think it is a correctness issue - if close wants to do
On Fri, 24 Sep 2010 14:36:19 -0500
Steve French smfre...@gmail.com wrote:
On Fri, Sep 24, 2010 at 2:32 PM, Jeff Layton jlay...@redhat.com wrote:
On Fri, 24 Sep 2010 14:24:31 -0500
Steve French smfre...@gmail.com wrote:
On Fri, Sep 24, 2010 at 2:08 PM, Jeff Layton jlay...@redhat.com wrote
On Sat, 25 Sep 2010 00:23:30 -0400
Christoph Hellwig h...@infradead.org wrote:
On Fri, Sep 24, 2010 at 02:11:37PM -0400, Jeff Layton wrote:
On Fri, 24 Sep 2010 12:58:55 -0500
Steve French smfre...@gmail.com wrote:
We need to see the performance impact. As you say cifs_writepages
On Mon, 27 Sep 2010 18:23:40 +0530
Suresh Jayaraman sjayara...@suse.de wrote:
On 09/20/2010 09:21 PM, Jeff Layton wrote:
It's causing some unwanted behaviour.
How can I change that, or is this not changeable?
Stef
I think it's just a matter of setting the inode-i_size
. You'll probably have to do some
debugging to track down the cause. Maybe look at captures in wireshark
and see if you can discern the difference in behavior between the two
runs.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
to returning from a write call.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 25 Sep 2010 08:16:44 -0400
Jeff Layton jlay...@redhat.com wrote:
On Sat, 25 Sep 2010 00:23:30 -0400
Christoph Hellwig h...@infradead.org wrote:
On Fri, Sep 24, 2010 at 02:11:37PM -0400, Jeff Layton wrote:
On Fri, 24 Sep 2010 12:58:55 -0500
Steve French smfre...@gmail.com wrote
...@kernel.org
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/inode.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 2256124..d6db805 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -853,6 +853,8 @@ retry_iget5_locked
that doesn't attempt to perform a reconnect.
Reported-and-Tested-by: Michal Suchanek hramr...@centrum.cz
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifssmb.c | 49 +
1 files changed, 33 insertions(+), 16 deletions(-)
diff --git a/fs/cifs
on the patch posting.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 29 Sep 2010 15:27:08 -0400
Jeff Layton jlay...@redhat.com wrote:
cifs_reconnect_tcon is called from smb_init. After a successful
reconnect, cifs_reconnect_tcon will call reset_cifs_unix_caps. That
function will, in turn call CIFSSMBQFSUnixInfo and CIFSSMBSetFSUnixInfo.
Those functions
On Wed, 29 Sep 2010 19:17:30 -0400
Christoph Hellwig h...@infradead.org wrote:
On Wed, Sep 29, 2010 at 09:49:54AM -0400, Jeff Layton wrote:
Testing on very recent kernel (2.6.36-rc6) made this warning pop:
WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x65/0x70()
Hardware name
On Mon, 4 Oct 2010 07:52:08 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Mon, Oct 4, 2010 at 6:02 AM, Jeff Layton jlay...@redhat.com wrote:
On Wed, 29 Sep 2010 09:39:37 -0500
shirishpargaon...@gmail.com wrote:
From: Shirish Pargaonkar shirishpargaon...@gmail.com
On Mon, 4 Oct 2010 08:00:57 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Mon, Oct 4, 2010 at 7:53 AM, Jeff Layton jlay...@redhat.com wrote:
On Mon, 4 Oct 2010 07:52:08 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Mon, Oct 4, 2010 at 6:02 AM, Jeff
-req.hdr.Flags2 |= SMBFLG2_EXT_SEC;
Ok, so basically this moves all of the session key data structures from
the server to session. Once you calculate the key however and have a
successful session setup, don't you need to copy that key from the
session to the server? Where does that happen?
--
Jeff Layton
, error %d building av pair blob, rc);
return rc;
The rest looks reasonable.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Mon, 4 Oct 2010 13:05:34 -0400
Christoph Hellwig h...@infradead.org wrote:
On Sat, Sep 25, 2010 at 08:16:44AM -0400, Jeff Layton wrote:
Hmm...there is one problem with this scheme. __fput ignores the error
return from -release. Only the errors from -flush will be returned to
userspace
from
cifsfs.h.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifs_fs_sb.h |1 +
fs/cifs/cifsfs.c | 18 ++
fs/cifs/cifsfs.h |6 ++
fs/cifs/cifsglob.h |1 -
fs/cifs/cifsproto.h |2 +-
fs/cifs/dir.c| 10 +++---
fs/cifs/file.c
of some bogus cargo-cult NULL pointer
checks in that function and reduce the level of indentation.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsglob.h |1 +
fs/cifs/dir.c |1 +
fs/cifs/file.c | 128 ++-
3 files changed
in cifs_writepages now that we hold a reference to one. I'll
hold back on that until I know how this set has been received.
This set is an ordered set and should not be committed out of order. It
should be bisectable. I've tested the resulting set and it seems to work
fine.
Jeff Layton (14):
cifs: keep dentry
All the remaining users of cifsFileInfo-pfile just use it to get
at the f_flags/f_mode. Now that we store that separately in the
cifsFileInfo, there's no need to consult the pfile at all from
a cifsFileInfo pointer.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsglob.h |1
errors
returned there do get reported to userspace.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsfs.c |1 -
fs/cifs/cifsglob.h |1 -
fs/cifs/file.c | 31 +++
fs/cifs/inode.c| 15 +--
4 files changed, 12 insertions
Have cifs_write take a cifsFileInfo pointer instead of a filp. Since
cifsFileInfo holds references on the dentry, and that holds one to
the inode, we can eliminate some unneeded NULL pointer checks.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/file.c | 51
On Mon, 4 Oct 2010 18:08:24 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Mon, Oct 4, 2010 at 5:41 AM, Jeff Layton jlay...@redhat.com wrote:
On Wed, 29 Sep 2010 09:38:48 -0500
shirishpargaon...@gmail.com wrote:
From: Shirish Pargaonkar shirishpargaon...@gmail.com
is certainly
appropriate at this point.
Acked-by: Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 4 Oct 2010 18:13:23 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Mon, Oct 4, 2010 at 8:18 AM, Jeff Layton jlay...@redhat.com wrote:
On Mon, 4 Oct 2010 08:00:57 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Mon, Oct 4, 2010 at 7:53 AM, Jeff
On Tue, 5 Oct 2010 18:21:11 -0400
Jeff Layton jlay...@redhat.com wrote:
On Tue, 5 Oct 2010 15:18:29 -0400
david.kond...@legrand.us wrote:
Greetings:
We have a product that uses cifs mounts to catalog digital music on
cifs/smb shares on our user's network. We have noticed
On Tue, 5 Oct 2010 22:24:01 -0500
Steve French smfre...@gmail.com wrote:
On Tue, Oct 5, 2010 at 5:19 PM, Jeff Layton jlay...@samba.org wrote:
On Tue, 5 Oct 2010 17:01:18 -0500
Steve French smfre...@gmail.com wrote:
In reviewing this patch which changes the show_options on cifs mounts
) {
if (iov[0].iov_len % 2) {
*bcc_ptr = 0;
Acked-by: Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
to the dentry. Since the dentry will have a
reference to the inode, we can eliminate the pInode field too and
convert the igrab/iput to dget/dput.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
Acked-by: Dave Kleikamp sha...@linux.vnet.ibm.com
---
fs/cifs
This function is redundant. The only thing it does is set the canCache
flags, but those get set in cifs_new_fileinfo anyway.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
Acked-by: Dave Kleikamp sha...@linux.vnet.ibm.com
---
fs/cifs/file.c | 67
of some bogus cargo-cult NULL pointer
checks in that function and reduce the level of indentation.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
Acked-by: Dave Kleikamp sha...@linux.vnet.ibm.com
---
fs/cifs/cifsglob.h |1 +
fs/cifs/dir.c
It's currently in dir.c which makes little sense...
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
Acked-by: Dave Kleikamp sha...@linux.vnet.ibm.com
---
fs/cifs/dir.c | 50 --
fs/cifs/file.c | 48
for
the presence of FMODE_READ. Luckily that only affects how the f_list is
ordered.
What we really want here is the file-f_mode. Since we pass in a file
pointer already anyway, just use the f_mode there for this purpose.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman
from
cifsfs.h.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
Acked-by: Dave Kleikamp sha...@linux.vnet.ibm.com
---
fs/cifs/cifs_fs_sb.h |1 +
fs/cifs/cifsfs.c | 18 ++
fs/cifs/cifsfs.h |6 ++
fs/cifs/cifsglob.h
The count for cifsFileInfo is currently an atomic, but that just adds
complexity for little value. We generally need to hold cifs_file_list_lock
to traverse the lists anyway so we might as well make this counter
non-atomic and simply use the cifs_file_list_lock to protect it.
Signed-off-by: Jeff
All the remaining users of cifsFileInfo-pfile just use it to get
at the f_flags/f_mode. Now that we store that separately in the
cifsFileInfo, there's no need to consult the pfile at all from
a cifsFileInfo pointer.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman
...and make it non-inlined in preparation for the move of most of
cifs_close to it.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsglob.h | 10 +-
fs/cifs/file.c | 10 ++
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/fs/cifs/cifsglob.h b
I am never able to type the old name right on the first try. It's also a
misleading name for the lock which really is used to protect the lists
that a cifsFileInfo sits on.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsfs.c |2 +-
fs/cifs/cifsglob.h |2 +-
fs/cifs
cifsFileInfo. If we have an active reference to the file
then it's never going to have a close pending.
cifs_close is converted to simply put the filehandle.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsglob.h |1 -
fs/cifs/file.c | 187
.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/file.c | 21 +++--
1 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 3a917be..74f1864 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -1625,20 +1625,13 @@ int cifs_flush
On Thu, 07 Oct 2010 12:37:19 +0530
Suresh Jayaraman sjayara...@suse.de wrote:
On 10/07/2010 01:24 AM, Jeff Layton wrote:
Now that it's feasible for a cifsFileInfo to outlive the filp under
which it was created, move the close processing into cifsFileInfo_put.
This means that the last
On Thu, 07 Oct 2010 14:18:50 +0530
Suresh Jayaraman sjayara...@suse.de wrote:
On 10/07/2010 01:24 AM, Jeff Layton wrote:
The count for cifsFileInfo is currently an atomic, but that just adds
complexity for little value. We generally need to hold cifs_file_list_lock
to traverse the lists
On Thu, 7 Oct 2010 10:37:54 -0500
Steve French smfre...@gmail.com wrote:
On Thu, Oct 7, 2010 at 7:43 AM, Jeff Layton jlay...@redhat.com wrote:
On Thu, 07 Oct 2010 17:42:57 +0530
Suresh Jayaraman sjayara...@suse.de wrote:
On 10/07/2010 04:48 PM, Jeff Layton wrote:
On Thu, 07 Oct 2010
-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/inode.c | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 7cf3d93..d3f9a18 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -1759,7 +1759,7 @@ check_inval:
}
int
. After
reviewing the code more thoroughly, I came to the conclusion that the
list order was essentially meaningless anyway.
The rest of the set is essentially unchanged. I've left Suresh and
Shaggy's Acked-by/Reviewed-by lines in place except on patches that
have had substantial changes.
Jeff Layton
from
cifsfs.h.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
Acked-by: Dave Kleikamp sha...@linux.vnet.ibm.com
---
fs/cifs/cifs_fs_sb.h |1 +
fs/cifs/cifsfs.c | 18 ++
fs/cifs/cifsfs.h |6 ++
fs/cifs/cifsglob.h
to the dentry. Since the dentry will have a
reference to the inode, we can eliminate the pInode field too and
convert the igrab/iput to dget/dput.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
Acked-by: Dave Kleikamp sha...@linux.vnet.ibm.com
---
fs/cifs
of some bogus cargo-cult NULL pointer
checks in that function and reduce the level of indentation.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
Acked-by: Dave Kleikamp sha...@linux.vnet.ibm.com
---
fs/cifs/cifsglob.h |1 +
fs/cifs/dir.c
All the remaining users of cifsFileInfo-pfile just use it to get
at the f_flags/f_mode. Now that we store that separately in the
cifsFileInfo, there's no need to consult the pfile at all from
a cifsFileInfo pointer.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman
(), and that will virtually never return a
NULL pointer anyway.
Finally, move the setting of the canCache* flags outside of the lock.
Other places in the code don't hold that lock when setting it, so I
assume it's not really needed here either.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh
The count for cifsFileInfo is currently an atomic, but that just adds
complexity for little value. We generally need to hold cifs_file_list_lock
to traverse the lists anyway so we might as well make this counter
non-atomic and simply use the cifs_file_list_lock to protect it.
Signed-off-by: Jeff
. cifsFileInfo_put can sleep and shouldn't be
called while holding the lock.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsfs.c |2 +-
fs/cifs/cifsglob.h |2 +-
fs/cifs/cifssmb.c |4 +-
fs/cifs/file.c | 54 ++--
fs/cifs
errors
returned there do get reported to userspace.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
---
fs/cifs/cifsfs.c |1 -
fs/cifs/cifsglob.h |1 -
fs/cifs/file.c | 34 --
fs/cifs/inode.c| 15
...and make it non-inlined in preparation for the move of most of
cifs_close to it.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
---
fs/cifs/cifsglob.h | 10 +-
fs/cifs/file.c | 10 ++
2 files changed, 11 insertions(+), 9
Signed-off-by: Jeff Layton jlay...@samba.org
---
mount.cifs.8 |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/mount.cifs.8 b/mount.cifs.8
index d01f2a3..7d2bf69 100644
--- a/mount.cifs.8
+++ b/mount.cifs.8
@@ -396,6 +396,13 @@ Enable local disk caching using FS
any real value, especially not with
something as simple as this.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
It's currently in dir.c which makes little sense...
Signed-off-by: Jeff Layton jlay...@redhat.com
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
Acked-by: Dave Kleikamp sha...@linux.vnet.ibm.com
---
fs/cifs/dir.c | 44
fs/cifs/file.c | 43
101 - 200 of 2365 matches
Mail list logo
