the callback.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsglob.h |2 +-
fs/cifs/connect.c | 27 ++-
fs/cifs/transport.c |3 +++
3 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index 921b884
...
Most likely you're seeing the result of a lack of parallelism in the
Linux kernel cifs client. It does not do async writes (yet), which
really hinders throughput.
I'm hoping to get to work on that in the next few months unless someone
else beats me to it...
--
Jeff Layton jlay...@redhat.com
to
reject it for that reason alone.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 28 Jan 2011 12:53:52 -0600
Steve French smfre...@gmail.com wrote:
On Fri, Jan 28, 2011 at 6:24 AM, Jeff Layton jlay...@redhat.com wrote:
The cERROR message in checkSMB when the calculated length doesn't match
the RFC1001 length is incorrect in many cases. It always says
and clean out the pending_mid_q.
While we're at it, clean up the function a bit and eliminate an
unnecessary NULL pointer check.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/misc.c | 37 -
1 files changed, 24 insertions(+), 13 deletions(-)
diff
: Shirish Pargaonkar shirishpargaon...@gmail.com
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/link.c |3 ++-
fs/cifs/smbencrypt.c |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index 02cd60a..e8804d3 100644
--- a/fs/cifs
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
I fixed this a few days ago along with a number of other compiler
warnings in:
[PATCH] cifs: clean up some compiler warnings
...just waiting for Steve to merge it.
--
Jeff
Recently CIFS was changed to use the kernel crypto API for MD4 hashes,
but the Kconfig dependencies were not changed to reflect this.
Signed-off-by: Jeff Layton jlay...@redhat.com
Reported-by: Suresh Jayaraman sjayara...@suse.de
---
fs/cifs/Kconfig |1 +
1 files changed, 1 insertions(+), 0
.
Signed-off-by: Jeff Layton jlay...@samba.org
---
mount.cifs.c |2 +-
mount.h |1 +
mtab.c | 16
3 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/mount.cifs.c b/mount.cifs.c
index f537a07..5f29761 100644
--- a/mount.cifs.c
+++ b/mount.cifs.c
It's possible to goto return_i in this function at several points
before line_buf is set. At that point, the NULL pointer check won't
work correctly and we can end up with a SIGSEGV.
Signed-off-by: Jeff Layton jlay...@samba.org
---
mount.cifs.c |2 +-
1 files changed, 1 insertions(+), 1
to implement some sort of LRU
scheme? Remember that this code is likely to be called quite
frequently if someone turns it on. It really is important to make this
very efficient.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
it ought to be a design goal here particularly since this is
likely to happen quite a lot...
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
eliminate those lines altogether.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
that so I
don't think there's any danger of a buffer overrun or anything, but the
stuff at the end could just be garbage or zeroed out.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More
cifs_sign_smb only generates a signature if the correct Flags2 bit is
set. Make sure that it gets set correctly if we're sending an async
call.
This patch fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=28142
Reported-and-Tested-by: JG j...@cms.ac
Signed-off-by: Jeff Layton jlay
unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord
currently maintain the cifs-utils package which contains the
cifs.upcall program, and wrote most of the in-kernel pieces of the
current SPNEGO/krb5 upcall for CIFS. I've also done a some work on
the GSSAPI upcall pieces in the RPC layer and in nfs-utils.
--
Jeff Layton jlay...@redhat.com
ses-status is never set to CifsExiting, so these checks are
always false.
Tested-by: JG j...@cms.ac
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifssmb.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index 46c66ed
On Mon, 7 Feb 2011 11:42:05 -0600
Steve French smfre...@gmail.com wrote:
On Mon, Feb 7, 2011 at 7:54 AM, Jeff Layton jlay...@redhat.com wrote:
Commit 247ec9b4 makes the SMB echo workqueue job skip doing echoes
unless the tcpStatus == CifsGood. Problem: tcpStatus == CifsGood
for this is bypassed.
Reported-by: Erik Logtenberg e...@logtenberg.eu
Signed-off-by: Jeff Layton jlay...@samba.org
---
mount.cifs.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/mount.cifs.c b/mount.cifs.c
index 3a2b539..8e1e32b 100644
--- a/mount.cifs.c
+++ b/mount.cifs.c
meaningless. I'd also like
to see the comment altered to mention why you're checking for
maxBuf == 0 as it's not at all obvious.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo
Follow-on patch to 7e90d705 which is already in Steve's tree...
The check for tcpStatus == CifsGood is not meaningful since it doesn't
indicate whether the NEGOTIATE request has been done. Also, clarify
why we're checking for maxBuf == 0.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs
to
find a matching mid_q_entry, mark it as having a malformed response and
issue the callback.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsglob.h |2 +-
fs/cifs/connect.c | 30 --
fs/cifs/transport.c |3 +++
3 files changed, 28 insertions
...@sernet.de
Signed-off-by: Jeff Layton jlay...@samba.org
---
resolve_host.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/resolve_host.c b/resolve_host.c
index 7687503..69859a3 100644
--- a/resolve_host.c
+++ b/resolve_host.c
@@ -71,7 +71,7 @@ int resolve_host(const char *host
) - 1)
+ == 0)) {
+ rc = cifs_sid_resolver(key, buf);
+ goto out;
+ }
+
have = decode_key_description(buf, arg);
SAFE_FREE(buf);
if ((have DKD_MUSTHAVE_SET) != DKD_MUSTHAVE_SET) {
--
Jeff Layton jlay...@redhat.com
This may also be helped by the d_automount patches that dhowells did
recently and that are going into 2.6.38, but I haven't had time to look
yet.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
;
+ }
}
static void
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 16 Feb 2011 08:46:03 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Wed, Feb 16, 2011 at 6:53 AM, Jeff Layton jlay...@redhat.com wrote:
On Tue, 15 Feb 2011 17:10:43 -0600
shirishpargaon...@gmail.com wrote:
From: Shirish Pargaonkar shirishpargaon...@gmail.com
On Wed, 16 Feb 2011 09:06:08 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Wed, Feb 16, 2011 at 9:01 AM, Jeff Layton jlay...@redhat.com wrote:
On Wed, 16 Feb 2011 08:46:03 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Wed, Feb 16, 2011 at 6:53 AM, Jeff
On Wed, 16 Feb 2011 09:27:28 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Wed, Feb 16, 2011 at 9:21 AM, Jeff Layton jlay...@redhat.com wrote:
On Wed, 16 Feb 2011 09:06:08 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Wed, Feb 16, 2011 at 9:01 AM, Jeff
++) {
key[i] = (key[i] 1);
+ if (!odd_parity(key[i]))
+ key[i] |= 0x1; /* add odd parity bit */
+ }
}
static void
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
On Wed, 16 Feb 2011 12:05:34 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Tue, Feb 15, 2011 at 2:45 PM, Jeff Layton jlay...@redhat.com wrote:
On Fri, 11 Feb 2011 12:49:09 -0600
shirishpargaon...@gmail.com wrote:
From: Shirish Pargaonkar shirishpargaon...@gmail.com
to do
this that I don't see right offhand.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 17 Feb 2011 00:59:44 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Wed, Feb 16, 2011 at 7:52 PM, Jeff Layton jlay...@redhat.com wrote:
On Wed, 16 Feb 2011 18:05:28 -0600
shirishpargaon...@gmail.com wrote:
From: Shirish Pargaonkar shirishpargaon...@gmail.com
On Thu, 17 Feb 2011 07:54:43 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Thu, Feb 17, 2011 at 6:59 AM, Jeff Layton jlay...@redhat.com wrote:
On Thu, 17 Feb 2011 00:59:44 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Wed, Feb 16, 2011 at 7:52 PM, Jeff
= {
.encode_fs = */
};
-#endif /* EXPERIMENTAL */
+#endif /* CIFS_NFSD_EXPORT */
Looks good.
Reviewed-by: Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
think about what the right approach is.
Reviewed-by: Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
since you
might not know the version until later. In that case, you probably will
just have to ignore options that don't have any effect on the version
negotiated.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message
be a NULL pointer, what prevents the code above
from oopsing if no one passes in a user= parm?
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Mon, 28 Feb 2011 15:09:00 -0600
Steve French smfre...@gmail.com wrote:
On Mon, Feb 28, 2011 at 12:59 PM, Jeff Layton jlay...@redhat.com wrote:
On Fri, 25 Feb 2011 12:24:17 -0600
Steve French smfre...@gmail.com wrote:
commit 355e57ca063338eb00ea067a7570bb5f136cc513
Author: Steve
no way to look up inodes by
anything like an inode number really makes this whole idea dead on
arrival.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
certainly possible that the
file has been renamed on the server or by another client. If that's the
case, the NFS client will have no valid path that it can reuse anyway.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
cifs_idmap_key_type;
+extern const struct cred *root_cred;
+#endif /* KERNEL */
+
extern int match_sid(struct cifs_sid *);
extern int compare_sids(const struct cifs_sid *, const struct cifs_sid *);
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe from this list: send the line
', 16);
memset(p21, '\0', 21);
rc = E_md4hash(passwd, p16);
perhaps ARRAY_SIZE() instead of a magic number is a better choice ?
Agreed. Care to propose a patch? There are almost certainly other
places in the code that could use a similar cleanup.
--
Jeff Layton jlay
On Mon, 7 Mar 2011 13:28:14 -0500
Jeff Layton jlay...@redhat.com wrote:
On Mon, 7 Mar 2011 11:09:06 -0600
Steve French smfre...@gmail.com wrote:
On Mon, Mar 7, 2011 at 9:53 AM, Jeff Layton jlay...@redhat.com wrote:
On Mon, 7 Mar 2011 09:07:52 -0600
Steve French smfre...@gmail.com
*);
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
change. Do you need to
invalidate the metadata for the inode at that point?
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 8 Mar 2011 09:17:48 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Tue, Mar 8, 2011 at 8:32 AM, Jeff Layton jlay...@redhat.com wrote:
On Mon, 7 Mar 2011 23:00:25 -0600
shirishpargaon...@gmail.com wrote:
From: Shirish Pargaonkar shirishpargaon...@gmail.com
. the cost of
allocating memory and performing an upcall.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 8 Mar 2011 09:55:08 -0600
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Tue, Mar 8, 2011 at 9:43 AM, Shirish Pargaonkar
shirishpargaon...@gmail.com wrote:
On Tue, Mar 8, 2011 at 9:22 AM, Jeff Layton jlay...@redhat.com wrote:
On Tue, 8 Mar 2011 09:17:48 -0600
Shirish
a SMB_COM_FLUSH for a NFS COMMIT call...
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
layer doesn't have a mechanism
to notify us of a TCP ACK. So, we have to wait for the next-best thing
-- a response from the server.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More
On Wed, 9 Mar 2011 18:33:20 -0600
Steve French smfre...@gmail.com wrote:
On Wed, Mar 9, 2011 at 5:54 PM, Jeff Layton jlay...@redhat.com wrote:
On Wed, 9 Mar 2011 16:01:30 -0600
Steve French smfre...@gmail.com wrote:
Except we don't need to wait that long with the page locked
ie
On Wed, 9 Mar 2011 18:45:42 -0500
Jeff Layton jlay...@redhat.com wrote:
On Thu, 10 Mar 2011 08:51:48 +1100
Dave Chinner da...@fromorbit.com wrote:
Sounds like a case for the same dirty page lifecycle as NFS: clean
- dirty - writeback - unstable - clean. i.e. the page is
unstable after
).
The only real danger is from processes that have the page mmapped as
they don't care about the page lock at all. A page_mkwrite routine that
does a wait_on_page_writeback should prevent that however.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe
contenders for the page lock.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-cifs-client/2010-February/005548.html
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 11 Mar 2011 14:59:17 -0500
Jeff Layton jlay...@redhat.com wrote:
On Fri, 25 Feb 2011 23:25:08 -0600
Steve French smfre...@gmail.com wrote:
+
+/* one of these for every pending SMB2 request to the server */
+struct smb2_mid_entry {
+ struct list_head qhead; /* mids waiting
-auth_key.response = kmalloc(tilen, GFP_KERNEL);
if (!ses-auth_key.response) {
Reviewed-by: Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
allow the client to chase the DFS referral at
mount time instead.
Cc: sta...@kernel.org
Reported-and-Tested-by: Yogesh Sharma ysha...@cymer.com
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/connect.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/cifs
://bugzilla.redhat.com/show_bug.cgi?id=682829
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
that the files created with
mapchars mount option may not be accessible if the share is mounted without
that option\.
--
1.7.1
Jeff, what's about this?
Merged.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
be changed to an int return and
the callers could return errors from it?
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
module option and
always inline the pages when writing.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsfs.c |4 ---
fs/cifs/cifsglob.h |1 -
fs/cifs/file.c | 62 ++--
3 files changed, 31 insertions(+), 36 deletions
The BCC is still __le16 at this point, and in any case we need to
use the get_bcc_le macro to make sure we don't hit alignment
problems.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/misc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/cifs/misc.c b/fs
the state has actually changed from
CifsNeedReconnect.
Reported-and-Tested-by: JG j...@cms.ac
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsglob.h |3 ++-
fs/cifs/cifssmb.c |4 ++--
fs/cifs/connect.c |8
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git
writeable until
the write call has completed.
With this, we can also remove the sign_zero_copy module option and
always inline the pages when writing.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsfs.c |4 ---
fs/cifs/cifsglob.h |1 -
fs/cifs/file.c | 62
cleanup. Don't forget the SoB line though ;)
Reviewed-by: Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 22 Mar 2011 09:50:43 -0500
Steve French smfre...@gmail.com wrote:
On Tue, Mar 22, 2011 at 7:04 AM, Jeff Layton jlay...@redhat.com wrote:
On Tue, 22 Mar 2011 15:01:11 +0300
Pavel Shilovsky pias...@etersoft.ru wrote:
2011/3/22 Jeff Layton jlay...@redhat.com:
On Wed, 16 Mar 2011
that much of the existing code could be repurposed
for SMB2? This approach is going to vastly increase the maintenance
burden and I don't see that we gain anything from it.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
On Wed, 23 Mar 2011 12:42:26 -0500
Steve French smfre...@gmail.com wrote:
On Wed, Mar 23, 2011 at 11:06 AM, Jeff Layton jlay...@redhat.com wrote:
On Sat, 12 Mar 2011 19:55:55 -0600
Steve French smfre...@gmail.com wrote:
Previously CIFS added a function, sync_mid_result, to better handle
On Wed, 23 Mar 2011 13:26:19 -0500
Steve French smfre...@gmail.com wrote:
On Wed, Mar 23, 2011 at 1:06 PM, Jeff Layton jlay...@redhat.com wrote:
Maybe you misunderstand me.
The struct is *exactly the same* aside from a few small differences. It
doesn't even need to be a union, IMO
attributes and don't need to
+ * aware about busy pages (-EBUSY error code).
+ */
+ if (err == -EBUSY)
+ err = 0;
if (!err) {
generic_fillattr(dentry-d_inode, stat);
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line
On Fri, 25 Mar 2011 07:56:07 +0300
Pavel Shilovsky pias...@etersoft.ru wrote:
2011/3/25 Jeff Layton jlay...@redhat.com:
On Thu, 24 Mar 2011 17:39:47 +0300
Pavel Shilovsky pias...@etersoft.ru wrote:
Base of approach for splitting all calls that uses cifs_invalidate_mapping
as that in the
default_backing_dev_info.
Cc: sta...@kernel.org
Reported-and-Tested-by: Till till2.schae...@uni-dortmund.de
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsfs.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index 1af2470..fb6a2ad
);
goto try_mount_again;
}
+ goto mount_fail_check;
#else /* No DFS support, return error on mount */
rc = -EOPNOTSUPP;
#endif
Other than that, it looks like a good cleanup. Nice work.
--
Jeff Layton jlay...@redhat.com
On Fri, 25 Mar 2011 16:25:57 -0400
Jeff Layton jlay...@redhat.com wrote:
Commit 522440ed made cifs set backing_dev_info on the mapping attached
to new inodes. This change caused a fairly significant read performance
regression, as cifs started doing page-sized reads exclusively.
By virtue
and decide which settings mean that you need to create a
new superblock instead of using an existing one on a new mount.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info
? It shouldn't, AFAICT.
The thread getting the -EBUSY ought to be the one that next attempts to
access the page.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
.
Shirish probably ought to review this... cc'ing him.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
of the existing callers of generic_file_mmap that
set the vm_ops don't do it unless generic_file_mmap succeeds. I'll
respin it...
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo
, TASK_INTERRUPTIBLE);
+ if (rc) {
+ cFYI(1, %s: sidid_pending_wait interrupted %d,
+ __func__, rc);
+ return rc;
+ }
+ }
+
+
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send
On Mon, 28 Mar 2011 16:09:09 -0400
Jeff Layton jlay...@redhat.com wrote:
If a process has a dirty page mapped into its page tables, then it has
the ability to change it while the client is trying to write the data
out to the server. If that happens after the signature has been
calculated
) then it negatively instantiates the key
with a 60s timeout.
Is that reasonable behavior here?
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
to use the get_bcc inline which should also clean up some
unaligned accesses.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifs_debug.c |2 +-
fs/cifs/cifspdu.h| 22 +
fs/cifs/cifsproto.h |1 -
fs/cifs/cifssmb.c| 61
an EBUSY as long as the
launder_page succeeds. If it doesn't then you probably want to return
an error in the above cases anyway.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More
smoke testing with the connectathon tests.
Jeff Layton (5):
cifs: turn BCC into a static inlined function
cifs: remove unneeded variable initialization in cifs_reconnect_tcon
cifs: fix comment in validate_t2
cifs: clean up length checks in check2ndT2
cifs: clean up various nits in unicode
Howells dhowe...@redhat.com
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifspdu.h |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h
index 291d735..de3aa28 100644
--- a/fs/cifs/cifspdu.h
+++ b/fs/cifs/cifspdu.h
it up per his recommendation...
Reported-and-acked-by: David Howells dhowe...@redhat.com
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/connect.c | 26 +-
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
Reported-and-acked-by: David Howells dhowe...@redhat.com
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifssmb.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index 1622978..4f5c6d0 100644
--- a/fs/cifs/cifssmb.c
+++ b
instead to use cpu_to_le16, and simply use put_unaligned to set them
in the string.
Reported-and-acked-by: David Howells dhowe...@redhat.com
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifs_unicode.c | 35 +--
fs/cifs/cifs_unicode.h |2 +-
2
mount_fail_check;
#else /* No DFS support, return error on mount */
rc = -EOPNOTSUPP;
#endif
Looks good. Nice work...
Reviewed-by: Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord
that check in there.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
return 0;
^^
In the event that there's no error, what frees mountdata_copy here?
+
+cifs_parse_mount_err:
+ kfree(mountdata_copy);
+ return 1;
}
/** Returns true if srcaddr isn't specified and rhs isn't
--
Jeff Layton jlay...@redhat.com
) {
- if (mount_data != mount_data_global)
- kfree(mount_data);
/* If find_unc succeeded then rc == 0 so we can not end */
/* up accidently freeing someone elses tcon struct */
if (tcon)
Other than the above nit...nice cleanup.
Reviewed-by: Jeff
On Fri, 1 Apr 2011 11:01:57 -0400
Jeff Layton jlay...@redhat.com wrote:
Good point. I wasn't thinking about that case.
I think having cifs_sb-mountdata as an unconditional member would be a
better option. We don't generally have *that* many superblocks and it
would be nice to get rid
On Fri, 1 Apr 2011 17:32:29 +0200
sean finney sean...@seanius.net wrote:
Hi Jeff,
On Fri, Apr 01, 2011 at 11:01:57AM -0400, Jeff Layton wrote:
On Fri, 1 Apr 2011 16:26:25 +0200
sean finney sean...@seanius.net wrote:
On Fri, Apr 01, 2011 at 09:09:08AM -0400, Jeff Layton wrote
On Sat, 2 Apr 2011 07:34:30 -0400
Jeff Layton jlay...@redhat.com wrote:
While testing my patchset to fix asynchronous writes, I hit a bunch
of signature problems when testing with signing on. The problem seems
to be that signature checks on receive can be running at the same
time
this requires that we take extra care
not to have sync_mid_result remove the mid from the list when the
mid is in a state where that has already happened. This prevents
list corruption when the mid is sitting on a private list for
reconnect or when cifsd is coming down.
Signed-off-by: Jeff Layton
501 - 600 of 2365 matches
Mail list logo
