On Fri, Jun 25, 2010 at 5:26 PM, Jeff Layton wrote:
>
> On Fri, 25 Jun 2010 22:46:38 +0100
> David Howells wrote:
>
> > Jeff Layton wrote:
> >
> > > Looks like it mostly uses the ctime. IMO, the mtime would be a better
> > > choice since it changes less frequently, but I don't guess that it
> >
On Mon, Jun 28, 2010 at 11:26 AM, David Howells wrote:
> Make the file creation time, inode data version number and inode generation
> number available on Ext4 by as xattrs named:
>
> file.crtime
> file.i_generation
> file.i_version (directories only for ext4)
>
> This could t
On Mon, Jun 28, 2010 at 11:48 AM, Jeremy Allison wrote:
> On Mon, Jun 28, 2010 at 11:33:10AM -0500, Steve French wrote:
>>
>> It would be easy enough to do something similar for crtime for cifs
>> (it may also be possible to do something similar to
>> i_generation and
On Mon, Jun 28, 2010 at 2:38 PM, David Howells wrote:
> Andreas Dilger wrote:
>
>> - I'd prefer calling these "file.generation" and "file.version".
>> I don't think there is value in the "i_" prefix adds anything,
>> and it seems more like an internal detail to me
>
> That's reasonable.
>
>>
On Tue, Jun 29, 2010 at 3:02 PM, David Howells wrote:
> Implement a pair of new system calls to provide extended and further
> extensible
> stat functions.
>
> The third of the associated patches provides these new system calls:
>
> struct xstat_dev {
> unsigned int major
On Tue, Jun 29, 2010 at 5:13 PM, Ulrich Drepper wrote:
> On Tue, Jun 29, 2010 at 13:03, David Howells wrote:
>> Add a pair of system calls to make extended file stats available, including
>> file creation time, inode version and data version where available through
>> the
>> underlying filesyste
On Wed, Jun 30, 2010 at 6:55 AM, Jeff Layton wrote:
> On Wed, 30 Jun 2010 09:25:10 +1000
> Andrew Bartlett wrote:
>
>> On Sat, 2010-04-10 at 23:09 -0500, Shirish Pargaonkar wrote:
>> > On Sat, Apr 10, 2010 at 5:17 PM, Jeff Layton wrote:
>> > > I've been playing with NTLMSSP today in CIFS, and ha
ok - sounds fine at first glance to me, but I will look. thx (this
will help smb2 too - to have dns code separated out)
On Wed, Jul 7, 2010 at 4:14 AM, David Howells wrote:
> Hi Steve,
>
> The associated patches extract the dns_resolver key type from the CIFS
> filesystem and make it useful by AF
On Wed, Jul 14, 2010 at 12:41 PM, Scott Lovenberg
wrote:
> On 7/5/2010 8:41 AM, Suresh Jayaraman wrote:
>>
>> This patchset is a second try at adding persistent, local caching facility
>> for
>> CIFS using the FS-Cache interface.
>>
>>
>
> Just wondering, have you bench marked this at all? I'd be
merged into cifs-2.6.git
On Mon, Jul 12, 2010 at 3:50 PM, Joe Perches wrote:
> Signed-off-by: Joe Perches
> ---
> fs/cifs/file.c | 24 ++--
> fs/cifs/inode.c | 4 ++--
> fs/cifs/ioctl.c | 3 +--
> 3 files changed, 13 insertions(+), 18 deletions(-)
>
> diff --git a/f
I merged the first 5 of this series, but wanted to understand what
behavior this changes first (it is probably ok). With current
userspace code - what changes would a user see with this?
On Sun, Jun 20, 2010 at 4:10 PM, Jeff Layton wrote:
> Right now, there's no clear separation between the uid
merged into cifs-2.6.git
On Fri, Jul 16, 2010 at 11:15 AM, Kulikov Vasiliy wrote:
> If kmalloc() fails exit with -ENOMEM.
>
> Signed-off-by: Kulikov Vasiliy
> ---
> fs/cifs/readdir.c | 5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/fs/cifs/readdir.c b/fs/cifs/re
On Tue, Jul 20, 2010 at 10:25 AM, Jeff Layton wrote:
> On Wed, 07 Jul 2010 10:14:11 +0100
> David Howells wrote:
>
>> From: Wang Lei
>>
>
> [snip]--
>
>> +/**
>> + * dns_resolve_unc_to_ip - Resolve UNC server name to ip address.
>> + * @unc: UNC path specifying th
On Fri, Jul 23, 2010 at 6:57 AM, Suresh Jayaraman wrote:
> On 07/22/2010 11:10 PM, David Howells wrote:
>> Suresh Jayaraman wrote:
>>
>>> As it can been seen, the performance while reading when data is cache
>>> hot (disk) is not great as the network link is a Gigabit ethernet (with
>>> server ha
On Thu, Jul 1, 2010 at 6:52 PM, Jeff Layton wrote:
> On Thu, 1 Jul 2010 16:55:58 -0500
> Steve French wrote:
>> For cifs: use CreationTime like an i_generation field
>> Seems like a good idea, but what happens if server is unix one without
>> birth time, eg samba w
On Mon, Jul 26, 2010 at 9:29 AM, Jeff Layton wrote:
> Seems like a more sensible mapping than -EIO.
I agree. Also helps common case of Samba exporting read only shares by default.
> Signed-off-by: Jeff Layton
> ---
> fs/cifs/netmisc.c | 1 +
> fs/cifs/smberr.h | 1 +
> 2 files changed,
agreed - merged
On Mon, Jul 26, 2010 at 1:25 PM, Jeff Layton wrote:
> I'm not sure why this was merged with this flag hardcoded on, but it
> seems quite dangerous. Turn it off.
>
> Also, mount.cifs hands unrecognized options off to the kernel so there
> should be no need for changes there in orde
Yes - I agree with Jeff, need to add the mention of the config option
and perhaps how to tell if fsc feature is available in kernel.
On Tue, Jul 27, 2010 at 9:33 AM, Jeff Layton wrote:
> On Tue, 27 Jul 2010 19:20:00 +0530
> Suresh Jayaraman wrote:
>
>> Document the newly added local caching feat
forces dependencies on the other kernel
options being set)
On Tue, Jul 27, 2010 at 10:15 AM, Jeff Layton wrote:
> On Tue, 27 Jul 2010 10:13:14 -0500
> Steve French wrote:
>
>> Yes - I agree with Jeff, need to add the mention of the config option
>> and perhaps how to t
On Tue, Jul 27, 2010 at 11:33 AM, Suresh Jayaraman wrote:
> On 07/27/2010 08:51 PM, Steve French wrote:
>> scripts/extract-ikconfig could be run against the image (or look at
>> /proc/config.gz) - but unless there is an easier way to view kernel
>> config options on particul
If someone ever wants a script to parse this - seems like your
(original?) idea of putting this in /proc/fs/cifs/features instead of
/proc/fs/cifs/DebugData (which has various other pieces of debug
information) could be easier.
On Fri, Jul 30, 2010 at 7:55 AM, Suresh Jayaraman wrote:
> Fixed the
I don't see a useful archive of this list (I used to use marc.info for
linux-cifs on samba.org) - has anyone found a good archive of this
list.
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majord...@vger.kernel.org
More maj
On Fri, Jul 30, 2010 at 9:57 AM, Jeff Layton wrote:
> On Fri, 30 Jul 2010 09:39:04 -0500
> Steve French wrote:
>
>> If someone ever wants a script to parse this - seems like your
>> (original?) idea of putting this in /proc/fs/cifs/features instead of
>> /proc/f
On Mon, Aug 2, 2010 at 12:46 PM, Jeff Layton wrote:
> On Fri, 23 Jul 2010 17:19:29 -0500
> Steve French wrote:
>
>> On Thu, Jul 1, 2010 at 6:52 PM, Jeff Layton wrote:
>> > On Thu, 1 Jul 2010 16:55:58 -0500
>> > Steve French wrote:
>> >> For cifs
On Mon, Aug 2, 2010 at 11:55 PM, Suresh Jayaraman wrote:
>
> Steve, are you considering the following patches as well..?
>
> cifs: show features compiled in as part of DebugData
> cifs: update README
>
> (I think there are no outstanding issues left unaddressed).
Yes - those are fine, and I will
looks fine
On Tue, Aug 3, 2010 at 9:20 AM, Jeff Layton wrote:
> The commit that added the creduid=0x%x parameter failed to increase the
> buffer allocation to account for it.
>
> Reported-by: J. Bruce Fields
> Signed-off-by: Jeff Layton
> ---
> fs/cifs/cifs_spnego.c | 4
> 1 files chan
Interesting.
Generally seems like a good idea.
Jeff made two valid review comments already (on the kmalloc vs. stack,
and the kernel coding style) but note that scripts/checkpatch.pl will
catch additional minor coding style things:
ste...@stevef-laptop:~/smb2$ scripts/checkpatch.pl ~/sm1.patch
W
I merged this (patch 3) - but patch 4 (and thus patch 5) did not merge.
Also patches 4 and 5 had trivial checkpatch warnings.
Patch 6 looks afs related so should probably merge out of your tree,
but it doesn't matter to me.
What about patches 1 and 2 - which is easier?
On Thu, Jul 22, 2010 at 12
merged.
On Fri, Jul 30, 2010 at 12:53 PM, Steve French wrote:
> On Fri, Jul 30, 2010 at 9:57 AM, Jeff Layton wrote:
>> On Fri, 30 Jul 2010 09:39:04 -0500
>> Steve French wrote:
>>
>>> If someone ever wants a script to parse this - seems like your
>>> (o
On Fri, Jul 23, 2010 at 6:13 PM, Jeff Layton wrote:
> On Fri, 23 Jul 2010 17:19:29 -0500
> Steve French wrote:
>
>> On Thu, Jul 1, 2010 at 6:52 PM, Jeff Layton wrote:
>> > On Thu, 1 Jul 2010 16:55:58 -0500
>> > Steve French wrote:
>> >> For cifs
On Wed, Aug 4, 2010 at 9:16 AM, David Howells wrote:
> From: Wang Lei
>
> Separate out the DNS resolver key type from the CIFS filesystem into its own
> module so that it can be made available for general use, including the AFS
> filesystem module.
Merged, after addressing trivial checkpatch err
The fix for the missing err.h include is merged. Not sure why I did
not run into that on my Ubuntu test builds or Dave on his builds.
Have not heard any feedback about the init.h change that Ben suggested yet.
On Wed, Aug 4, 2010 at 10:51 PM, Stephen Rothwell wrote:
> Hi Steve,
>
> After mergi
On Thu, Aug 5, 2010 at 10:38 PM, Neil Brown wrote:
> On Thu, 5 Aug 2010 16:52:18 -0700
> Jeremy Allison wrote:
>> Don't add it as an EA. It's *not* an EA, it's a timestamp.
>
> I'm curious. Why do you particularly care what interface the kernel uses to
> provide you with access to this attribut
On Fri, Aug 6, 2010 at 6:30 PM, Neil Brown wrote:
> On Thu, 5 Aug 2010 22:55:06 -0500
> Steve French wrote:
>
>> On Thu, Aug 5, 2010 at 10:38 PM, Neil Brown wrote:
>> > On Thu, 5 Aug 2010 16:52:18 -0700
>> > Jeremy Allison wrote:
>>
>> >&
On Fri, Aug 6, 2010 at 7:29 PM, Neil Brown wrote:
> On Fri, 6 Aug 2010 18:58:42 -0500
> Steve French wrote:
>
>> On Fri, Aug 6, 2010 at 6:30 PM, Neil Brown wrote:
>> > On Thu, 5 Aug 2010 22:55:06 -0500
>> > Steve French wrote:
>> >
>> >&
On Fri, Aug 6, 2010 at 9:42 PM, Steve French wrote:
> On Fri, Aug 6, 2010 at 7:29 PM, Neil Brown wrote:
>> On Fri, 6 Aug 2010 18:58:42 -0500
>> Steve French wrote:
>>
>>> On Fri, Aug 6, 2010 at 6:30 PM, Neil Brown wrote:
>>> > On Thu, 5 Aug 201
OK - will take a look.
Please let me know if anyone wants to add tested-by/reviewed-by
On Mon, Aug 9, 2010 at 11:58 AM, Stefan Metzmacher wrote:
> Hi Steve,
>
> here's the next patch set for Minshall+French symlink support.
>
> metze
>
>
--
Thanks,
Steve
--
To unsubscribe from this list: se
Patches 1 - 3 of this series now in cifs-2.6.git
On Wed, Aug 11, 2010 at 3:37 AM, David Howells wrote:
> From: Bryan Schumaker
>
> Use the kernel DNS resolver to translate hostnames to IP addresses. Create a
> new config option to choose between the legacy DNS resolver and the new
> resolver.
>
On Wed, Aug 11, 2010 at 10:17 PM, Stephen Rothwell
wrote:
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> net/dns_resolver/dns_key.c: In function 'dns_resolver_instantiate':
> net/dns_resolver/dns_key.c:70: error: dereferencing pointer to
On Thu, Aug 12, 2010 at 2:46 AM, Stephen Rothwell wrote:
> See above. You need CONFIG_NFS_USE_KERNEL_DNS to also depend on
> CONFIG_KEYS ...
Fixed in cifs-2.6.git
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majord...@v
On Fri, Aug 13, 2010 at 12:54 PM, Jeremy Allison wrote:
> On Fri, Aug 13, 2010 at 08:54:32AM -0400, J. Bruce Fields wrote:
>> On Sun, Aug 08, 2010 at 06:05:01AM -0700, Jeremy Allison wrote:
>> > We don't need to ape Windows in everything.
>> > The coming ACL disaster will show that (we will go fro
Reviewed and merged into cifs-2.6.git
On Mon, Aug 23, 2010 at 10:38 AM, Jeff Layton wrote:
>
> It's possible for a cifsSesInfo struct to have a NULL password, so we
> need to check for that prior to running strncmp on it.
>
> Signed-off-by: Jeff Layton
> ---
> fs/cifs/connect.c | 1 +
> 1 fi
On Tue, Aug 24, 2010 at 12:34 PM, Jeff Layton wrote:
> On Tue, 24 Aug 2010 18:16:19 +0200
> Björn JACKE wrote:
>
>> Hi,
>>
>> attached are patches to spot the clock_gettime function and to use that and
>> the
>> monotonic clock for timeout handling if possible.
>>
>> If there are no objections,
On Tue, Aug 24, 2010 at 6:30 PM, Jeff Layton wrote:
> On Tue, 24 Aug 2010 22:08:09 +0200
> Björn JACKE wrote:
>
> Ok, thanks for the clarification. Committed...
>
> This should make the 4.7 release.
>
> Thanks!
Yes - makes sense - thanks
--
Thanks,
Steve
--
To unsubscribe from this list: se
On Fri, Aug 20, 2010 at 2:31 PM, Jeff Layton wrote:
> The VFS always checks that the source and target of a rename are on the
> same vfsmount, and hence have the same superblock. So, this check is
> redundant. Remove it and simplify the error handling.
I looked more closely at this, and although
On Wed, Aug 25, 2010 at 6:00 PM, Ben Greear wrote:
> When using multi-homed machines, it's nice to be able to specify
> the local IP to use for outbound connections. This patch gives
> cifs the ability to bind to a particular IP address.
>
> Usage: mount -t cifs -o bindaddr=192.168.1.50,user=foo
On Wed, Aug 25, 2010 at 8:02 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/cifs/sess.c: In function 'CIFS_SessSetup':
> fs/cifs/sess.c:623: warning: unused variable 'ntlmsspblob'
>
> Introdu
This is a good one to go upstream soon - if others critical to go
upstream soon let me know.
On Thu, Aug 26, 2010 at 7:23 AM, Jeff Layton wrote:
> On Thu, 26 Aug 2010 14:46:09 +0530
> Suresh Jayaraman wrote:
>
>> On 08/26/2010 01:56 AM, joe hefner wrote:
>> > On a recent Fedora (13), I am seeing
There are clearly valid reasons for being able to select outgoing
interface - I wouldn't mind doing this using IPv6 address format if
that is more natural (since that can include ipv4 addresses) - or
distinct ipv4/ipv6
On Thu, Aug 26, 2010 at 2:57 PM, Jeff Layton wrote:
> On Thu, 26 Aug 2010 10:3
On Fri, Aug 27, 2010 at 11:52 AM, Jeff Layton wrote:
> On Fri, 27 Aug 2010 08:29:49 -0700
> Ben Greear wrote:
>
>> On 08/27/2010 06:54 AM, Jeff Layton wrote:
>>
>> >> Also, I think bindaddr might not be the best name for the option. How
>> >> about sourceaddr or srcaddr?
>> >>
>> >
>> > Sounds re
On Fri, Aug 27, 2010 at 12:34 PM, Jeff Layton wrote:
> On Fri, 27 Aug 2010 10:12:16 -0700
> Ben Greear wrote:
>
>> On 08/27/2010 10:08 AM, Steve French wrote:
>> > On Fri, Aug 27, 2010 at 11:52 AM, Jeff Layton wrote:
>> >> On Fri, 27 Aug 2010 08
On Sun, Aug 29, 2010 at 3:52 PM, Rolf G. Økland wrote:
> Hi
>
> I got an annoying problem, when I'm trying to mount my Dreambox DM800 (Linux
> client) to a windows server 2008 R2 share I get access denied for some reason.
> This have been working like a charm on my old Windows 2003 Server, but no
n for that user differs from what you think
(add something like "domain=yourserversdomain")
On Sun, Aug 29, 2010 at 4:14 PM, Steve French wrote:
> On Sun, Aug 29, 2010 at 3:52 PM, Rolf G. Økland wrote:
>> Hi
>>
>> I got an annoying problem, when I'm trying
merged
On Mon, Aug 30, 2010 at 8:05 AM, Jeff Layton wrote:
> 9fbc590860e75785bdaf8b83e48fabfe4d4f7d58 needlessly changed some "else
> if" statements in decode_negTokenInit to "if's". Not only was the change
> not needed, but it's less efficient than the existing code.
>
> When compare_oid returns
On Mon, Aug 30, 2010 at 12:38 PM, Jeff Layton wrote:
> On Mon, 30 Aug 2010 11:49:04 -0500
> Shirish Pargaonkar wrote:
>
>> On Mon, Aug 30, 2010 at 11:35 AM, Jeff Layton wrote:
>> > Testing recent kernel based on Steve's current tree (with the multiuser
>> > patchset on top). At unmount, I just g
On Mon, Aug 30, 2010 at 12:25 PM, Randy Dunlap wrote:
> On Mon, 30 Aug 2010 12:14:53 -0500 Shirish Pargaonkar wrote:
>
>> On Mon, Aug 30, 2010 at 12:00 PM, Suresh Jayaraman
>> wrote:
>> > (Cc linux-cifs@vger.kernel.org)
>> >
>> > Couldn't get a chance to check this, but I guess this is perhaps d
On Wed, Sep 1, 2010 at 7:41 AM, Jeff Layton wrote:
>
> On Tue, 31 Aug 2010 12:55:14 -0700
> Ben Greear wrote:
> > + else
> > + printk(KERN_WARNING "cifs: "
> > + "Failed to bind to: %pI4, error: %d\n",
> > +
On 9/1/10, Ben Greear wrote:
> On 09/01/2010 05:41 AM, Jeff Layton wrote:
>> On Tue, 31 Aug 2010 12:55:14 -0700
>> Ben Greear wrote:
>>
>>> When using multi-homed machines, it's nice to be able to specify
>>> the local IP to use for outbound connections. This patch gives
>>> cifs the ability to
On Thu, Sep 2, 2010 at 5:56 AM, Jeff Layton wrote:
> On Wed, 01 Sep 2010 22:07:29 -0700
> Ben Greear wrote:
>
>> On 09/01/2010 05:38 PM, Jeff Layton wrote:
>>
>> >> No warning, it always returns something since the default case catches
>> >> all others. If I did put the return at the end, then t
On Fri, Sep 3, 2010 at 5:21 PM, Steve French wrote:
>
> Good point - I need to update the smb2 howto ...
>
> If you have Windows 2008, Windows Vista or Windows 7 - smb2 just works (it is
> the default for current Windows) but for Samba (version 3.5 or later, but
> current S
On Sun, Sep 5, 2010 at 7:45 AM, Jeff Layton wrote:
> On Sun, 5 Sep 2010 18:30:46 +1000
> Andrew Hendry wrote:
>
>> Started hitting this since rc3.
>>
>> System has 6 cifs mounts from the one server, during shutdown they get
>> unmounted and gives this error.
>> If manually unmounting one at a tim
On Tue, Sep 7, 2010 at 12:21 PM, Ben Greear wrote:
>
> Here's a compile-tested patch to enable srcaddr= for smb2.
>
> It converts a bit of smb2 to be more like cifs (seems smb2 was copy
> and pasted and then cifs moved on).
>
> It also seems like much of the common code could move to a
> helper mo
On Tue, Sep 7, 2010 at 1:08 PM, Steve French wrote:
> On Tue, Sep 7, 2010 at 12:21 PM, Ben Greear wrote:
>>
>> Here's a compile-tested patch to enable srcaddr= for smb2.
>>
>> It converts a bit of smb2 to be more like cifs (seems smb2 was copy
>> and pasted
This looks independent of the others - does this have dependencies on
the rest of the series?
On Mon, Sep 6, 2010 at 10:32 PM, wrote:
> From: Shirish Pargaonkar
>
> Signed-off-by: Shirish Pargaonkar
> ---
> fs/cifs/cifssmb.c | 15 +--
> 1 files changed, 9 insertions(+), 6 deleti
-- Forwarded message --
From: Steve French
Date: Wed, Sep 8, 2010 at 2:35 PM
Subject: Re: smb2 kernel panic on module unload
To: Ben Greear
On Wed, Sep 8, 2010 at 1:37 PM, Ben Greear wrote:
> I saw this when attempting to rmmod smb2.
>
> Thanks,
> Ben
>
>
&
CIFS tree updated to back out the crypto/ntlmv2/ntlmssp change
(included patch 2/8 because it was reviewed and independent). Added
to the cifs tree the fixes to prevent premature exit to cifsd and to
prevent the possibly ip address memory corruption.
--
Thanks,
Steve
--
To unsubscribe from thi
On Thu, Sep 9, 2010 at 7:01 AM, Suresh Jayaraman wrote:
> On 09/09/2010 05:22 PM, Jeff Layton wrote:
>> On Wed, 8 Sep 2010 16:25:09 -0500
>> Steve French wrote:
>>
>>> CIFS tree updated to back out the crypto/ntlmv2/ntlmssp change
>>> (included patch 2/8
On Thu, Sep 9, 2010 at 1:18 PM, Pavel Shilovsky wrote:
> 2010/9/8 Jeff Layton :
>> On Wed, 8 Sep 2010 10:49:13 +0400
>>
>> What sort of server were you working with here?
>
> Samba 3.4, Samba 4, Windows XP.
>
>>
>> At the very least, we should consider a "strict" caching model like you
>> describe
On Thu, Sep 9, 2010 at 1:34 PM, Pavel Shilovsky wrote:
> 2010/9/9 Steve French :
>> Note that metadata caching is common for most network file systems
>> (not unique to cifs or nfs) - and is usually done on a timer.
>>
>> NFSv3 data caching is unsafe - no guarant
On Wed, Sep 8, 2010 at 1:37 PM, Ben Greear wrote:
> I saw this when attempting to rmmod smb2.
>
> Thanks,
> Ben
>
>
> [ cut here ]
> WARNING: at fs/proc/generic.c:816 remove_proc_entry+0xf3/0x26d()
> Hardware name: X8STi
> name 'DebugData'
> Modules linked in: smb2(-) xt_CT
On Sun, Sep 12, 2010 at 9:55 AM, Pavel Shilovsky wrote:
> 2010/9/12 Jeff Layton :
>> That's just because our client is primitive in this regard. When an
>> oplock break comes in, it always drops the entire oplock rather than
>> trying to downgrade it.
>>
>> Notice that when the client sends the "r
On Sun, Sep 12, 2010 at 7:15 PM, Jeff Layton wrote:
> On Sun, 12 Sep 2010 16:19:46 -0500
> Steve French wrote:
>
>> On Sun, Sep 12, 2010 at 9:55 AM, Pavel Shilovsky wrote:
>> > 2010/9/12 Jeff Layton :
>> >> That's just because our client is primitive i
On Fri, Sep 10, 2010 at 7:45 PM, Javier Martinez Canillas
wrote:
> In today linux-next I got a compile warning due a possibly uninitialized
> variable
>
> This trivial patch solves the issue
>
> Thanks a lot
>
> Signed-off-by: Javier Martinez Canillas
> ---
> fs/cifs/cifssmb.c | 2 +-
> 1 fi
it/sfrench/cifs-2.6.git master
Jeff Layton (4):
cifs: eliminate redundant xdev check in cifs_rename
cifs: prevent cifsd from exiting prematurely
cifs: eliminate some more premature cifsd exits
cifs: prevent possible memory corruption in cifs_demultiplex_thread
Steve
On Tue, Sep 14, 2010 at 6:39 AM, Jeff Layton wrote:
> On Tue, 14 Sep 2010 15:18:32 +0530
> Suresh Jayaraman wrote:
>
>> On 09/13/2010 11:32 PM, Jeff Layton wrote:
>> > cifs_get_smb_ses must be called on a server pointer on which it holds an
>> > active reference. It first does a search for an exi
The following changes since commit bfa88ea7ee9e6b4fd673e45a8cc0a8e0b7ef4761:
Merge branch 'sched/urgent' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
(2010-09-13 14:34:27 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sfrenc
On Thu, Sep 16, 2010 at 4:39 PM, wrote:
> Hello,
>
> Trying out a CIFS mount of a W2K8 x64 file system from CentOS
> 5.5 and running into problems, and trying to figure out how to
> proceed.
>
> I mount up the Windows share, then run a script that expands
> about ten TAR format archives containin
On Thu, Sep 16, 2010 at 7:00 PM, wrote:
> At 05:50 PM 9/16/2010 -0500, Steve French wrote:
>>On Thu, Sep 16, 2010 at 4:39 PM, wrote:
>>> Trying out a CIFS mount of a W2K8 x64 file system from CentOS
>>> 5.5 and running into problems, and trying to figure out how to
&
On Fri, Sep 17, 2010 at 12:27 PM, Steve French wrote:
>
>
> On Fri, Sep 17, 2010 at 12:15 PM, Jeff Layton wrote:
>>
>> On Fri, 17 Sep 2010 13:00:05 -0400
>> Jeff Layton wrote:
>>
>> > I recently noticed a regression in samba in the last few weeks
Obviously correct (and merged this along with the previous patch from you).
Wonder why sparse didn't spot this - we avoided the cast in the other
(posix) helper.
On Fri, Sep 17, 2010 at 9:39 AM, Jeff Layton wrote:
> On Fri, 17 Sep 2010 19:43:10 +0530
> Suresh Jayaraman wrote:
>
>> ... and avoid
On Sat, Sep 18, 2010 at 1:32 AM, Pavel Shilovsky wrote:
> Add cifs_sync_read call to provide reading from the cache if we have at least
> Level II oplock and otherwise - reading from the server.
This is a stricter guarantee than NFS and will slow performance
dramatically. If you are going to pre
Ben,
Dr. Holder took a look at this and acked it.
This does help the problem of choosing
wired vs. wireless for mounts to specific servers
(where the default route would be wrong as happened
to me last week) and also there are some IPv6
cases it helps with.
If nfs guys require a different name for
Strange that it reports ext4 symbols in the oops ... but it is possible.
clearly are bugs in the smb2 read and write code though - slowly
working through them
made some fixes (some from pavel) today in smb2.git
On Mon, Sep 20, 2010 at 4:51 PM, Ben Greear wrote:
> I got smb2 to work against the
Alternatively - I could merge the trivially modified bkl cifs patch
into the cifs-2.6.git tree if that is easier
On Tue, Sep 21, 2010 at 1:10 AM, Stephen Rothwell wrote:
> Hi Arnd,
>
> Today's linux-next merge of the bkl-vfs tree got a conflict in
> fs/cifs/cifsfs.c between commit d090dbeacd37638
> Yep, that's correct. Note that the secType is a per-server parameter
> right now.
>
> We could mix sectypes on a socket. I sent a patchset that did that this
> past spring, but Steve basically NAK'ed it.
At least for the case of signing, and for CIFS especially (where all
users of the socket, u
The patch does seem to change one behavior.
If CIFSSMBWrite2 writes data, but less than requested
(bytes written < bytes_to_write) this may change the file size but the
(local copy of eof?) eof won't be updated in that case (as it was
before)
On Wed, Sep 22, 2010 at 4:23 PM, Jeff Layton wrote:
>
Sorry about that - we merged one of Jeff's patches (in a series) out
of order by three hours due to review comments. Should be ok now -
verifying.
On Wed, Sep 22, 2010 at 8:20 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconf
On Wed, Sep 22, 2010 at 8:32 PM, Steve French wrote:
> Sorry about that - we merged one of Jeff's patches (in a series) out
> of order by three hours due to review comments. Should be ok now -
> verifying.
Built fine. Will try to merge the rest in order.
--
Thanks,
Steve
--
On Mon, Sep 20, 2010 at 6:01 PM, Jeff Layton wrote:
> cifsFileInfo needs a pointer to a tcon, but it doesn't currently hold a
> reference to it. Change it to keep a pointer to a tcon_link instead and
> hold a reference to it.
Nice work on these patches but they do end up more complex than I expec
This one looked ok (other than the earlier comment that
the series is bigger change than I expected).
On Mon, Sep 20, 2010 at 6:01 PM, Jeff Layton wrote:
> When we implement multiuser mounts, we'll need to filter filehandles
> by fsuid. Add a flag for multiuser mounts and code to filter by
> fsui
obviously harmless/fine (would merge now, but don't want to do it
out of order with 8 and 9)
On Mon, Sep 20, 2010 at 6:01 PM, Jeff Layton wrote:
> ...based on CIFS_MOUNT_MULTIUSER flag.
>
> Signed-off-by: Jeff Layton
> ---
> fs/cifs/cifsfs.c | 6 +-
> 1 files changed, 5 insertions(+), 1
Won't this overwrite the effect of the "uid" mount parameter?
linux_uid is set at mount time to either current uid or what is passed
in on uid (if "uid" is specified on mount). Your code seems to
unconditionally change that to ignore the uid passed in or mount.
On Mon, Sep 20, 2010 at 6:01 PM,
We need to see the performance impact. As you say cifs_writepages is
synchronous so we should be ok without it. Any test results
before/after?
On Fri, Sep 24, 2010 at 7:59 AM, Jeff Layton wrote:
> It's possible that the kernel will call cifs_close on a filp while there
> is still dirty data att
Looks like an Apache bug if they rely on the value of st_size for
directories. See
http://www.opengroup.org/onlinepubs/95399/basedefs/sys/stat.h.html
"For regular files, the file size in bytes. For symbolic links, the
length in bytes of the pathname contained in the symbolic link." ...
"For o
inode open - and should be
able to just do flush
On Fri, Sep 24, 2010 at 1:11 PM, Jeff Layton wrote:
> On Fri, 24 Sep 2010 12:58:55 -0500
> Steve French wrote:
>
>> We need to see the performance impact. As you say cifs_writepages is
>> synchronous so we should be ok without
On Fri, Sep 24, 2010 at 2:08 PM, Jeff Layton wrote:
> On Fri, 24 Sep 2010 13:43:40 -0500
> Steve French wrote:
>
>> It don't think it is a correctness issue - if close wants to do an
>> fsync why do we have a flush routine at all? close is the only place
>> f
On Fri, Sep 24, 2010 at 2:32 PM, Jeff Layton wrote:
> On Fri, 24 Sep 2010 14:24:31 -0500
> Steve French wrote:
>
>> On Fri, Sep 24, 2010 at 2:08 PM, Jeff Layton wrote:
>> > On Fri, 24 Sep 2010 13:43:40 -0500
>> > Steve French wrote:
>> >
>>
On Fri, Sep 24, 2010 at 11:23 PM, Christoph Hellwig wrote:
> On Fri, Sep 24, 2010 at 02:11:37PM -0400, Jeff Layton wrote:
>> On Fri, 24 Sep 2010 12:58:55 -0500
>> Steve French wrote:
>>
>> > We need to see the performance impact. As you say cifs_writepages is
>&
Seems that it makes it more confusing? - if null were a valid value
for pdata we would need to check for this later in the function before
the memcpy
It didn't throw that error on my gcc version - is your gcc older or do
you use different compile options or different arch?
On Sun, Sep 26, 2010 at
Lots of progress on cifs and smb2 kernel clients at the SNIA
conference/plugfest. Some highlights:
- Jeff and I worked together to review various patchsets in more detail
- Merged Metze's "Minshall-French" (MacOS) symlink patchset. We can
now create symlinks to servers which do not support the C
1 - 100 of 1471 matches
Mail list logo
