Re: [PATCH] CPU Jitter RNG: inclusion into kernel crypto API and /dev/random

2013-11-14 Thread Clemens Ladisch
Stephan Mueller wrote: Am Mittwoch, 13. November 2013, 12:51:44 schrieb Clemens Ladisch: (And any setting that increases accesses to main memory is likey to introduce more entropy due to clock drift between the processor and the memory bus. Or where do you assume the entropy comes from?)

Re: crypto: s390 - Fix aes-cbc IV corruption

2013-11-14 Thread Jan Glauber
On Thu, Oct 31, 2013 at 11:25:47AM +0800, Herbert Xu wrote: Hi: Hi Herbert, just seen this as my old email address is dead... Your patch looks fine as it keeps the iv and the key together as required by the instruction. However, I'm curious how this could be racy with threads. The encryption

Re: [PATCH] CPU Jitter RNG: inclusion into kernel crypto API and /dev/random

2013-11-14 Thread Stephan Mueller
Am Donnerstag, 14. November 2013, 11:51:03 schrieb Clemens Ladisch: Hi Clemens, Stephan Mueller wrote: Am Mittwoch, 13. November 2013, 12:51:44 schrieb Clemens Ladisch: (And any setting that increases accesses to main memory is likey to introduce more entropy due to clock drift between the

Re: [PATCH] CPU Jitter RNG: inclusion into kernel crypto API and /dev/random

2013-11-14 Thread Clemens Ladisch
Stephan Mueller wrote: Am Donnerstag, 14. November 2013, 11:51:03 schrieb Clemens Ladisch: An attacker would not try to detect patterns; he would apply knowledge of the internals. I do not buy that argument, because if an attacker can detect or deduce the internals of the CPU, he surely can

Re: [PATCH] CPU Jitter RNG: inclusion into kernel crypto API and /dev/random

2013-11-14 Thread Stephan Mueller
Am Donnerstag, 14. November 2013, 19:30:22 schrieb Clemens Ladisch: Hi Clemens, Stephan Mueller wrote: Am Donnerstag, 14. November 2013, 11:51:03 schrieb Clemens Ladisch: An attacker would not try to detect patterns; he would apply knowledge of the internals. I do not buy that argument,

[PATCH] crypto: fix potential NULL pointer dereference in skcipher_alloc_sgl()

2013-11-14 Thread Jeff Liu
From: Jie Liu jeff@oracle.com In skcipher_alloc_sgl(), there is a potential null pointer dereference issue to retrieve the last item from ctx-tsgl list if the list is empty. This patch fix it by checking if the list is empty or not at first. Signed-off-by: Jie Liu jeff@oracle.com ---