Re: [PATCH v5 2/7] crypto: SHA1 multibuffer crypto hash infrastructure

2014-07-25 Thread Peter Zijlstra
On Tue, Jul 22, 2014 at 03:09:32PM -0700, Tim Chen wrote: +/* Called in workqueue context, do one real cryption work (via + * req-complete) and reschedule itself if there are more work to + * do. */ You seem to manage the 'normal' comment style in other places, this one 'special' for a reason?

Re: [PATCH v5 3/7] crypto: SHA1 multibuffer crypto opportunistic flush

2014-07-25 Thread Peter Zijlstra
On Tue, Jul 22, 2014 at 03:09:35PM -0700, Tim Chen wrote: The crypto daemon can take advantage of available cpu cycles to flush any unfinished jobs if it is the only task running on the cpu, and there are no more crypto jobs to process. You conveniently forgot to mention energy efficiency,

Re: [PATCH v5 2/7] crypto: SHA1 multibuffer crypto hash infrastructure

2014-07-25 Thread Peter Zijlstra
On Tue, Jul 22, 2014 at 03:09:32PM -0700, Tim Chen wrote: This patch introduces the multi-buffer crypto daemon which is responsible for submitting crypto jobs in a work queue to the responsible multi-buffer crypto algorithm. The idea of the multi-buffer algorihtm is to put data streams from

[net-next] crypto: Resolve shadow warnings

2014-07-25 Thread Jeff Kirsher
From: Mark Rustad mark.d.rus...@intel.com Change formal parameters to not clash with global names to eliminate many W=2 warnings. Signed-off-by: Mark Rustad mark.d.rus...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- crypto/cryptd.c | 12

Re: [PATCH v4 2/3] ARM: sunxi: dt: Add DT bindings documentation for SUNXI Security System

2014-07-25 Thread Maxime Ripard
On Sat, Jul 12, 2014 at 02:59:12PM +0200, LABBE Corentin wrote: This patch adds documentation for Device-Tree bindings for the Security System cryptographic accelerator driver. Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com

Re: [PATCH v4 3/3] crypto: Add Allwinner Security System crypto accelerator

2014-07-25 Thread Maxime Ripard
On Sat, Jul 12, 2014 at 02:59:13PM +0200, LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that support AES/MD5/SHA1/DES/3DES/PRNG algorithms. Signed-off-by: LABBE Corentin

[GIT PULL] Keyrings: PKCS#7 fixup

2014-07-25 Thread David Howells
/linux/kernel/git/dhowells/linux-fs.git tags/keys-next-20140725 for you to fetch changes up to 8f3438ccea149647ad1849651d1e14c7b8b85e63: PKCS#7: Missing inclusion of linux/err.h (2014-07-25 11:33:53 +0100) (from the branch

Re: [PATCH -v5] random: introduce getrandom(2) system call

2014-07-25 Thread Henrique de Moraes Holschuh
On Thu, 24 Jul 2014, Theodore Ts'o wrote: On Thu, Jul 24, 2014 at 05:30:19PM -0300, Henrique de Moraes Holschuh wrote: I wouldn't add the error to the man page until we actually modify the kernel to add such a restriction. By then, it might be too late. It would be really sad to find

Re: [PATCH -v5] random: introduce getrandom(2) system call

2014-07-25 Thread Theodore Ts'o
On Thu, Jul 24, 2014 at 04:27:36PM -0700, Andy Lutomirski wrote: I think that people might do: try getrandom(GRND_RANDOM) fall back to /dev/random fall back to something intensely stupid We want them to at least attempt the fallback from GRND_RANDOM to !GRND_RANDOM. We can't

Re: [PATCH v5 2/7] crypto: SHA1 multibuffer crypto hash infrastructure

2014-07-25 Thread Tim Chen
On Fri, 2014-07-25 at 09:08 +0200, Peter Zijlstra wrote: On Tue, Jul 22, 2014 at 03:09:32PM -0700, Tim Chen wrote: +/* Called in workqueue context, do one real cryption work (via + * req-complete) and reschedule itself if there are more work to + * do. */ You seem to manage the 'normal'

Re: [PATCH v5 2/7] crypto: SHA1 multibuffer crypto hash infrastructure

2014-07-25 Thread Tim Chen
On Fri, 2014-07-25 at 09:26 +0200, Peter Zijlstra wrote: On Tue, Jul 22, 2014 at 03:09:32PM -0700, Tim Chen wrote: This patch introduces the multi-buffer crypto daemon which is responsible for submitting crypto jobs in a work queue to the responsible multi-buffer crypto algorithm. The idea

General flags to turn things off (getrandom, pid lookup, etc)

2014-07-25 Thread Andy Lutomirski
[new thread because this sort of combines two threads] There is recent interest in having a way to turn generally-available kernel features off. Maybe we should add a good one so we can stop bikeshedding and avoid proliferating dumb interfaces. Things that might want to be turn-off-able

Re: General flags to turn things off (getrandom, pid lookup, etc)

2014-07-25 Thread Dave Jones
On Fri, Jul 25, 2014 at 11:30:48AM -0700, Andy Lutomirski wrote: There is recent interest in having a way to turn generally-available kernel features off. Maybe we should add a good one so we can stop bikeshedding and avoid proliferating dumb interfaces. Things that might want to be

Re: General flags to turn things off (getrandom, pid lookup, etc)

2014-07-25 Thread Andy Lutomirski
On Fri, Jul 25, 2014 at 1:15 PM, Dave Jones da...@redhat.com wrote: On Fri, Jul 25, 2014 at 11:30:48AM -0700, Andy Lutomirski wrote: There is recent interest in having a way to turn generally-available kernel features off. Maybe we should add a good one so we can stop bikeshedding and

Re: General flags to turn things off (getrandom, pid lookup, etc)

2014-07-25 Thread One Thousand Gnomes
On Fri, 25 Jul 2014 11:30:48 -0700 Andy Lutomirski l...@amacapital.net wrote: [new thread because this sort of combines two threads] There is recent interest in having a way to turn generally-available kernel features off. Maybe we should add a good one so we can stop bikeshedding and

Re: General flags to turn things off (getrandom, pid lookup, etc)

2014-07-25 Thread Andy Lutomirski
On Fri, Jul 25, 2014 at 2:35 PM, One Thousand Gnomes gno...@lxorguk.ukuu.org.uk wrote: On Fri, 25 Jul 2014 11:30:48 -0700 Andy Lutomirski l...@amacapital.net wrote: [new thread because this sort of combines two threads] There is recent interest in having a way to turn generally-available

[PATCH 00/10] crypto: qat: Checkpatch and other cleanups plus SKU1

2014-07-25 Thread Tadeusz Struk
issue. Hi, Minor cleanups for the qat driver. The last patch fixes SKU1 device startup issue. Rest of the patches clean up new checkpatch issues plus some minor and cosmetic updates. --- Tadeusz Struk (10): crypto: qat: Fixed SKU1 dev issue crypto: qat: Cleanup - Use hweight for bit

[PATCH 01/10] crypto: qat: Cleanup - remove unnecessary return codes

2014-07-25 Thread Tadeusz Struk
Remove unnecessary return code variables and change function types accordingly. Signed-off-by: Bruce Allan bruce.w.al...@intel.com Signed-off-by: Tadeusz Struk tadeusz.st...@intel.com --- drivers/crypto/qat/qat_common/qat_uclo.c | 23 --- 1 file changed, 8 insertions(+),

[PATCH 2/2] arm aes: fix encryption of unaligned data

2014-07-25 Thread Mikulas Patocka
Fix the same alignment bug as in arm64 - we need to pass residue unprocessed bytes as the last argument to blkcipher_walk_done. Signed-off-by: Mikulas Patocka mpato...@redhat.com Cc: sta...@vger.kernel.org # 3.13+ Index: linux-3.16.0-0.rc6.git1.1.fc21.aarch64/arch/arm/crypto/aesbs-glue.c

Re: General flags to turn things off (getrandom, pid lookup, etc)

2014-07-25 Thread H. Peter Anvin
On 07/25/2014 11:30 AM, Andy Lutomirski wrote: - 32-bit GDT code segments [huge attack surface] - 64-bit GDT code segments [probably pointless] I presume you mean s/GDT/LDT/. We already don't allow 64-bit LDT code segments. Also, it is unclear to me how 32-bit LDT segments have a huge

Re: General flags to turn things off (getrandom, pid lookup, etc)

2014-07-25 Thread Andy Lutomirski
On Fri, Jul 25, 2014 at 4:43 PM, H. Peter Anvin h...@zytor.com wrote: On 07/25/2014 11:30 AM, Andy Lutomirski wrote: - 32-bit GDT code segments [huge attack surface] - 64-bit GDT code segments [probably pointless] I presume you mean s/GDT/LDT/. We already don't allow 64-bit LDT code

Re: [GIT PULL] Keyrings: PKCS#7 fixup

2014-07-25 Thread James Morris
in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/keys-next-20140725 for you to fetch changes up to 8f3438ccea149647ad1849651d1e14c7b8b85e63: PKCS#7: Missing inclusion of linux/err.h (2014-07-25 11:33:53 +0100) Thanks, pulled. -- James