Using non-constant time memcmp() makes the verification of the authentication
tag in the decrypt path vulnerable to timing attacks. Fix this by using
crypto_memneq() instead.
Signed-off-by: David Gstir
---
drivers/crypto/talitos.c | 2 +-
1 file changed, 1 insertion(+), 1
Using non-constant time memcmp() makes the verification of the authentication
tag in the decrypt path vulnerable to timing attacks. Fix this by using
crypto_memneq() instead.
Signed-off-by: David Gstir
---
drivers/crypto/nx/nx-aes-ccm.c | 2 +-
From: Markus Elfring
Date: Sun, 15 Nov 2015 18:28:39 +0100
The dma_pool_destroy() function was called twice with a null pointer
if a "npe_error" was reported.
This implementation detail could be improved by the introduction
of another jump label.
Signed-off-by:
Tata Consultancy Services (TCS)
Registered Office :
Elphinstone Building,
2nd Floor, New Delhi,
Delhi,
India
Tata Consultancy Services promotion 2015 . Apply for a loan of any amount,
e-mail consultant in respond
to this email : financemanager_ajayku...@hotmail.com
The Interest rate
On 2015年11月15日 06:41, Heiko Stuebner wrote:
> Hi Zain,
>
> Am Freitag, 13. November 2015, 14:44:43 schrieb Zain:
>> On 2015年11月12日 20:32, Heiko Stuebner wrote:
>>> Hi Zain,
>>>
>>> I was able to sucessfully test your crypto-driver, but have found some
>>> improvements below that should probably
From: Markus Elfring
Date: Sun, 15 Nov 2015 19:39:00 +0100
Further update suggestions were taken into account after a patch
was applied from static source code analysis.
Markus Elfring (4):
Delete unnecessary checks before the function call "dma_pool_destroy"
From: Markus Elfring
Date: Sun, 15 Nov 2015 16:51:21 +0100
The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
From: Markus Elfring
Date: Sun, 15 Nov 2015 19:06:44 +0100
The variable "ret" was set more often than necessary by the
init_ixp_crypto() function.
* Omit its initialisation at the beginning.
* Use an error return code in two cases directly.
* Improve compliance
From: Markus Elfring
Date: Sun, 15 Nov 2015 19:23:55 +0100
The dma_pool_destroy() function was called in up to two cases by the
init_ixp_crypto() function during error handling even if a call of
the dma_pool_create() function failed.
This implementation detail