[PATCH] crypto: qat - use list_for_each_entry*

2015-12-16 Thread Geliang Tang
Use list_for_each_entry*() instead of list_for_each*() to simplify the code. Signed-off-by: Geliang Tang --- drivers/crypto/qat/qat_common/adf_cfg.c | 35 +++ drivers/crypto/qat/qat_common/adf_ctl_drv.c | 13 +++

RE: [PATCH] crypto: qat - fix CTX_ENABLES bits shift direction issue

2015-12-16 Thread Yang, Pingchao
There is no very strong reason, but I think 0xff << CE_ENABLE_BITPOS is more clearly for reading, So that we can clearly know we are accessing the 8 CTXs in CTX_ENABLES CSR 8-15 bits. Best Regards, Pingchao yang -Original Message- From: walter harms [mailto:wha...@bfs.de] Sent:

Re: [PATCH] crypto: qat - fix CTX_ENABLES bits shift direction issue

2015-12-16 Thread walter harms
Am 16.12.2015 03:39, schrieb Yang Pingchao: > AE CTX bits should be 8-15 in CTX_ENABLES, so the mask > value 0xff should be left shifted 0x8. > > Reported-by: Dan Carpenter > Signed-off-by: Yang Pingchao > --- >