Re: [RFC][PATCH 0/6] /dev/random - a new approach

2016-04-21 Thread Stephan Mueller
Am Donnerstag, 21. April 2016, 22:51:55 schrieb Theodore Ts'o: Hi Theodore, > I still have a massive problem with the claims that the "Jitter" RNG > provides any amount of entropy. Just because you and I might not be > able to analyze it doesn't mean that somebody else couldn't. After > all, DU

Re: [RFC][PATCH 0/6] /dev/random - a new approach

2016-04-21 Thread Theodore Ts'o
I still have a massive problem with the claims that the "Jitter" RNG provides any amount of entropy. Just because you and I might not be able to analyze it doesn't mean that somebody else couldn't. After all, DUAL-EC DRNG was very complicated and hard to analyze. So would be something like A

[PATCH] crypto: talitos - fix ahash algorithms registration

2016-04-21 Thread Horia Geantă
Provide hardware state import/export functionality, as mandated by commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero") Cc: # 4.3+ Reported-by: Jonas Eymann Signed-off-by: Horia Geantă --- drivers/crypto/talitos.c | 64 1 file ch

Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt handler

2016-04-21 Thread Rob Herring
On Tue, Apr 19, 2016 at 03:44:12PM +0200, Krzysztof Kozlowski wrote: > Beside regular feed control interrupt, the driver requires also hash > interrupt for older SoCs (samsung,s5pv210-secss). However after > requesting it, the interrupt handler isn't doing anything with it, not > even clearing the

Re: [RFC][PATCH 0/6] /dev/random - a new approach

2016-04-21 Thread Stephan Mueller
Am Donnerstag, 21. April 2016, 15:03:37 schrieb Nikos Mavrogiannopoulos: Hi Nikos, > > [quote from pdf] > > > ... DRBG is “minimally” seeded with 112^6 bits of entropy. > > This is commonly achieved even before user space is initiated. > > Unfortunately one of the issues of the /dev/urandom int

Re: AEAD in TALITOS SEC1 versus TALITOS SEC2

2016-04-21 Thread Horia Ioan Geanta Neag
On 4/20/2016 3:04 PM, Christophe Leroy wrote: > Today, in Talitos driver crypto alg registration is based on predefined > templates with a predefined descriptor type and verification against the > descriptors supported by the HW. This works well for ALG that require a > unique descriptor. But fo

Re: [RFC][PATCH 0/6] /dev/random - a new approach

2016-04-21 Thread Stephan Mueller
Am Donnerstag, 21. April 2016, 15:03:37 schrieb Nikos Mavrogiannopoulos: Hi Nikos, > On Thu, Apr 21, 2016 at 11:11 AM, Stephan Mueller wrote: > > Hi Herbert, Ted, > > > > The venerable Linux /dev/random served users of cryptographic mechanisms > > well for a long time. Its behavior is well und

Re: [RFC][PATCH 0/6] /dev/random - a new approach

2016-04-21 Thread Nikos Mavrogiannopoulos
On Thu, Apr 21, 2016 at 11:11 AM, Stephan Mueller wrote: > Hi Herbert, Ted, > > The venerable Linux /dev/random served users of cryptographic mechanisms well > for a long time. Its behavior is well understood to deliver entropic data. In > the last years, however, the Linux /dev/random showed sign

Re: [PATCH 0/2] crypto: talitos - fix conversion to new AEAD interface

2016-04-21 Thread Herbert Xu
On Wed, Apr 20, 2016 at 11:29:52AM +, Horia Ioan Geanta Neag wrote: > > Shouldn't these have been included in the recent "Crypto Update for 4.6" > pull request? It will go in the next pull request. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://

[PATCH 1/6] crypto: DRBG - externalize DRBG functions for LRNG

2016-04-21 Thread Stephan Mueller
This patch allows several DRBG functions to be called by the LRNG kernel code paths outside the drbg.c file. Signed-off-by: Stephan Mueller --- crypto/drbg.c | 11 +-- include/crypto/drbg.h | 7 +++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/crypto/drbg.

[PATCH 3/6] crypto: Linux Random Number Generator

2016-04-21 Thread Stephan Mueller
The LRNG with all its properties is documented in [1]. This documentation covers the functional discussion as well as testing of all aspects of entropy processing. In addition, the documentation explains the conducted regression tests to verify that the LRNG is API and ABI compatible with the legac

[RFC][PATCH 0/6] /dev/random - a new approach

2016-04-21 Thread Stephan Mueller
Hi Herbert, Ted, The venerable Linux /dev/random served users of cryptographic mechanisms well for a long time. Its behavior is well understood to deliver entropic data. In the last years, however, the Linux /dev/random showed signs of age where it has challenges to cope with modern computing envi

[PATCH 5/6] crypto: LRNG - hook LRNG into interrupt handler

2016-04-21 Thread Stephan Mueller
The LRNG places a callback into the interrupt handler to be triggered for each interrupt. With this callback, entropy is collected. Signed-off-by: Stephan Mueller --- kernel/irq/handle.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index a15b548..

[PATCH 2/6] random: conditionally compile code depending on LRNG

2016-04-21 Thread Stephan Mueller
When selecting the LRNG for compilation, disable the legacy /dev/random implementation. The LRNG is a drop-in replacement for the legacy /dev/random which implements the same in-kernel and user space API. Only the hooks of /dev/random into other parts of the kernel need to be disabled. Signed-off

[PATCH 6/6] hyperv IRQ handler: trigger LRNG

2016-04-21 Thread Stephan Mueller
The Hyper-V Linux Integration Services use the VMBus implementation for communication with the Hypervisor. VMBus registers its own interrupt handler that completely bypasses the common Linux interrupt handling. The interrupt handler is now added the invocation of the LRNG IRQ collection function t

[PATCH 4/6] crypto: LRNG - enable compile

2016-04-21 Thread Stephan Mueller
Add LRNG compilation support. Signed-off-by: Stephan Mueller --- crypto/Kconfig | 10 ++ crypto/Makefile | 1 + 2 files changed, 11 insertions(+) diff --git a/crypto/Kconfig b/crypto/Kconfig index 93a1fdc..938f2dc 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -1587,6 +1587,16 @@

[RFC PATCH] crypto: Make the page handling of hash walk compatible to networking.

2016-04-21 Thread Steffen Klassert
The network layer tries to allocate high order pages for skb_buff fragments, this leads to problems if we pass such a buffer to crypto because crypto assumes to have always order null pages in the scatterlists. This was not a problem so far, because the network stack linearized all buffers before