[PATCH -next] crypto: ccp - Fix non static symbol warning

2016-08-11 Thread Wei Yongjun
Fixes the following sparse warning: drivers/crypto/ccp/ccp-dev.c:62:14: warning: symbol 'ccp_increment_unit_ordinal' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/crypto/ccp/ccp-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

FIPS self test failures (kernel panic) in kernel-4.7

2016-08-11 Thread Tapas Sarangi
Hello, A few algorithms are failing Ĺ’alg self tests' during kernel boot into FIPS mode (fips=1), causing a kernel panic (see below). I am using vanilla kernel-4.7 source for these tests. These messages were from individual boots into FIPS mode, where algorithms are taken out from

Re: [PATCH v6 0/5] /dev/random - a new approach

2016-08-11 Thread Theodore Ts'o
On Thu, Aug 11, 2016 at 02:24:21PM +0200, Stephan Mueller wrote: > > The following patch set provides a different approach to /dev/random which > I call Linux Random Number Generator (LRNG) to collect entropy within the > Linux > kernel. The main improvements compared to the legacy /dev/random

Re: [PATCH] crypto: XTS - remove test that will fail in FIPS mode

2016-08-11 Thread Tapas Sarangi
Hi Stephan, Any other ideas about this problem ? Since XTS is not amongst the self-tests as you observed, is it safe to disable .fips_allowed for xts(aes) in testmgr.c ? Thanks -Tapas On 8/10/16, 5:08 PM, "Tapas Sarangi" wrote: >Hi Stephan, > >Thanks. Sorry for a late

Data type for aio_buf under X32?

2016-08-11 Thread Jeffrey Walton
Hi Everyone, My apologies for this question and my confusion. When interfacing with the kernel crypto through AF_ALG, what is the type of 'aio_buf' under X32? I know is X32 uses ILP32 data model, so integers/longs/pointers are 32-bits (cf., http://www.unix.org/version2/whatsnew/lp64_wp.html). I

D'oh! (Re: robot build error)

2016-08-11 Thread Gary R Hook
Please ignore this patch. [PATCH] crypto: CCP - build error: label 'e_hwrng' undefined Gary R Hook Wed, 10 Aug 2016 12:27:28 -0700 Fix goto target for when registration fails Reported-by: kbuild test robot Signed-off-by: Gary R Hook ---

Re: [PATCH v6 4/5] crypto: LRNG - enable compile

2016-08-11 Thread Stephan Mueller
Am Donnerstag, 11. August 2016, 21:50:15 CEST schrieb kbuild test robot: Hi, > Hi Stephan, > > [auto build test ERROR on cryptodev/master] > [also build test ERROR on v4.8-rc1] > [cannot apply to next-20160811] > [if your patch is applied to the wrong git tree, please drop u

Re: [PATCH v6 4/5] crypto: LRNG - enable compile

2016-08-11 Thread kbuild test robot
Hi Stephan, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.8-rc1] [cannot apply to next-20160811] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stephan-Mueller/crypto

Re: [PATCH 2/2] ath9k: disable RNG by default

2016-08-11 Thread Jason Cooper
On Thu, Aug 11, 2016 at 10:54:11AM +0800, miaoq...@codeaurora.org wrote: > On 2016-08-10 21:24, Jason Cooper wrote: > >The fact is, barring userspace expectations of /dev/hwrng, hw_random is > >the appropriate place for it. It's not a devicetree blob, mac address, > >or pci config space. Which

[PATCH v6 4/5] crypto: LRNG - enable compile

2016-08-11 Thread Stephan Mueller
Add LRNG compilation support. Signed-off-by: Stephan Mueller --- crypto/Kconfig | 11 +++ crypto/Makefile | 2 ++ 2 files changed, 13 insertions(+) diff --git a/crypto/Kconfig b/crypto/Kconfig index 84d7148..71df7fc 100644 --- a/crypto/Kconfig +++

[PATCH v6 0/5] /dev/random - a new approach

2016-08-11 Thread Stephan Mueller
Hi Herbert, Ted, The following patch set provides a different approach to /dev/random which I call Linux Random Number Generator (LRNG) to collect entropy within the Linux kernel. The main improvements compared to the legacy /dev/random is to provide sufficient entropy during boot time as well as

[PATCH v6 1/5] crypto: DRBG - externalize DRBG functions for LRNG

2016-08-11 Thread Stephan Mueller
This patch allows several DRBG functions to be called by the LRNG kernel code paths outside the drbg.c file. Signed-off-by: Stephan Mueller --- crypto/drbg.c | 11 +-- include/crypto/drbg.h | 7 +++ 2 files changed, 12 insertions(+), 6 deletions(-)

[PATCH v6 3/5] crypto: Linux Random Number Generator

2016-08-11 Thread Stephan Mueller
The LRNG with the following properties: * noise source: interrupts timing with fast boot time seeding * lockless LFSR to collect raw entropy * use of kernel crypto API DRBG * in case kernel crypto API is not compiled, use standalone ChaCha20 based RNG * used cipher types for hashes and DRBG

[PATCH v6 2/5] random: conditionally compile code depending on LRNG

2016-08-11 Thread Stephan Mueller
When selecting the LRNG for compilation, disable the legacy /dev/random implementation. The LRNG is a drop-in replacement for the legacy /dev/random which implements the same in-kernel and user space API. Only the hooks of /dev/random into other parts of the kernel need to be disabled.

[PATCH] X.509: Fix double free in x509_cert_parse().

2016-08-11 Thread Artem Savkov
Patch "crypto: KEYS: convert public key and digsig asym to the akcipher api" introduced double freeing of cert->pub->key. There is no need to free it in error_decode label as it is later freed in x509_free_certificate(). Signed-off-by: Artem Savkov ---

[PATCH v6 5/5] crypto: LRNG - add ChaCha20 support

2016-08-11 Thread Stephan Mueller
In case the kernel crypto API is not compiled, use ChaCha20 stream cipher as DRNG. The LRNG ChaCha20 support provides the DRNG implementation with the generate and update functions. Th DRNG implements enhanced backward secrecy by re-creating the entire internal state after generating random