Re: [PATCH] crypto: nx-842: Delete an error message for a failed memory allocation in nx842_pseries_init()

is issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Dan Streetman <ddstr...@ieee.org> > --- > drivers/crypto/nx/nx-842-pseries.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletio

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Sun, Sep 3, 2017 at 4:32 AM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote: > On 09/02/2017 09:17 AM, Dan Streetman wrote: >> On Sat, Sep 2, 2017 at 4:40 AM, Haren Myneni <ha...@linux.vnet.ibm.com> >> wrote: >>> On 08/29/2017 06:58 AM, Dan Streetman wrote:

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Sat, Sep 2, 2017 at 4:40 AM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote: > On 08/29/2017 06:58 AM, Dan Streetman wrote: >> On Sat, Jul 22, 2017 at 1:01 AM, Haren Myneni <ha...@linux.vnet.ibm.com> >> wrote: >>> >>> This patch adds P9 N

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Fri, Sep 1, 2017 at 7:29 AM, Michael Ellerman <m...@ellerman.id.au> wrote: > Hi Dan, > > Thanks for reviewing this series. > > Dan Streetman <ddstr...@ieee.org> writes: >> On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni <ha...@linux.vnet.ibm.com> >>

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Thu, Aug 31, 2017 at 3:44 AM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote: > Thanks MIchael and Dan for your review comments. > > > On 08/29/2017 06:32 AM, Dan Streetman wrote: >> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman <m...@ellerman.id.au> >&g

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote: > On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote: >> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote: >>>> + >>>> + ret = -EINVAL; >&

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Support for PowerPC Nest (NX) compression acceleration. This > diff --git a/drivers/crypto/nx/nx-842-powernv.c > b/drivers/crypto/nx/nx-842-powernv.c > index c0dd4c7e17d3..13089a0b9dfa 100644 > --- a/drivers/crypto/nx/nx-842-powernv.c > +++ b/drivers/crypto/nx/nx-842-powern

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman wrote: > Hi Haren, > > Some comments inline ... > > Haren Myneni writes: > >> diff --git a/drivers/crypto/nx/nx-842-powernv.c >> b/drivers/crypto/nx/nx-842-powernv.c >> index

Re: [PATCH] crypto/nx: Update MAINTAINERS entry for 842 compression

On Sat, Apr 1, 2017 at 1:25 PM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote: > [PATCH] crypto/nx: Update MAINTAINERS entry for 842 compression > > Signed-off-by: Haren Myneni <ha...@us.ibm.com> Acked-by: Dan Streetman <ddstr...@ieee.org> > > --- > MAI

[PATCH] crypto: 842 - remove WARN inside printk

results. Reported-by: Randy Dunlap <rdun...@infradead.org> Signed-off-by: Dan Streetman <ddstr...@ieee.org> --- lib/842/842_decompress.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/lib/842/842_decompress.c b/lib/842/842_decompress.c index 8881dad..a7

Re: crypto/nx842: Ignore queue overflow informative error

On Sun, Dec 6, 2015 at 2:46 AM, Haren Myneni wrote: > > NX842 coprocessor sets bit 3 if queue is overflow. It is just for > information to the user. So the driver prints this informative message > and ignores it. > > Signed-off-by: Haren Myneni > >

Re: crypto/nx842: Ignore queue overflow informative error

On Sun, Dec 6, 2015 at 5:57 PM, Daniel Axtens wrote: > Haren Myneni writes: > >> NX842 coprocessor sets bit 3 if queue is overflow. It is just for >> information to the user. So the driver prints this informative message >> and ignores it. > > What

Re: [PATCH] crypto: nx: use of_property_read_u32()

On Mon, Nov 23, 2015 at 4:56 AM, Saurabh Sengar <saurabh.tr...@gmail.com> wrote: > use of_propert_read_u32() for reading int value, > it can help reducing number of variables used > > Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> Acked-by: Dan Stre

Re: [PATCH] nx-842: Endian swap ->count before handing over to the nx-842 compressor

On Sat, Oct 31, 2015 at 2:39 PM, Ram Pai <linux...@us.ibm.com> wrote: > On Sat, Oct 31, 2015 at 08:38:17AM -0400, Dan Streetman wrote: >> On Fri, Oct 30, 2015 at 6:45 PM, Ram Pai <linux...@us.ibm.com> wrote: >> > The nx-842 compressor overshoots the output buffer cor

Re: [PATCH] nx-842: Endian swap ->count before handing over to the nx-842 compressor

On Fri, Oct 30, 2015 at 6:45 PM, Ram Pai wrote: > The nx-842 compressor overshoots the output buffer corrupting memory. Verified > that the following patch fixes the issue on a little-endian system. > > Signed-off-by: Ram Pai > --- >

Re: [PATCH] nx-842: Ignore bit 3 of condition register returned by icswx

gnored it. > > Signed-off-by: Ram Pai <linux...@us.ibm.com> Acked-by: Dan Streetman <ddstr...@ieee.org> > --- > arch/powerpc/include/asm/icswx.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/include/asm/icswx.h > b/

Re: [PATCH] crypto: add asynchronous compression support

On Wed, Oct 21, 2015 at 3:59 AM, Li, Weigang <weigang...@intel.com> wrote: >> -Original Message- >> From: Herbert Xu [mailto:herb...@gondor.apana.org.au] >> Sent: Wednesday, October 21, 2015 3:34 PM >> To: Sergey Senozhatsky >> Cc: Minchan Kim; Joonsoo K

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Wed, Sep 23, 2015 at 5:54 AM, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Tue, Sep 22, 2015 at 11:08:22AM -0400, Dan Streetman wrote: >> >> you think we should just strip out the 842-nx alignment/sizing code >> and change it to fallback to the sw driver? >

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Tue, Sep 22, 2015 at 10:42 AM, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Tue, Sep 22, 2015 at 10:39:53AM -0400, Dan Streetman wrote: >> >> hmm, that's true, and that would simplify the code a lot! No need for >> the header anymore. But, since the sw

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Tue, Sep 22, 2015 at 8:21 AM, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Mon, Sep 21, 2015 at 11:21:14AM -0400, Dan Streetman wrote: >> >> As far as the hw and sw drivers producing the exact same output, I >> don't think that's possible with the current hw

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Mon, Sep 21, 2015 at 10:26 AM, Herbert Xu wrote: > On Sat, Sep 19, 2015 at 05:02:42PM -0700, Haren Myneni wrote: >> Hi, >> >> This patch allows nx842 coprocessor to add CRC for compression and >> check the computed CRC value for uncompression. Please let me know >>

[PATCH] MAINTAINERS: change 842 NX owner email address

Change my IBM email to my personal IEEE email. I'm leaving IBM, so my email there won't work anymore. This changes the owner to my personal email, so I can still get cc'ed on patches, until someone at IBM sends a patch to take it over. Signed-off-by: Dan Streetman ddstr...@ieee.org

[PATCH] crypto: nx - use be32_to_cpu for __be32 field in debug msg

One of the debug messages in the NX 842 PowerNV driver is missing the required be32_to_cpu() wrapper when accessing the __be32 field csb-count. Add the wrapper so the message will show the correct count. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/nx-842-powernv.c | 3

[PATCH 1/8] crypto: nx - remove __init/__exit from VIO functions

Remove the __init and __exit modifiers from the VIO driver probe and remove functions. The driver functions should not be marked __init/__exit because they can/will be called during runtime, not only at module init and exit. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx

[PATCH 0/8] remove 'platform' shared NX driver

on the platform, their registration will not conflict. Dan Streetman (8): crypto: nx - remove __init/__exit from VIO functions crypto: nx - remove pSeries NX 'status' field crypto: nx - move kzalloc() out of spinlock crypto: nx - don't register pSeries driver if ENODEV crypto: nx - use

[PATCH 3/8] crypto: nx - move kzalloc() out of spinlock

Move the kzalloc() calls in nx842_probe() and nx842_OF_upd() to the top of the functions, before taking the devdata spinlock. Since kzalloc() without GFP_ATOMIC can sleep, it can't be called while holding a spinlock. Move the calls to before taking the lock. Signed-off-by: Dan Streetman ddstr

[PATCH 5/8] crypto: nx - use common code for both NX decompress success cases

, and includes the pr_debug() msg in both cases as well. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/nx-842-crypto.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/nx/nx-842-crypto.c b/drivers/crypto/nx/nx-842-crypto.c index 3288a70

[PATCH 7/8] crypto: nx - rename nx-842-crypto.c to nx-842.c

The last commit merged nx-842.c's code into nx-842-crypto.c. It did not rename nx-842-crypto.c to nx-842.c, in order to let the patch more clearly show what was merged. This just renames nx-842-crypto.c to nx-842.c, with no changes to its code. Signed-off-by: Dan Streetman ddstr...@ieee.org

[PATCH 2/8] crypto: nx - remove pSeries NX 'status' field

Remove the 'status' field from the pSeries NX driver data. The 'status' field isn't used by the driver at all; it simply checks the devicetree status node at initialization, and returns success if 'okay' and failure otherwise. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx

[PATCH 8/8] crypto: nx - make platform drivers directly register with crypto

with the crypto subsystem, using the same alg and driver name. This removes unneeded complexity. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Makefile | 6 +-- drivers/crypto/nx/nx-842-platform.c | 84 - drivers/crypto/nx/nx-842

[PATCH 4/8] crypto: nx - don't register pSeries driver if ENODEV

nodes, except when ENODEV is returned. However ENODEV should not be a special case and the driver should not register when there is no hw device, or the hw device is disabled. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/nx-842-pseries.c | 5 + 1 file changed, 1

[PATCH 6/8] crypto: nx - merge nx-compress and nx-compress-crypto

Merge the nx-842.c code into nx-842-crypto.c. This allows later patches to remove the 'platform' driver, and instead allow each platform driver to directly register with the crypto compression api. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Kconfig | 17

Re: [PATCH 5/6] [RFC] crypto/testmgr: add null test for 842 algorithm

On Mon, Jul 13, 2015 at 8:05 PM, Nishanth Aravamudan n...@linux.vnet.ibm.com wrote: On 13.07.2015 [17:05:36 -0700], Nishanth Aravamudan wrote: On 04.07.2015 [15:24:53 +0800], Herbert Xu wrote: On Thu, Jul 02, 2015 at 03:41:19PM -0700, Nishanth Aravamudan wrote: Currently, when the

Re: [PATCH 6/6] nx-842-platform: if NX842 platform drivers are not modules, don't try to load them

...@linux.vnet.ibm.com Cc: Dan Streetman ddstr...@us.ibm.com Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Cc: linux-crypto@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org Ugh, I think this whole thing is redundant. The whole point of the crypto API is to allow

[PATCH] MAINTAINERS: clarify drivers/crypto/nx/ file ownership

driver which has its own section. This lists explicitly what files are owned by the Crypto driver and which files are owned by the 842 compression driver. Signed-off-by: Dan Streetman ddstr...@ieee.org --- Leonidas, I assume you'll update the owner line at some point too, since you're the new NX

[PATCH] crypto: nx - add LE support to pSeries platform driver

Add support to the nx-842-pseries.c driver for running in little endian mode. The pSeries platform NX 842 driver currently only works as big endian. This adds cpu_to_be*() and be*_to_cpu() in the appropriate places to work in LE mode also. Signed-off-by: Dan Streetman ddstr...@ieee.org

Re: [cryptodev:master 73/233] drivers/crypto/nx/nx-842-pseries.c:45:14: error: 'DDE_BUFFER_LAST_MULT' undeclared here (not in a function)

On Sat, Jun 13, 2015 at 8:58 AM, kbuild test robot fengguang...@intel.com wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 81781e681551ed3f56c9202e9adc7ef941cba654 commit: 959e6659b6f74ec1fa4d391a3b88d63dc0189f36 [73/233] crypto: nx - add

[PATCH 1/2] crypto: move include/linux/nx842.h into drivers/crypto/nx/nx-842.h

compression driver, since the direct nx-842 api is very limited in the buffer alignments and sizes that it will accept, and the crypto compression interface handles those limitations and allows any alignment and size buffers. Signed-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS

[PATCH 0/2] remove nx842.h from include/linux

get the required working memory size from the NX 842 hw driver. This cleans up include/linux/ by 1 file, and it saves some memory by reducing the 842-nx working memory size down to exactly what the NX 842 platform driver requires. Dan Streetman (2): crypto: move include/linux/nx842.h into drivers

[PATCH 2/2] crypto: replace NX842_MEM_COMPRESS with function

sizeof() amount, as well as using the specific loaded platform driver's required amount, instead of the maximum of both. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/nx-842-crypto.c | 2 +- drivers/crypto/nx/nx-842-powernv.c | 11 +++ drivers/crypto/nx/nx-842

Re: [PATCH] crypto: prevent nx 842 load if no hw driver

On Wed, Jun 3, 2015 at 1:08 AM, Herbert Xu herb...@gondor.apana.org.au wrote: On Thu, May 28, 2015 at 04:21:31PM -0400, Dan Streetman wrote: Change the nx-842 common driver to wait for loading of both platform drivers, and fail loading if the platform driver pointer is not set. Add

[PATCH] crypto: prevent nx 842 load if no hw driver

) that expect an available crypto compression driver to actually work, this is bad. This patch fixes that, so the 842-nx crypto compression driver won't load if it doesn't have the driver and hardware available to perform the compression. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers

Re: [PATCH] crypto: move Kconfig 842 to end of list, default to N

On Fri, May 22, 2015 at 8:34 PM, Herbert Xu herb...@gondor.apana.org.au wrote: On Fri, May 22, 2015 at 08:08:28PM -0400, Dan Streetman wrote: Move the 842 compression alg choice to last in the list, so it's not in the middle of LZO/LZ4/LZ4HC. Change its default to N, as it is a very slow alg

[PATCH] crypto: move Kconfig 842 to end of list, default to N

Move the 842 compression alg choice to last in the list, so it's not in the middle of LZO/LZ4/LZ4HC. Change its default to N, as it is a very slow alg, which generally should only be used with compression hardware that's capable of doing it much faster. Signed-off-by: Dan Streetman ddstr

Re: [PATCH 09/11] crypto: remove LZO fallback from crypto 842

On Wed, Apr 8, 2015 at 10:38 AM, Herbert Xu herb...@gondor.apana.org.au wrote: On Wed, Apr 08, 2015 at 10:28:23AM -0400, Dan Streetman wrote: So, the sw implementation is only for decompression; there's no sw compression implementation in these patches. As a general rule we don't add any

Re: [PATCH 09/11] crypto: remove LZO fallback from crypto 842

On Wed, Apr 8, 2015 at 10:16 AM, Herbert Xu herb...@gondor.apana.org.au wrote: On Tue, Apr 07, 2015 at 01:34:28PM -0400, Dan Streetman wrote: Update the crypto 842 driver to no longer fallback to LZO if the 842 hardware is unavailable. Simplify the crpypto 842 driver to remove all headers

Re: [PATCH 11/11] crypto: add crypto compression sefltest

On Wed, Apr 8, 2015 at 10:16 AM, Herbert Xu herb...@gondor.apana.org.au wrote: On Tue, Apr 07, 2015 at 01:34:30PM -0400, Dan Streetman wrote: Add configurable module to perform self-tests on any crypto compression driver. This allows testing any crypto compression driver with any input buffer

[PATCH 11/11] crypto: add crypto compression sefltest

by the compressor during compression or decompression will end the test and be logged. Signed-off-by: Dan Streetman ddstr...@ieee.org --- crypto/Kconfig | 9 + crypto/Makefile| 1 + crypto/comp_selftest.c | 928 + 3 files changed, 938

[PATCH 06/11] drivers/crypto/nx: add nx842 constraints

the 842 hardware requires buffers to meet specific constraints that vary based on platform - for example, the pSeries max length is much lower than the PowerNV max length. These constraints are used by a later patch that improves the crypto 842 driver. Signed-off-by: Dan Streetman ddstr...@ieee.org

[PATCH 00/11] add 842 hw compression for PowerNV platform

variable alignment and length buffers, multiple threads, and can calculate the throughput. Dan Streetman (11): powerpc: export of_get_ibm_chip_id function powerpc: Add ICSWX instruction crypto: add software 842 decompression drivers/crypto/nx: move nx-842.c to nx-842-pseries.c drivers/crypto/nx

[PATCH 03/11] crypto: add software 842 decompression

function is required by later patches that update the crypto 842 driver to fall back to software 842 decompression if the NX-842 hardware fails and/or returns an error. Signed-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS | 2 + include/linux/sw842.h| 7 + lib/842

[PATCH 07/11] drivers/crypto/nx: add PowerNV platform NX-842 driver

Add driver for NX-842 hardware on the PowerNV platform. This allows the use of the 842 compression hardware coprocessor on the PowerNV platform. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Kconfig | 10 + drivers/crypto/nx/Makefile | 2 + drivers

[PATCH 09/11] crypto: remove LZO fallback from crypto 842

/decompression. The user of the crypto 842 driver can fallback to another format if desired. Signed-off-by: Dan Streetman ddstr...@ieee.org --- crypto/842.c | 139 - crypto/Kconfig | 4 +- 2 files changed, 29 insertions(+), 114 deletions

[PATCH 10/11] crypto: rewrite crypto 842 to use nx842 constraints

with any alignment or length buffers; previously with only the pSeries NX-842 driver all (uncompressed) buffers needed to be page-sized and page-aligned. Signed-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS | 1 + crypto/842.c | 414

[PATCH 08/11] drivers/crypto/nx: simplify pSeries nx842 driver

-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/nx-842-pseries.c | 779 - 1 file changed, 153 insertions(+), 626 deletions(-) diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842-pseries.c index 3773e36..0b7bad3 100644

[PATCH 01/11] powerpc: export of_get_ibm_chip_id function

Export the of_get_ibm_chip_id() function. This will be used by the PowerNV NX-842 driver. Signed-off-by: Dan Streetman ddstr...@ieee.org --- arch/powerpc/kernel/prom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c index b8e15c6

[PATCH 05/11] drivers/crypto/nx: add NX-842 platform frontend driver

Add NX-842 frontend that allows using either the pSeries platform or PowerNV platform driver for the NX-842 hardware. Update the MAINTAINERS file to include the new filenames. Signed-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS| 2 +- crypto/842.c

[PATCH 04/11] drivers/crypto/nx: move nx-842.c to nx-842-pseries.c

-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Makefile |2 +- drivers/crypto/nx/nx-842-pseries.c | 1603 drivers/crypto/nx/nx-842.c | 1603 3 files changed, 1604 insertions(+), 1604

[PATCH 02/11] powerpc: Add ICSWX instruction

for communication with the NX-842 coprocessor on a PowerNV system. Signed-off-by: Dan Streetman ddstr...@ieee.org --- arch/powerpc/include/asm/icswx.h | 184 ++ arch/powerpc/include/asm/ppc-opcode.h | 13 +++ 2 files changed, 197 insertions(+) create mode

Re: algif for compression?

On Thu, Apr 3, 2014 at 8:41 AM, Herbert Xu herb...@gondor.apana.org.au wrote: Dan Streetman ddstr...@ieee.org wrote: I see the algif_hash and algif_blkcipher implementations to allow userspace AF_ALG socket access to kernel blkcipher and hash algorithms, but has anyone done a algif_compression

algif for compression?

I see the algif_hash and algif_blkcipher implementations to allow userspace AF_ALG socket access to kernel blkcipher and hash algorithms, but has anyone done a algif_compression to allow userspace access to compression algs? I'm asking specifically wrt the 842 crypto module, which uses the