Re: [PATCH] crypto: dh - fix memory leak

rification test") > Signed-off-by: Gustavo A. R. Silva Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: DRBG - use caller buffer if suitable

e to sync skcipher algorithms won't be useful? It's something that others have asked for in the past too. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: DRBG - use caller buffer if suitable

ess can be used on an SG list. A better solution would be either an SG-list interface for rng, or alternatively a virtual address interface for sync skcipher. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: dh - fix calculating encoded key size

ould be a last resort. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v1 0/5] crypto: ccp - Driver updates 2018-07-03

ivers/crypto/ccp/psp-dev.h | 19 +-- > drivers/crypto/ccp/sp-dev.h |7 ++- > drivers/crypto/ccp/sp-pci.c | 36 ++-- > 4 files changed, 54 insertions(+), 40 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: padlock-aes - Fix Nano workaround data corruption

: a76c1c23d0c3 ("crypto: padlock-aes - work around Nano CPU...") Cc: Reported-by: Jamie Heilman Signed-off-by: Herbert Xu diff --git a/drivers/crypto/padlock-aes.c b/drivers/crypto/padlock-aes.c index 1c6cbda..09d823d 100644 --- a/drivers/crypto/padlock-aes.c +++ b/drivers/crypto/padlock-aes.c

Re: [PATCH] crypto: dh - fix calculating encoded key size

- add public key verification test") > Signed-off-by: Eric Biggers Is it possible to return an error and use WARN_ON instead of BUG_ON? Or do the callers not bother to check for errors? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/6] crypto: fixes and cleanups

-- > drivers/crypto/ccree/cc_driver.c | 4 +- > drivers/crypto/ccree/cc_hash.c | 81 +---------- > 4 files changed, 153 insertions(+), 124 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/6] crypto: remove redundant type specifications

ting of type flags > crypto: remove redundant type flags from tfm allocation All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: x86/sha256-mb - fix digest copy in sha256_mb_mgr_get_comp_job_avx2()

printf("wrong digest: "); > for (i = 0; i < 32; i++) > printf("%02x", digest[i]); > printf("\n"); > } > > Output was: > > wrong digest: > ad7facb2ffef7cb47c7a85dabd8b48892ca

Re: [PATCH] crypto: MAINTAINERS - fix file path for SHA multibuffer code

applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/4] crypto: decrease priority of multibuffer SHA algorithms

crypto/sha512_generic.c | 2 ++ > 6 files changed, 29 insertions(+), 3 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/5] crypto: inside-secure - support more algorithms

c | 157 ++-- > drivers/crypto/inside-secure/safexcel_ring.c | 48 ++- > 6 files changed, 553 insertions(+), 164 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ECDH - add public key verification test

rstrass equation given in D.1.2 where a = p - 3. > > Without the test, the NIST ACVP testing fails. After adding this check, > the NIST ACVP testing passes. > > Signed-off-by: Stephan Mueller Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~he

Re: [PATCH] crypto: arm/speck - fix building in Thumb2 mode

lso matches what aes-neonbs-core.S does. > > Reported-by: Stefan Agner > Fixes: ede9622162fa ("crypto: arm/speck - add NEON-accelerated implementation > of Speck-XTS") > Signed-off-by: Eric Biggers Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/4] crypto: vmac - various fixes

> crypto/tcrypt.c | 2 +- > crypto/testmgr.c | 4 +- > crypto/testmgr.h | 217 + > crypto/vmac.c | 444 -- > include/crypto/vmac.h | 63 -- > 5 files changed, 351 insertions(+), 379 deletions(-

Re: [PATCH] crypto: cavium: make structure algs static

warning: symbol 'algs' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: atmel-ecc - fix to allow multi segment scatterlists

")'. > > Signed-off-by: Tudor Ambarus Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 00/10] crypto: inside-secure - sha512/384 support

e/safexcel.c | 6 + > drivers/crypto/inside-secure/safexcel.h | 23 +- > .../crypto/inside-secure/safexcel_cipher.c| 89 +++- > drivers/crypto/inside-secure/safexcel_hash.c | 381 -- > include/crypto/sha.h | 4 + > 6 files changed,

Re: [PATCH] crypto: atmel-ecc - remove overly verbose dev_info

t; Signed-off-by: Tudor Ambarus Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: don't optimize keccakf()

- rewrite KECCAK transform to help > the compiler optimize") > Reported-by: syzbot+37035ccfa9a0a017f...@syzkaller.appspotmail.com > Reported-by: syzbot+e073e4740cfbb3ae2...@syzkaller.appspotmail.com > Cc: linux-crypto@vger.kernel.org > Cc: "David S. Miller" > Cc:

Re: [PATCH v2] crypto: arm64/aes-blk - fix and move skcipher_walk_done out of kernel_neon_begin,_end

83381747270 ("crypto: arm64/aes-blk - move kernel mode neon > en/disable into loop") > > [1] https://www.spinics.net/lists/linux-crypto/msg33103.html > > Signed-off-by: jia...@hxt-semitech.com > Acked-by: Ard Biesheuvel > Cc: # 4.17 Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: morus640 - Fix out-of-bounds access

.c). > > Fixes: 396be41f16fd ("crypto: morus - Add generic MORUS AEAD implementations") > Reported-by: syzbot+1fafa9c4cf42df33f...@syzkaller.appspotmail.com > Reported-by: syzbot+d82643ba80bf6937c...@syzkaller.appspotmail.com > Signed-off-by: Ondrej Mosnacek Patch applied.

Re: [PATCH V3 1/2] evm: Don't deadlock if a crypto algorithm is unavailable

; instead of deadlocking. > > Signed-off-by: Matthew Garrett Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH V2 1/2] evm: Don't deadlock if a crypto algorithm is unavailable

; instead of deadlocking. > > Signed-off-by: Matthew Garrett > --- > crypto/api.c| 2 +- > include/linux/crypto.h | 5 + > security/integrity/evm/evm_crypto.c | 3 ++- > 3 files changed, 8 insertions(+), 2 deletions(-) Acked-by: Herbe

Re: [PATCH 1/2] evm: Don't deadlock if a crypto algorithm is unavailable

there is no algorithm registered. So what's the difference? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/2] crypto: remove x86 salsa20 implementations

e mode 100644 arch/x86/crypto/salsa20_glue.c > delete mode 100644 include/crypto/salsa20.h All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] crypto:chelsio: Fixes and cleanup

; 4 files changed, 140 insertions(+), 183 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: clarify licensing of OpenSSL asm code

he GPLv2 license prominent. > > The .S files have been regenerated from the updated .pl files. > > This is a comment-only change. No code is changed. > > Signed-off-by: Adam Langley Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/3] crypto: caam - fix MC firmware detection

Chassis don't have an MC block (thus no MC f/w) > > To fix this, MC f/w detection will be based on the presence of > "fsl,qoriq-mc" compatible string in the device tree. > > Fixes: 297b9cebd2fc0 ("crypto: caam/jr - add support for DPAA2 parts") > Signed-off-by:

Re: [PATCH v2] crypto: Mark MORUS SIMD glue as x86-specific

> 5 files changed, 11 insertions(+), 8 deletions(-) > rename {crypto => arch/x86/crypto}/morus1280_glue.c (98%) > rename {crypto => arch/x86/crypto}/morus640_glue.c (98%) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/5] crypto: eliminate redundant decryption test vectors

ctor > crypto: testmgr - eliminate redundant decryption test vectors > > crypto/testmgr.c | 409 +- > crypto/testmgr.h | 12227 ++++- > 2 files changed, 954 insertions(+), 11682 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: x86/aegis256 - Fix wrong key buffer size

<ebigge...@gmail.com> > Signed-off-by: Ondrej Mosnacek <omosna...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/6] crypto: crc32 cleanups and unkeyed tests

++-- > crypto/tcrypt.c | 4 -- > crypto/testmgr.c| 56 +- > crypto/testmgr.h| 102 ++-- > 5 files changed, 66 insertions(+), 119 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> H

Re: [PATCH] crypto: chtls - fix a missing-check bug

bad data to the kernel, cause chtls_setkey() to set a wrong key or other > issues. > > This patch reuses the data copied in the first try so as to ensure these > checks will not be bypassed. > > Signed-off-by: Wenwen Wang <wang6...@umn.edu> Patch applied.

Re: [PATCH] crypto: inside-secure - do not use memset on MMIO

ne.ten...@bootlin.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 00/10] crypto: inside-secure - AEAD support

| 32 + > drivers/crypto/inside-secure/safexcel.h | 44 +- > .../crypto/inside-secure/safexcel_cipher.c| 642 ++ > drivers/crypto/inside-secure/safexcel_hash.c | 23 +- > 5 files changed, 600 insertions(+), 142 deletions(-) All applied. Thanks. -- Emai

Re: [PATCH] crypto: chtls: generic handling of data and hdr

; > Signed-off-by: Atul Gupta <atul.gu...@chelsio.com> > Signed-off-by: Harsh Jain <ha...@chelsio.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: PBKDF2 support in the linux kernel

n 2) support in the > kernel? (https://tools.ietf.org/html/rfc2898#5.2) > We have hmac sha1 in the kernel, do we have plan to port/implement > corresponding PBKDF2 in the kernel too? The rule for adding crypto code to the kernel is simple, there must be an in-kernel user of the algorithm. Cheers,

Re: [PATCH 0/4] Add support for MORUS AEAD algorithm

t; crypto: testmgr - Add test vectors for MORUS > crypto: Add common SIMD glue code for MORUS > crypto: x86 - Add optimized MORUS implementations All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] Add support for AEGIS AEAD algorithm

ions.html > [4] https://bench.cr.yp.to/ebaead.html > [5] https://is.muni.cz/th/409879/fi_m/?lang=en > > Ondrej Mosnacek (3): > crypto: Add generic AEGIS AEAD implementations > crypto: testmgr - Add test vectors for AEGIS > crypto: x86 - Add optimized AEGIS implemen

Re: [PATCH] crypto: reorder paes test lexicographically

for hardware keys") > Reported-by: Abdul Haleem <abdha...@linux.vnet.ibm.com> > Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: nx: fix spelling mistake: "seqeunce" -> "sequence"

On Wed, May 09, 2018 at 10:16:36AM +0100, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in CSB_ERR error message text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks.

Re: [PATCH] crypto: chelsio: request to HW should wrap

only > -Few reverse christmas tree correction > > Signed-off-by: Atul Gupta <atul.gu...@chelsio.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: n2: fix spelling mistake: "restesting" -> "retesting"

Colin King <colin.k...@canonical.com> wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in dev_err error message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herber

Re: [PATCH 1/2] crypto: vmx - Remove overly verbose printk from AES init routines

m_call+0x58/0x6c > > > Is it normal for init to be called on every system call? This is the tfm init function, so yes it is called every time you allocate a tfm. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH resend 00/10] crypto: arm64 - play nice with CONFIG_PREEMPT

+- > 12 files changed, 762 insertions(+), 435 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 1/7] crypto: chtls: wait for memory sendmsg, sendpage

please add a cover email for the series. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

gt; I have got rid of the mcryptd layer( have an inner layer, outer SIMD layer, > handled the pointers and completions accordingly), but still facing some > issues after removing the per cpu mcryptd_cpu_queue. Why don't you post what you've got and we can work it out together? Thanks, --

Re: DMA map buffer allocated in ahash_request_ctx

map it to H/W.? > > Not Herbert but... the ccree driver is doing just and Herbert > specifically indicated ahash request contexts are not allowed to be > allocated from stack (I asked) so it should be OK. That's right. For async algorithms the request must come from kmalloc

Re: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

ion. Which is fine as long as you can disable the FPU. If not the simd wrapper will defer the job to kthread context as required. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ghash-clmulni: fix spelling mistake: "acclerated" -> "accelerated"

On Fri, Apr 27, 2018 at 07:08:05PM +0100, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in module description text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks.

Re: [PATCH] crypto: tcrypt: Remove VLA usage

mium.org> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: caam - fix size of RSA prime factor q

Fixes: 4a651b122adb ("crypto: caam - add support for RSA key form 3") > Reported-by: David Binderman <dcb...@hotmail.com> > Signed-off-by: Horia Geantă <horia.gea...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http

Re: [PATCH 0/2] Fix stm32-rng for default state and suspend

Lionel Debieve (2): > hwrng: stm32 - define default state for rng driver > hwrng: stm32-rng: Fix pm_suspend issue > > drivers/char/hw_random/Kconfig | 1 + > drivers/char/hw_random/stm32-rng.c | 9 +++-- > 2 files changed, 8 insertions(+), 2 deletions(-) All applied.

Re: [PATCH 0/2] crypto: implement SM4 for arm64 using special instructions

sm4_generic.c| 10 +-- > include/crypto/sm4.h| 3 + > 6 files changed, 127 insertions(+), 4 deletions(-) > create mode 100644 arch/arm64/crypto/sm4-ce-core.S > create mode 100644 arch/arm64/crypto/sm4-ce-glue.c All applied. Thanks. -- Email: Herbert X

Re: [PATCH v2 0/2] cleanup and hardware keys

t > > crypto/testmgr.c | 43 + > drivers/crypto/ccree/cc_cipher.c | 350 > ++- > drivers/crypto/ccree/cc_cipher.h | 30 +--- > drivers/crypto/ccree/cc_driver.c | 2 +- > 4 files changed, 362 insertions(+),

Re: [PATCH 01/10] crypto: aead - allow to allocate AEAD requests on the stack

f the synchonous crypto API. I would suggest either allocating a new request on the spot or if that is not convenient, pre-allocating it in the cra_init function. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 01/10] crypto: aead - allow to allocate AEAD requests on the stack

ou need this? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v1 1/7] crypto: crypto4xx - performance optimizations

@gmail.com> All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RESEND PATCH v2] crypto: cavium: zip: Remove unnecessary parentheses

> 1 file changed, 21 insertions(+), 21 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 06/61] crypto: simplify getting .drvdata

ted only. buildbot is happy. Please apply individually. > > drivers/crypto/exynos-rng.c | 6 ++ > drivers/crypto/picoxcell_crypto.c | 6 ++ > 2 files changed, 4 insertions(+), 8 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> H

Re: [PATCH] crypto: omap-sham: fix memleak

> Cc: sta...@vger.kernel.org > Signed-off-by: Bin Liu <b-...@ti.com> > --- > drivers/crypto/omap-sham.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au

Crypto Fixes for 4.17

currently being tested Stephan Mueller (1): crypto: drbg - set freed buffers to NULL crypto/api.c | 11 --- crypto/drbg.c |2 ++ 2 files changed, 10 insertions(+), 3 deletions(-) Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page

Re: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

if we simply > call the inner algorithm. I don't think mcryptd is providing any real facility to the flushing apart from a helper. That same helper can live anywhere. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 2/2] crypto: caam - allow retrieving 'era' from register

property is optional, so 0eeabcad7da5 is not incorrect > by not passing it. > > As we can retrieve the era information by reading the CAAM registers > we can fix the problem on imx7 running 4.17-rc with this patch. As this is a new device support issue I'd prefer to delay thi

Re: [PATCH v4 2/2] crypto: caam - allow retrieving 'era' from register

300 (Era -524) Is this a regression or a preexisting bug? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: via-rng - support new Centaur CPU

On Fri, Apr 13, 2018 at 03:03:03PM +0800, David Wang wrote: > New Centaur CPU(Family > 6) supprt Random Number Generator, but can't > support MSR_VIA_RNG. Just like VIA Nano. > > Signed-off-by: David Wang <davidw...@zhaoxin.com> Patch applied. Thanks. -- Em

Re: [PATCH] crypto: api - fix finding algorithm currently being tested

ms. Also > don't leak a reference to the algorithm. > > Fixes: eb02c38f0197 ("crypto: api - Keep failed instances alive") > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: caam: - Use kmemdup() function

lle script. > > Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: caam - strip input zeros from RSA input buffer

oryktapcb4izhnanekkgfi9xaqmjhi_n-8ywoc...@mail.gmail.com > Signed-off-by: Horia Geantă <horia.gea...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: drbg - set freed buffers to NULL

...@chronox.de> > Reported-by: syzbot+75397ee3df5c70164...@syzkaller.appspotmail.com Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: rsa - Remove unneeded error assignment

d to the error > code inside the if block. > > In the case of non failure, 'ret' will be overwritten > immediately after, so remove the unneeded assignment. > > Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH] crypto: testmgr: Allow different compression results

thms seem to be all over the place on this so we should fix them all to use the -generic suffix and then we can simply append the -generic suffix here before allocating it. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: h

Re: [PATCH][next] crypto: chtls: don't leak information from the stack to userspace

Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto : chtls_cm - Fix potential NULL pointer dereferences

stavo A. R. Silva <gust...@embeddedor.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][next] crypto: chtls: remove redundant assignment to cdev->ports

t;Unused value") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 1/2] crypto: caam - staticize caam_get_era()

t; > Reviewed-by: Horia Geantă <horia.gea...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: testmgr: Allow different compression results

Signed-off-by: Balakrishna Bhamidipati <bbhamidip...@cavium.com> > [jglau...@cavium.com: removed unrelated printk changes, rewrote commit msg, > fixed whitespace and unneeded initialization] > Signed-off-by: Jan Glauber <jglau...@cavium.com> Patch applied. Thanks. -- Email: Herbert

Re: [PATCH v2 0/2] crypto: removing various VLAs

On Mon, Apr 09, 2018 at 03:54:45PM +0200, Salvatore Mesoraca wrote: > v2: > As suggested by Herbert Xu, the blocksize and alignmask checks > have been moved to crypto_check_alg. > So, now, all the other separate checks are not necessary. > Also, the defines

Re: [PATCH v4 2/2] crypto: caam - allow retrieving 'era' from register

fsl,sec-era' property is not passed in the device > tree. > > This function is based on the U-Boot implementation from > drivers/crypto/fsl/sec.c > > Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au

Re: [PATCH v2 0/5] ThunderX ZIP driver bug fixes

in.c| 24 +++- > drivers/crypto/cavium/zip/zip_main.h| 1 - > 7 files changed, 52 insertions(+), 28 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 1/2] crypto: authenc - don't leak pointers to authenc keys

; > Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RESEND PATCH] crypto: Add zstd support

erre...@fb.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 2/2] crypto: authencesn - don't leak pointers to authenc keys

; > Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto/ecc: Actually remove stack VLA usage

ml.org/lkml/2018/3/7/621 > > Signed-off-by: Kees Cook <keesc...@chromium.org> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] crypto: caam - IV-related fixes

++--- > 2 files changed, 219 insertions(+), 239 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: testmgr: Allow different compression results

o perform the decompression. This way if there were multiple implementations we can at least test them against the generic one. Otherwise you could end up with a buggy implementation that works against itself but still generates incorrect output. Cheers, -- Email: Herbert Xu <herb...@gondor.a

Re: [PATCH 2/2] crypto: ccree: enable support for hardware keys

nary blob. The s390 code seems to do this correctly. > > As noted above, the haes "key" is really a token encoding 3 different > pieces of information: My point is that you should not just cast it but instead do a copy to properly aligned kernel memory. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

cryptd, then we will have just the 2? It should be down to just one, i.e., the current inner algorithm. It's doing all the scheduling work already so I don't really see why it needs the wrappers around it. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Pa

Re: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

On Tue, Apr 17, 2018 at 06:40:17PM +, Dey, Megha wrote: > > > >-Original Message----- > >From: Herbert Xu [mailto:herb...@gondor.apana.org.au] > >Sent: Friday, March 16, 2018 7:54 AM > >To: Dey, Megha <megha@intel.com> > >Cc: linux-ker...@vge

Re: [PATCH 3/6] crypto: api - avoid VLA use

>cra_type && (alg->cra_flags & CRYPTO_ALG_TYPE_MASK) == CRYPTO_ALG_TYPE_CIPHER) do_cipher_specific_check(); Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/6] crypto: ctr - avoid VLA use

On Sun, Apr 08, 2018 at 10:58:48AM +0200, Salvatore Mesoraca wrote: > > Fair enough. > After removing the individual checks the modification to the single files > will be just a couple of lines, is it OK for you if I collapse all of them in > just a single commit? Sure. -- Em

Re: [PATCH 2/6] crypto: ctr - avoid VLA use

e you're also adding a check to cipher algorithms in general, none of these individual checks are needed anymore. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 3/6] crypto: api - avoid VLA use

ct cipher_tfm *ops = >crt_cipher; > struct cipher_alg *cipher = >__crt_alg->cra_cipher; > > + if (size > MAX_BLOCKSIZE || alignmask > MAX_ALIGNMASK) > + return -EINVAL; > + This check should be done when the algorithm is registered. Perhaps crypto

Re: [PATCH 1/6] crypto: api - laying macros for statically allocated buffers

ntend on using it everywhere. This file is reserved for truly internal bits. Perhaps include/crypto/algapi.h would be a better place. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Update for 4.17

gth crypto: chelsio - Update IV before sending request to HW crypto: chelsio - Fix iv passed in fallback path for rfc3686 crypto: chelsio -Split Hash requests for large scatter gather list crypto: chelsio - Remove declaration of static function from header Herbert Xu

Re: [PATCH 2/2] crypto: ccree: enable support for hardware keys

e., your patch's use of "haes". It should be OK to just use paes for everyone, no? As to your patch specifically, there is one issue where you're directly dereferencing the key as a struct. This is a no-no because the key may have come from user-space. You must treat it as a binary blob.

Re: [PATCH] crypto: rsa - remove unneeded initializations

will then have to add the initialisation for it and we'll be back to square one. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: ccree: remove unused enums

On Mon, Mar 26, 2018 at 08:32:18AM +0100, Gilad Ben-Yossef wrote: > Remove enums definitions unused in the driver code. > > Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http:

<    1   2   3   4   5   6   7   8   9   10   >