Re: [RFC PATCH] crypto: brcm - explicitly cast cipher to hash type

~ ~^~~ > > Signed-off-by: Stefan Agner <ste...@agner.ch> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/9] crypto: don't leak pointers to authenc keys

s/crypto/talitos.c | 2 ++ > 9 files changed, 28 insertions(+), 12 deletions(-) Patches 3-9 applied. Please remove the unrelated changes from patches 1-2 and resubmit. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v1] crypto: Deduplicate le32_to_cpu_array() and cpu_to_le32_array()

Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: talitos - fix IPsec cipher in length

: <sta...@vger.kernel.org> # 4.8+ > Fixes: 549bd8bc5987 ("crypto: talitos - Implement AEAD for SEC1 using > HMAC_SNOOP_NO_AFEU") > Reported-by: Horia Geantă <horia.gea...@nxp.com> > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Than

Re: [PATCH v2] crypto: doc - clarify hash callbacks state machine

uture > > Link: https://lkml.kernel.org/r/20180222114741.ga27...@gondor.apana.org.au > Signed-off-by: Horia Geantă <horia.gea...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/9] crypto: inside-secure - hmac(sha256/sha224) support

.c| 8 +- > drivers/crypto/inside-secure/safexcel.h| 6 +- > drivers/crypto/inside-secure/safexcel_cipher.c | 3 +- > drivers/crypto/inside-secure/safexcel_hash.c | 189 > +++++++++ > 4 files changed, 170 insertions(+), 36 deletions(-) All appl

Re: [PATCH 1/1] crypto:chelsio - Remove declaration of static function from header

en Rothwell <s...@canb.auug.org.au> > Signed-off-by: Harsh Jain <ha...@chelsio.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: rsa - remove unneeded initializations

es in > rsa_enc/dec/sign. > > Reported-by: Benjamin Bales <techsupp...@mycode.ai> > Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com> The existing code looks fine. If anything we should move the assignments out of the if clause. Thanks, -- Email: Herbert Xu

Re: [PATCH 2/2] crypto: ccree: enable support for hardware keys

.flow_mode = S_DIN_to_AES, > + .min_hw_rev = CC_HW_REV_630, > + }, How can this possibly pass the self-test? If we want to add hardware keys we will need to figure out how to deal with it in the top-level API first. Are there other crypto drivers doing this? Th

Re: [PATCH v2 1/9] crypto: authenc - don't leak pointers to authenc keys

to badkey; > + if (crypto_authenc_extractkeys(, key, keylen) != 0) { > + crypto_aead_set_flags(authenc, CRYPTO_TFM_RES_BAD_KEY_LEN); > + goto out; > + } Why did you change this? The existing goto arrangement should work fine even with your addit

Re: [PATCH] omap-crypto - fix kernel oops and output buffer update

ubject, e.g., with a v2, v3, and so on. Also please retain the complete patch description on each occasion. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RESEND PATCH] crypto: Add zstd support

] > > lkml.kernel.org/r/9c9416b2dff19f05fb4c35879aaa83d11ff72c92.1521626182.git.geliangt...@gmail.com > > Signed-off-by: Nick Terrell <terre...@fb.com> ? Please resend with sign-off. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC PATCH] crypto: brcm - explicitly cast cipher to hash type

On Wed, Mar 28, 2018 at 05:41:30PM +0200, Stefan Agner wrote: > > Herbert, given that Raveendra agrees to the change, do you want me to > send a non-RFC version or can you merge the patch as is? There is no need to resend it. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.a

Re: [RESEND] SHASH_DESC_ON_STACK macro

Currently, this macro is being used in 46 different places. > > I wonder how big can tfm->descsize can get? descsize is capped at PAGE_SIZE / 8. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH v2] crypto: ahash - Fix early termination in hash walk

ectly in this case but move onto the next page. ---8<-- When we have an unaligned SG list entry where there is no leftover aligned data, the hash walk code will incorrectly return zero as if the entire SG list has been processed. This patch fixes it by moving onto the next page instead. Reporte

Re: [PATCH] crypto: cavium: cpt: Replace mdelay with msleep in cpt_device_init

tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: arm,arm64 - Fix random regeneration of S_shipped

oken perl. The solution is minimally intrusive to > make it easier to push into stable. > > Another report on a similar issue here: https://lkml.org/lkml/2018/3/8/1379 > > Signed-off-by: Leonard Crestez <leonard.cres...@nxp.com> > Cc: <sta...@vger.kernel.org> Patch ap

Re: [PATCH] crypto: doc - Document remaining members in struct crypto_alg

ff-by: Gary R Hook <gary.h...@amd.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 19/47] crypto: remove blackfin CRC driver

On Wed, Mar 14, 2018 at 04:35:32PM +0100, Arnd Bergmann wrote: > The blackfin architecture is getting removed, so this > driver won't be used any more. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.or

Re: [PATCH v2 0/2] Keystone2 HW random generator

ar/hw_random/ks-sa-rng.c All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] crypto: inside-secure: improve clock management

crypto/inside-secure/safexcel.h| 1 + > 3 files changed, 38 insertions(+), 16 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: fix missing unlock on error in safexcel_ahash_send_req()

; Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: talitos: Delete an error message for a failed memory allocation in talitos_edesc_alloc()

by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: ctr - avoid VLA use

ou have efficient unaligned access in general doesn't mean that every implementation can live with unaligned access. In particular, on x86 there are quite a few implementations that require alignment or they will fault. So please just make it 15 unconditionally. Thanks, -- Email: Herbert Xu <her

Re: [RFC PATCH] crypto: pcrypt - forbid recursive instantiation

. This is somewhat of a hack, but it's a > simple fix that should be sufficient to prevent the deadlock. I'm a bit uneasy with this fix. What if pcrypt is used in the underlying algorithm as a fallback? Wouldn't it still dead-lock without triggering this check? Thanks, -- Email: Herbert Xu <

crypto: lrw - Free rctx->ext with kzfree

The buffer rctx->ext contains potentially sensitive data and should be freed with kzfree. Cc: <sta...@vger.kernel.org> Fixes: 700cb3f5fe75 ("crypto: lrw - Convert to skcipher") Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Herbert Xu <herb..

Re: [PATCH 0/9] don't leak pointers to authenc keys

authenc keys. Please put this blurb into each patch description. Because when people look up the commit years from now they won't be able to find this email. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://g

crypto: api - Keep failed instances alive

w creation by deleting the instance from user-space. A new error (ELIBBAD) has been commandeered for this purpose and will be returned when all registered algorithm of a given name have failed the self-test. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> diff --git a/crypto/a

crypto: api - Remove unused crypto_type lookup function

The lookup function in crypto_type was only used for the implicit IV generators which have been completely removed from the crypto API. This patch removes the lookup function as it is now useless. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> diff --git a/crypto/api.c b/crypto

Re: [PATCH v5 00/23] crypto: arm64 - play nice with CONFIG_PREEMPT

waiting for the next > cycle, so be it. Sure it's done now. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: doc - clarify hash callbacks state machine

ations can be pending to be processed by the hardware. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: doc - clarify hash callbacks state machine

t objects. > I assume this is clear enough. My point is that all of the state associated with a request needs to be stored in the request object. If you're start storing things in the driver/hardware, then things will get ugly one way or another. Cheers, -- Email: Herbert Xu <herb...@gondor.ap

Re: [PATCH v11 crypto 00/12] Chelsio Inline TLS

On Sun, Mar 18, 2018 at 10:36:02AM -0400, David Miller wrote: > > Herbert, is it OK for this entire series to go via net-next? Sure, although there could be conflicts since the chelsio driver seems to be changing quite fast. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au&g

Re: [PATCH][next] crypto: x86/des3_ede: make array des3_ede_skciphers static

/crypto/des3_ede_glue.c:407:21: warning: symbol > 'des3_ede_skciphers' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> This patch no longer applies because it's already been merged from someone else. Thanks, -- Email: Herbert

Re: [PATCH v5 00/23] crypto: arm64 - play nice with CONFIG_PREEMPT

SHA512, SHA-3 and SM3 code that landed > in v4.16-rc1 Looks good to me. If more work is needed we can always do incremental fixes. Patches 1-22 applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto/ecc: Remove stack VLA usage

;nbytes" variable). > > [1] https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Kees Cook <keesc...@chromium.org> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: virtio - remove dependency on CRYPTO_AUTHENC

gt; > Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver") > Signed-off-by: Peter Wu <pe...@lekensteyn.nl> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ccp: Use memdup_user() rather than duplicating its implementation

issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: hash.h: Prevent use of req->result in ahash update

y: Kamil Konieczny <k.koniec...@partner.samsung.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto/ccp: Validate buffer lengths for copy operations

S. Szmigiero <m...@maciej.szmigiero.name> > Signed-off-by: Gary R Hook <gary.h...@amd.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/2] crypto: introduce SM4 symmetric cipher algorithm

rypto/sm4_generic.c > create mode 100644 include/crypto/sm4.h All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/5] crypto:chelsio: Bug fixes and cleanup

+++--- > drivers/crypto/chelsio/chcr_algo.h | 11 +- > drivers/crypto/chelsio/chcr_core.h | 6 +- > drivers/crypto/chelsio/chcr_crypto.h | 32 ++- > 4 files changed, 354 insertions(+), 160 deletions(-) All applied. Thanks. -- Email:

Re: [PATCH v2 0/2] hwrng: mxc-rnga - add driver support on boards with device tree

=> imx-rng.txt} | 11 +-- > drivers/char/hw_random/mxc-rnga.c | 23 > +- > 2 files changed, 19 insertions(+), 15 deletions(-) > rename Documentation/devicetree/bindings/rng/{imx-rngc.txt => imx-rng.txt} > (54%) All applied.

Re: [RFC PATCH] crypto: arm64/speck - add NEON-accelerated implementation of Speck-XTS

186.3 MB/s 181.8 MB/s >AES-128-XTS (NEON bit-sliced) 142.0 MB/s 124.3 MB/s >AES-256-XTS (NEON bit-sliced) 104.7 MB/s 91.1 MB/s > > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. -- Email: Herbert Xu &l

Re: [PATCH] crypto: doc - clarify hash callbacks state machine

se modify your commit description. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

mcryptd completely and expose the underlying algorithm as a proper async skcipher/hash? Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 00/12] crypto: inside-secure - hmac(sha256/sha224) support

On Thu, Mar 15, 2018 at 04:45:54PM +0100, Antoine Tenart wrote: > > I made a small mistake as the first 3 patches of the series already > were merged into your tree, as they already were sent in a previous > series. You can just ignore them. OK. Thanks, -- Email: Herb

Re: [Blackfin removal] [PATCH 18/28] crypto: Remove Blackfin crypto support

late on them, it makes no sense to do so and nobody provides a direct hmac(crc32) implementation. So there is no point for this test vector to exist. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ctr: avoid VLA use

ctr instance creation time. That is, if the underlying blocksize is greater than 16 bytes than simply fail the creation. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC PATCH cryptodev] crypto: des3_ede_skciphers[] can be static

On Sat, Mar 03, 2018 at 04:29:46AM +0800, kbuild test robot wrote: > > Fixes: 09c0f03bf8ce ("crypto: x86/des3_ede - convert to skcipher interface") > Signed-off-by: Fengguang Wu <fengguang...@intel.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.a

Re: [PATCH] crypto/ccp - Fill the result buffer only on digest, finup, and final ops

est misuse of result in ahash") > Signed-off-by: Gary R Hook <gary.h...@amd.com> > Cc: <sta...@vger.kernel.org> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] Crypto:Chelsio: no csum offload for ipsec path

On Wed, Feb 28, 2018 at 11:18:08PM +0530, Atul Gupta wrote: > The Inline IPSec driver does not offload csum. > > Signed-off-by: Atul Gupta <atul.gu...@chelsio.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org

Re: [PATCH 0/2] add crypto support for TPM communication

+ > crypto/Makefile | 1 + > crypto/cfb.c| 353 > crypto/ecdh.c | 23 +++- > 4 files changed, 379 insertions(+), 6 deletions(-) > create mode 100644 crypto/cfb.c All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page:

Re: [PATCH 1/4] crypto: omap-sham: Remove useless check for non-null request

rivers/crypto/omap-sham.c:812 omap_sham_prepare_request() warn: variable > dereferenced before check 'req' (see line 805) > > Signed-off-by: Krzysztof Kozlowski <k...@kernel.org> All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gond

Re: [PATCH 0/2] hwrng: omap: Fix clock resource for Armada 7K/8K

p-rng.c | 22 > ++ > 2 files changed, 24 insertions(+), 5 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: talitos - do not perform unnecessary dma synchronisation

t; to necessary situations. > > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/6] crypto: omap: fixes + tweaks for omap crypto

eferable? All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: talitos - don't persistently map req_ctx->hw_context and req_ctx->buf

chain in buffered data for ahash on > SEC1") > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: cavium: make two functions static

: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] crypto: inside-secure - fixes for heavy load usage

59 > ++------ > 3 files changed, 30 insertions(+), 57 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[]

On Fri, Mar 09, 2018 at 06:35:35AM -0800, Joe Perches wrote: > > and likely, as this is a global name, it should > be something like crypto_hash_alg_name crypto_ is not a good prefix here. Perhaps crypto_bcm_. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au>

Re: [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[]

t;sha3_224", "sha3_256", "sha3_384", "sha3_512" }; > +char const * const hash_alg_name[] = { "None", "md5", "sha1", "sha224", Please make that const char *const Ditto with patch 4. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 0/4] crypto: AF_ALG AIO improvements

On Tue, Feb 27, 2018 at 03:08:58PM +0100, Stephan Müller wrote: > Am Freitag, 23. Februar 2018, 13:00:26 CET schrieb Herbert Xu: > > Hi Herbert, > > > On Fri, Feb 23, 2018 at 09:33:33AM +0100, Stephan Müller wrote: > > > A simple copy operation, however, will im

Re: [PATCH v2 0/5] crypto:chelsio: Bug fixes and cleanup

d patches based on that. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Why are we testing an intermediate result in ahash?

rypto: testmgr - test misuse of result in...") Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> diff --git a/drivers/crypto/ccp/ccp-crypto-aes-cmac.c b/drivers/crypto/ccp/ccp-crypto-aes-cmac.c index 60fc0fa..acc8c64 100644 --- a/drivers/crypto/ccp/ccp-crypto-aes-cmac.c +++ b/driver

Re: Why are we testing an intermediate result in ahash?

> changes the operation is failed. > > My question is: why? The problem is that you must not touch the result buffer unless you're doing a finalisation. Indeed, the caller may have provided a NULL pointer for what it's worth. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.or

Re: [PATCH 2/3] crypto: ccp - return an actual key size from RSA max_size callback

(since CCP RSA implementation has a higher priority than the software > RSA implementation). That normally goes through the security tree. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/3] crypto: ccp - return an actual key size from RSA max_size callback

t; input buffer. > > Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> > Fixes: ceeec0afd684 ("crypto: ccp - Add support for RSA on the CCP") > Cc: sta...@vger.kernel.org Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home

Re: [PATCH] crypto/ccp: don't disable interrupts while setting up debugfs

from_fork+0x27/0x50 > > If any locking is required, a simple mutex will do it. > > Cc: Gary R Hook <gary.h...@amd.com> > Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 0/4] Enable CAAM on i.MX7s fix TrustZone issues

- Horia. > > V3: > - Added Cc: clk driver maintainers - Fabio Estevam > - Added Cc: i.MX arch maintainers - Fabio Estevam > - Removed bouncing email address for Herbert Xu > > V2-resend: > - Patch 0005 lost in the ether - resending > > V2: > - Endian detection is ok

Re: [PATCH] crypto: atmel-aes - fix the keys zeroing on errors

uthenc - add support to > authenc(hmac(shaX), Y(aes)) modes") > Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: ccp: add check to get PSP master only when PSP is detected

--- > > Changes since v1: > > v1 contained a local change I used for triggering the crash on EPYC system. > we do not need those changes in final patch. Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 00/30] crypto: x86 glue code cleanup/conversion

blk_helper.h | 32 -- > include/crypto/internal/simd.h | 7 + > include/crypto/lrw.h | 44 --- > include/crypto/xts.h | 17 - > 27 files changed, 1489 insertions(+), 4634 deletions(-) > delete mode 100644 cry

Re: [PATCH] crypto: marvell/cesa - Clean up redundant #include

> Signed-off-by: Robin Murphy <robin.mur...@arm.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/4] cleanups and new HW rev support

| 14 ++ > 15 files changed, 240 insertions(+), 158 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: ccp: Fix sparse, use plain integer as NULL pointer

b...@suse.de> > Cc: Herbert Xu <herb...@gondor.apana.org.au> > Cc: Gary Hook <gary.h...@amd.com> > Cc: Tom Lendacky <thomas.lenda...@amd.com> > Signed-off-by: Brijesh Singh <brijesh.si...@amd.com> All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana

Re: [PATCH Resend 0/5] hwrng: stm32 - Improvement for stm32-rng

/bindings/rng/st,stm32-rng.txt | 4 ++ > drivers/char/hw_random/stm32-rng.c | 44 > ++ > 2 files changed, 32 insertions(+), 16 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http:/

Re: [PATCH Resend 0/5] hwrng: stm32 - Improvement for stm32-rng

On Thu, Feb 22, 2018 at 04:25:46PM +0100, Alexandre Torgue wrote: > Hi > > On 02/22/2018 03:03 PM, Herbert Xu wrote: > >On Thu, Feb 15, 2018 at 02:03:07PM +0100, Lionel Debieve wrote: > >>This set of patches add extended functionalities for stm32 rng > >>driv

Re: [PATCH v3 0/4] crypto: AF_ALG AIO improvements

ubmission process. If you're instead processing lots of tiny requests, do NOT use algif because it's not designed for that. Therefore spending too much time to optimise the submission overhead seems pointless to me. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au>

Re: [PATCH] crypto: ixp4xxx: Use dma_pool_zalloc()

On Thu, Feb 22, 2018 at 08:54:27PM +0530, Souptick Joarder wrote: > > Apology, Missed it. Then adding dma_pool_zalloc() not making much difference. > Shall I drop this patch or send v2 ? I think we should probably leave it alone. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.

Re: [PATCH 0/2] crypto/sahara: Adjustments for sahara_probe()

ng (2): > Delete an error message for a failed memory allocation > Improve a size determination > > drivers/crypto/sahara.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: ht

Re: [PATCH] crypto: bfin_crc: Delete an error message for a failed memory allocation in bfin_crypto_crc_probe()

by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: bcm: Delete an error message for a failed memory allocation in do_shash()

by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: atmel: Delete error messages for a failed memory allocation in six functions

by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ixp4xxx: Use dma_pool_zalloc()

On Thu, Feb 22, 2018 at 08:32:36PM +0530, Souptick Joarder wrote: > On Thu, Feb 22, 2018 at 7:40 PM, Herbert Xu <herb...@gondor.apana.org.au> > wrote: > > On Sat, Feb 17, 2018 at 03:41:13PM +0530, Souptick Joarder wrote: > >> Use dma_pool_zalloc() instead

Re: [PATCH] crypto: fix memdup.cocci warnings

by: scripts/coccinelle/api/memdup.cocci > > Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support") > CC: Gilad Ben-Yossef <gi...@benyossef.com> > Signed-off-by: Fengguang Wu <fengguang...@intel.com> Patch applied. Thanks. -- Email: Herbert Xu <he

Re: [PATCH v2 00/14] x86/crypto gcmaes SSE scatter/gather support

byte update > x86/crypto: aesni: Introduce scatter/gather asm function stubs > x86/crypto: aesni: Update aesni-intel_glue to use scatter/gather > > arch/x86/crypto/aesni-intel_asm.S | 1414 > ++-- > arch/x86/crypto/aesni-intel_glue.c | 230 +- > 2 files changed, 899 insertions(+), 745 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: nx-842: Delete an error message for a failed memory allocation in nx842_pseries_init()

by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 0/5] crypto: Speck support

1 + > crypto/speck.c| 307 ++ > crypto/testmgr.c | 36 + > crypto/testmgr.h | 1486 + > include/crypto/speck.h| 62 ++ > 10 files changed, 2634 insertions(+) > create mode 100644 arc

Re: [PATCH 0/4] Ux500 crypto: Adjustments for ux500_cryp_probe()

9 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/8] crypto: inside-secure - stabilization and fixes

> +++--- > drivers/crypto/inside-secure/safexcel.h| 6 ++-- > drivers/crypto/inside-secure/safexcel_cipher.c | 2 +- > drivers/crypto/inside-secure/safexcel_hash.c | 10 --- > 5 files changed, 33 insertions(+), 27 deletions(-) All applied. Thanks.

Re: [PATCH] hwrng: bcm2835: Handle deferred clock properly

ge an optional clock") > Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: arm/aes-cipher - move S-box to .rodata section

On Mon, Feb 12, 2018 at 10:52:37PM +0900, Jinbum Park wrote: > Move the AES inverse S-box to the .rodata section > where it is safe from abuse by speculation. > > Signed-off-by: Jinbum Park <jinb.pa...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gond

Re: [PATCH] crypto: sunxi-ss: Add MODULE_ALIAS to sun4i-ss

to > accelerator") > Cc: <sta...@vger.kernel.org> > Signed-off-by: Peter Robinson <pbrobin...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 0/4] crypto: aesni - Use zero-copy for gcm(aes) buffers that are partially contiguous

) I think this conflicts with Dave Watson's work. Could you rebase this on top of his patches? Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Fixes for 4.16

+--- 1 file changed, 9 insertions(+), 3 deletions(-) Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ixp4xxx: Use dma_pool_zalloc()

move the memset at these other points. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH Resend 0/5] hwrng: stm32 - Improvement for stm32-rng

nly patches 1/3/5, right? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

do batching in drivers. Such optimisations should instead be done at a higher level. For example, for disk encryption we want to do the aggregation at the block layer rather than the crypto API because that has innate knowledge of the data layout which we can only guess. Cheers, -- Email: Herb

Re: [PATCH 2/2] crypto: bcm: One function call less in do_shash() after error detection

f the passed variable contained a null pointer. > > * Reorder two function calls at the end. > > * Add a jump target. This patch is pointless as kfree on NULL is a no-op. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP K

<    1   2   3   4   5   6   7   8   9   10   >