Re: [PATCH 2/2] crypto: omap: Improve a size determination in three functions

2018-02-22 Thread Herbert Xu
ct omap_aes_dev), GFP_KERNEL); I'm fine with sizeof(*dd) but please don't combine the allocation with the declaration. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 0/4] crypto: AF_ALG AIO improvements

2018-02-22 Thread Herbert Xu
. Remember, you must not start the sendmsg for the next request until the recvmsg system call for the previous request has completed. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

2018-02-22 Thread Herbert Xu
t; > .init() -> .update() -> .finup() > ^| | > '' '---> HASH > >.digest() >| >'---> HASH The documentation is simply incomplete in this regard. Cheers, -- Email: Herbert Xu <herb...@

Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

2018-02-20 Thread Herbert Xu
curs is unacceptable, both from user-space and the kernel. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/6] crypto: engine - Permit to enqueue all async requests

2018-02-16 Thread Herbert Xu
the patches to be squashed then please send them in one email. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/7] crypto: ccree: Introduce Arm TrustZone CryptoCell

2018-02-15 Thread Herbert Xu
iver > crypto: ccree: add skcipher support > crypto: ccree: add ahash support > crypto: ccree: add AEAD support > crypto: ccree: add FIPS support > MAINTAINERS: update ccree entry All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 0/5] crypto: ahash.c: Require export/import in ahash

2018-02-15 Thread Herbert Xu
> drivers/crypto/mxs-dcp.c | 14 ++ > drivers/crypto/n2_core.c | 12 > drivers/crypto/ux500/hash/hash_core.c | 18 ++ > 5 files changed, 58 insertions(+), 16 deletions(-) All applied. Thanks. -

Re: [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static

2018-02-15 Thread Herbert Xu
i.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: mcryptd - remove pointless wrapper functions

2018-02-15 Thread Herbert Xu
@google.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: sha1-mb - remove HASH_FIRST flag

2018-02-15 Thread Herbert Xu
On Wed, Jan 24, 2018 at 07:10:08PM -0800, Eric Biggers wrote: > From: Eric Biggers <ebigg...@google.com> > > The HASH_FIRST flag is never set. Remove it. > > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@

Re: [PATCH] crypto: crypto_user: Replace GFP_ATOMIC with GFP_KERNEL in crypto_report

2018-02-15 Thread Herbert Xu
proves again that crypto_report can call functions which may sleep. > Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com> Patch applie

Re: [PATCH] crypto: rsa-pkcs1pad: Replace GFP_ATOMIC with GFP_KERNEL in pkcs1pad_encrypt_sign_complete

2018-02-15 Thread Herbert Xu
und by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/2] crypto: stm32/cryp - add AEAD cipher algorithms

2018-02-15 Thread Herbert Xu
AEAD cipher algortihms. > > Fabien Dessenne (2): > crypto: stm32/cryp - add aes gcm / ccm support > crypto: stm32/cryp - add stm32mp1 support All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP

Re: [PATCH v3] crypto: s5p-sss.c: Fix kernel Oops in AES-ECB mode

2018-02-15 Thread Herbert Xu
'Fixes: 8f9702aad138' as the error was > introduced earlier. Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat - Make several functions static

2018-02-15 Thread Herbert Xu
s/crypto/qat/qat_common/qat_asym_algs.c:1027:5: warning: symbol > 'qat_rsa_set_d' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondo

Re: [PATCH] crypto: s5p-sss.c: Fix kernel Oops in AES-ECB mode

2018-02-15 Thread Herbert Xu
onieczny <k.koniec...@partner.samsung.com> > Reported-by: Anand Moon <linux.am...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] crypto: stm32/hash: Correction to improve robustness

2018-02-15 Thread Herbert Xu
el Debieve (3): > crypto: stm32/hash: avoid error if maxburst not defined > crypto: stm32/hash: fix performance issues > crypto: stm32/hash: rework padding length All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/3] crypto: caam/qi - return -EBADMSG for ICV check failure

2018-02-15 Thread Herbert Xu
-off-by: Horia Geantă <horia.gea...@nxp.com> All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/6] crypto: engine - Permit to enqueue all async requests

2018-02-15 Thread Herbert Xu
to_transfer_xxx_request_to_engine functions > > Corentin Labbe (6): > Documentation: crypto: document crypto engine API > crypto: engine - Permit to enqueue all async requests > crypto: omap: convert to new crypto engine API > crypto: virtio: convert to new crypto engine AP

Re: [PATCH] crypto: sha256-mb - remove HASH_FIRST flag

2018-02-15 Thread Herbert Xu
On Wed, Jan 24, 2018 at 07:10:15PM -0800, Eric Biggers wrote: > From: Eric Biggers <ebigg...@google.com> > > The HASH_FIRST flag is never set. Remove it. > > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@

Re: [PATCH 0/5] hwrng: stm32 - Improvement for stm32-rng

2018-02-15 Thread Herbert Xu
/bindings/rng/st,stm32-rng.txt | 4 ++ > drivers/char/hw_random/stm32-rng.c | 44 > ++ > 2 files changed, 32 insertions(+), 16 deletions(-) I never received patch 5. Which trees are patch 2 and 4 meant to go through? Thanks

Re: [PATCH v3 2/3] MIPS: crypto: Add crc32 and crc32c hw accelerated module

2018-02-15 Thread Herbert Xu
ff-by: Marcin Nowakowski <marcin.nowakow...@mips.com> > Signed-off-by: James Hogan <jho...@kernel.org> > Cc: Ralf Baechle <r...@linux-mips.org> > Cc: Herbert Xu <herb...@gondor.apana.org.au> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: lin

Crypto Fixes for 4.16

2018-02-11 Thread Herbert Xu
|4 + include/linux/compiler-gcc.h |7 +- include/linux/compiler.h |4 + 7 files changed, 146 insertions(+), 111 deletions(-) Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page

Re: [PATCH 0/2] sun4i_ss_prng fixes

2018-02-09 Thread Herbert Xu
onvert lock to _bh in sun4i_ss_prng_generate > > drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PG

Re: [PATCH] crypto/generic - sha3: deal with oversize stack frames

2018-02-09 Thread Herbert Xu
reserves most > of the performance gain achieved by the rewrite, and also gets rid of > the excessive use of stack space. > > Reported-by: kbuild test robot <fengguang...@intel.com> > Suggested-by: Arnd Bergmann <a...@arndb.de> > Signed-off-by: Ard Biesheuvel <ard.bi

Re: [PATCH] crypto: talitos: fix Kernel Oops on hashing an empty file

2018-02-09 Thread Herbert Xu
t Oops by checking if src is NULL. > > Fixes: 6a1e8d14156d4 ("crypto: talitos - making mapping helpers more generic") > Cc: <sta...@vger.kernel.org> > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: sha512-mb - initialize pending lengths correctly

2018-02-09 Thread Herbert Xu
y syzkaller. > > Fixes: 45691e2d9b18 ("crypto: sha512-mb - submit/flush routines for AVX2") > Reported-by: syzbot <syzkal...@googlegroups.com> > Cc: <sta...@vger.kernel.org> # v4.8+ > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks

Re: [PATCH 1/2] libcrc32c: Add crc32c_impl function

2018-02-03 Thread Herbert Xu
> Crypto maintainers, would it be still possible to squeeze this patch to > 4.16? It's quite trivial, but as it is not in a code I maintain I'm not > comfortable to add it to my tree (unless I get an ACK). > > The linked patch depends on that change and would let us get rid of som

Crypto Update for 4.16

2018-01-29 Thread Herbert Xu
lsio - Add authenc versions of ctr and sha crypto: chelsio - Remove dst sg size zero check crypto: chelsio - Fix indentation warning Hauke Mehrtens (1): crypto: ecdh - fix typo in KPP dependency of CRYPTO_ECDH Herbert Xu (1): Merge git://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH v2] crypto: AES-NI GCM - handle zero length dst buffer

2018-01-26 Thread Herbert Xu
t. > > This fixes a crash that can be triggered by user space via AF_ALG. > > CC: <sta...@vger.kernel.org> > Signed-off-by: Stephan Mueller <smuel...@chronox.de> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: inside-secure - make function safexcel_try_push_requests static

2018-01-26 Thread Herbert Xu
sparse warning: > symbol 'safexcel_try_push_requests' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > [Antoine: fixed alignment] > Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Patch applied. Thanks. -- Email:

Re: [PATCH -next] crypto: axis - remove unnecessary platform_get_resource() error check

2018-01-26 Thread Herbert Xu
On Wed, Jan 17, 2018 at 11:26:47AM +, Wei Yongjun wrote: > devm_ioremap_resource() already checks if the resource is NULL, so > remove the unnecessary platform_get_resource() error check. > > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Patch applied. Thanks. --

Re: [PATCH] crypto: testmgr.c: test misuse of result in ahash

2018-01-26 Thread Herbert Xu
h applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: artpec6 - remove select on non-existing CRYPTO_SHA384

2018-01-26 Thread Herbert Xu
lerator > driver") > Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()

2018-01-26 Thread Herbert Xu
On Wed, Jan 17, 2018 at 11:40:34AM +, Wei Yongjun wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Patch applied. Thanks.

Re: [PATCH 0/8] crypto: arm64+generic - SHA3/SHA-512/SM-3 roundup

2018-01-26 Thread Herbert Xu
o/sha3-ce-glue.c > create mode 100644 arch/arm64/crypto/sm3-ce-core.S > create mode 100644 arch/arm64/crypto/sm3-ce-glue.c All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: picoxcell - Fix error handling in spacc_probe()

2018-01-26 Thread Herbert Xu
.org). > > Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: stm32 - remove redundant dev_err call in stm32_cryp_probe()

2018-01-26 Thread Herbert Xu
On Wed, Jan 17, 2018 at 11:40:24AM +, Wei Yongjun wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Patch applied. Thanks.

Re: [PATCH 1/2] crypto: Implement a generic crypto statistics

2018-01-26 Thread Herbert Xu
c to > crypto_user_base.c) since crypto_user.ko is made of two files. > > Which one do you prefer ? I think you should check with the crconf author, Steffen Klassert since that will be affected by this change. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: ht

Re: [PATCH v2] [v2] crypto: aes-generic - fix aes-generic regression on powerpc

2018-01-19 Thread Herbert Xu
; Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83651 > Fixes: 148b974deea9 ("crypto: aes-generic - build with -Os on gcc-7+") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/1] crypto: chelsio - Fix indentation warning

2018-01-19 Thread Herbert Xu
@chelsio.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: imx-rngc: simplify the power management definitions

2018-01-18 Thread Herbert Xu
more. > > Signed-off-by: Martin Kaiser <mar...@kaiser.cx> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

2018-01-18 Thread Herbert Xu
> didn't exist when the offending code was first merged, but it does now. > > Signed-off-by: Robin Murphy <robin.mur...@arm.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hw_random: mediatek: Setup default RNG quality

2018-01-18 Thread Herbert Xu
ue is being picked up as the default value. > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] hwrng: exynos - remove redundant dev_err call in exynos_trng_probe()

2018-01-18 Thread Herbert Xu
On Wed, Jan 10, 2018 at 01:30:59PM +, Wei Yongjun wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Patch applied. Thanks.

Re: [PATCH 0/5] crypto: chelsio - Cleanup and bug fixes

2018-01-18 Thread Herbert Xu
t; 2 files changed, 233 insertions(+), 73 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: exynos - Signedness bug in exynos_trng_do_read()

2018-01-18 Thread Herbert Xu
gt; Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/7] arm64: move literal data into .rodata section

2018-01-18 Thread Herbert Xu
On Thu, Jan 18, 2018 at 11:46:07AM +, Ard Biesheuvel wrote: > On 18 January 2018 at 11:41, Herbert Xu <herb...@gondor.apana.org.au> wrote: > > On Wed, Jan 10, 2018 at 12:11:35PM +, Ard Biesheuvel wrote: > >> Prevent inadvertently creating speculative gadget

Re: [RFT PATCH] crypto: arm64 - implement SHA-512 using special instructions

2018-01-18 Thread Herbert Xu
On Tue, Jan 09, 2018 at 06:23:02PM +, Ard Biesheuvel wrote: > Implement the SHA-512 using the new special instructions that have > been introduced as an optional extension in ARMv8.2. > > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Patch applied. Thanks. --

Re: [PATCH 1/2] crypto: exynos-rng - Add SPDX license identifier and correct module license

2018-01-18 Thread Herbert Xu
om/exynos-rng.c driver (on which this was based on). > However the module license indicated GPL-2.0 or later. GPL-2.0 was > intended by author so fix up this mess. > > Signed-off-by: Krzysztof Kozlowski <k...@kernel.org> All applied. Thanks. -- Email: Herbert Xu <herb...@

Re: [PATCH 0/7] arm64: move literal data into .rodata section

2018-01-18 Thread Herbert Xu
ting this. Note that this conflicts with the mitigation > of erratum #843419 for Cortex-A53. Ard, which tree is this supposed to go through? Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 00/17] crypto: inside-secure - various improvements

2018-01-15 Thread Herbert Xu
On Fri, Jan 12, 2018 at 02:02:51PM +0100, Antoine Tenart wrote: > Hi Herbert, > > On Fri, Dec 22, 2017 at 03:28:38PM +0100, Antoine Tenart wrote: > > On Fri, Dec 22, 2017 at 08:11:54PM +1100, Herbert Xu wrote: > > > > > > Patches 1-16 applied. If patch

Re: [PATCH] crypto: chacha20 - use rol32() macro from bitops.h

2018-01-12 Thread Herbert Xu
om> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4] crypto: AF_ALG - whitelist mask and type

2018-01-12 Thread Herbert Xu
: Stephan Mueller <smuel...@chronox.de> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] [v2] crypto: aes-generic - build with -Os on gcc-7+

2018-01-12 Thread Herbert Xu
bug.cgi?id=83356 > Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83651 > Cc: Richard Biener <rguent...@suse.de> > Cc: Jakub Jelinek <ja...@gcc.gnu.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Signed-off-by: Arnd Bergmann <a...@arndb.de> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: clear htmldocs build warnings for crypto/hash

2018-01-12 Thread Herbert Xu
finish the transformation (then > the data buffered by the device driver is processed). > > Signed-off-by: Tobin C. Harding <m...@tobin.cc> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/3] crypto: salsa20 - cleanup and convert to skcipher API

2018-01-12 Thread Herbert Xu
rtions(+), 498 deletions(-) > create mode 100644 include/crypto/salsa20.h All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: tcrypt - free xoutbuf instead of axbuf

2018-01-12 Thread Herbert Xu
63420 ("Copy-paste error") > > Fixes: 427988d981c4 ("crypto: tcrypt - add multibuf aead speed test") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://

Re: [PATCH] crypto: Use zeroing memory allocator instead of allocator/memset

2018-01-12 Thread Herbert Xu
lures. > > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC PATCH 0/9] crypto: prevent unkeyed use of keyed algorithms

2018-01-12 Thread Herbert Xu
without setting key > crypto: ghash - remove checks for key being set > crypto: skcipher - prevent using skciphers without setting key > crypto: aead - prevent using AEADs without setting key All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: testmgr: change `guard` to unsigned char

2018-01-12 Thread Herbert Xu
stack usage. > > Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][crypto-next] crypto: tcrypt: fix spelling mistake: "bufufer"-> "buffer"

2018-01-12 Thread Herbert Xu
On Tue, Jan 02, 2018 at 09:21:06AM +, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistakes in pr_err error message text. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks.

Re: [PATCH 2/6] crypto: engine - Permit to enqueue all async requests

2018-01-11 Thread Herbert Xu
> - int ret, rtype; > + int ret; > + struct crypto_engine_reqctx *enginectx; This all looks very good. Just one minor nit, since you're storing this in the tfm ctx as opposed to the request ctx (which is indeed an improvement), you should remove the "req" from its

Crypto Fixes for 4.15

2018-01-11 Thread Herbert Xu
in crypto_remove_spawns() crypto/algapi.c | 12 1 file changed, 12 insertions(+) Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Getting the ccree driver out of staging

2018-01-10 Thread Herbert Xu
On Thu, Jan 11, 2018 at 08:33:00AM +0200, Gilad Ben-Yossef wrote: > > Herbert, it's up to you - shall I send a new patch set or do you want to just > move what's in the staging tree? Please send a new patch. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au>

Re: [PATCH] crypto: clear htmldocs build warnings for crypto/hash

2018-01-08 Thread Herbert Xu
the old days before we started requiring them. These should be removed so that the registration fails if they're not provided. The requirement has been in place for a while now and we have been failing any algorithms with a zero statesize which is only used by import/export. Thanks, -- Email: Her

Re: [PATCH v2] hwrng: Clean up RNG list when last hwrng is unregistered

2018-01-07 Thread Herbert Xu
t needs to make the 4.15 kernel, please. Just want to > ensure this gets the proper attention. Thank you. I don't think breaking rmmod is sufficiently serious to warrant immediate inclusion at this point. We can always send it via stable after the release. Thanks, -- Email

Re: [PATCH] crypto: algapi - fix NULL dereference in crypto_remove_spawns()

2018-01-05 Thread Herbert Xu
rypto_remove_spawns() treat a NULL ->cra_users list as empty. > > Reported-by: syzbot <syzkal...@googlegroups.com> > Cc: sta...@vger.kernel.org > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] crypto: poly1305 - get rid of cra_alignmask

2018-01-05 Thread Herbert Xu
crypto/poly1305_generic.c | 10 -- > 2 files changed, 4 insertions(+), 7 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: algapi - convert cra_refcnt to refcount_t

2018-01-05 Thread Herbert Xu
f reference leak bugs. crypto_alg.cra_refcount is a > reference counter with the usual semantics, so switch it over to > refcount_t. > > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http:

Re: [PATCH] crypto: algapi - remove unused notifications

2018-01-05 Thread Herbert Xu
s listening for those messages; currently there are only > listeners for the algorithm request and registration messages. > > Get rid of these unused notifications for now. > > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. -- Email: Herbert Xu <

Re: [PATCH 0/2] crypto: inside-secure - 2 extra fixes

2018-01-05 Thread Herbert Xu
lock > > drivers/crypto/inside-secure/safexcel_hash.c | 54 > ++-- > 1 file changed, 36 insertions(+), 18 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [v1] crypto: crypto4xx - perform aead icv check in the driver

2018-01-05 Thread Herbert Xu
t; |internal : no > |type : aead > |async: yes > |blocksize: 1 > |ivsize : 16 > |maxauthsize : 16 > |geniv: > > Signed-off-by: Christian Lamparter <chunk...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondo

Re: [v1,1/4] crypto: crypto4xx - shuffle iomap in front of request_irq

2018-01-05 Thread Herbert Xu
gt; This way, the ce_base will always be valid in the handler and > a branch in an critical path can be avoided. > > Signed-off-by: Christian Lamparter <chunk...@gmail.com> All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http

Re: [PATCH v5] hwrng: exynos - add Samsung Exynos True RNG driver

2018-01-05 Thread Herbert Xu
applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: padata: add SPDX identifier

2018-01-05 Thread Herbert Xu
gt; Acked-by: Steffen Klassert <steffen.klass...@secunet.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Fixes for 4.15

2018-01-04 Thread Herbert Xu
| 89 +--- drivers/crypto/n2_core.c |3 + include/crypto/if_alg.h|5 +- lib/mpi/longlong.h | 18 - 12 files changed, 173 insertions(+), 62 deletions(-) Thanks, -- Email: Herbert

Re: [PATCH v3 0/2] Fix out-of-bounds memory accesses in generic-gcm-aesni

2017-12-27 Thread Herbert Xu
On Wed, Dec 20, 2017 at 05:08:36PM -0800, Junaid Shahid wrote: > Changelog: > v3: > - Fixed a bug in READ_PARTIAL_BLOCK when used for reading the AAD > - Some refactoring per CR feedback All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au&g

Re: [PATCH] crypto: scomp - delete unused comments

2017-12-27 Thread Herbert Xu
On Wed, Dec 20, 2017 at 04:03:12PM +0800, Zhou Wang wrote: > There are no init and exit callbacks, so delete its comments. > > Signed-off-by: Zhou Wang <wangzh...@hisilicon.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http:

Re: [PATCH] crypto: stm32 - Use standard CONFIG name

2017-12-27 Thread Herbert Xu
<cla...@baylibre.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 1/4] crypto: caam - constify key data

2017-12-27 Thread Herbert Xu
On Tue, Dec 19, 2017 at 12:16:04PM +0200, Horia Geantă wrote: > Key data is not modified, it is copied in the shared descriptor. > > Signed-off-by: Horia Geantă <horia.gea...@nxp.com> All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http:

Re: [PATCH v2 0/6] crypto: tcrypt: fix and add multi buf speed tests

2017-12-27 Thread Herbert Xu
ity seems questionable. Do let me know if you disagree. > > Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: x86/twofish-3way - Fix %rbp usage

2017-12-27 Thread Herbert Xu
Haswell processor, the new version was actually about 2% faster. > (Perhaps 'xchg' is not as well optimized as plain moves.) > > Reported-by: syzbot <syzkal...@googlegroups.com> > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. -- Email: He

Re: [PATCH] padata: add SPDX identifier

2017-12-27 Thread Herbert Xu
terface to process data streams in parallel > * Steffen, are you OK with this patch? Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [QUESTION] hash import and request initialization

2017-12-26 Thread Herbert Xu
e changed to either do the proper request allocation or switch over to allocating sync algorithms. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [QUESTION] hash import and request initialization

2017-12-26 Thread Herbert Xu
ON_STACK cannot possibly be used on an async ahash implementation for obvious reasons so this shouldn't be an issue. The construct is simply a compatibility aid for sync-only users to use the ahash interface. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.

Re: [QUESTION] hash import and request initialization

2017-12-25 Thread Herbert Xu
e end of a hash operation such as init. IOW you cannot expect a hash state to be finalised. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 0/4] crypto: inside-secure - set of fixes

2017-12-22 Thread Herbert Xu
On Mon, Dec 11, 2017 at 12:10:54PM +0100, Antoine Tenart wrote: > Hi Herbert, > > This series is a set of 4 fixes on the Inside Secure SafeXcel crypto > engine driver. The series will be followed by another non-fix one. > > This is based on v4.15-rc3. All applied. Thanks. --

Re: [PATCH crypto] crypto: aesni - add wrapper for generic gcm(aes)

2017-12-22 Thread Herbert Xu
t; FPU state. > > Fixes: cce2ea8d90fe ("crypto: aesni - add generic gcm(aes)") > Reported-by: Ilya Lesokhin <il...@mellanox.com> > Signed-off-by: Sabrina Dubroca <s...@queasysnail.net> > Reviewed-by: Stefano Brivio <sbri...@redhat.com> Patch applied. Thanks. -

Re: [PATCH crypto] crypto: aesni - fix typo in generic_gcmaes_decrypt

2017-12-22 Thread Herbert Xu
4106_gcm_ctx. > > Fixes: cce2ea8d90fe ("crypto: aesni - add generic gcm(aes)") > Signed-off-by: Sabrina Dubroca <s...@queasysnail.net> > Reviewed-by: Stefano Brivio <sbri...@redhat.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Hom

Re: [PATCH 00/17] crypto: inside-secure - various improvements

2017-12-22 Thread Herbert Xu
ted. This crypto engine can be > found on Marvell boards. (The corresponding device tree patches will follow > once this series lands in). Patches 1-16 applied. If patch 17 needs to go through the crypto tree please let me know. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.or

Re: [PATCH v2] hwrng: Clean up RNG list when last hwrng is unregistered

2017-12-22 Thread Herbert Xu
turn the global variables to their > original state and decrement all references to the object. > > Fixes: 142a27f0a731 ("hwrng: core - Reset user selected rng by writing "" to > rng_current") > Signed-off-by: Gary R Hook <gary.h...@amd.com> Patch applied. Thanks. -

Re: [PATCH v3 0/4] Assorted changes for Exynos PRNG driver

2017-12-22 Thread Herbert Xu
simultaneous access to the > hardware from more than one thread/process. > > Changes since v2: All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: seqiv - Remove unused alg/spawn variable

2017-12-22 Thread Herbert Xu
@baylibre.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: echainiv - Remove unused alg/spawn variable

2017-12-22 Thread Herbert Xu
ylibre.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: artpec6: set correct iv size for gcm(aes)

2017-12-22 Thread Herbert Xu
rator > driver") > Signed-off-by: Lars Persson <lar...@axis.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: gf128mul - remove incorrect comment

2017-12-22 Thread Herbert Xu
.com> > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH RFC 1/4] crypto: engine - Permit to enqueue all async requests

2017-12-22 Thread Herbert Xu
ed API should take the final types such as aead_request before casting it. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat - reduce stack size with KASAN

2017-12-22 Thread Herbert Xu
f which is for the 'savuwords' array. The > function > now no longer returns an error code, but nothing ever evaluated that anyway. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondo

Re: [PATCH] crypto: api - Unexport crypto_larval_lookup()

2017-12-22 Thread Herbert Xu
Eric Biggers <ebigge...@gmail.com> wrote: > From: Eric Biggers <ebigg...@google.com> > > crypto_larval_lookup() is not used outside of crypto/api.c, so unexport > it and mark it 'static'. > > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied.

<    1   2   3   4   5   6   7   8   9   10   >