ame as their non-2
> equivalents. So switch callers of the "2" versions over to the original
> versions and remove the "2" versions.
>
> Signed-off-by: Eric Biggers <ebigg...@google.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gond
ndefined reference to `__multi3'
>
> Therefore add an efficient MIPS64r6 implementation of umul_ppmm() using
> inline assembly and the DMULU/DMUHU instructions, to prevent __multi3
> calls being emitted.
>
> Fixes: 7fd08ca58ae6 ("MIPS: Add build support for the MIPS R6 ISA&quo
gt; software implementations, but allow them to be selected in FIPS-mode
> (fips=1 in the kernel command line).
>
> Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apa
h applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Atul Gupta <atul.gu...@chelsio.com> wrote:
> fix a type cast error for queue descriptor
>
> Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
> Signed-off-by: Atul Gupta <atul.gu...@chelsio.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gon
rnel.org> # v4.2+
> Signed-off-by: Eric Biggers <ebigg...@google.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
(inlined) handle_exec_unit
> [10c61eb4] spu_mdesc_scan+0x1f4/0x460 [n2_crypto]
> [10c62b80] n2_mau_probe+0x100/0x220 [n2_crypto]
> [0084b174] platform_drv_probe+0x34/0xc0
>
> Signed-off-by: Jan Engelhardt <jeng...@inai.de>
On Fri, Dec 22, 2017 at 09:29:38AM +0100, Marek Szyprowski wrote:
> Hi,
>
> On 2017-12-22 09:24, Herbert Xu wrote:
> >On Mon, Dec 04, 2017 at 01:53:50PM +0100, Łukasz Stelmach wrote:
> >>Add support for True Random Number Generator found in Samsung Exynos
> >&g
>
> This adds a Kconfig select statement for it, next to the ones we
> already have.
>
> Fixes: b8fd1f4170e7 ("crypto: chcr - Add ctr mode and process large sg
> entries for cipher")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
Patch applied. Thanks.
--
Email
On Fri, Dec 22, 2017 at 08:59:21AM +0100, Ralf Baechle wrote:
> On Fri, Dec 22, 2017 at 06:08:08PM +1100, Herbert Xu wrote:
>
> > I can take this but I'd like to see an ack from someone on the
> > MIPS side.
>
> Sure:
>
> Acked-by: Ralf Baechle <r...@linux-
I understand that, but does user space need to utilize this logic?
I'm open to a white list as well. But we should certainly fix
the underlying bugs rather than just papering over them as they
could come back via other channels.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
H
On Fri, Dec 22, 2017 at 08:50:01AM +0100, Stephan Mueller wrote:
> Am Freitag, 22. Dezember 2017, 08:48:03 CET schrieb Herbert Xu:
>
> Hi Herbert,
>
> > On Tue, Dec 19, 2017 at 10:31:22AM +, Jonathan Cameron wrote:
> > > This variable was increased and decre
et lock from the callback.
commit 7d2c3f54e6f646887d019faa45f35d6fe9fe82ce
Author: Stephan Mueller <smuel...@chronox.de>
Date: Fri Nov 10 13:20:55 2017 +0100
crypto: af_alg - remove locking in async callback
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert
de paths that can create instances.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ndefined reference to `__multi3'
>
> Therefore add an efficient MIPS64r6 implementation of umul_ppmm() using
> inline assembly and the DMULU/DMUHU instructions, to prevent __multi3
> calls being emitted.
>
> Fixes: 7fd08ca58ae6 ("MIPS: Add build support for the MIPS R6 ISA&quo
++-
crypto/skcipher.c| 10 --
include/crypto/mcryptd.h |1 +
6 files changed, 37 insertions(+), 35 deletions(-)
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
be exposed through that.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> Signed-off-by: Corentin Labbe <cla...@baylibre.com>
No this is intentional. The idea is that you can hot-replace
an implementation by registering a new version of it while the
old one is still in use. The new one will be used for all new
allocations.
Cheers,
--
Email: Herbert Xu <h
/G table for test_aead_speed()
Yet your patch still fails to apply.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
: algif_skcipher - overhaul memory management")
> Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management")
> Reported-by: syzbot <syzkal...@googlegroups.com>
> Cc: <sta...@vger.kernel.org> # v4.14+
> Signed-off-by: Stephan Mueller <smuel...@chronox.
e some of my paid time for reviewing and verifying changes
> to the driver.
>
> Signed-off-by: Kamil Konieczny <k.koniec...@partner.samsung.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PG
' undeclared
> here (not in a function)
> MODULE_DEVICE_TABLE(of, sti_dt_ids);
>
> Let's replace sti_dt_ids with stm32_dt_ids which is just declared
> before.
>
> Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Patch applied. Thanks.
--
Email: Herbert Xu
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
uot;chcr: Add support for Inline IPSec")
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> crypto/cryptd.c:35:14: warning: symbol 'cryptd_max_cpu_qlen' was not
> declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.
sgl_ent_len'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
help.
> In order to keep work-item on the local CPU (and avoid RR) I changed it
> to queue_work_on().
>
> Cc: sta...@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
7c ("crypto: algif_skcipher - overhaul memory management")
> Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management")
> Reported-by: syzbot <syzkal...@googlegroups.com>
> Cc: <sta...@vger.kernel.org> # v4.14+
> Signed-off-by: Stephan Mueller <
vere than an uninitialized pointer bug.
>
> This change also matches the behavior of the older blkcipher_walk API.
>
> Fixes: 0cabf2af6f5a ("crypto: skcipher - Fix crash on zero-length input")
> Reported-by: syzbot <syzkal...@googlegroups.com>
> Cc: <sta...@vger.kernel.org
R_SG
> qm_sg_ents, CAAM_QI_MAX_ABLKCIPHER_SG);
> ^
>
> Fixes: eb9ba37dc15a ("crypto: caam/qi - handle large number of S/Gs case")
> Signed-off-by: Horia Geantă <horia.gea...@nxp.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
TR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonov...@gmail.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http:
rtens <ha...@hauke-m.de>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
est performance of such
> tfm providers.
>
> Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Sorry, this no longer applies to the current cryptodev tree.
Please respin.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.
l).
That's one way to do it. Ideally you'd only use the local buffer
for the non-final case so that the final case just does the DMA to
the final destination.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.
On Fri, Dec 08, 2017 at 03:20:40PM +, Horia Geantă wrote:
> On 10/12/2017 6:20 PM, Herbert Xu wrote:
> > On Fri, Oct 06, 2017 at 03:04:31PM +0200, Christophe Leroy wrote:
> >> This serie fixes and improves the talitos crypto driver.
> >>
> >> First 6 p
rmine whether to copy data into it. For example, I could
be making an update call with a non-NULL areq->result and it would
be completely wrong if you overwrote that with the above memcpy.
IOW areq->result should not be touched at all unless you are doing
a finalisation.
Thanks,
--
Email: Her
+-
crypto/rsa_helper.c|2 +-
crypto/salsa20_generic.c |7 ---
crypto/shash.c |5 +++--
include/crypto/internal/hash.h |8
8 files changed, 25 insertions(+), 25 deletions(-)
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org
ect use in user-space we could think about
restricting access to these base implementations.
For chacha20 we did not add a restrictive template because the
primary user IPsec uses it only through AEAD where the IV restriction
is in place.
Cheers,
--
Email: Herbert Xu <herb...@gon
yes,
> then test fails ?
Yes we should modify testmgr to check that.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
copy is made
regardless of whether the operation is final or update. That's
why a check is required.
If the operation is finup/final/digest then req->result must be
set and you don't need to check it.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ugh any user-space facing API.
If a kernel API user did this then they're just shooting themselves
in the foot.
So unless there is a valida call path that leads to this then I
would say that there is nothing to fix.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: ht
On Wed, Nov 29, 2017 at 09:38:52AM -0800, Florian Fainelli wrote:
>
> Hu, okay, I actually had a v3 prepared that I was going to post
> addressing some of the comments. Should I send an incremental set of
> changes now?
Please send it as an incremental set.
Thanks,
--
Email: Herb
On Wed, Nov 29, 2017 at 11:51:09AM -0800, Eric Biggers wrote:
>
> Herbert, if it's not too late can you fix the subject? It got split into two
> lines:
Sorry, it's already pushed out with other patches sitting on top
of it.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.a
g will block
indefinitely. It can still be interrupted from user-space.
As the behaviour is currently undefined anyway, I don't think we
need to backport this fix. At least not until we maintain a list
of ctx->enc like we discussed.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.a
On Wed, Nov 29, 2017 at 11:28:43AM +0100, Stephan Mueller wrote:
> Am Mittwoch, 29. November 2017, 11:22:34 CET schrieb Herbert Xu:
>
> Hi Herbert,
>
> > On Wed, Nov 29, 2017 at 11:17:26AM +0100, Stephan Müller wrote:
> > > @@ -111,6 +111,12 @@ static int _aead_
zero, and we would skip the wait right?
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Since tcrypt is merely a debugging
interface I don't think it's that critical.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Wed, Nov 29, 2017 at 07:48:53AM +0100, Stephan Mueller wrote:
> Am Mittwoch, 29. November 2017, 00:02:40 CET schrieb Herbert Xu:
>
> > This is wrong. You can't fetch ctx->enc before you wait. It has
> > to be done after the wait as otherwise ctx->enc may not even h
.k...@canonical.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
w; use-after-free.
>
> Signed-off-by: Corentin Labbe <cla...@baylibre.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
g key and IV
> crypto: chacha20 - Remove cra_alignmask
> crypto: x86/chacha20 - Remove cra_alignmask
> crypto: chacha20 - Fix keystream alignment for chacha20_block()
All applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>
> Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
> Acked-by: Rob Herring <r...@kernel.org>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
...@gmail.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
an this up, and move the asm() blocks into a separate .S
> file.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
alibaba-inc.com>
> Cc: Herbert Xu <herb...@gondor.apana.org.au>
> Cc: "David S. Miller" <da...@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
rap.c: In function ‘crypto_kw_encrypt’:
> crypto/keywrap.c:224: warning: integer constant is too large for ‘long’
> type
>
> Fixes: 9e49451d7a15365d ("crypto: keywrap - simplify code")
> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
Pa
: Fixed a build warning and added flag for data packet
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
e info.
>
> Detected by CoverityScan, CID#1408439 ("Resource Leak")
>
> Fixes: c694b233295b ("crypto: cavium - Add the Virtual Function driver for
> CPT")
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Patch applied. Thanks.
--
Email: Herbert Xu &l
atch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
and added flag for data packet
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Tue, Nov 14, 2017 at 04:59:15PM +0200, Tudor-Dan Ambarus wrote:
> Results better code readability.
>
> Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com>
> Reviewed-by: Horia Geantă <horia.gea...@nxp.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb..
> As https://www.gnu.org/licenses/gpl-howto.html suggests, we replace the
> postal address with "<http://www.gnu.org/licenses/>".
>
> Signed-off-by: Martin Kepplinger <mart...@posteo.de>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au&
ter dereference.
> Returning the error directly, as was supposedly
> intended when looking at the code, fixes this.
>
> Signed-off-by: Pierre Ducroquet <pina...@pinaraf.info>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gond
On Fri, Nov 10, 2017 at 12:26:04AM +0300, Dan Carpenter wrote:
> This code seems correct, but the goto was indented too far.
>
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.a
> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
All applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
to chcr from lld
> cxgb4 driver")
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
algo.c:2020:2: warning: Value stored to
> 'dst_size' is never read
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
crypt / testmgr.
>
> Changes since v5:
> -add timeout in wait_busy function
> -clear key after use
> -misc : remove unused functions, use -Exx, use dev_err
All applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
om>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
reqfd = accept(algfd, 0, 0);
> setsockopt(algfd, SOL_ALG, ALG_SET_KEY, key, sizeof(key));
> read(reqfd, key, sizeof(key));
> }
>
> Reported-by: syzbot <syzkal...@googlegroups.com>
> Fixes: eb6f13eb9f81 ("[CRYPTO] salsa20_generic: Fix multi-page processin
/af_alg.c:221 [inline]
> alg_setsockopt+0x2a1/0x350 crypto/af_alg.c:254
> SYSC_setsockopt net/socket.c:1851 [inline]
> SyS_setsockopt+0x189/0x360 net/socket.c:1830
> entry_SYSCALL_64_fastpath+0x1f/0x96
>
> Reported-by: syzbot <syzkal...@googlegroups.com>
> Cc: <sta...@vger.kernel.org>
> Signed-off-by: Eric Biggers <ebigg...@google.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ed-by: syzbot <syzkal...@googlegroups.com>
> Cc: <sta...@vger.kernel.org> # v4.14+
> Signed-off-by: Eric Biggers <ebigg...@google.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
tpath+0x1f/0x96
>
> Fixes: 5a7de97309f5 ("crypto: rsa - return raw integers for the ASN.1 parser")
> Cc: <sta...@vger.kernel.org> # v4.8+
> Cc: Tudor Ambarus <tudor-dan.amba...@nxp.com>
> Signed-off-by: Eric Biggers <ebigg...@google.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
@googlegroups.com>
> Cc: <sta...@vger.kernel.org> # v4.14+
> Signed-off-by: Eric Biggers <ebigg...@google.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Tue, Nov 28, 2017 at 10:54:32AM +, David Howells wrote:
> Hi Herbert,
>
> Are you going to take this?
Yes it's in my queue.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
++-
crypto/algif_skcipher.c | 23 +--
crypto/skcipher.c |3 +++
include/crypto/if_alg.h |1 +
5 files changed, 66 insertions(+), 38 deletions(-)
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.
e
been initialised.
In fact the position of the wait call is just wrong. You should only
ever do at most one wait at the start of the recvmsg call. Once you
have enough data from that wait no further waits should be done for
that recvmsg call. The original commit had it right with just one
wait
On Fri, Nov 24, 2017 at 05:04:19PM +0100, Stephan Mueller wrote:
>
> Would it make sense to feed it to stable?
I already added stable Cc's so it should go in automatically once
it's pushed to Linus.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.
formation is const
> until .final ?
Yes you may.
> Is is possible to have okey derived from different key then ikey ? I think
> not.
We do not need to support that case. If the user changes the
key mid-stream it results in undefined behaviour. However,
the code should not crash though.
On Fri, Nov 24, 2017 at 11:53:53AM +0100, Ondrej Mosnáček wrote:
> (I accidentally hit "reply" instead of "reply all", so resending)
>
> 2017-11-24 6:07 GMT+01:00 Herbert Xu <herb...@gondor.apana.org.au>:
> > On Thu, Nov 23, 2017 at 01:49:06PM +010
t using the libkcapi test
> suite.
>
> Fixes: 72548b093ee38 ("crypto: algif_aead - copy AAD from src to dst")
> Signed-off-by: Stephan Mueller <smuel...@chronox.de>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
haul memory management")
> Fixes: d887c52d6ae43 ("crypto: algif_aead - overhaul memory management")
> Reported-by: Romain Izard <romain.izard@gmail.com>
> Signed-off-by: Stephan Mueller <smuel...@chronox.de>
Patch applied. Thanks.
--
Email: Herbert Xu
alk_copychunks(NULL, >out, req->assoclen, 2);
>
> + scatterwalk_done(>in, 0, walk->total);
> + scatterwalk_done(>out, 0, walk->total);
That should be 1 instead of 0 for walk->out.
Could you please fix and resubmit?
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Wed, Nov 22, 2017 at 08:55:14AM +, Ard Biesheuvel wrote:
>
> Would this also fix it?
Looks good. Could you resubmit with a sign-off?
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org
o/chcr_core.c:169: undefined reference to
> >> `chcr_add_xfrmops'
Atul, can you fix this and resubmit your patches please?
Thanks!
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
or associated data, filled outside
> sg_init_aead()
> -sg[1]..sg[npo] (npo entries) - input data, entries pointing to
> xbuf[0]..xbuf[npo-1]
You are right. I will apply the patch.
Thanks!
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apa
limit of
dsgl header
crypto: chelsio - Move DMA un/mapping to chcr from lld cxgb4 driver
crypto: chelsio - Fix memory leak
Herbert Xu (1):
Merge git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux
Himanshu Jha (3):
crypto: n2 - remove null check before kfree
ake that driver selectable with
> ARCH_BRCMSTB gating the enabling of such SoCs.
>
> Thank you
>
> Florian Fainelli (2):
> dt-bindings: rng: Document BCM7278 RNG200 compatible
> hwrng: iproc-rng200: Add support for BCM7278
All applied. Thanks.
--
Email: Herbert Xu <herb.
bit
> from the exponent is processed. It's still noninterruptible, but at
> least it's preemptible now.
>
> Cc: sta...@vger.kernel.org # v4.12+
> Signed-off-by: Eric Biggers <ebigg...@google.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
qat - Clean up error handling in qat_dh_set_secret()
> crypto: dh - Remove pointless checks for NULL 'p' and 'g'
All applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> Signed-off-by: Lionel Debieve <lionel.debi...@st.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
, the code with
your patch will create an SG list that's one page longer than
buflen.
AFAICS it should be harmless but it would still be better if we can
generate an SG list that's exactly buflen long rather than one page
longer.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
return -EIOCBQUEUED;
> + }
Since we're allowing backlogs, what about EBUSY?
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Fri, Nov 10, 2017 at 06:37:22AM +, Horia Geantă wrote:
> On 11/10/2017 12:21 AM, Herbert Xu wrote:
> > On Thu, Nov 09, 2017 at 02:37:29PM +, Horia Geantă wrote:
> >>
> >>>> sg_init_table(sg, np + 1);
> >> sg_mark_e
sg_set_buf([k + 1], xbuf[k], PAGE_SIZE);
> In case rem == 0, last k value is np-1, thus sg[np-1+1] will be filled
> here with xbuf[np-1].
No, if rem == 0, then the last k value is np-2.
The whole point of the patch is to shrink the SG table by one
entry when rem == 0. How can you shrink i
that the pointer can be DMAed you can opt in to the new interface.
The crypto API can then provide a helper to do the copying where
necessary.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ame with any other callback in the crypto API. The
completion function is called if the return value is EINPROGRESS
or EBUSY.
In fact the algif_aead/algif_skcipher code already frees the SG lists
and areq on a sync return. So perhaps you can merge this with the
completion function.
Cheers,
--
Em
On Mon, Nov 06, 2017 at 05:06:09PM +0100, Stephan Mueller wrote:
> Am Freitag, 3. November 2017, 14:20:16 CET schrieb Herbert Xu:
>
> > Are you sure about that? In particular is the callback function still
> > sane without the socket lock if a concurrent recvmsg/sendmsg call i
A. R. Silva <garsi...@embeddedor.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
o virtio_restore().
>
> Reviewed-by: Liam Merwick <liam.merw...@oracle.com>
> Signed-off-by: Jim Quigley <jim.quig...@oracle.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
401 - 500 of 5254 matches
Mail list logo
