Re: [PATCH] crypto: marvell - Add a NULL entry at the end of mv_cesa_plat_id_table[]

s Brezillon <boris.brezil...@free-electrons.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [v3 PATCH 2/3] crypto: atmel-aes/tdes - remove empty functions

e can safely remove these empty functions. > > Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] MAINTAINERS: update maintainer for qat

On Thu, Nov 02, 2017 at 09:09:06AM +, Salvatore Benedetto wrote: > Removing myself as I'm not longer following QAT development. > > Signed-off-by: Salvatore Benedetto <salvatore.benede...@intel.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.a

Re: [PATCH] crypto: ecdh - remove empty exit()

> remove the function. > > Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: caam - remove unused param of ctx_map_to_sec4_sg()

t;horia.gea...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: caam - remove unneeded edesc zeroization

> its members - edesc->src_nents and edesc->dst_dma. > > Signed-off-by: Horia Geantă <horia.gea...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Fixes for 4.14

/ccm.c |4 +++- 3 files changed, 15 insertions(+), 13 deletions(-) Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: cavium: clean up clang warning on unread variable offset

Fix this. > > Cleans up clang warning: Value stored to 'offset' is never read > > Fixes: 14fa93cdcd9b ("crypto: cavium - Add support for CNN55XX adapters.") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herb

Re: [PATCH 0/3] crypto: marvell - Remove the old CESA driver

sa.h| 150 - > 8 files changed, 12 insertions(+), 1396 deletions(-) > delete mode 100644 drivers/crypto/mv_cesa.c > delete mode 100644 drivers/crypto/mv_cesa.h All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs

On Thu, Oct 12, 2017 at 05:55:29PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Patch applied. Thanks. --

Re: [PATCH] crypto: qat: remove unused and redundant pointer vf_info

is never read > > Fixes: ed8ccaef52fa ("crypto: qat - Add support for SRIOV") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] MAINTAINERS: update caam crypto driver maintainers list

On Fri, Oct 13, 2017 at 03:01:23PM +0300, Horia Geantă wrote: > Dan steps down as caam maintainer, being replaced by Aymen. > > Signed-off-by: Horia Geantă <horia.gea...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http:

Re: [PATCH 0/2] Fixes for the Atmel AES crypto module

the controller before each use > > drivers/crypto/atmel-aes.c | 50 > -- > 1 file changed, 40 insertions(+), 10 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v8 0/2] crypto: s5p-sss: Add HASH support for Exynos

clude delay.h, fix typo in commit > message, fix descriptions of struct s5p_hash_reqctx and function > s5p_hash_final() All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] drivers/crypto: Convert timers to use timer_setup()

On Wed, Oct 25, 2017 at 03:18:42AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: H

Re: [PATCH] hw_random: core: Reset user selected rng by writing "" to rng_current

ng. > > Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: caam/qi - abort algorithm setup on DPAA2 parts

ts") > Signed-off-by: Horia Geantă <horia.gea...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/3] crypto: atmel-aes/tdes/sha - return appropriate error code

On Mon, Oct 23, 2017 at 06:34:39PM +0300, Tudor Ambarus wrote: > Return -ENODEV when dma_request_slave_channel_compat() fails. > > Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.a

Re: [PATCH v10 00/20] simplify crypto wait for async op

ast tests the crypto users via testmgr and > tcrypt but I do note that I do not have access to some > of the HW whose drivers are modified nor do I claim I was > able to test all of the corner cases. > > The patch set is based upon linux-next release tagged > next-20171017. All a

Re: [PATCH] crypto: caam - fix incorrect define

xp.com> > Signed-off-by: Horia Geantă <horia.gea...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 3/3] crypto: atmel-aes/tdes/sha - remove useless irq init

On Mon, Oct 23, 2017 at 06:34:41PM +0300, Tudor Ambarus wrote: > irq would be set to -1 and then unused, if we failed to get IORESOURCE_MEM. > > Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.a

Re: [PATCH] crypto: vmx - Use skcipher for ctr fallback

On Mon, Oct 16, 2017 at 08:54:19PM -0200, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo <pfsmor...@linux.vnet.ibm.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert

Re: [PATCH] crypto: marvell - Switch cipher algs to the skcipher interface

he skcipher_alg interface. While at > it, get rid of all references to ablkcipher including in internal struct > or function names. > > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@

Re: [PATCH] crypto: ccp: remove unused variable qim

es: 4b394a232df7 ("crypto: ccp - Let a v5 CCP provide the same function as > v3") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: tcrypt - fix buffer lengths in test_aead_speed()

scu <robert.barone...@nxp.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: tcrypt: mark expected switch fall-throughs in do_test()

On Mon, Oct 09, 2017 at 02:43:21PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Cc: Herbert Xu <herb...@gondor.apana.org.au> > Cc: "David S. Miller" <da...

Re: [PATCH v2 1/7] crypto:chelsio: Remove unused parameter

On Sun, Oct 08, 2017 at 01:37:18PM +0530, Harsh Jain wrote: > From: Yeshaswi M R Gowda <yesha...@chelsio.com> > > Remove unused parameter sent to latest fw. > > Signed-off-by: Harsh Jain <ha...@chelsio.com> All applied. Thanks. -- Email: Herbert Xu <herb...@

Re: [PATCH] crypto: ccm - preserve the IV buffer

eserve the > IV's value during the ciphering step in the decryption case. > > Signed-off-by: Romain Izard <romain.izard@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] x86/crypto/sha256-mb: fix panic due to unaligned access

56-mb - submit/flush routines for AVX2") > Reported-by: Josh Poimboeuf <jpoim...@redhat.com> > Signed-off-by: Andrey Ryabinin <aryabi...@virtuozzo.com> > Cc: <sta...@vger.kernel.org> Both patches applied. Thanks. -- Email: Herbert Xu <herb...@gondor.ap

Re: [PATCH] crypto: AF_ALG - remove locking in async callback

ular is the callback function still sane without the socket lock if a concurrent recvmsg/sendmsg call is made? Your fixes header is wrong too as the locks weren't introduced in that commit, they just got moved around. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Pa

Re: [PATCH 1/2] crypto: tcrypt - fix S/G table for test_aead_speed()

([k + 1], xbuf[k], rem); > + if (rem) > + sg_set_buf([k + 1], xbuf[k], rem); Sorry but I think this is still buggy because you have not moved the end-of-table marking in the rem == 0 case. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: testmgr: don't allocate IV on stack

work on that then we have to fix the drivers to fit the current API. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: testmgr: don't allocate IV on stack

ating the IV using kmalloc instead. > > Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> The driver that is mapping the IV directly should be fixed instead. Only input that is given in the form of SG lists can be mapped. Everything else should be copied if they need to go over DM

Crypto Fixes for 4.14

/crypto/chacha20-ssse3-x86_64.S |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hw_random: core: Remove unnecessary new line in MODULE_PARM_DESC

like this. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hw_random: Include device.h instead of declaring struct device

ard declaration is enough. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Kernel panic when using ccm(aes) with the Atmel AES HW accelerator

On Mon, Oct 23, 2017 at 03:38:59PM +0300, Tudor Ambarus wrote: > > I will propose a fix, but I'm taking my time to better understand why > CTR requires to overwrite the iv with the last ciphertext block. That's an API requirement. So we should fix ccm. Cheers, -- Email: Herbert

Re: [PATCH v9 00/20] simplify crypto wait for async op

On Sun, Oct 15, 2017 at 10:19:45AM +0100, Gilad Ben-Yossef wrote: > > Changes from v8: > - Remove the translation of EAGAIN return code to the > previous return code of EBUSY for the user space > interface of algif as no one seems to rely on it as > requested by Herbert

Re: [PATCH 00/18] crypto: talitos - fixes and performance improvement

rypto: talitos - remove to_talitos_ptr_len() > crypto: talitos - simplify tests in ipsec_esp() > crypto: talitos - DMA map key in setkey() > crypto: talitos - do hw_context DMA mapping outside the requests > crypto: talitos - chain in buffered data for ahash on SEC1 >

Re: [PATCH 1/3] crypto: dh_helper - return unsigned int for dh_data_size()

On Fri, Sep 29, 2017 at 12:21:04PM +0300, Tudor Ambarus wrote: > p->key_size, p->p_size, p->g_size are all of unsigned int type. > > Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.ap

Re: [PATCH] crypto: ecdh_helper - return unsigned value for crypto_ecdh_key_len()

On Fri, Sep 29, 2017 at 12:13:08PM +0300, Tudor Ambarus wrote: > ECDH_KPP_SECRET_MIN_SIZE and params->key_size are both returning > unsigned values. > > Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@g

Re: [PATCH 01/13] crypto: crypto4xx: wire up hmac_mc to hmac_muting

All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] chacha20-ssse3/avx2: satisfy stack validation 2.0

7b9 ("objtool: Implement stack validation 2.0") Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Fixes for 4.14

/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Arnd Bergmann (2): crypto: axis - hide an unused variable crypto: stm32 - Try to fix hash padding Christophe Jaillet (1): crypto: xts - Fix an error handling path in 'create()' Herbert Xu (2): crypto: skcipher - Fix

Re: crypto API - async semantics

is by issuing update() repeatedly and performing > wait_for_completion() at the very end. That is most certainly not legal. Is dm-crypt doing that? Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: crypto API - async semantics

parallel given a single tfm. The tfm is simply a representation of the key. All hash state must be stored in the request. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v8 01/20] crypto: change transient busy return code to -EAGAIN

On Sat, Oct 07, 2017 at 10:51:42AM +0300, Gilad Ben-Yossef wrote: > On Sat, Oct 7, 2017 at 6:05 AM, Herbert Xu <herb...@gondor.apana.org.au> > wrote: > > On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote: > >> > >> diff --git a/crypto/algif_has

[PATCH v2] crypto: shash - Fix zero-length shash ahash digest crash

On Mon, Oct 09, 2017 at 05:13:48PM +0200, Stephan Müller wrote: > Am Montag, 9. Oktober 2017, 16:19:25 CEST schrieb Herbert Xu: > > Hi Herbert, > > > On Sat, Oct 07, 2017 at 02:56:24PM +0200, Stephan Müller wrote: > > > Though, this opens up the shash issue I

Re: [PATCH 1/2] crypto: skcipher - noop for enc/dec with NULL data

en a zero-length input together with a null SG list. This is because it tries to read the SG list before looking at the length. This patch fixes it by checking the length first. Cc: <sta...@vger.kernel.org> Reported-by: Stephan Müller<smuel...@chronox.de> Signed-off

Re: [PATCH] crypto: stm32: use of_device_get_match_data

@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: bcm: use of_device_get_match_data

@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: omap: use of_device_get_match_data

@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: algboss: remove redundant setting of len to zero

etected by clang scan-build: > " warning: Value stored to 'len' is never read" > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 02/10] drivers:crypto: return -ENOMEM on allocation failure.

Allen Pais <allen.l...@gmail.com> wrote: > Signed-off-by: Allen Pais <allen.l...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: stm32 - Fix uninitialized data usage

ng. Please check. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> This is already fixed in cryptodev. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: stm32 - Try to fix hash padding

- Support for STM32 HASH module") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crc32-pclmul: remove useless relative addressing

n. > > Signed-off-by: Mikulas Patocka <mpato...@redhat.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: xts - Fix an error handling path in 'create()'

Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ccp - unmap pages and remove unmap objects in callback

off-by: Gary R Hook <gary.h...@amd.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto:ccp - invoke the DMA callback in a standard way

On Tue, Sep 05, 2017 at 05:08:14PM -0500, Gary R Hook wrote: > From: amd <a...@sosxen2.amd.com> > > Use the provided mechanism in dmaengine.h to invoke the > completion callback. > > Signed-off-by: Gary R Hook <gary.h...@amd.com> Patch applied. Thank

Re: [PATCH 0/3] padata cpu awareness fixes

ata: ensure the reorder timer callback runs on the correct CPU > padata: ensure padata_do_serial() runs on the correct CPU All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC PATCH] crypto: make the seed() function optional

y: Mathieu Malaterre <ma...@debian.org> > --- > The PRNG as found on Ingenic JZ4780 is one such example. This is found on a > MIPS Creator CI20 SoC. So how does it seed itself? This also contradicts with the JZ4780 driver that's currently in the patch queue as it does contain a seed f

Re: [PATCH 1/2] crypto: skcipher - noop for enc/dec with NULL data

k forward so that it does the right thing. Fixes: b286d8b1a690 ("crypto: skcipher - Add skcipher walk...") Cc: <sta...@vger.kernel.org> Reported-by: Stephan Müller <smuel...@chronox.de> Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> diff --git a/crypto/skcipher.c b/

Re: [PATCH 1/2] crypto: skcipher - noop for enc/dec with NULL data

g as your other patch suggested? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: skcipher - noop for enc/dec with NULL data

This fixes a kernel crash with authenc() ciphers and zero plaintext / > ciphertext that can be triggered via AF_ALG from unprivileged user > space. > > Fixes: 7a7ffe65c8c5f ("crypto: skcipher - Add top-level skcipher > interface") > CC: Herbert Xu <herb...@gondor.a

Re: [PATCH 2/2] crypto: shash - no kmap of zero SG

aintext is zero and thus the > encryption operation is a noop. In this case, no input data exists that > can be hashed. The crash is triggerable via AF_ALG from unprivileged > user space. > > Fixes: 3b2f6df08258e ("crypto: hash - Export shash through ahash") > CC: Herbert

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

On Thu, Oct 05, 2017 at 06:16:20PM +0800, Herbert Xu wrote: > > That was my point. Functions like sctp_pack_cookie shouldn't be > setting the key in the first place. The setkey should happen at > the point when the key is generated. That's sctp_endpoint_init > which AFAICS o

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

enerates the secret key in the first place. AFAICS that's only called in GFP_KERNEL context. What am I missing? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 1/3] crypto: engine - permit to enqueue aead_request

ow. > Would it make sense to have this driver reviewed first, and then > reworked (I expect minor update here) when the interface update is ready? Hmm, is it possible to disable the AEAD part of the driver first? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: htt

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

or every hashing operation. But so far these are uses have been very few so there has been no need to provide an API for them. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] padata cpu awareness fixes

On Mon, Oct 02, 2017 at 01:14:24PM +0200, Mathias Krause wrote: > > Ping! Herbert, will these patches go through your tree or Steffen's? They are in my queue. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ P

Re: [GIT PULL] KEYS: Fixes and crypto fixes

it's worth I'm satisfied with the crypto changes. GCM is a much better > > choice > > than ECB as long as we don't repeat (key, IV) pairs --- which we don't. > > And in > > any case ECB mode makes no sense in this context; you'd need a *very* good > > reason to actuall

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

> see here? OK I was mistaken. While SG lists can contain entries that are larger than PAGE_SIZE, there is no reason why scatterwalk_ffwd should gratuitously insert a page_offset that is greater than PAGE_SIZE. Harsh, can you please submit your original patch with a sign-off? Thanks, -- Email: Herbert

Re: Question about ahash export and import

er an export ? No export should not affect the ability to perform subsequent update/finalize calls. IOW it should be a read-only operation as far as the hash state is concerned. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herb

Re: Question about ahash export and import

ou cannot keep a hash state in hardware indefinitely just because the user has not called finalize on it. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] mac80211: aead api to reduce redundancy

ould stay there. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] mac80211: aead api to reduce redundancy

API, rather than touching actual crypto API code, I think you should handle it as you do with any other wireless patch. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: aesni: make arrays aesni_simd_skciphers and aesni_simd_skciphers2 static

parse warnings: > symbol 'aesni_simd_skciphers' was not declared. Should it be static? > symbol 'aesni_simd_skciphers2' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <

Re: [PATCH 01/12] crypto: crypto4xx: remove bad list_del

...@googlemail.com> All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 00/11] crypto: gcm - add GCM IV size constant

nstant > crypto: chelsio - Use GCM IV size constant > crypto: omap - Use GCM IV size constant > crypto: gcm - Use GCM IV size constant > crypto: aesni - Use GCM IV size constant All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home

Re: [PATCH 0/2] remove NULL check before kfree

On Sun, Aug 27, 2017 at 02:45:28AM +0530, Himanshu Jha wrote: > *** BLURB HERE *** > > Himanshu Jha (2): > crypto: n2 - remove null check before kfree > crypto: inside-secure - remove null check before kfree All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana

Re: [PATCH] crypto: padlock-sha: constify x86_cpu_id

v <arvind.yadav...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: padlock-aes: constify x86_cpu_id

v <arvind.yadav...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: brcm - Explicity ACK mailbox message

tt.bran...@broadcom.com> > Cc: sta...@vger.kernel.org Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: drop unnecessary return statements

c:280: > FILE: crypto/tcrypt.c:385: > FILE: drivers/crypto/ixp4xx_crypto.c:538: > FILE: drivers/crypto/marvell/cesa.c:81: > FILE: drivers/crypto/ux500/cryp/cryp_core.c:1755: > > Signed-off-by: Geliang Tang <geliangt...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH] crypto: Use PTR_ERR_ZERO

On Sun, Aug 27, 2017 at 11:52:48AM +0530, Himanshu Jha wrote: > Use PTR_ERROR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. > Build successfully. > > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.ap

Re: [PATCH] crypto: axis - hide an unused variable

ides the only user. > > Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator > driver") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.

Re: [PATCH v1] crypto: mediatek - Add empty messages check in GCM mode

On Tue, Aug 22, 2017 at 03:53:39PM +0800, Ryder Lee wrote: > Currently, empty messages are not supported in GCM mode, hence add > a check to prevent producing incorrect results. > > Signed-off-by: Ryder Lee <ryder@mediatek.com> Patch applied. Thanks. -- Email

Re: [PATCH] crypto: nx: 842: constify vio_device_id

v <arvind.yadav...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/2] crypto: add OSCCA SM3 secure hash and tests

t. Compile > tested for x86_64. > > Gilad Ben-Yossef (2): > crypto: add OSCCA SM3 secure hash > crypto: add SM3 test vectors All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: pseries: constify vio_device_id

v <arvind.yadav...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: doc - clarify return values for async hash methods

n struct ahash_alg > description > > * fix description of @final method in struct ahash_alg > > * fix typo in crypto_ahash_finup() description > > Signed-off-by: Kamil Konieczny <k.koniec...@partner.samsung.com> Patch applied. Thanks. -- Email: Herbert Xu <herb.

Re: [PATCH] Documentation: hw_random: Fix issue related to feeding entropy pool

el can now feed /dev/random as an option. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 1/1] crypto: engine - Permit to enqueue skcipher request

..@gmail.com> Hmm, you have not addressed my suggestion in https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1474434.html Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 1/3] crypto: engine - permit to enqueue aead_request

interface cleaned up a little before we expand it further. Please refer to https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1474434.html Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Fixes for 4.14

|9 +-- 20 files changed, 236 insertions(+), 212 deletions(-) Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

14-rc1 > introduced a complete new code base which addresses this bug in > a different way. Yet, that patch is too invasive for stable kernels > and was therefore not marked for stable. > > Fixes: 8ff590903d5fc ("crypto: algif_skcipher - User-space interface > for skcipher oper

Re: [PATCH] crypto: talitos - Don't provide setkey for non hmac hashing algs.

t;Generation of hash for file kcap"..., 50) = 50 > munmap(0x77f5, 378880) = 0 > > This patch ensures that setkey() function is set only > for hmac hashing. > > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied.

Re: [PATCH] crypto: talitos - fix hashing

test > > This patch fixes this issue > > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: caam - fix LS1021A support on ARMv7 multiplatform kernel

out we have to detect at runtime whether driver is running > on an i.MX platform or not. > > Cc: <sta...@vger.kernel.org> > Fixes: 6c3af9559352 ("crypto: caam - add support for LS1021A") > Signed-off-by: Horia Geantă <horia.gea...@nxp.com> Patch applied. Thanks

<    1   2   3   4   5   6   7   8   9   10   >