RE: [patch 1/2] crypto: img-hash - fix some compile warnings

2015-03-20 Thread James Hartley
Hi Dan, Thanks for the patch. James. -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: 20 March 2015 14:21 To: Herbert Xu; James Hartley Cc: David S. Miller; linux-crypto@vger.kernel.org; kernel- janit...@vger.kernel.org Subject: [patch 1/2] crypto

RE: [patch 2/2] crypto: img-hash - shift wrapping bug in img_hash_hw_init()

2015-03-20 Thread James Hartley
Hi Dan, I'm assuming you mean the upper 3 bits rather than bytes? Thanks for the patch James. -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: 20 March 2015 14:22 To: Herbert Xu; James Hartley Cc: David S. Miller; linux-crypto@vger.kernel.org; kernel

[PATCH] crypto: img-hash: Fix Kconfig selections

2015-03-19 Thread James Hartley
-off-by: James Hartley james.hart...@imgtec.com --- drivers/crypto/Kconfig |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 8b18b66..800bf41 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -448,10 +448,9

Re: crypto: img-hash - undefined Kconfig symbols

2015-03-18 Thread James Hartley
Hi Valentin, On 18 Mar 2015, at 01:35, Valentin Rothberg valentinrothb...@gmail.com wrote: Hi James, your commit d358f1abbf71 (crypto: img-hash - Add Imagination Technologies hw hash accelerator) adds two selects on undefined Kconfig symbols, namely CRYPTO_ALG_API and CRYPTO_SHA224.

RE: [PATCH V4 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-12 Thread James Hartley
Hi Andrew, -Original Message- From: abres...@google.com [mailto:abres...@google.com] On Behalf Of Andrew Bresticker Sent: 12 March 2015 18:57 To: James Hartley Cc: Herbert Xu; smuel...@chronox.de; devicet...@vger.kernel.org; Ezequiel Garcia; linux-crypto@vger.kernel.org Subject

[PATCH V5 0/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-12 Thread James Hartley
Zapolskiy * rebased to current linux-next James Hartley (2): This adds support for the Imagination Technologies hash accelerator which provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes. This adds the binding documentation for the Imagination Technologies

[PATCH V5 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-12 Thread James Hartley
This adds support for the Imagination Technologies hash accelerator which provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes. Signed-off-by: James Hartley james.hart...@imgtec.com --- drivers/crypto/Kconfig| 14 + drivers/crypto/Makefile |1 + drivers/crypto/img

[PATCH V5 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2015-03-12 Thread James Hartley
This adds the binding documentation for the Imagination Technologies hash accelerator that provides hardware acceleration for SHA1/SHA224/SHA256/MD5 hashes. This hardware will be present in the upcoming pistachio SoC. Signed-off-by: James Hartley james.hart...@imgtec.com Reviewed-by: Andrew

[PATCH V4 0/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-11 Thread James Hartley
of the above rework Changes from V1: * Addressed review comments from Andrew Bresticker and Vladimir Zapolskiy * rebased to current linux-next James Hartley (2): This adds support for the Imagination Technologies hash accelerator which provides hardware

RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-11 Thread James Hartley
Hi Andrew, -Original Message- From: abres...@google.com [mailto:abres...@google.com] On Behalf Of Andrew Bresticker Sent: 10 March 2015 18:02 To: James Hartley Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

[PATCH V4 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-11 Thread James Hartley
This adds support for the Imagination Technologies hash accelerator which provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes. Signed-off-by: James Hartley james.hart...@imgtec.com --- drivers/crypto/Kconfig| 14 + drivers/crypto/Makefile |1 + drivers/crypto/img

[PATCH V4 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2015-03-11 Thread James Hartley
This adds the binding documentation for the Imagination Technologies hash accelerator that provides hardware acceleration for SHA1/SHA224/SHA256/MD5 hashes. This hardware will be present in the upcoming pistachio SoC. Signed-off-by: James Hartley james.hart...@imgtec.com --- .../devicetree

RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread James Hartley
-Original Message- From: Herbert Xu [mailto:herb...@gondor.apana.org.au] Sent: 10 March 2015 09:37 To: Stephan Mueller Cc: James Hartley; robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com; ga...@codeaurora.org; andrew.brestic...@chromium.org; Ezequiel Garcia; linux- cry

RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread James Hartley
Resend with correct email address for Andrew Bresticker. -Original Message- From: James Hartley Sent: 10 March 2015 09:53 To: 'Herbert Xu'; Stephan Mueller Cc: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com; ga...@codeaurora.org; andrew.brestic...@chromium.org

RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread James Hartley
-Original Message- From: linux-crypto-ow...@vger.kernel.org [mailto:linux-crypto- ow...@vger.kernel.org] On Behalf Of Herbert Xu Sent: 10 March 2015 09:56 To: James Hartley Cc: Stephan Mueller; robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com; ga...@codeaurora.org

RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread James Hartley
Hi Andrew -Original Message- From: abres...@google.com [mailto:abres...@google.com] On Behalf Of Andrew Bresticker Sent: 09 March 2015 05:42 To: James Hartley Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

RE: [PATCH V3 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2015-03-10 Thread James Hartley
Hi Andrew -Original Message- From: abres...@google.com [mailto:abres...@google.com] On Behalf Of Andrew Bresticker Sent: 06 March 2015 21:50 To: James Hartley Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH V3 2/2] Documentation: crypto: Add DT binding info for the img hw

[PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-05 Thread James Hartley
This adds support for the Imagination Technologies hash accelerator which provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes. Signed-off-by: James Hartley james.hart...@imgtec.com --- drivers/crypto/Kconfig| 14 + drivers/crypto/Makefile |2 + drivers/crypto/img

[PATCH V3 0/2] Add support for the IMG hash accelerator

2015-03-05 Thread James Hartley
* rebased to current linux-next James Hartley (2): crypto: Add Imagination Technologies hw hash accelerator Documentation: crypto: Add DT binding info for the img hw hash accelerator .../devicetree/bindings/crypto/img-hash.txt| 27 + drivers/crypto/Kconfig

[PATCH V3 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2015-03-05 Thread James Hartley
This adds the binding documentation for the Imagination Technologies hash accelerator that provides hardware acceleration for SHA1/SHA224/SHA256/MD5 hashes. This hardware will be present in the upcoming pistachio SoC. Signed-off-by: James Hartley james.hart...@imgtec.com --- .../devicetree

Re: [PATCH V2 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-01-28 Thread James Hartley
On 01/28/15 00:56, Herbert Xu wrote: On Wed, Jan 28, 2015 at 12:29:29AM +, James Hartley wrote: - If it is mandatory to impement a fallback driver (because the potential users of the framework would not know only digest is supported?) Yes it is mandatory. If I need to implement

Re: [PATCH V2 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-01-27 Thread James Hartley
On 01/28/15 00:01, James Hartley wrote: +struct img_hash_request_ctx { +struct img_hash_dev*hdev; +u8 digest[SHA256_DIGEST_SIZE] __aligned(sizeof(u32)); +unsigned longflags; +size_tdigsize; + +dma_addr_tdma_addr; +size_t

RE: [PATCH V2 1/2] crypto: Add Imagination Technologies hw hash accelerator

2014-11-24 Thread James Hartley
Hi Herbert, thanks for the review. -Original Message- From: devicetree-ow...@vger.kernel.org [mailto:devicetree- ow...@vger.kernel.org] On Behalf Of Herbert Xu Sent: 20 November 2014 14:22 To: James Hartley Cc: da...@davemloft.net; grant.lik...@linaro.org; robh...@kernel.org; gre

RE: [PATCH V2 0/2] crypto: Add support for the IMG hash accelerator

2014-11-19 Thread James Hartley
Hi All, Apologies for this approach, but although my email replies seem to get through to the mailing list, my patches dont (although they do appear to land on the device tree list). I'm sure Herbert will have received it in his inbox, but for anyone else who might want to comment on the

RE: [PATCH 1/2] crypto: Add Imagination Technologies hw hash accelerator

2014-11-18 Thread James Hartley
Andrew, Thanks for the review -Original Message- From: abres...@google.com [mailto:abres...@google.com] On Behalf Of Andrew Bresticker Sent: 14 November 2014 23:59 To: James Hartley Cc: Herbert Xu; da...@davemloft.net; Grant Likely; Rob Herring; a...@linux-foundation.org; Greg

RE: [PATCH 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2014-11-18 Thread James Hartley
Hi Andrew -Original Message- From: abres...@google.com [mailto:abres...@google.com] On Behalf Of Andrew Bresticker Sent: 10 November 2014 17:30 To: James Hartley Cc: herb...@gondor.apana.org.au; da...@davemloft.net; Grant Likely; Rob Herring; a...@linux-foundation.org; Greg Kroah

[PATCH V2 0/2] crypto: Add support for the IMG hash accelerator

2014-11-18 Thread James Hartley
James Hartley (2): crypto: Add Imagination Technologies hw hash accelerator Documentation: crypto: Add DT binding info for the img hw hash accelerator .../devicetree/bindings/crypto/img-hash.txt| 26 + MAINTAINERS|5 + drivers/crypto

[PATCH V2 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2014-11-18 Thread James Hartley
This adds the binding documenation for the Imagination Technologies hash accelerator that provides hardware acceleration for SHA1/SHA224/SHA256/MD5 hashes. This hardware will be present in the upcoming pistachio SoC. Signed-off-by: James Hartley james.hart...@imgtec.com --- .../devicetree

[PATCH V2 1/2] crypto: Add Imagination Technologies hw hash accelerator

2014-11-18 Thread James Hartley
This adds support for the Imagination Technologies hash accelerator which provides hardware acceleratopm for SHA1 SHA224 SHA256 and MD5 hashes. Signed-off-by: James Hartley james.hart...@imgtec.com --- MAINTAINERS |5 + drivers/crypto/Kconfig| 14 + drivers/crypto

RE: [PATCH 1/2] crypto: Add Imagination Technologies hw hash accelerator

2014-11-11 Thread James Hartley
Hi Vladimir, thanks for the review! -Original Message- From: Vladimir Zapolskiy [mailto:vladimir_zapols...@mentor.com] Sent: 10 November 2014 15:10 To: James Hartley; herb...@gondor.apana.org.au; da...@davemloft.net; grant.lik...@linaro.org; robh...@kernel.org; a...@linux

RE: [PATCH 1/2] crypto: Add Imagination Technologies hw hash accelerator

2014-11-11 Thread James Hartley
Hi Vladimir -Original Message- From: linux-crypto-ow...@vger.kernel.org [mailto:linux-crypto- ow...@vger.kernel.org] On Behalf Of Vladimir Zapolskiy Sent: 11 November 2014 15:12 To: James Hartley; grant.lik...@linaro.org; robh...@kernel.org; a...@linux-foundation.org Cc: herb

[PATCH 0/2] crypto: Add support for the IMG hash accelerator

2014-11-10 Thread James Hartley
This adds support for the Imagination Technologies hash accelerator that provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 Hashes. This hardware is present in the upcoming Pistachio SoC. James Hartley (2): crypto: Add Imagination Technologies hw hash accelerator Documentation

[PATCH 1/2] crypto: Add Imagination Technologies hw hash accelerator

2014-11-10 Thread James Hartley
This adds support for the Imagination Technologies hash accelerator that provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 Hashes. Signed-off-by: James Hartley james.hart...@imgtec.com --- MAINTAINERS |5 + drivers/crypto/Kconfig| 13 + drivers/crypto/Makefile

[PATCH 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2014-11-10 Thread James Hartley
Signed-off-by: James Hartley james.hart...@imgtec.com --- .../devicetree/bindings/crypto/img-hash.txt| 28 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/crypto/img-hash.txt diff --git a/Documentation/devicetree/bindings