Re: [RFC PATCH v2 8/8] clavis: Introduce new LSM called clavis

2024-06-10 Thread Randy Dunlap
Hi Eric, On 5/30/24 5:39 PM, Eric Snowberg wrote: > > Signed-off-by: Eric Snowberg > --- > Documentation/admin-guide/LSM/clavis.rst | 198 +++ > MAINTAINERS | 7 + > crypto/asymmetric_keys/signature.c | 4 + > include/linux/lsm_hook_def

Re: [PATCH RFC 8/8] clavis: Introduce new LSM called clavis

2024-03-11 Thread Randy Dunlap
On 3/11/24 09:11, Eric Snowberg wrote: > In the future it is envisioned this LSM could be enhanced to provide > access control for UEFI Secure Boot Advanced Targeting (SBAT). Using > the same clavis= boot param and storing the additional contents within > the new RT UEFI var, SBAT restrictions

[PATCH] crypto: camellia: drop duplicate "depends on CRYPTO"

2021-04-17 Thread Randy Dunlap
ellia - add AVX2/AES-NI/x86_64 assembler implementation of camellia cipher") Fixes: c5aac2df6577 ("sparc64: Add DES driver making use of the new des opcodes.") Signed-off-by: Randy Dunlap Cc: Sebastian Siewior Cc: Jussi Kivilinna Cc: Herbert Xu Cc: "David S. Miller" Cc: linu

[PATCH] crypto: fix kernel-doc notation in chacha.c and af_alg.c

2021-04-11 Thread Randy Dunlap
or member 'areqlen' not described in 'af_alg_alloc_areq' af_alg.c:1146: warning: Function parameter or member 'sk' not described in 'af_alg_get_rsgl' af_alg.c:1146: warning: Function parameter or member 'msg' not described in 'af_alg_get_rsgl'

crypto: FIPS 200 mode

2021-03-30 Thread Randy Dunlap
The Kconfig help text for CRYPTO_FIPS says config CRYPTO_FIPS bool "FIPS 200 compliance" ... help This option enables the fips boot option which is required if you want the system to operate in a FIPS 200 certification. You should say no unless you

Re: [PATCH v2] Documentation: crypto: add info about "fips=" boot option

2021-03-30 Thread Randy Dunlap
On 3/29/21 10:29 PM, Eric Biggers wrote: > On Mon, Mar 29, 2021 at 10:06:51PM -0700, Randy Dunlap wrote: >> Having just seen a report of using "fips=1" on the kernel command line, >> I could not find it documented anywhere, so add some help for it. >> >> Signe

[PATCH v2] Documentation: crypto: add info about "fips=" boot option

2021-03-29 Thread Randy Dunlap
Having just seen a report of using "fips=1" on the kernel command line, I could not find it documented anywhere, so add some help for it. Signed-off-by: Randy Dunlap Cc: Dexuan Cui Cc: linux-crypto@vger.kernel.org Cc: Eric Biggers Cc: Herbert Xu Cc: "David S. Miller" Cc:

Re: [PATCH] Documentation: crypto: add info about "fips=" boot option

2021-03-29 Thread Randy Dunlap
On 3/29/21 9:37 PM, Herbert Xu wrote: > On Mon, Mar 29, 2021 at 09:00:01PM -0700, Randy Dunlap wrote: >> >> +If fips_enabled = 1, some crypto tests are skipped. > > I don't think any tests are skipped. It does however disable > many algorithms b

crypto: possible NULL reference

2021-03-29 Thread Randy Dunlap
As I was trying to document "fips= here is not checked for NULL or not NULL before it is used. Nor is the use of in most other functions in ecc.c. Is there something else protecting the improper use of in these cases? or is a patch warranted? thanks. -- ~Randy

[PATCH] Documentation: crypto: add info about "fips=" boot option

2021-03-29 Thread Randy Dunlap
Having just seen a report of using "fips=1" on the kernel command line, I could not find it documented anywhere, so add some help for it. Signed-off-by: Randy Dunlap Cc: Dexuan Cui Cc: linux-crypto@vger.kernel.org Cc: Eric Biggers Cc: Herbert Xu Cc: "David S. Miller" Cc:

Re: [PATCH] crypto: chelsio: fix incorrect kernel-doc comment syntax in file

2021-03-29 Thread Randy Dunlap
part of the Chelsio T4/T5/T6 Ethernet driver for Linux." > > Provide a simple fix by replacing this occurrence with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. > > Signed-off-by: Aditya Srivastava Acked-by: Randy Dunlap Thanks. &g

Re: [PATCH] crypto: async_tx/async_xor.c: Few mundane spello fixes

2021-03-25 Thread Randy Dunlap
On 3/25/21 7:34 PM, Bhaskar Chowdhury wrote: > > s/eninges/engines/ ...two different places. > s/explicity/explicitly/ two different places. > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > crypto/async_tx/async_xor.c | 8 > 1 fi

Re: [PATCH] init/Kconfig: Support sign module with SM3 hash algorithm

2021-03-23 Thread Randy Dunlap
On 3/23/21 1:35 AM, Tianjia Zhang wrote: > The kernel module signature supports the option to use the SM3 > secure hash (OSCCA GM/T 0004-2012 SM3). > > Signed-off-by: Tianjia Zhang > --- > Documentation/admin-guide/module-signing.rst | 5 +++-- > crypto/asymmetric_keys/pkcs7_parser.c| 7

Re: [PATCH] s390/crc32-vx: Couple of typo fixes

2021-03-22 Thread Randy Dunlap
On 3/22/21 6:05 AM, Bhaskar Chowdhury wrote: > > s/defintions/definitions/ > s/intermedate/intermediate/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > arch/s390/crypto/crc32be-vx.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH] crypto: nx: fix incorrect kernel-doc comment syntax in files

2021-03-21 Thread Randy Dunlap
Looks good. Thanks. Acked-by: Randy Dunlap

Re: [PATCH] crypto: ux500: fix incorrect kernel-doc comment syntax

2021-03-21 Thread Randy Dunlap
LGTM. Thanks. Acked-by: Randy Dunlap

Re: [PATCH] crypto: amcc: fix incorrect kernel-doc comment syntax in files

2021-03-21 Thread Randy Dunlap
Looks good. Thanks. Acked-by: Randy Dunlap

Re: [PATCH] crypto: atmel-ecc - fix W=1 "cannot understand" warning

2021-03-20 Thread Randy Dunlap
On Sat, 20 Mar 2021, Meng Yu wrote: Fix kernel-doc warnings due to missing "struct" keyword. The warning likes: drivers/crypto/atmel-ecc.c:40: warning: cannot understand function prototype: 'struct atmel_ecdh_ctx ' Signed-off-by: Meng Yu Acked-by: Randy Dunlap T

Re: [PATCH] md/raid6: Couple of typo fixes

2021-03-19 Thread Randy Dunlap
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: s/boudary/boundary/ s/compliled/compiled/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- crypto/async_tx/raid6test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/async_tx/raid6test.c b/crypto

Re: [PATCH] crypto: inside-secure: Minor typo fix in the file safexcel.c

2021-03-17 Thread Randy Dunlap
On 3/17/21 2:14 AM, Bhaskar Chowdhury wrote: > > s/procesing/processing/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/crypto/inside-secure/safexcel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/d

Re: [PATCH 4/4] Documentation/admin-guide/module-signing.rst: add openssl command option example for CodeSign EKU

2021-02-22 Thread Randy Dunlap
Hi, On 2/21/21 10:42 PM, Lee, Chun-Yi wrote: > Add an openssl command option example for generating CodeSign extended > key usage in X.509 when CONFIG_CHECK_CODESIGN_EKU is enabled. > > Signed-off-by: "Lee, Chun-Yi" > --- > Documentation/admin-guide/module-signing.rst | 6 ++ > 1 file chang

Re: [PATCH] drivers: crypto: qat: qat_common: Two different lines fix the same spelling in the file adf_vf2pf_msg.c

2021-02-03 Thread Randy Dunlap
On 2/3/21 7:01 AM, Bhaskar Chowdhury wrote: > > s/messge/message/ ..two different lines > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap Thanks. > --- > drivers/crypto/qat/qat_common/adf_vf2pf_msg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH] crypto: Fixed optimzation to optimization in the file crypto/xor.c

2021-02-03 Thread Randy Dunlap
On 2/3/21 7:39 AM, Bhaskar Chowdhury wrote: > > s/optimzation/optimization/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap Thanks. > --- > crypto/xor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/xor.c b/crypto

Re: [PATCH] crypto: octeontx2 - Add dependency on NET_VENDOR_MARVELL

2021-01-28 Thread Randy Dunlap
On 1/28/21 9:48 PM, Herbert Xu wrote: > On Mon, Jan 25, 2021 at 09:41:12AM -0800, Randy Dunlap wrote: >> on x86_64: >> >> ld: drivers/crypto/marvell/octeontx2/otx2_cptpf_main.o: in function >> `cptpf_flr_wq_handler': >> otx2_cptpf_main.

Re: mmotm 2021-01-25-21-18 uploaded (octeontx2)

2021-01-27 Thread Randy Dunlap
ko] undefined! ERROR: modpost: "otx2_mbox_msg_send" [drivers/crypto/marvell/octeontx2/octeontx2-cpt.ko] undefined! ERROR: modpost: "otx2_mbox_init" [drivers/crypto/marvell/octeontx2/octeontx2-cpt.ko] undefined! ERROR: modpost: "otx2_mbox_alloc_msg_rsp" [drivers/crypto/marvell/octeontx2/octeontx2-cpt.ko] undefined! Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap config-r7419.gz Description: application/gzip

linux-next-20210125: drivers/crypto/marvell/octeontx2/ build errors

2021-01-25 Thread Randy Dunlap
efined reference to `otx2_mbox_alloc_msg_rsp' ld: drivers/crypto/marvell/octeontx2/otx2_cptvf_mbox.o: in function `otx2_cptvf_send_kvf_limits_msg': otx2_cptvf_mbox.c:(.text+0x302): undefined reference to `otx2_mbox_alloc_msg_rsp' ld: drivers/crypto/marvell/octeontx2/otx2_cptvf_mbox.o: in function `otx2_cptvf_pfvf_mbox_handler': otx2_cptvf_mbox.c:(.text+0x14f): undefined reference to `otx2_mbox_reset' Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap config-r7396.gz Description: application/gzip

Re: linux-next: Tree for Dec 1 [crypto/aegis128.ko]

2020-12-01 Thread Randy Dunlap
On 12/1/20 1:37 PM, Randy Dunlap wrote: > On 12/1/20 1:29 PM, Ard Biesheuvel wrote: >> On Tue, 1 Dec 2020 at 20:53, Randy Dunlap wrote: >>> >>> On 12/1/20 2:03 AM, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20201130:

Re: linux-next: Tree for Dec 1 [crypto/aegis128.ko]

2020-12-01 Thread Randy Dunlap
On 12/1/20 1:29 PM, Ard Biesheuvel wrote: > On Tue, 1 Dec 2020 at 20:53, Randy Dunlap wrote: >> >> On 12/1/20 2:03 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20201130: >>> >> >> on i386 or x86_64: >&g

Re: linux-next: Tree for Dec 1 [crypto/aegis128.ko]

2020-12-01 Thread Randy Dunlap
On 12/1/20 2:03 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20201130: > on i386 or x86_64: CONFIG_CRYPTO_AEGIS128=m CONFIG_CRYPTO_AEGIS128_AESNI_SSE2=y ERROR: modpost: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefined! -- ~Randy Reported-by: Randy Dunlap

Re: [PATCH 4/4] Documentation/admin-guide/module-signing.rst: add openssl command option example for CodeSign EKU

2020-11-25 Thread Randy Dunlap
Hi-- On 11/24/20 11:26 PM, Lee, Chun-Yi wrote: > Add an openssl command option example for generating CodeSign extended > key usage in X.509 when CONFIG_CHECK_CODESIGN_EKU be enabled. is enabled. > > Signed-off-by: "Lee, Chun-Yi" > --- > Doc

Re: [RFC PATCH 2/2] PKCS#7: Check codeSigning EKU for kernel module and kexec pe verification

2020-10-20 Thread Randy Dunlap
On 10/20/20 6:42 AM, Ben Boeckel wrote: > On Tue, Oct 20, 2020 at 14:50:01 +0800, Lee, Chun-Yi wrote: >> +config CHECK_CODESIGN_EKU >> +bool "Check codeSigning extended key usage" >> +depends on PKCS7_MESSAGE_PARSER=y >> +depends on SYSTEM_DATA_VERIFICATION >> +help >> + This o

Re: drivers/crypto/chelsio/chcr_ktls.c:1078: undefined reference to `tls_get_record'

2020-10-08 Thread Randy Dunlap
On 8/7/20 9:16 AM, kernel test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 86cfccb66937dd6cbf26ed619958b9e587e6a115 commit: 5a4b9fe7fece62ecab6fb28fe92362f83b41c33e cxgb4/chcr: complete record tx handling date: 5 months ago config: pa

Re: [DISCUSSION PATCH 00/41] random: possible ways towards NIST SP800-90B compliance

2020-10-02 Thread Randy Dunlap
s ; Andy Lutomirski ; >> Florian Weimer ; Lennart >> Poettering ; Peter Matthias >> ; Marcelo Henrique Cerri >> ; Neil Horman ; Randy >> Dunlap ; Julia Lawall >> ; Dan Carpenter ; Andy Lavr >> ; Eric Biggers >> ; Jason A. Donenfeld ; Stephan Müller

Re: [PATCH v2] certs: Add EFI_CERT_X509_GUID support for dbx entries

2020-09-09 Thread Randy Dunlap
On 9/9/20 10:27 AM, Eric Snowberg wrote: > diff --git a/include/crypto/pkcs7.h b/include/crypto/pkcs7.h > index 38ec7f5f9041..d8f2e0fdfbf4 100644 > --- a/include/crypto/pkcs7.h > +++ b/include/crypto/pkcs7.h > @@ -26,11 +26,19 @@ extern int pkcs7_get_content_data(const struct > pkcs7_message *pkcs

Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc

2020-08-30 Thread Randy Dunlap
gt;> Signed-off-by: Krzysztof Kozlowski >> --- >> crypto/asymmetric_keys/asymmetric_type.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) > > Hi David, Herbert, > > Any comments here? > > Best regards, > Krzysztof LGTM. Thanks. Acked-by: Randy Dunlap -- ~Randy

[PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error

2020-08-06 Thread Randy Dunlap
From: Randy Dunlap sa2ul.c uses sha{1,256,512}_zero_message_hash, so select the Kconfig symbols that provide those, like other crypto drivers do. Fixes this build error: ld: drivers/crypto/sa2ul.o: in function `sa_sha_digest': sa2ul.c:(.text+0x2b25): undefined referen

[PATCH 2/6] crypto: asymmetric_keys: pkcs7_parser: delete duplicated word

2020-07-30 Thread Randy Dunlap
Drop the doubled word "the". Signed-off-by: Randy Dunlap Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org --- crypto/asymmetric_keys/pkcs7_parser.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/cr

[PATCH 6/6] crypto: tcrypt: delete duplicated words in messages

2020-07-30 Thread Randy Dunlap
Drop the doubled word "failed" in pr_err() messages. Signed-off-by: Randy Dunlap Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org --- crypto/tcrypt.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200730.orig/crypto/tcr

[PATCH 5/6] crypto: crypto_engine: delete duplicated word

2020-07-30 Thread Randy Dunlap
Drop the doubled word "a". Signed-off-by: Randy Dunlap Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org --- crypto/crypto_engine.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/crypto/crypto_engine.c +++ linux-

[PATCH 1/6] crypto: algif_aead: delete duplicated word

2020-07-30 Thread Randy Dunlap
Drop the doubled word "is". Signed-off-by: Randy Dunlap Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org --- crypto/algif_aead.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/crypto/algif_aead.c +++ linux-

[PATCH 3/6] crypto: crc32c_generic: delete and fix duplicated words

2020-07-30 Thread Randy Dunlap
Drop the doubled word "the". Change "at at" to "at a". Signed-off-by: Randy Dunlap Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org --- crypto/crc32c_generic.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 4/6] crypto: crct10dif_generic: fix duplicated words

2020-07-30 Thread Randy Dunlap
Change the doubled word "at" to "at a". Signed-off-by: Randy Dunlap Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org --- crypto/crct10dif_generic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200730.orig/crypto

[PATCH 0/6] crypto: delete or fix duplicated words

2020-07-30 Thread Randy Dunlap
Drop doubled words or fix them to what they should be. Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org crypto/algif_aead.c |2 +- crypto/asymmetric_keys/pkcs7_parser.h |2 +- crypto/crc32c_generic.c |4 ++-- crypto/crct10dif_ge

Re: linux-next: Tree for Jul 29 (drivers/crypto/sa2ul.c)

2020-07-29 Thread Randy Dunlap
(req->result, sha512_zero_message_hash, sa_digest_size); break; #endif default: return -EINVAL; } return 0; } -- ~Randy Reported-by: Randy Dunlap

Re: [PATCH 2/2] crypto: Ingenic: Add hardware RNG for Ingenic JZ4780 and X1000.

2020-07-22 Thread Randy Dunlap
On 7/22/20 9:40 AM, 周琰杰 (Zhou Yanjie) wrote: > diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig > index 0ad17efc96df..fcb06027cd88 100644 > --- a/drivers/char/hw_random/Kconfig > +++ b/drivers/char/hw_random/Kconfig > @@ -257,6 +257,21 @@ config HW_RANDOM_IMX_RNGC > >

[PATCH] crypto: testmgr.h: delete duplicated words

2020-07-19 Thread Randy Dunlap
Delete the doubled word "from" in multiple places. Signed-off-by: Randy Dunlap Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org --- crypto/testmgr.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) --- linux-next-20200717.orig/crypto

[PATCH] crypto: hash.h: drop duplicated word in a comment

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "in" in a comment. Signed-off-by: Randy Dunlap Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org --- include/crypto/hash.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714

[PATCH] crypto: skcipher.h: drop duplicated word in kernel-doc

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "request" in a kernel-doc comment. Signed-off-by: Randy Dunlap Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org --- include/crypto/skcipher.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linu

Re: linux-next: Tree for May 26 (drivers/crypto/chelsio/chcr_ktls.c)

2020-05-26 Thread Randy Dunlap
r named 'skc_v6_daddr'; did you mean 'skc_daddr'? #define sk_v6_daddr __sk_common.skc_v6_daddr ^ ../arch/x86/include/asm/string_32.h:182:45: note: in definition of macro 'memcpy' #define memcpy(t, f, n) __builtin_memcpy(t, f, n) ^ ../drivers/crypto/chelsio/chcr_ktls.c:497:22: note: in expansion of macro 'sk_v6_daddr' memcpy(daaddr, sk->sk_v6_daddr.in6_u.u6_addr8, 16); ^~~ -- ~Randy Reported-by: Randy Dunlap

Re: [PATCH v2 3/4] crypto: amlogic: Add crypto accelerator for amlogic GXL

2019-10-13 Thread Randy Dunlap
Hi, On 10/13/19 10:31 PM, Corentin Labbe wrote: > diff --git a/drivers/crypto/amlogic/Kconfig b/drivers/crypto/amlogic/Kconfig > new file mode 100644 > index ..9c4bf96afeb3 > --- /dev/null > +++ b/drivers/crypto/amlogic/Kconfig > @@ -0,0 +1,24 @@ > +config CRYPTO_DEV_AMLOGIC_GXL > +

[PATCH -next] crypto: inside-secure: fix build error for safexcel_hash.c

2019-10-09 Thread Randy Dunlap
From: Randy Dunlap safexcel_hash.c (CRYPTO_DEV_SAFEXCEL) needs to select CRYPTO_SM3. Fixes this build error: safexcel_hash.c:(.text+0x1b17): undefined reference to `sm3_zero_message_hash' Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver"

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-17 Thread Randy Dunlap
On 10/17/18 8:17 AM, AnilKumar Chimata wrote: > This patch adds support for Inline Crypto Engine (ICE), which > is embedded into storage device/controller such as UFS/eMMC. > ICE is intended for high throughput cryptographic encryption > or decryption of storage data. > > Signed-off-by: AnilKumar

Re: linux-next: Tree for Sep 25 (crypto/caam/)

2018-09-25 Thread Randy Dunlap
On 9/24/18 10:39 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180924: > on i386: # CONFIG_NET is not set drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_fqdan_cb': caamalg_qi2.c:(.text+0x502): undefined reference to `napi_schedule_prep' caamalg_qi2.c:(.text+0x50d): unde

Re: process? [Re: Crypto Fixes for 4.19]

2018-09-19 Thread Randy Dunlap
On 9/19/18 9:40 AM, Greg KH wrote: > On Wed, Sep 19, 2018 at 09:10:55AM -0700, Randy Dunlap wrote: >> On 9/19/18 6:23 AM, Greg KH wrote: >>> On Wed, Sep 19, 2018 at 02:22:01PM +0800, Herbert Xu wrote: >>>> Hi Greg: >>>> >>>> This push fixes

process? [Re: Crypto Fixes for 4.19]

2018-09-19 Thread Randy Dunlap
On 9/19/18 6:23 AM, Greg KH wrote: > On Wed, Sep 19, 2018 at 02:22:01PM +0800, Herbert Xu wrote: >> Hi Greg: >> >> This push fixes a potential boot hang in ccp and an incorrect >> CPU capability check in aegis/morus on x86. >> >> >> Please pull from >> >> git://git.kernel.org/pub/scm/linux/kernel/

Re: [PATCH 1/7] vfio/sdmdev: Add documents for WarpDrive framework

2018-09-06 Thread Randy Dunlap
Hi, On 09/02/2018 05:51 PM, Kenneth Lee wrote: > From: Kenneth Lee > > WarpDrive is a common user space accelerator framework. Its main component > in Kernel is called sdmdev, Share Domain Mediated Device. It exposes > the hardware capabilities to the user space via vfio-mdev. So processes in >

Re: [PATCH 7/7] vfio/sdmdev: add user sample

2018-09-02 Thread Randy Dunlap
On 09/02/2018 05:52 PM, Kenneth Lee wrote: > From: Kenneth Lee > > This is the sample code to demostrate how WrapDrive user application > should be. > > It contains: > > 1. wd.[ch], the common library to provide WrapDrive interface. WarpDrive > 2. d

Re: [PATCH 6/7] crypto: add sdmdev support to Hisilicon QM

2018-09-02 Thread Randy Dunlap
On 09/02/2018 05:52 PM, Kenneth Lee wrote: > diff --git a/drivers/crypto/hisilicon/Kconfig > b/drivers/crypto/hisilicon/Kconfig > index 1d155708cd69..b85fab48fdab 100644 > --- a/drivers/crypto/hisilicon/Kconfig > +++ b/drivers/crypto/hisilicon/Kconfig > @@ -17,6 +17,16 @@ config CRYPTO_DEV_HISI_SE

Re: [PATCH 4/7] crypto: add hisilicon Queue Manager driver

2018-09-02 Thread Randy Dunlap
On 09/02/2018 05:52 PM, Kenneth Lee wrote: > diff --git a/drivers/crypto/hisilicon/Kconfig > b/drivers/crypto/hisilicon/Kconfig > index 8ca9c503bcb0..02a6eef84101 100644 > --- a/drivers/crypto/hisilicon/Kconfig > +++ b/drivers/crypto/hisilicon/Kconfig > @@ -1,4 +1,8 @@ > # SPDX-License-Identifier

Re: [PATCH 3/7] vfio: add sdmdev support

2018-09-02 Thread Randy Dunlap
On 09/02/2018 05:52 PM, Kenneth Lee wrote: > diff --git a/drivers/vfio/sdmdev/Kconfig b/drivers/vfio/sdmdev/Kconfig > new file mode 100644 > index ..51474272870d > --- /dev/null > +++ b/drivers/vfio/sdmdev/Kconfig > @@ -0,0 +1,10 @@ > +# SPDX-License-Identifier: GPL-2.0 > +config VFIO_S

Re: [RFC PATCH 3/7] vfio: add spimdev support

2018-08-01 Thread Randy Dunlap
On 08/01/2018 03:22 AM, Kenneth Lee wrote: > From: Kenneth Lee > > SPIMDEV is "Share Parent IOMMU Mdev". It is a vfio-mdev. But differ from > the general vfio-mdev: > > 1. It shares its parent's IOMMU. > 2. There is no hardware resource attached to the mdev is created. The > hardware resource (A

Re: [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8

2018-07-24 Thread Randy Dunlap
On 07/24/2018 02:00 PM, Andrew Morton wrote: > On Tue, 24 Jul 2018 13:13:25 +0200 Arnd Bergmann wrote: > >> Almost all files in the kernel are either plain text or UTF-8 >> encoded. A couple however are ISO_8859-1, usually just a few >> characters in a C comments, for historic reasons. >> >> This

Re: [PATCH] random: add a config option to trust the CPU's hwrng

2018-07-17 Thread Randy Dunlap
On 07/17/2018 06:43 PM, Theodore Ts'o wrote: > This gives the user building their own kernel (or a Linux > distribution) the option of deciding whether or not to trust the CPU's > hardware random number generator (e.g., RDRAND for x86 CPU's) as being > correctly implemented and not having a back do

Re: Decreasing time for `rsa_init`

2017-12-26 Thread Randy Dunlap
On 12/26/2017 12:28 AM, Paul Menzel wrote: > Dear Stephan, dear Linux folks, > > > Am 13.07.2017 um 20:20 schrieb Paul Menzel: > >> Am Mittwoch, den 12.07.2017, 19:38 +0200 schrieb Paul Menzel: >> >>> On 07/12/17 19:28, Stephan Müller wrote: Am Mittwoch, 12. Juli 2017, 12:59:58 CEST schrieb

Re: [PATCH RFC 2/3] crypto: Implement a generic crypto statistics

2017-12-20 Thread Randy Dunlap
On 12/20/2017 12:09 PM, Corentin Labbe wrote: > This patch implement a generic way to get statistics about all crypto > usages. > > Signed-off-by: Corentin Labbe > --- > crypto/Kconfig | 11 +++ > crypto/ahash.c | 18 + > crypto/algapi.c| 186 >

Re: [PATCH RFC 3/3] crypto: tools: Add cryptostat userspace

2017-12-20 Thread Randy Dunlap
On 12/20/2017 12:09 PM, Corentin Labbe wrote: > Add an example tool for getting easily crypto statistics. > > Signed-off-by: Corentin Labbe > --- > tools/crypto/cryptostat | 40 > 1 file changed, 40 insertions(+) > create mode 100755 tools/crypto/cryptos

Re: [PATCH] crypto: cavium: fix Kconfig dependencies

2017-02-14 Thread Randy Dunlap
On 02/14/17 09:09, David Daney wrote: > On 02/14/2017 09:07 AM, Arnd Bergmann wrote: >> The driver fails to build if MSI support is disabled: >> >> In file included from >> /git/arm-soc/drivers/crypto/cavium/cpt/cptpf_main.c:18:0: >> drivers/crypto/cavium/cpt/cptpf.h:57:20: error: array type has i

Re: linux-next: Tree for Oct 26 (crypto/acompress.ko)

2016-10-26 Thread Randy Dunlap
On 10/25/16 19:51, Stephen Rothwell wrote: > Hi all, > > There will probably be no linux-next releases next week while I attend > the Kernel Summit. > > Changes since 20161025: > on x864_64: ERROR: "crypto_acomp_scomp_alloc_ctx" [crypto/acompress.ko] undefined! ERROR: "crypto_acomp_scomp_free_

Re: select on non-existing Kconfig option CRC32C

2016-06-15 Thread Randy Dunlap
On 06/15/16 03:00, Andreas Ziegler wrote: > Hi Hendrik, > > your patch "s390/crc32-vx: add crypto API module for optimized CRC-32 > algorithms" showed up in linux-next today (next-20160615) as commit > 364148e0b195. > > The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC

[PATCH] crypto: fix kernel-doc warnings in crypto/aead.h

2015-12-03 Thread Randy Dunlap
From: Randy Dunlap Fix 21 occurrences of this kernel-doc warning in : ..//include/crypto/aead.h:149: warning: No description found for parameter 'base' Signed-off-by: Randy Dunlap --- include/crypto/aead.h |1 + 1 file changed, 1 insertion(+) --- lnx-44-rc3.orig/include/cry

Re: [PATCH] crypto: Documentation: remove colons in comments

2015-01-20 Thread Randy Dunlap
On 01/19/15 19:47, Herbert Xu wrote: > On Mon, Jan 19, 2015 at 12:13:39AM +0100, Stephan Mueller wrote: >> As documented in Documentation/kernel-doc-nano-HOWTO.txt lines >> terminated with a colon are treated as headings. >> >> The current layout of the documentation when compiling the kernel >> cr

Re: linux-next: Tree for Aug 26 (drbg)

2014-08-27 Thread Randy Dunlap
On 08/26/14 14:07, Randy Dunlap wrote: > On 08/26/14 13:19, Stephan Mueller wrote: >> Am Dienstag, 26. August 2014, 12:03:31 schrieb Randy Dunlap: >> >> Hi Randy, >> >>> On 08/26/14 00:34, Stephen Rothwell wrote: >>>> Hi all, >>>> >&g

Re: linux-next: Tree for Aug 26 (drbg)

2014-08-26 Thread Randy Dunlap
On 08/26/14 13:19, Stephan Mueller wrote: > Am Dienstag, 26. August 2014, 12:03:31 schrieb Randy Dunlap: > > Hi Randy, > >> On 08/26/14 00:34, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20140825: >>> >>> Th

Re: linux-next: Tree for Aug 26 (drbg)

2014-08-26 Thread Randy Dunlap
On 08/26/14 00:34, Stephen Rothwell wrote: > Hi all, > > Changes since 20140825: > > The net tree gained a build failure for which I reverted a commit. > > The mfd tree still had its build failure so I used the version from > next-20140822. > on i386: ../include/crypto/drbg.h:157:2: warning:

Re: [PATCH v2 12/12] crypto: caam - add Run Time Library (RTA) docbook

2014-08-19 Thread Randy Dunlap
On 08/14/14 05:54, Horia Geanta wrote: > Add SGML template for generating RTA docbook. > Source code is in drivers/crypto/caam/flib > > Cc: Randy Dunlap > Signed-off-by: Horia Geanta > --- > Documentation/DocBook/Makefile | 3 +- > Documentation/DocBoo

Re: [PATCH 2/4] DRBG: cleanup of preprocessor macros

2014-06-29 Thread Randy Dunlap
On 06/28/14 22:07, Stephan Mueller wrote: > Am Sonntag, 29. Juni 2014, 12:20:15 schrieb Stephen Rothwell: > > Hi Stephen, > >> Hi Stephan, >> >> On Sat, 28 Jun 2014 22:00:07 +0200 Stephan Mueller > wrote: >>> diff --git a/crypto/drbg.c b/crypto/drbg.c >>> index 6679a26..03a230e 100644 >>> --- a

Re: linux-next: Tree for Jun 26 (crypto/drbg)

2014-06-26 Thread Randy Dunlap
On 06/25/14 23:41, Stephen Rothwell wrote: > Hi all, > > The powerpc allyesconfig is again broken more than usual. > > Changes since 20140625: > on i386: ../crypto/drbg.c:1097:3: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'size_t' [-Wformat] .

Re: [RFC][PATCH 4/4] crypto: Updated makefiles to add QAT

2014-06-03 Thread Randy Dunlap
On 06/03/2014 11:24 AM, Tadeusz Struk wrote: > Update to makefiles etc. > Signed-off-by: Tadeusz Struk > --- > Documentation/ioctl/ioctl-number.txt | 1 + > MAINTAINERS | 6 ++ > drivers/crypto/Kconfig | 1 + > drivers/crypto/Makefile | 1 +

Re: randconfig build error with next-20131210, in drivers/crypto/ccp/ccp-pci.c

2013-12-19 Thread Randy Dunlap
On 12/10/13 07:34, Tom Lendacky wrote: > > On Tuesday, December 10, 2013 07:21:36 AM Jim Davis wrote: >> Building with the attached random configuration file, >> >> drivers/crypto/ccp/ccp-pci.c: In function ‘ccp_get_msix_irqs’: >> drivers/crypto/ccp/ccp-pci.c:44:20: error: array type has incomplet

Re: linux-next: Tree for Oct 31 (crypto, rsa, mpi)

2013-11-01 Thread Randy Dunlap
On 11/01/13 08:16, David Howells wrote: > Randy Dunlap wrote: > >> crypto/built-in.o: In function `RSA_verify_signature': >> rsa.c:(.text+0x1d347): undefined reference to `mpi_get_nbits' >> rsa.c:(.text+0x1d354): undefined reference to `mpi_get_nbits' >

Re: linux-next: Tree for Oct 31 (crypto, rsa, mpi)

2013-10-31 Thread Randy Dunlap
On 10/31/13 03:00, Stephen Rothwell wrote: > Hi all, > > Changes since 20131030: > > The net-next tree gained a conflict against the net tree. > > The devicetree tree gained a conflict against the crypto tree. > > The tty tree gained a build failure so I used the version from > next-20131030. >

Re: linux-next: Tree for Jan 23 (mtd/ubi and iio and crypto/crc32[c])

2013-01-23 Thread Randy Dunlap
On 01/23/13 15:23, Herbert Xu wrote: > On Wed, Jan 23, 2013 at 03:10:01PM -0800, Randy Dunlap wrote: >> On 01/22/13 22:43, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20130122: >>> >> >> >> on i386: >&

Re: linux-next: Tree for Jan 23 (mtd/ubi and iio and crypto/crc32[c])

2013-01-23 Thread Randy Dunlap
On 01/22/13 22:43, Stephen Rothwell wrote: > Hi all, > > Changes since 20130122: > on i386: ERROR: "crc32_le" [drivers/mtd/ubi/ubi.ko] undefined! ERROR: "iio_triggered_buffer_setup" [drivers/iio/adc/max1363.ko] undefined! ERROR: "iio_triggered_buffer_cleanup" [drivers/iio/adc/max1363.ko] undef

[PATCH -next] asymmetric keys: fix printk format warning

2012-10-03 Thread Randy Dunlap
From: Randy Dunlap Fix printk format warning in x509_cert_parser.c: crypto/asymmetric_keys/x509_cert_parser.c: In function 'x509_note_OID': crypto/asymmetric_keys/x509_cert_parser.c:113:3: warning: format '%zu' expects type 'size_t', but argument 2 has type '

Re: linux-next: Tree for July 2 (crypto/hifn_795x)

2012-07-09 Thread Randy Dunlap
On 07/09/2012 10:54 AM, Jussi Kivilinna wrote: > Quoting Randy Dunlap : > >> On 07/02/2012 12:23 AM, Stephen Rothwell wrote: >> >>> Hi all, >>> >>> Changes since 20120629: >>> >> >> >> on i386: >> >> >> E

Re: linux-next: Tree for July 2 (crypto/hifn_795x)

2012-07-02 Thread Randy Dunlap
On 07/02/2012 12:23 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20120629: > on i386: ERROR: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined! -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kerne

Re: [PATCH 2/2 v2] crypto: bfin_crc: CRC hardware driver for BF60x family processors.

2012-06-03 Thread Randy Dunlap
On 06/03/2012 09:00 PM, Sonic Zhang wrote: > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > index 69fdf18..3a05ba9 100644 > --- a/drivers/crypto/Kconfig > +++ b/drivers/crypto/Kconfig > @@ -306,4 +306,11 @@ if CRYPTO_DEV_UX500 > source "drivers/crypto/ux500/Kconfig" > endif

Re: [PATCH 1/2] crypto: camellia-x86_64 - module init/exit functions should be static

2012-03-21 Thread Randy Dunlap
On 03/15/2012 01:11 PM, Jussi Kivilinna wrote: > This caused conflict with twofish-x86_64-3way when compiled into kernel, > same function names and not static. Have these patches been merged anywhere? I'm still seeing build problems in linux-next 20120321. > Reported-by: Randy Du

Re: [PATCH 2/2] crypto: twofish-x86_64-3way - module init/exit functions should be static

2012-03-15 Thread Randy Dunlap
On 03/15/2012 01:11 PM, Jussi Kivilinna wrote: > This caused conflict with camellia-x86_64 when compiled into kernel, same > function names and not static. > > Reported-by: Randy Dunlap > Signed-off-by: Jussi Kivilinna Acked-by: Randy Dunlap Thanks. > ---

Re: [PATCH 1/2] crypto: camellia-x86_64 - module init/exit functions should be static

2012-03-15 Thread Randy Dunlap
On 03/15/2012 01:11 PM, Jussi Kivilinna wrote: > This caused conflict with twofish-x86_64-3way when compiled into kernel, > same function names and not static. > > Reported-by: Randy Dunlap > Signed-off-by: Jussi Kivilinna Acked-by: Randy Dunlap Thanks. > ---

Re: [PATCH] crypto: serpent-sse2 - should select CRYPTO_CRYPTD

2011-11-24 Thread Randy Dunlap
On 11/23/2011 10:37 PM, Jussi Kivilinna wrote: > Since serpent_sse2_glue.c uses cryptd, CRYPTO_SERPENT_SSE2_X86_64 and > CRYPTO_SERPENT_SSE2_586 should be selecting CRYPTO_CRYPTD. > > Reported-by: Randy Dunlap > Signed-off-by: Jussi Kivilinna Acked-by: Randy Dunlap Thanks.

Re: [PATCH -next] digsig: fix build errors

2011-11-21 Thread Randy Dunlap
On 11/21/2011 02:32 AM, Kasatkin, Dmitry wrote: > On Mon, Nov 21, 2011 at 8:12 AM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix build errors by adding kconfig dependency on KEYS: >> >> lib/digsig.c:106:16: error: dereferencing pointer to incomplete t

[PATCH -next] digsig: fix build errors

2011-11-20 Thread Randy Dunlap
From: Randy Dunlap Fix build errors by adding kconfig dependency on KEYS: lib/digsig.c:106:16: error: dereferencing pointer to incomplete type lib/digsig.c:107:11: error: dereferencing pointer to incomplete type lib/digsig.c:184:14: error: dereferencing pointer to incomplete type lib/digsig.c

Re: Crypto Update for 3.2

2011-10-31 Thread Randy Dunlap
On 10/30/2011 09:09 PM, Herbert Xu wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi Linus: > > Here is the crypto update for 3.2: > > * User-space interface for algorithm selection/configuration > * SSSE3 implementation of SHA1. > * X86-64 assembly implementation of blowfish. > *

Re: linux-next: Tree for Oct 25 (crypto)

2011-10-26 Thread Randy Dunlap
On 10/26/11 05:33, Stefan Richter wrote: > On Oct 26 Herbert Xu wrote: >> On Tue, Oct 25, 2011 at 05:42:01PM -0700, Randy Dunlap wrote: >>> On 10/25/11 02:36, Stephen Rothwell wrote: >>>> Hi all, >>> >>> >>> When CONFIG_NET is not enabl

Re: linux-next: Tree for Oct 25 (crypto)

2011-10-25 Thread Randy Dunlap
On 10/25/11 02:36, Stephen Rothwell wrote: > Hi all, When CONFIG_NET is not enabled: ERROR: "nla_put" [crypto/rng.ko] undefined! ERROR: "nla_put" [crypto/pcompress.ko] undefined! ERROR: "netlink_kernel_release" [crypto/crypto_user.ko] undefined! ERROR: "netlink_kernel_create" [crypto/crypto_user

[PATCH -next] crypto: fix aesni build on i386

2011-05-17 Thread Randy Dunlap
From: Randy Dunlap Fix build error on i386 by moving function prototypes: arch/x86/crypto/aesni-intel_glue.c: In function 'aesni_init': arch/x86/crypto/aesni-intel_glue.c:1263: error: implicit declaration of function 'crypto_fpu_init' arch/x86/crypto/aesni-intel_glue.c: In

[PATCH -next] crypto: fix af_alg memory_allocated data type

2010-12-16 Thread Randy Dunlap
From: Randy Dunlap Change data type to fix warning: crypto/af_alg.c:35: warning: initialization from incompatible pointer type Signed-off-by: Randy Dunlap --- crypto/af_alg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20101216.orig/crypto/af_alg.c +++ linux-next

[PATCH] crypto: ghash-clmulni-intel_glue needs err.h

2010-12-14 Thread Randy Dunlap
From: Randy Dunlap Add missing header file: arch/x86/crypto/ghash-clmulni-intel_glue.c:256: error: implicit declaration of function 'IS_ERR' arch/x86/crypto/ghash-clmulni-intel_glue.c:257: error: implicit declaration of function 'PTR_ERR' Signed-off-by: Randy Dunlap

Re: linux-next: Tree for November 29 (aesni-intel)

2010-11-29 Thread Randy Dunlap
On 11/29/10 12:21, Mathias Krause wrote: > On 29.11.2010, 21:11 Randy Dunlap wrote: >> On 11/29/10 12:02, Mathias Krause wrote: >>> On 29.11.2010, 20:54 Randy Dunlap wrote: >>>> On 11/29/10 11:45, Mathias Krause wrote: >>>>> On 29.11.2010, 20:31

  1   2   >