Re: [PATCH] X.509: fix comparisons of ->pkey_algo

2017-11-28 Thread David Howells
Eric Biggers wrote: > if (strcmp(x509->pub->pkey_algo, sinfo->sig->pkey_algo)) Can you make this strcmp(...) != 0? I know it may seem picky, but checking strcmp() in this way kind of inverts the true/false thing. Thanks, David

Re: [PATCH] X.509: fix comparisons of ->pkey_algo

2017-11-27 Thread James Morris
On Sun, 26 Nov 2017, Eric Biggers wrote: > From: Eric Biggers > > ->pkey_algo used to be an enum, but was changed to a string by commit > 4e8ae72a75aa ("X.509: Make algo identifiers text instead of enum"). But > two comparisons were not updated. Fix them to use strcmp().

[PATCH] X.509: fix comparisons of ->pkey_algo

2017-11-26 Thread Eric Biggers
From: Eric Biggers ->pkey_algo used to be an enum, but was changed to a string by commit 4e8ae72a75aa ("X.509: Make algo identifiers text instead of enum"). But two comparisons were not updated. Fix them to use strcmp(). This bug broke signature verification in certain