Re: [PATCH] lz4: fix performance regressions

2017-02-14 Thread Sven Schmidt
Hey Eric, On Sun, Feb 12, 2017 at 03:38:02PM -0800, Eric Biggers wrote: > Hi Sven, > > On Sun, Feb 12, 2017 at 12:16:18PM +0100, Sven Schmidt wrote: > > /*- > > * Reading and writing into memory > > **/ > > +typedef

Re: [PATCH] lz4: fix performance regressions

2017-02-13 Thread Willy Tarreau
On Mon, Feb 13, 2017 at 12:53:49PM +0100, Sven Schmidt wrote: > On Sun, Feb 12, 2017 at 10:41:17PM +0100, Willy Tarreau wrote: > > On Sun, Feb 12, 2017 at 04:20:00PM +0100, Sven Schmidt wrote: > > > On Sun, Feb 12, 2017 at 02:05:08PM +0100, Willy Tarreau wrote: > > > > Hi Sven, > > > > > > > > On

Re: [PATCH] lz4: fix performance regressions

2017-02-13 Thread Sven Schmidt
On Sun, Feb 12, 2017 at 10:41:17PM +0100, Willy Tarreau wrote: > On Sun, Feb 12, 2017 at 04:20:00PM +0100, Sven Schmidt wrote: > > On Sun, Feb 12, 2017 at 02:05:08PM +0100, Willy Tarreau wrote: > > > Hi Sven, > > > > > > On Sun, Feb 12, 2017 at 12:16:18PM +0100, Sven Schmidt wrote: > > > > Fix

Re: [PATCH] lz4: fix performance regressions

2017-02-12 Thread Eric Biggers
Hi Sven, On Sun, Feb 12, 2017 at 12:16:18PM +0100, Sven Schmidt wrote: > /*- > * Reading and writing into memory > **/ > +typedef union { > + U16 u16; > + U32 u32; > + size_t uArch; > +} __packed unalign; >

Re: [PATCH] lz4: fix performance regressions

2017-02-12 Thread Willy Tarreau
On Sun, Feb 12, 2017 at 04:20:00PM +0100, Sven Schmidt wrote: > On Sun, Feb 12, 2017 at 02:05:08PM +0100, Willy Tarreau wrote: > > Hi Sven, > > > > On Sun, Feb 12, 2017 at 12:16:18PM +0100, Sven Schmidt wrote: > > > Fix performance regressions compared to current kernel LZ4 > > > > Your patch

Re: [PATCH] lz4: fix performance regressions

2017-02-12 Thread Sven Schmidt
On Sun, Feb 12, 2017 at 02:05:08PM +0100, Willy Tarreau wrote: > Hi Sven, > > On Sun, Feb 12, 2017 at 12:16:18PM +0100, Sven Schmidt wrote: > > Fix performance regressions compared to current kernel LZ4 > > Your patch contains mostly style cleanups which certainly are welcome > but make the

Re: [PATCH] lz4: fix performance regressions

2017-02-12 Thread Willy Tarreau
Hi Sven, On Sun, Feb 12, 2017 at 12:16:18PM +0100, Sven Schmidt wrote: > Fix performance regressions compared to current kernel LZ4 Your patch contains mostly style cleanups which certainly are welcome but make the whole patch hard to review. These cleanups would have been better into a

[PATCH] lz4: fix performance regressions

2017-02-12 Thread Sven Schmidt
Fix performance regressions compared to current kernel LZ4 Signed-off-by: Sven Schmidt <4ssch...@informatik.uni-hamburg.de> --- include/linux/lz4.h | 2 +- lib/lz4/lz4_compress.c | 157 +++- lib/lz4/lz4_decompress.c | 50 lib/lz4/lz4defs.h