Re: [PATCH 1/4] ASN.1: Fix handling of CHOICE in ASN.1 compiler

2015-08-06 Thread David Howells
James Morris jmor...@namei.org wrote: It's pretty late in the -rc cycle. If you'd rather just pull the patches into your next tree, and wait for the next merge window, I'm okay with this. I've rebased my asn1-fixes branch on your next branch and created a new tag there:

[PATCH 1/4] ASN.1: Fix handling of CHOICE in ASN.1 compiler

2015-08-05 Thread David Howells
Fix the handling of CHOICE types in the ASN.1 compiler to make SEQUENCE and SET elements in a CHOICE be correctly rendered as skippable and conditional as appropriate. For example, in the following ASN.1: Foo ::= SEQUENCE { w1 INTEGER, w2 Bar, w3 OBJECT IDENTIFIER } Bar ::=

Re: [PATCH 1/4] ASN.1: Fix handling of CHOICE in ASN.1 compiler

2015-08-05 Thread David Howells
James Morris jmor...@namei.org wrote: What are the security implications of these bugs? I've fed them various bits of butchered ASN.1 and observed the effects as well as checking what happens in the code. I don't think there are any security implications. I've outlined my reasoning in each

Re: [PATCH 1/4] ASN.1: Fix handling of CHOICE in ASN.1 compiler

2015-08-05 Thread James Morris
On Wed, 5 Aug 2015, David Howells wrote: Fix the handling of CHOICE types in the ASN.1 compiler to make SEQUENCE and SET elements in a CHOICE be correctly rendered as skippable and conditional as appropriate. What are the security implications of these bugs? It's pretty late in the -rc