[v4 PATCH 2/8] crypto: rsa - Generate fixed-length output

2016-06-29 Thread Herbert Xu
Every implementation of RSA that we have naturally generates output with leading zeroes. The one and only user of RSA, pkcs1pad wants to have those leading zeroes in place, in fact because they are currently absent it has to write those zeroes itself. So we shouldn't be stripping leading zeroes

Re: [v3 PATCH 2/8] crypto: rsa - Generate fixed-length output

2016-06-29 Thread Herbert Xu
On Wed, Jun 29, 2016 at 11:23:06AM +, Benedetto, Salvatore wrote: > Hi Herbert, > > > > > This patch also changes DH to use the new interface. > > > > Signed-off-by: Herbert Xu > > --- > > > > crypto/rsa.c|8 +++ > > include/linux/mpi.h |2

RE: [v3 PATCH 2/8] crypto: rsa - Generate fixed-length output

2016-06-29 Thread Benedetto, Salvatore
Hi Herbert, > > This patch also changes DH to use the new interface. > > Signed-off-by: Herbert Xu > --- > > crypto/rsa.c|8 +++ > include/linux/mpi.h |2 - > lib/mpi/mpicoder.c | 55 --- > - >

[v3 PATCH 2/8] crypto: rsa - Generate fixed-length output

2016-06-29 Thread Herbert Xu
Every implementation of RSA that we have naturally generates output with leading zeroes. The one and only user of RSA, pkcs1pad wants to have those leading zeroes in place, in fact because they are currently absent it has to write those zeroes itself. So we shouldn't be stripping leading zeroes

[PATCH 2/8] crypto: rsa - Generate fixed-length output

2016-06-22 Thread Herbert Xu
Every implementation of RSA that we have naturally generates output with leading zeroes. The one and only user of RSA, pkcs1pad wants to have those leading zeroes in place, in fact because they are currently absent it has to write those zeroes itself. So we shouldn't be stripping leading zeroes