Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-07-04 Thread Dan Carpenter
On Sat, Jun 28, 2014 at 08:53:19PM -0700, Joe Perches wrote: On Sun, 2014-06-29 at 05:46 +0200, Stephan Mueller wrote: Am Sonntag, 29. Juni 2014, 12:24:02 schrieb Stephen Rothwell: Hi Stephen, Hi Stephan, On Sat, 28 Jun 2014 22:01:46 +0200 Stephan Mueller smuel...@chronox.de

Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-07-04 Thread Joe Perches
On Fri, 2014-07-04 at 14:21 +0300, Dan Carpenter wrote: On Sat, Jun 28, 2014 at 08:53:19PM -0700, Joe Perches wrote: On Sun, 2014-06-29 at 05:46 +0200, Stephan Mueller wrote: Am Sonntag, 29. Juni 2014, 12:24:02 schrieb Stephen Rothwell: Hi Stephen, Hi Stephan, On Sat,

Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-07-04 Thread Stephan Mueller
Am Freitag, 4. Juli 2014, 09:57:20 schrieb Joe Perches: Hi Joe, On Fri, 2014-07-04 at 14:21 +0300, Dan Carpenter wrote: On Sat, Jun 28, 2014 at 08:53:19PM -0700, Joe Perches wrote: On Sun, 2014-06-29 at 05:46 +0200, Stephan Mueller wrote: Am Sonntag, 29. Juni 2014, 12:24:02 schrieb

Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-07-04 Thread Joe Perches
On Sat, 2014-07-05 at 01:57 +0200, Stephan Mueller wrote: And I also get the same output. Yet I am not sure how that code can be compared to the code in the kernel. What that code shows is that the ARRAY_SIZE type is size_t. The difference is ARRAY_SIZE in the kernel should be output with

Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-07-04 Thread Stephan Mueller
Am Freitag, 4. Juli 2014, 17:09:33 schrieb Joe Perches: Hi Joe, On Sat, 2014-07-05 at 01:57 +0200, Stephan Mueller wrote: And I also get the same output. Yet I am not sure how that code can be compared to the code in the kernel. What that code shows is that the ARRAY_SIZE type is

Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-07-04 Thread Joe Perches
On Sat, 2014-07-05 at 02:15 +0200, Stephan Mueller wrote: Am Freitag, 4. Juli 2014, 17:09:33 schrieb Joe Perches: On Sat, 2014-07-05 at 01:57 +0200, Stephan Mueller wrote: And I also get the same output. Yet I am not sure how that code can be compared to the code in the kernel. What

Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-07-04 Thread Stephan Mueller
Am Freitag, 4. Juli 2014, 17:24:09 schrieb Joe Perches: Hi Joe, On Sat, 2014-07-05 at 02:15 +0200, Stephan Mueller wrote: Am Freitag, 4. Juli 2014, 17:09:33 schrieb Joe Perches: On Sat, 2014-07-05 at 01:57 +0200, Stephan Mueller wrote: And I also get the same output. Yet I am not sure

[PATCH 3/4] DRBG: Fix format string for debugging statements

2014-06-28 Thread Stephan Mueller
The initial format strings caused warnings on several architectures. The updated format strings now match the variable types. Reported-by: kbuild test robot fengguang...@intel.com Reported-by: Randy Dunlap rdun...@infradead.org Signed-off-by: Stephan Mueller smuel...@chronox.de --- crypto/drbg.c

Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-06-28 Thread Stephen Rothwell
Hi Stephan, On Sat, 28 Jun 2014 22:01:46 +0200 Stephan Mueller smuel...@chronox.de wrote: @@ -1987,8 +1987,9 @@ static int __init drbg_init(void) if (ARRAY_SIZE(drbg_cores) * 2 ARRAY_SIZE(drbg_algs)) { pr_info(DRBG: Cannot register all DRBG types -

Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-06-28 Thread Stephan Mueller
Am Sonntag, 29. Juni 2014, 12:24:02 schrieb Stephen Rothwell: Hi Stephen, Hi Stephan, On Sat, 28 Jun 2014 22:01:46 +0200 Stephan Mueller smuel...@chronox.de wrote: @@ -1987,8 +1987,9 @@ static int __init drbg_init(void) if (ARRAY_SIZE(drbg_cores) * 2 ARRAY_SIZE(drbg_algs)) {

Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-06-28 Thread Joe Perches
On Sun, 2014-06-29 at 05:46 +0200, Stephan Mueller wrote: Am Sonntag, 29. Juni 2014, 12:24:02 schrieb Stephen Rothwell: Hi Stephen, Hi Stephan, On Sat, 28 Jun 2014 22:01:46 +0200 Stephan Mueller smuel...@chronox.de wrote: @@ -1987,8 +1987,9 @@ static int __init drbg_init(void)

Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

2014-06-28 Thread Stephan Mueller
Am Samstag, 28. Juni 2014, 20:53:19 schrieb Joe Perches: Hi Joe, On Sun, 2014-06-29 at 05:46 +0200, Stephan Mueller wrote: Am Sonntag, 29. Juni 2014, 12:24:02 schrieb Stephen Rothwell: Hi Stephen, Hi Stephan, On Sat, 28 Jun 2014 22:01:46 +0200 Stephan Mueller