Re: [PATCH crypto-2.6] lib: make memzero_explicit more robust against dead store elimination

2015-04-30 Thread mancha security
On Thu, Apr 30, 2015 at 01:43:07AM +0200, Daniel Borkmann wrote: On 04/29/2015 04:54 PM, mancha security wrote: On Wed, Apr 29, 2015 at 04:01:19PM +0200, Daniel Borkmann wrote: On 04/29/2015 03:08 PM, mancha security wrote: ... By the way, has anyone been able to verify that __memory_barrier

Re: [PATCH crypto-2.6] lib: make memzero_explicit more robust against dead store elimination

2015-04-29 Thread mancha security
Hi Daniel et al. Looks good from here. By the way, has anyone been able to verify that __memory_barrier provides DSE protection under various optimizations? Unfortunately, I don't have ready access to ICC at the moment or I'd test it myself. --mancha PS It would be nice if memset_s were

Re: [PATCH crypto-2.6] lib: make memzero_explicit more robust against dead store elimination

2015-04-29 Thread mancha security
On Wed, Apr 29, 2015 at 04:01:19PM +0200, Daniel Borkmann wrote: On 04/29/2015 03:08 PM, mancha security wrote: ... By the way, has anyone been able to verify that __memory_barrier provides DSE protection under various optimizations? Unfortunately, I don't have ready access to ICC at the

Re: [PATCH crypto-2.6] lib: make memzero_explicit more robust against dead store elimination

2015-04-28 Thread Stephan Mueller
Am Dienstag, 28. April 2015, 17:22:20 schrieb Daniel Borkmann: Hi Daniel, In commit 0b053c951829 (lib: memzero_explicit: use barrier instead of OPTIMIZER_HIDE_VAR), we made memzero_explicit() more robust in case LTO would decide to inline memzero_explicit() and eventually find out it could be

[PATCH crypto-2.6] lib: make memzero_explicit more robust against dead store elimination

2015-04-28 Thread Daniel Borkmann
In commit 0b053c951829 (lib: memzero_explicit: use barrier instead of OPTIMIZER_HIDE_VAR), we made memzero_explicit() more robust in case LTO would decide to inline memzero_explicit() and eventually find out it could be elimiated as dead store. While using barrier() works well for the case of