Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-11-16 Thread Maxime Ripard
On Thu, Nov 06, 2014 at 10:32:18PM +0800, Herbert Xu wrote: On Thu, Nov 06, 2014 at 03:26:33PM +0100, Maxime Ripard wrote: But you still haven't explain why the driver, while it doesn't handle the user space buffer at any time, should be worried that the data the framework has given him

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-11-06 Thread Herbert Xu
On Sun, Oct 19, 2014 at 04:16:22PM +0200, LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that support AES/MD5/SHA1/DES/3DES/PRNG algorithms. Signed-off-by: LABBE Corentin

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-11-06 Thread Maxime Ripard
On Mon, Nov 03, 2014 at 06:35:28PM +0800, Herbert Xu wrote: On Mon, Nov 03, 2014 at 10:34:46AM +0100, Maxime Ripard wrote: What I mean is that since you are saying that drivers should do the kmap themselves, then *all* of the drivers are broken if they are not using it. And all of them are

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-11-06 Thread Herbert Xu
On Thu, Nov 06, 2014 at 03:26:33PM +0100, Maxime Ripard wrote: But you still haven't explain why the driver, while it doesn't handle the user space buffer at any time, should be worried that the data the framework has given him are actually mapped. Encryption is used by IPsec and SKBs can be

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-11-03 Thread Maxime Ripard
On Fri, Oct 31, 2014 at 06:05:22PM +0800, Herbert Xu wrote: On Fri, Oct 31, 2014 at 10:57:06AM +0100, Maxime Ripard wrote: On a 3.18-rc2 kernel: $ git grep kmap -- crypto/ crypto/ahash.c: walk-data = kmap(walk-pg); crypto/ahash.c:

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-11-03 Thread Herbert Xu
On Mon, Nov 03, 2014 at 10:34:46AM +0100, Maxime Ripard wrote: What I mean is that since you are saying that drivers should do the kmap themselves, then *all* of the drivers are broken if they are not using it. And all of them are missing this kmap. kmap is used by the software implementations

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-31 Thread Herbert Xu
On Thu, Oct 30, 2014 at 06:19:33PM +0100, Maxime Ripard wrote: With AF_ALG and cryptodev, the SG is in highmem. Verified with some PageHighMem(). Then fix AF_ALG and cryptodev, because all of the other drivers might be affected. No it's the driver that needs to be fixed. Of course if

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-31 Thread Herbert Xu
On Fri, Oct 31, 2014 at 09:13:23AM +0100, Maxime Ripard wrote: I don't understand here. Why would other drivers *not* being affected? If the scatter list passed by AF_ALG can be in highmem, I guess it's the case for every driver out there. Almost every kernel code I've seen so far makes the

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-31 Thread Maxime Ripard
On Fri, Oct 31, 2014 at 04:18:03PM +0800, Herbert Xu wrote: On Fri, Oct 31, 2014 at 09:13:23AM +0100, Maxime Ripard wrote: I don't understand here. Why would other drivers *not* being affected? If the scatter list passed by AF_ALG can be in highmem, I guess it's the case for every

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-31 Thread Herbert Xu
On Fri, Oct 31, 2014 at 10:57:06AM +0100, Maxime Ripard wrote: On a 3.18-rc2 kernel: $ git grep kmap -- crypto/ crypto/ahash.c: walk-data = kmap(walk-pg); crypto/ahash.c: walk-data = kmap_atomic(walk-pg); crypto/async_tx/async_memcpy.c:

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-30 Thread Maxime Ripard
On Fri, Oct 24, 2014 at 08:52:26PM +0200, Corentin LABBE wrote: On 10/21/14 21:11, Maxime Ripard wrote: Hi Corentin, Thanks for resending it. On Sun, Oct 19, 2014 at 04:16:22PM +0200, LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The

Re: [linux-sunxi] Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-24 Thread Corentin LABBE
Le 22/10/2014 11:00, Arnd Bergmann a écrit : On Sunday 19 October 2014 16:16:22 LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that support AES/MD5/SHA1/DES/3DES/PRNG algorithms.

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-24 Thread Corentin LABBE
On 10/21/14 21:11, Maxime Ripard wrote: Hi Corentin, Thanks for resending it. On Sun, Oct 19, 2014 at 04:16:22PM +0200, LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that support

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-22 Thread Arnd Bergmann
On Sunday 19 October 2014 16:16:22 LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that support AES/MD5/SHA1/DES/3DES/PRNG algorithms. Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-21 Thread Corentin LABBE
On 10/21/14 01:28, Vladimir Zapolskiy wrote: Hello LABBE, On 19.10.2014 17:16, LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that support AES/MD5/SHA1/DES/3DES/PRNG algorithms. [] + +

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-21 Thread Corentin LABBE
Le 21/10/2014 01:52, Joe Perches a écrit : On Tue, 2014-10-21 at 02:28 +0300, Vladimir Zapolskiy wrote: On 19.10.2014 17:16, LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that support

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-21 Thread Vladimir Zapolskiy
Hi Corentin, On 21.10.2014 19:25, Corentin LABBE wrote: On 10/21/14 01:28, Vladimir Zapolskiy wrote: Hello LABBE, On 19.10.2014 17:16, LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-21 Thread Maxime Ripard
Hi Corentin, Thanks for resending it. On Sun, Oct 19, 2014 at 04:16:22PM +0200, LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that support AES/MD5/SHA1/DES/3DES/PRNG algorithms.

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-20 Thread Vladimir Zapolskiy
Hello LABBE, On 19.10.2014 17:16, LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that support AES/MD5/SHA1/DES/3DES/PRNG algorithms. Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-10-20 Thread Joe Perches
On Tue, 2014-10-21 at 02:28 +0300, Vladimir Zapolskiy wrote: On 19.10.2014 17:16, LABBE Corentin wrote: Add support for the Security System included in Allwinner SoC A20. The Security System is a hardware cryptographic accelerator that support AES/MD5/SHA1/DES/3DES/PRNG algorithms. []