Re: [RFC] how to handle AAD copy operation for algif_aead

2017-03-09 Thread Stephan Müller
Am Donnerstag, 9. März 2017, 11:23:16 CET schrieb Herbert Xu: Hi Herbert, > I see. Yes that looks good. Thank you. I will provide an official patch after the discussion about the memory handling is completed. As the memory handling patch should be considered for stable whereas the AAD copy

Re: [RFC] how to handle AAD copy operation for algif_aead

2017-03-09 Thread Herbert Xu
On Thu, Mar 09, 2017 at 11:08:32AM +0100, Stephan Müller wrote: > > This is the first patch (0001-crypto-algif_aead-copy-AAD-from-src-to- > dst_separate.patch). > > The second alternative patch (0001-crypto-algif_aead-copy-AAD-from-src-to- > dst_inplace.patch) does: I see. Yes that looks good.

Re: [RFC] how to handle AAD copy operation for algif_aead

2017-03-09 Thread Stephan Müller
Am Donnerstag, 9. März 2017, 11:05:54 CET schrieb Herbert Xu: Hi Herbert, > On Thu, Mar 09, 2017 at 11:02:41AM +0100, Stephan Müller wrote: > > > > The patch > > > > 0001-crypto-algif_aead-copy-AAD-from-src-to-dst_separate.patch > > > > simply copies the AAD over from TX SGL to RX SGL. The pro

Re: [RFC] how to handle AAD copy operation for algif_aead

2017-03-09 Thread Herbert Xu
On Thu, Mar 09, 2017 at 11:02:41AM +0100, Stephan Müller wrote: > > > > The patch 0001-crypto-algif_aead-copy-AAD-from-src-to-dst_separate.patch > > > simply copies the AAD over from TX SGL to RX SGL. The pro is that the > > > patch is small. The con is that this approach does *not* provide an > >

Re: [RFC] how to handle AAD copy operation for algif_aead

2017-03-09 Thread Stephan Müller
Am Donnerstag, 9. März 2017, 11:00:11 CET schrieb Herbert Xu: Hi Herbert, > On Fri, Feb 24, 2017 at 02:24:47PM +0100, Stephan Müller wrote: > > Hi Herbert et al, > > > > attached are two patches where each patch has a different approach to copy > > the AAD in the algif_aead operation. I would

Re: [RFC] how to handle AAD copy operation for algif_aead

2017-03-09 Thread Herbert Xu
On Fri, Feb 24, 2017 at 02:24:47PM +0100, Stephan Müller wrote: > Hi Herbert et al, > > attached are two patches where each patch has a different approach to copy > the > AAD in the algif_aead operation. I would like to hear your opinion which > approach should be taken. > > The patch

[RFC] how to handle AAD copy operation for algif_aead

2017-02-24 Thread Stephan Müller
Hi Herbert et al, attached are two patches where each patch has a different approach to copy the AAD in the algif_aead operation. I would like to hear your opinion which approach should be taken. The patch 0001-crypto-algif_aead-copy-AAD-from-src-to-dst_separate.patch simply copies the AAD