Re: [patch] crypto: nx - off by one bug in nx_of_update_msc()

2016-07-18 Thread Herbert Xu
On Fri, Jul 15, 2016 at 02:09:13PM +0300, Dan Carpenter wrote: > The props->ap[] array is defined like this: > > struct alg_props ap[NX_MAX_FC][NX_MAX_MODE][3]; > > So we can see that if msc->fc and msc->mode are == to NX_MAX_FC or > NX_MAX_MODE then we're off by one. > > Fixes:

[patch] crypto: nx - off by one bug in nx_of_update_msc()

2016-07-15 Thread Dan Carpenter
The props->ap[] array is defined like this: struct alg_props ap[NX_MAX_FC][NX_MAX_MODE][3]; So we can see that if msc->fc and msc->mode are == to NX_MAX_FC or NX_MAX_MODE then we're off by one. Fixes: ae0222b7289d ('powerpc/crypto: nx driver code supporting nx encryption')