RE: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-05 Thread Ronen Shitrit
-Original Message- From: Evgeniy Polyakov [mailto:[EMAIL PROTECTED] Sent: Sunday, September 04, 2005 11:52 PM To: Ronen Shitrit Cc: [EMAIL PROTECTED]; linux-crypto@vger.kernel.org Subject: Re: [ACRYPTO] dm-crypt ported to acrypto. On Sun, Sep 04, 2005 at 11:27:24PM +0300, Ronen Shitrit ([EMAIL

RE: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Ronen Shitrit
Hi Nice job, (horoshaya rabota) Just two issue: -I saw this patch is using a global variable which counts the number pending requests: dm_async_pending. I think that this variable should be allocated per dm_crypt session, i.e for each crypt_config, since there can be more then 2 consumers

Re: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Evgeniy Polyakov
On Sun, Sep 04, 2005 at 03:51:57PM +0300, Ronen Shitrit ([EMAIL PROTECTED]) wrote: Hi Hello, Ronen. Nice job, (horoshaya rabota) :) thank you. Just two issue: -I saw this patch is using a global variable which counts the number pending requests: dm_async_pending. I think that this

Re: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Evgeniy Polyakov
On Sun, Sep 04, 2005 at 10:41:02PM +0300, Ronen Shitrit ([EMAIL PROTECTED]) wrote: Hi What do you think about the second remark?? -I think that we might have a problem if a write operation will be processed in parallel to a read operation, the read might wait for the write to

RE: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Ronen Shitrit
-crypto@vger.kernel.org Subject: Re: [ACRYPTO] dm-crypt ported to acrypto. On Sun, Sep 04, 2005 at 10:41:02PM +0300, Ronen Shitrit ([EMAIL PROTECTED]) wrote: Hi What do you think about the second remark?? -I think that we might have a problem if a write operation will be processed

Re: [ACRYPTO] dm-crypt ported to acrypto.

2005-09-04 Thread Evgeniy Polyakov
On Sun, Sep 04, 2005 at 11:27:24PM +0300, Ronen Shitrit ([EMAIL PROTECTED]) wrote: Hi I already ported this patch to the OCF, and I'm using it over the OCF. I also don't see any issue with small partitions?? The crypt_convert API is called from 2 different places in the code: 1. For