RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-11 Thread James Hartley
Hi Andrew, -Original Message- From: abres...@google.com [mailto:abres...@google.com] On Behalf Of Andrew Bresticker Sent: 10 March 2015 18:02 To: James Hartley Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread James Hartley
...@vger.kernel.org Subject: Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator On Mon, Mar 09, 2015 at 07:35:57AM +0100, Stephan Mueller wrote: +static struct ahash_alg img_algs[] = { + { + .init = img_hash_init, + .update = img_hash_update

Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread Herbert Xu
On Mon, Mar 09, 2015 at 07:35:57AM +0100, Stephan Mueller wrote: +static struct ahash_alg img_algs[] = { +{ +.init = img_hash_init, +.update = img_hash_update, +.final = img_hash_final, +.finup = img_hash_finup, +.digest =

Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread Herbert Xu
On Tue, Mar 10, 2015 at 09:54:49AM +, James Hartley wrote: Hi Herbert, and Stephan, The difficulty here is that the driver was written by a summer placement student who has since left the company, and despite searching our internal commit logs I'm unable to find any reason why 301

RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread James Hartley
; Ezequiel Garcia; linux-crypto@vger.kernel.org Subject: RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator -Original Message- From: Herbert Xu [mailto:herb...@gondor.apana.org.au] Sent: 10 March 2015 09:37 To: Stephan Mueller Cc: James Hartley; robh

RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread James Hartley
; Andrew Bresticker (abres...@chromium.org); Ezequiel Garcia; linux-crypto@vger.kernel.org Subject: Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator On Tue, Mar 10, 2015 at 09:54:49AM +, James Hartley wrote: Hi Herbert, and Stephan, The difficulty here

Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread Andrew Bresticker
Hi James, +static irqreturn_t img_irq_handler(int irq, void *dev_id) { + struct img_hash_dev *hdev = dev_id; + u32 reg; + + reg = img_hash_read(hdev, CR_INTSTAT); + img_hash_write(hdev, CR_INTCLEAR, reg); + + if (reg CR_INT_NEW_RESULTS_SET) { +

RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread James Hartley
Hi Andrew -Original Message- From: abres...@google.com [mailto:abres...@google.com] On Behalf Of Andrew Bresticker Sent: 09 March 2015 05:42 To: James Hartley Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-09 Thread Stephan Mueller
Am Freitag, 6. März 2015, 02:58:26 schrieb James Hartley: Hi James, This adds support for the Imagination Technologies hash accelerator which provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes. Signed-off-by: James Hartley james.hart...@imgtec.com --- drivers/crypto/Kconfig

Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-08 Thread Andrew Bresticker
Hi James, On Thu, Mar 5, 2015 at 7:01 PM, James Hartley james.hart...@imgtec.com wrote: This adds support for the Imagination Technologies hash accelerator which provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes. Signed-off-by: James Hartley james.hart...@imgtec.com Some