Re: [PATCH] hw_random: Include device.h instead of declaring struct device

2017-10-30 Thread PrasannaKumar Muralidharan
Hi Herbert, On 30 October 2017 at 12:22, Herbert Xu wrote: > On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote: >> Include linux/device.h instead of declaring struct device. >> >> Signed-off-by: PrasannaKumar Muralidharan

Re: [PATCH] hw_random: Include device.h instead of declaring struct device

2017-10-30 Thread Herbert Xu
On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote: > Include linux/device.h instead of declaring struct device. > > Signed-off-by: PrasannaKumar Muralidharan Nack. We should not include a header file when a simple forward declaration is