Re: [PATCH 2/7] crypto: add blkcipher implementation of ARC4

2010-04-05 Thread Herbert Xu
On Sat, Apr 03, 2010 at 09:49:24AM +0200, Sebastian Andrzej Siewior wrote: +#include crypto/arc4.h This file doesn't seem to exist in the kernel tree or your patch-set? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au Home Page:

[PATCH v2] crypto: add blkcipher implementation of ARC4

2010-04-05 Thread Sebastian Andrzej Siewior
This is a pure blkcipher implementation of ARC4. The internal state is saved within an IV which is supplied by the user. The goal is that the cipher does not change its internal state now, only the iv changes during encryption. Signed-off-by: Sebastian Andrzej Siewior sebast...@breakpoint.cc ---

Re: [PATCH 4/7] net/wireless: switch lib80211_crypt_tkip from arc4 to arc4blk

2010-04-05 Thread John W. Linville
On Sat, Apr 03, 2010 at 09:49:26AM +0200, Sebastian Andrzej Siewior wrote: ecb(arc4) is getting replaced by arc4 which is a blkcipher by itself. The required selects are now pulled in by LIB80211_CRYPT_TKIP instead of selecting it by every driver. Signed-off-by: Sebastian Andrzej Siewior

Re: [PATCH 6/7] net/mac80211: convert wep from arc4 to arc4blk

2010-04-05 Thread John W. Linville
On Sat, Apr 03, 2010 at 09:49:28AM +0200, Sebastian Andrzej Siewior wrote: ecb(arc4) is getting replaced by arc4 which is a blkcipher by itself. Signed-off-by: Sebastian Andrzej Siewior sebast...@breakpoint.cc Seems ok to me... John -- John W. LinvilleSomeday the world will

Re: Convert arc4 from a cipher into a block cipher

2010-04-05 Thread Pavel Roskin
On Sat, 2010-04-03 at 09:49 +0200, Sebastian Andrzej Siewior wrote: This patch series converts arc4 into a block cipher and converts all its users (except those in staging) to use it. The first two patches ensure that two implementations can coexist, the following patches convert each user so

Re: Convert arc4 from a cipher into a block cipher

2010-04-05 Thread Herbert Xu
On Mon, Apr 05, 2010 at 04:33:45PM -0400, Pavel Roskin wrote: Are you trying to speed up arc4? Or you want to simplify the code? Or maybe you are trying to make arc4 unsuitable for anything other than WEP and TKIP? The later should be fine, actually, considering the known security issues.