RE: [PATCH] crypto: remove unnecessary includes
From what I could see there is nothing from those includes that is used inside authenc.c. The build passes without them. Cristian S. diff --git a/crypto/authenc.c b/crypto/authenc.c index 1875e70..7d4bfaa 100644 --- a/crypto/authenc.c +++ b/crypto/authenc.c @@ -17,11 +17,8 @@ #include crypto/scatterwalk.h #include linux/err.h #include linux/init.h -#include linux/kernel.h #include linux/module.h #include linux/rtnetlink.h -#include linux/slab.h -#include linux/spinlock.h typedef u8 *(*authenc_ahash_t)(struct aead_request *req, unsigned int flags); Why are these includes unnecessary? -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST
Shawn, Am Freitag, 29. November 2013, 06:47:04 schrieb Hannes Frederic Sowa: On Sun, Nov 24, 2013 at 10:36:28PM -0800, Shawn Landden wrote: Commit 35f9c09fe (tcp: tcp_sendpages() should call tcp_push() once) added an internal flag MSG_SENDPAGE_NOTLAST, similar to MSG_MORE. algif_hash, algif_skcipher, and udp used MSG_MORE from tcp_sendpages() and need to see the new flag as identical to MSG_MORE. This fixes sendfile() on AF_ALG. v3: also fix udp The UDP bits look fine to me. please don't forget to resend the patch (only the UDP fix). I sent the AF_ALG part already. Thanks, //richard -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] s390/crypto: fix aes ctr concurrency issue
On Fri, 2013-11-29 at 09:50 +0800, Herbert Xu wrote: On Thu, Nov 28, 2013 at 04:39:43PM +0100, Harald Freudenberger wrote: You can't use mutex_lock because you may be in a non-sleepable context. Perhaps just fall back to doing it block-by-block, like we do in aesni-intel on x86? The first attempt to lock the mutex is done with mutex_trylock() which should be safe for non-sleepable context. If this fails, an attempt is made to allocate a fresh page __get_free_page(GFP_ATOMIC). If this also fails, well what could be done then ? I think, it is valid to wait for the preallocated page to get released with an mutex_lock(). Should I really add code here for handling the 3rd level of the exceptional path ? If it's wrong per se, how does hiding it behind two if's make it OK? Sorry, I got the point now. Will do a rework of the patch according to your hints. Thanks -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] crypto: remove unnecessary includes
On Fri, Nov 29, 2013 at 08:49:42AM +, Cristian Stoica wrote: From what I could see there is nothing from those includes that is used inside authenc.c. The build passes without them. Just because it compiles it doesn't meant that the files you removed are unnecessary. The only file that is really unnecessary here is spinlock.h. [] OK then, but let's reverse the question. In a construct similar to authenc.c, what would be the purpose of slab.h and kernel.h? (That leads to the next question which is - what is the purpose of those files in authenc.c?) Thanks, Cristian S. -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST
From: Shawn Landden sh...@churchofgit.com Date: Sun, 24 Nov 2013 22:36:28 -0800 Commit 35f9c09fe (tcp: tcp_sendpages() should call tcp_push() once) added an internal flag MSG_SENDPAGE_NOTLAST, similar to MSG_MORE. algif_hash, algif_skcipher, and udp used MSG_MORE from tcp_sendpages() and need to see the new flag as identical to MSG_MORE. This fixes sendfile() on AF_ALG. v3: also fix udp Cc: Tom Herbert therb...@google.com Cc: Eric Dumazet eric.duma...@gmail.com Cc: David S. Miller da...@davemloft.net Cc: sta...@vger.kernel.org # 3.4.x + 3.2.x Reported-and-tested-by: Shawn Landden shawnland...@gmail.com Original-patch: Richard Weinberger rich...@nod.at Signed-off-by: Shawn Landden sh...@churchofgit.com Applied and queued up for -stable, thanks everyone. -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
