Re: [PATCH 1/3] Documentation: devicetree: add Freescale SCC bindings

2016-02-16 Thread Steffen Trumtrar
Hi! Shawn Guo writes: > On Thu, Feb 11, 2016 at 03:04:43PM +0100, Steffen Trumtrar wrote: >> Add documentation for the Freescale Security Controller (SCC) >> found on i.MX25 SoCs. >> >> Signed-off-by: Steffen Trumtrar >> --- >>

[PATCH 4/4] Documentation: crypto - add skcipher API documentation

2016-02-16 Thread Stephan Mueller
The crypto API received the skcipher API which is intended to replace the ablkcipher and blkcipher API. This patch adds the skcipher API documentation to the DocBook, updates the code sample (including removing the blkcipher example) replaces the references to ablkcipher and blkcipher with

[PATCH 1/4] Documentation: crypto - add akcipher API

2016-02-16 Thread Stephan Mueller
Reference the new akcipher API calls in the kernel crypto API DocBook. Also, fix the comments in the akcipher.h file: double dashes do not look good in the DocBook; fix a typo. Signed-off-by: Stephan Mueller --- Documentation/DocBook/crypto-API.tmpl | 23

[PATCH 0/4] Documentation: crypto API documentation updates

2016-02-16 Thread Stephan Mueller
Hi, This patch set updates the kernel crypto API documentation. Due to recent updates to the API, the documentation needs to be synchronized with the reality. The output of the DocBook with these patches is found in [1]. Herbert: The documentation in include/crypto/skcipher.h references

[PATCH 2/4] Documentation: crypto - add crypto_rng_generate

2016-02-16 Thread Stephan Mueller
Add new crypto API call crypto_rng_generate to DocBook. Signed-off-by: Stephan Mueller --- Documentation/DocBook/crypto-API.tmpl | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/DocBook/crypto-API.tmpl b/Documentation/DocBook/crypto-API.tmpl index

[PATCH 3/4] Documentation: crypto - update AEAD AD handling

2016-02-16 Thread Stephan Mueller
The associated data handling with the kernel crypto API has been updated. This needs to be reflected in the documentation. Signed-off-by: Stephan Mueller --- Documentation/DocBook/crypto-API.tmpl | 1 - include/crypto/aead.h | 6 +++--- 2 files changed, 3

Re: [PATCH v2 0/2] crypto: asynchronous compression api

2016-02-16 Thread Herbert Xu
On Tue, Feb 09, 2016 at 05:31:07PM +, Giovanni Cabiddu wrote: > > Changes in v2: > - added compression and decompression request sizes in acomp_alg > in order to enable noctx support > - extended api with helpers to allocate compression and > decompression requests with

Re: [PATCH 0/4] Documentation: crypto API documentation updates

2016-02-16 Thread Herbert Xu
On Tue, Feb 16, 2016 at 11:31:26AM +0100, Stephan Mueller wrote: > Hi, > > This patch set updates the kernel crypto API documentation. Due to recent > updates to the API, the documentation needs to be synchronized with the > reality. > > The output of the DocBook with these patches is found in

Re: [PATCH] crypto: implement DH primitives under akcipher API

2016-02-16 Thread Herbert Xu
On Mon, Feb 15, 2016 at 09:01:55AM +, Salvatore Benedetto wrote: > Implement Diffie-Hellman primitives required by the scheme under the > akcipher API. Here is how it works. > 1) Call set_pub_key() by passing DH parameters (p,g) in PKCS3 format > 2) Call set_priv_key() to set your own private

Re: [PATCH] crypto: caam - Staticize caam_jr_shutdown()

2016-02-16 Thread Herbert Xu
On Sun, Feb 14, 2016 at 01:08:21PM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > caam_jr_shutdown() is only used in this file, so it can be > made static. > > This avoids the following sparse warning: > > drivers/crypto/caam/jr.c:68:5: warning: symbol

Re: [PATCH] crypto: qat - fix leak on error path

2016-02-16 Thread Herbert Xu
On Wed, Feb 10, 2016 at 02:59:44PM -0800, Tadeusz Struk wrote: > Fix a leak on error path in qat asym > > Reported-by: Salvatore Benedetto > Signed-off-by: Tadeusz Struk Appiled. -- Email: Herbert Xu Home

Re: [PATCH v2 1/2] dt/bindings: Add bindings for the PIC32 random number generator

2016-02-16 Thread Herbert Xu
On Mon, Feb 08, 2016 at 02:17:52PM -0700, Joshua Henderson wrote: > Document the devicetree bindings for the random number generator found > on Microchip PIC32 class devices. > > Signed-off-by: Joshua Henderson > Acked-by: Rob Herring All

Re: [PATCH 0/2] crypto: atmel-sha - fix .import()/.export() implementation

2016-02-16 Thread Herbert Xu
On Mon, Feb 08, 2016 at 04:26:47PM +0100, Cyrille Pitchen wrote: > This series of patches includes two fixes for the atmel-sha.c driver. > > The first one fixes the implementation of the import/export hooks, which > did not pass the recent updates in testmgr.c (partial update exercise). > The new

Re: [PATCH] crypto: mark authenticated ctr(aes) also as FIPS able

2016-02-16 Thread Herbert Xu
On Sat, Feb 06, 2016 at 11:53:07AM +0100, Marcus Meissner wrote: > (2nd try that adds missing , to build.) > > Signed-off-by: Marcus Meissner Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH v2] crypto: xts - consolidate sanity check for keys

2016-02-16 Thread Herbert Xu
On Tue, Feb 09, 2016 at 03:37:47PM +0100, Stephan Mueller wrote: > Hi, > > Changes v2: remove comment and remove FIPS ifdefs as requested by Ard > Biesheuvel Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH] crypto: qat - fix leak on error path

2016-02-16 Thread Tadeusz Struk
On 02/16/2016 12:20 PM, Herbert Xu wrote: > On Wed, Feb 10, 2016 at 02:59:44PM -0800, Tadeusz Struk wrote: >> > Fix a leak on error path in qat asym >> > >> > Reported-by: Salvatore Benedetto >> > Signed-off-by: Tadeusz Struk > Appiled.

Re: [PATCH] crypto: implement DH primitives under akcipher API

2016-02-16 Thread Tadeusz Struk
On 02/16/2016 12:19 PM, Herbert Xu wrote: > On Mon, Feb 15, 2016 at 09:01:55AM +, Salvatore Benedetto wrote: >> > Implement Diffie-Hellman primitives required by the scheme under the >> > akcipher API. Here is how it works. >> > 1) Call set_pub_key() by passing DH parameters (p,g) in PKCS3

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-16 Thread Tadeusz Struk
Hi David, On 02/11/2016 02:08 AM, David Howells wrote: > David Howells wrote: > >> > Tadeusz Struk wrote: >> > > > > Why didn't you put the RSA signature parsing - ie. where the OID and > > > the other > > > bits are checked - into

[cryptodev:master 95/101] arch/arm/crypto/aesbs-glue.c:94:2: error: implicit declaration of function 'xts_check_key'

2016-02-16 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: ba871e1d299154953dcee23590c0316283897261 commit: 28856a9e52c7cac712af6c143de04766617535dc [95/101] crypto: xts - consolidate sanity check for keys config: arm-multi_v7_defconfig (attached as .config)

[cryptodev:master 95/101] arch/s390/crypto/aes_s390.c:592:2: error: implicit declaration of function 'xts_check_key'

2016-02-16 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: ba871e1d299154953dcee23590c0316283897261 commit: 28856a9e52c7cac712af6c143de04766617535dc [95/101] crypto: xts - consolidate sanity check for keys config: s390-performance_defconfig (attached as

Re: [PATCH] X.509: Fix test for self-signed certificate

2016-02-16 Thread lee joey
2016-02-11 21:34 GMT+08:00 Michal Marek : > If either the Subject + subjectKeyId or the Issuer + Serial number > differs between the certificate and the CA, the certificate is not > self-signed. In practice, both will be equal for self-signed > certificates and both will differ

[PATCH] crypto: fix compile errors of XTS

2016-02-16 Thread Stephan Mueller
Commit 28856a9e52c7 missed the addition of the crypto/xts.h include file for different architecture-specific AES implementations. Signed-off-by: Stephan Mueller --- arch/arm/crypto/aes-ce-glue.c | 1 + arch/arm/crypto/aesbs-glue.c | 1 +

Re: [PATCH] crypto: qat - fix leak on error path

2016-02-16 Thread Herbert Xu
On Tue, Feb 16, 2016 at 12:23:19PM -0800, Tadeusz Struk wrote: > On 02/16/2016 12:20 PM, Herbert Xu wrote: > > On Wed, Feb 10, 2016 at 02:59:44PM -0800, Tadeusz Struk wrote: > >> > Fix a leak on error path in qat asym > >> > > >> > Reported-by: Salvatore Benedetto

Re: [PATCH] crypto: fix compile errors of XTS

2016-02-16 Thread Herbert Xu
On Wed, Feb 17, 2016 at 07:00:01AM +0100, Stephan Mueller wrote: > Commit 28856a9e52c7 missed the addition of the crypto/xts.h include file > for different architecture-specific AES implementations. > > Signed-off-by: Stephan Mueller Applied. -- Email: Herbert Xu