Re: [PATCH v3] crypto: algapi - make crypto_xor() and crypto_inc() alignment agnostic

2017-02-13 Thread Jason A. Donenfeld
On Sun, Feb 5, 2017 at 11:06 AM, Ard Biesheuvel wrote: > + if (IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) || > + !((unsigned long)b & (__alignof__(*b) - 1))) Why not simply use the IS_ALIGNED macro? Also, are you might consider checking to see

[PATCH v4 4/4] dt-bindings: Add DT bindings document for Broadcom SBA RAID driver

2017-02-13 Thread Anup Patel
This patch adds the DT bindings document for newly added Broadcom SBA RAID driver. Signed-off-by: Anup Patel Reviewed-by: Ray Jui Reviewed-by: Scott Branden --- .../devicetree/bindings/dma/brcm,iproc-sba.txt | 29

[PATCH v4 0/4] Broadcom SBA RAID support

2017-02-13 Thread Anup Patel
The Broadcom SBA RAID is a stream-based device which provides RAID5/6 offload. It requires a SoC specific ring manager (such as Broadcom FlexRM ring manager) to provide ring-based programming interface. Due to this, the Broadcom SBA RAID driver (mailbox client) implements DMA device having one

[bug report] crypto: brcm - Add Broadcom SPU driver

2017-02-13 Thread Dan Carpenter
Hello Rob Rice, The patch 9d12ba86f818: "crypto: brcm - Add Broadcom SPU driver" from Feb 3, 2017, leads to the following static checker warning: drivers/crypto/bcm/cipher.c:2340 ahash_finup() warn: 'tmpbuf' was already freed. drivers/crypto/bcm/cipher.c 2316

Re: [PATCH v3 3/4] dmaengine: Add Broadcom SBA RAID driver

2017-02-13 Thread Anup Patel
On Fri, Feb 10, 2017 at 11:20 PM, Dan Williams wrote: > On Fri, Feb 10, 2017 at 1:07 AM, Anup Patel wrote: >> The Broadcom stream buffer accelerator (SBA) provides offloading >> capabilities for RAID operations. This SBA offload engine is >>

Re: [PATCH v3 3/4] dmaengine: Add Broadcom SBA RAID driver

2017-02-13 Thread Anup Patel
On Mon, Feb 13, 2017 at 2:43 PM, Anup Patel wrote: > On Fri, Feb 10, 2017 at 11:20 PM, Dan Williams > wrote: >> On Fri, Feb 10, 2017 at 1:07 AM, Anup Patel wrote: >>> The Broadcom stream buffer accelerator (SBA)

[PATCH] crypto: fix typo in doc

2017-02-13 Thread Gilad Ben-Yossef
Fix a single letter typo in api-skcipher.rst. Signed-off-by: Gilad Ben-Yossef --- Documentation/crypto/api-skcipher.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/crypto/api-skcipher.rst b/Documentation/crypto/api-skcipher.rst index

[PATCH v4 3/4] dmaengine: Add Broadcom SBA RAID driver

2017-02-13 Thread Anup Patel
The Broadcom stream buffer accelerator (SBA) provides offloading capabilities for RAID operations. This SBA offload engine is accessible via Broadcom SoC specific ring manager. This patch adds Broadcom SBA RAID driver which provides one DMA device with RAID capabilities using one or more Broadcom

[PATCH v4 2/4] async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome()

2017-02-13 Thread Anup Patel
The DMA_PREP_FENCE is to be used when preparing Tx descriptor if output of Tx descriptor is to be used by next/dependent Tx descriptor. The DMA_PREP_FENSE will not be set correctly in do_async_gen_syndrome() when calling dma->device_prep_dma_pq() under following conditions: 1. ASYNC_TX_FENCE not

[PATCH v4 1/4] lib/raid6: Add log-of-2 table for RAID6 HW requiring disk position

2017-02-13 Thread Anup Patel
The raid6_gfexp table represents {2}^n values for 0 <= n < 256. The Linux async_tx framework pass values from raid6_gfexp as coefficients for each source to prep_dma_pq() callback of DMA channel with PQ capability. This creates problem for RAID6 offload engines (such as Broadcom SBA) which take

Re: [PATCH v4 0/3] Add Broadcom SPU Crypto Driver

2017-02-13 Thread Jon Mason
On Sat, Feb 11, 2017 at 5:54 AM, Herbert Xu wrote: > On Fri, Feb 03, 2017 at 12:55:31PM -0500, Rob Rice wrote: >> Changes in v4: >> - Added Rob Herring's Acked-by to patch 1/3 for bindings doc >> - In response to Herbert's comment, in ahash_export() and >>

Qualcomm QCE driver: XTS setkey only allows 128 bit AES

2017-02-13 Thread Stephan Müller
Hi, The Qualcomm QCE driver implementation defines: .flags = QCE_ALG_AES | QCE_MODE_XTS, .name = "xts(aes)", .drv_name = "xts-aes-qce", .blocksize = AES_BLOCK_SIZE, .ivsize =

Re: [PATCH] lz4: fix performance regressions

2017-02-13 Thread Sven Schmidt
On Sun, Feb 12, 2017 at 10:41:17PM +0100, Willy Tarreau wrote: > On Sun, Feb 12, 2017 at 04:20:00PM +0100, Sven Schmidt wrote: > > On Sun, Feb 12, 2017 at 02:05:08PM +0100, Willy Tarreau wrote: > > > Hi Sven, > > > > > > On Sun, Feb 12, 2017 at 12:16:18PM +0100, Sven Schmidt wrote: > > > > Fix

Re: [PATCH v7 0/5] Update LZ4 compressor module

2017-02-13 Thread Sven Schmidt
On Mon, Feb 13, 2017 at 09:03:24AM +0900, Minchan Kim wrote: > Hi Sven, > > On Sun, Feb 12, 2017 at 12:16:17PM +0100, Sven Schmidt wrote: > > > > > > > > On 02/10/2017 01:13 AM, Minchan Kim wrote: > > > Hello Sven, > > > > > > On Thu, Feb 09, 2017 at 11:56:17AM +0100, Sven Schmidt wrote: > >

[PATCH] hw_random: update help description for omap-rng

2017-02-13 Thread Russell King
omap-rng also supports Marvell Armada 7k/8k SoCs, but no mention of this is made in the help text, despite the dependency being added. Explicitly mention these SoCs in the help description so people know that it covers more than just TI SoCs. Fixes: 383212425c92 ("hwrng: omap - Add device variant

Re: [PATCH v3 3/4] dmaengine: Add Broadcom SBA RAID driver

2017-02-13 Thread Anup Patel
On Fri, Feb 10, 2017 at 11:20 PM, Dan Williams wrote: > On Fri, Feb 10, 2017 at 1:07 AM, Anup Patel wrote: >> The Broadcom stream buffer accelerator (SBA) provides offloading >> capabilities for RAID operations. This SBA offload engine is >>

Re: crypto: NULL deref in sha512_mb_mgr_get_comp_job_avx2

2017-02-13 Thread Tim Chen
On Sat, 2017-02-11 at 18:50 +0800, Herbert Xu wrote: > On Wed, Feb 01, 2017 at 10:45:02AM -0800, Tim Chen wrote: > > > > > > One theory that Mehga and I have is that perhaps the flusher > > and regular computaion updates are stepping on each other.  > > Can you try this patch and see if it

[PATCH v3 0/2] crypto: AF_ALG memory management fix

2017-02-13 Thread Stephan Müller
Hi Herbert, Changes v3: * in *_pull_tsgl: make sure ctx->processed cannot be less than zero * perform fuzzing of all input parameters with bogus values Changes v2: * import fix from Harsh Jain to remove SG from list before freeing * fix return code used for ki_complete to

[PATCH v3 2/2] crypto: aead AF_ALG - overhaul memory management

2017-02-13 Thread Stephan Müller
The updated memory management is described in the top part of the code. As one benefit of the changed memory management, the AIO and synchronous operation is now implemented in one common function. The AF_ALG operation uses the async kernel crypto API interface for each cipher operation. Thus, the

[PATCH v3 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-02-13 Thread Stephan Müller
The updated memory management is described in the top part of the code. As one benefit of the changed memory management, the AIO and synchronous operation is now implemented in one common function. The AF_ALG operation uses the async kernel crypto API interface for each cipher operation. Thus, the

Re: [PATCH] lz4: fix performance regressions

2017-02-13 Thread Willy Tarreau
On Mon, Feb 13, 2017 at 12:53:49PM +0100, Sven Schmidt wrote: > On Sun, Feb 12, 2017 at 10:41:17PM +0100, Willy Tarreau wrote: > > On Sun, Feb 12, 2017 at 04:20:00PM +0100, Sven Schmidt wrote: > > > On Sun, Feb 12, 2017 at 02:05:08PM +0100, Willy Tarreau wrote: > > > > Hi Sven, > > > > > > > > On