Re: [PATCH 1/6] virtio: wrap find_vqs

2017-03-30 Thread Michael S. Tsirkin
On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote: > > > On 2017年03月30日 04:48, Michael S. Tsirkin wrote: > > We are going to add more parameters to find_vqs, let's wrap the call so > > we don't need to tweak all drivers every time. > > > > Signed-off-by: Michael S.

Re: [PATCH v5 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-03-30 Thread Stephan Müller
Am Donnerstag, 16. März 2017, 10:52:48 CEST schrieb Herbert Xu: Hi Herbert, > More importantly, with the current code, a very large recvmsg > would still work by doing it piecemeal. With your patch, won't > it fail because sock_kmalloc could fail to allocate memory for > the whole thing? For

Re: [PATCH] crypto: vmx: Remove dubiously licensed crypto code

2017-03-30 Thread Paulo Flabiano Smorigo
On 2017-03-29 20:08, Tyrel Datwyler wrote: On 03/29/2017 08:13 AM, Michal Suchánek wrote: On Wed, 29 Mar 2017 16:51:35 +0200 Greg Kroah-Hartman wrote: On Wed, Mar 29, 2017 at 02:56:39PM +0200, Michal Suchanek wrote: While reviewing commit 11c6e16ee13a ("crypto:

[PATCH] crypto: gf128mul - define gf128mul_x_ble in gf128mul.h

2017-03-30 Thread Ondrej Mosnacek
The gf128mul_x_ble function is currently defined in gf128mul.c, because it depends on the gf128mul_table_be multiplication table. However, since the function is very small and only uses two values from the table, it is better for it to be defined as inline function in gf128mul.h. That way, the

Re: [PATCH] crypto: gf128mul - define gf128mul_x_ble in gf128mul.h

2017-03-30 Thread Eric Biggers
Hi Ondrej, On Thu, Mar 30, 2017 at 09:25:35PM +0200, Ondrej Mosnacek wrote: > The gf128mul_x_ble function is currently defined in gf128mul.c, because > it depends on the gf128mul_table_be multiplication table. > > However, since the function is very small and only uses two values from > the

RE: [RFC TLS Offload Support 00/15] cover letter

2017-03-30 Thread Boris Pismenny
> >> TLS Tx crypto offload is a new feature of network devices. It enables > >> the kernel TLS socket to skip encryption and authentication > >> operations on the transmit side of the data path, delegating those to > >> the NIC. In turn, the NIC encrypts packets that belong to an > >> offloaded

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-03-30 Thread Cornelia Huck
On Wed, 29 Mar 2017 23:48:44 +0300 "Michael S. Tsirkin" wrote: > We are going to add more parameters to find_vqs, let's wrap the call so > we don't need to tweak all drivers every time. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/block/virtio_blk.c

Re: [PATCH] crypto: gf128mul - define gf128mul_x_ble in gf128mul.h

2017-03-30 Thread Ondrej Mosnáček
Hi Eric, 2017-03-30 21:55 GMT+02:00 Eric Biggers : > This is an improvement; I'm just thinking that maybe this should be done for > all > the gf128mul_x_*() functions, if only so that they use a consistent style and > are all defined next to each other. Right, that doesn't

[PATCH v2] crypto: gf128mul - define gf128mul_x_* in gf128mul.h

2017-03-30 Thread Ondrej Mosnacek
The gf128mul_x_ble function is currently defined in gf128mul.c, because it depends on the gf128mul_table_be multiplication table. However, since the function is very small and only uses two values from the table, it is better for it to be defined as inline function in gf128mul.h. That way, the

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-03-30 Thread Jason Wang
On 2017年03月30日 04:48, Michael S. Tsirkin wrote: We are going to add more parameters to find_vqs, let's wrap the call so we don't need to tweak all drivers every time. Signed-off-by: Michael S. Tsirkin --- A quick glance and it looks ok, but what the benefit of this series,

Re: [PATCH v2] crypto: gf128mul - define gf128mul_x_* in gf128mul.h

2017-03-30 Thread Eric Biggers
On Fri, Mar 31, 2017 at 12:04:42AM +0200, Ondrej Mosnacek wrote: > The gf128mul_x_ble function is currently defined in gf128mul.c, because > it depends on the gf128mul_table_be multiplication table. > > However, since the function is very small and only uses two values from > the table, it is

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-03-30 Thread Jason Wang
On 2017年03月30日 22:32, Michael S. Tsirkin wrote: On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote: On 2017年03月30日 04:48, Michael S. Tsirkin wrote: We are going to add more parameters to find_vqs, let's wrap the call so we don't need to tweak all drivers every time. Signed-off-by: