Why care about signal when instantiate an crypt template

2014-04-11 Thread Fan Du
Hi, I recently bump into a issue, ike daemon got interrupted(EINTR), after looking at the code, it seems there are places in crypto code where returning EINTR when current tasks has signal pending. For example: crypto_alloc_base and crypto_alloc_tfm 435 err: 436 if (err !=

Re: [PATCH v2 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

2014-04-11 Thread Marek Vasut
On Friday, April 11, 2014 at 07:10:24 AM, Sonic Zhang wrote: From: Sonic Zhang sonic.zh...@analog.com in case of multiple crc devices are probed. Call platform_set_drvdata() before adding new CRC device into the list. Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- v2-chagnes: -

[PATCH v3 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

2014-04-11 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com in case of multiple crc devices are probed. Call platform_set_drvdata() before adding new CRC device into the list. Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- v3-change: - check list_is_singular() before register the algorithm

Re: [PATCH v3 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

2014-04-11 Thread Marek Vasut
On Friday, April 11, 2014 at 11:30:25 AM, Sonic Zhang wrote: From: Sonic Zhang sonic.zh...@analog.com in case of multiple crc devices are probed. Call platform_set_drvdata() before adding new CRC device into the list. Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- v3-change: -

Re: Fwd: [crypto:master 60/60] arch/x86/crypto/ghash-clmulni-intel_glue.c:71:25: sparse: cast to restricted __be64

2014-04-11 Thread gre...@linuxfoundation.org
On Fri, Apr 04, 2014 at 10:11:19AM +0200, Ard Biesheuvel wrote: Greg, This pertains to commit 8ceee72808d1 (crypto: ghash-clmulni-intel - use C implementation for setkey()) that has been pulled by Linus during the current merge window. It is missing two things: - a cc to stable

[PATCH v4 2/6] header file for DRBG

2014-04-11 Thread Stephan Mueller
Changes v4: * change return codes of generate functions to signed int to convey error codes and to match the kernel crypto API expecations on the generate function. Signed-off-by: Stephan Mueller smuel...@chronox.de --- create mode 100644 include/crypto/drbg.h diff --git

Re: [PATCH v4 1/6] SP800-90A Deterministic Random Bit Generator

2014-04-11 Thread Joe Perches
On Fri, 2014-04-11 at 20:07 +0200, Stephan Mueller wrote: Changes v4: * change return codes of generate functions to signed int to convey error codes and to match the kernel crypto API expecations on the generate function. * add BUG_ON throughout drbg_healthcheck_sanity() since any

Re: [PATCH v4 1/6] SP800-90A Deterministic Random Bit Generator

2014-04-11 Thread Stephan Mueller
Am Freitag, 11. April 2014, 11:20:21 schrieb Joe Perches: Hi Joe, It looks like const could be used a bit more often. For instance: perhaps uses of key could be changed to const unsigned char *key Good point. I will try to find areas where const can be used. However, due to the use of

Re: Fwd: [crypto:master 60/60] arch/x86/crypto/ghash-clmulni-intel_glue.c:71:25: sparse: cast to restricted __be64

2014-04-11 Thread Ard Biesheuvel
On 11 April 2014 18:03, gre...@linuxfoundation.org gre...@linuxfoundation.org wrote: On Fri, Apr 04, 2014 at 10:11:19AM +0200, Ard Biesheuvel wrote: Greg, This pertains to commit 8ceee72808d1 (crypto: ghash-clmulni-intel - use C implementation for setkey()) that has been pulled by Linus

Re: [PATCH 5/9] crypto: qce: Adds sha and hmac transforms

2014-04-11 Thread Stephen Boyd
On 04/10, Stanimir Varbanov wrote: On 04/09/2014 03:09 AM, Stephen Boyd wrote: On 04/03, Stanimir Varbanov wrote: + + return 0; +} + +static int qce_ahash_import(struct ahash_request *req, const void *in) +{ + struct qce_sha_reqctx *rctx = ahash_request_ctx(req); + u32

Re: Fwd: [crypto:master 60/60] arch/x86/crypto/ghash-clmulni-intel_glue.c:71:25: sparse: cast to restricted __be64

2014-04-11 Thread gre...@linuxfoundation.org
On Fri, Apr 11, 2014 at 09:48:42PM +0200, Ard Biesheuvel wrote: On 11 April 2014 18:03, gre...@linuxfoundation.org gre...@linuxfoundation.org wrote: On Fri, Apr 04, 2014 at 10:11:19AM +0200, Ard Biesheuvel wrote: Greg, This pertains to commit 8ceee72808d1 (crypto: ghash-clmulni-intel -