Re: [PATCH v2 0/2] crypto: qat - Fix for invalid dma mapping and numa

2014-10-15 Thread Nikolay Aleksandrov
On 14/10/14 03:24, Tadeusz Struk wrote: Hi, These two patches fix invalid (zero length) dma mapping and enforce numa configuration for maximum performance. Change log: v2 - Removed numa node calculation based bus number and use predefined functions instead. Signed-off-by: Tadeusz Struk

Re: [PATCH v2 0/2] crypto: qat - Fix for invalid dma mapping and numa

2014-10-15 Thread Prarit Bhargava
On 10/15/2014 06:35 AM, Nikolay Aleksandrov wrote: On 14/10/14 03:24, Tadeusz Struk wrote: Hi, These two patches fix invalid (zero length) dma mapping and enforce numa configuration for maximum performance. Change log: v2 - Removed numa node calculation based bus number and use predefined

Re: [PATCH v2 2/2] crypto: caam - add support for rfc4106(gcm(aes))

2014-10-15 Thread Tudor Ambarus
On 10/14/2014 12:17 PM, Tudor Ambarus wrote: +static int rfc4106_setkey(struct crypto_aead *aead, + const u8 *key, unsigned int keylen) +{ + struct caam_ctx *ctx = crypto_aead_ctx(aead); + struct device *jrdev = ctx-jrdev; + int ret = 0; + + /*

Re: [PATCH v2 0/2] crypto: qat - Fix for invalid dma mapping and numa

2014-10-15 Thread Tadeusz Struk
On 10/15/2014 04:25 AM, Prarit Bhargava wrote: I just gave a quick run of these patches and they seem to fix the NUMA issue and the 0 length warnings. Tested-by: Nikolay Aleksandrov niko...@redhat.com Thanks Nik :) Reviewed-by: Prarit Bhargava pra...@redhat.com Thank you Nik and

Re: [PATCH] kernel crypto API interface specification

2014-10-15 Thread Jason Cooper
Stephan, Wow. This is very thorough. Herbert and others will be making the final call on this, but if I may make a suggestion: On Tue, Oct 14, 2014 at 09:46:50PM +0200, Stephan Mueller wrote: The update adds a complete interface documentation of the kernel crypto API. All cipher types

[cryptodev PATCH] qat: cleanup coccicheck warning - NULL check before freeing functions

2014-10-15 Thread Bruce Allan
Analyzing with coccinelle MODE=report... Please check for false positives in the output before submitting a patch. When using patch mode, carefully review the patch before submitting it. drivers/crypto/qat/qat_dh895xcc/adf_isr.c:191:3-8: WARNING: NULL check before freeing functions like kfree,

[cryptodev PATCH] qat: cleanup unnecessary break checkpatch warning

2014-10-15 Thread Bruce Allan
WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return #472: FILE: drivers/crypto/qat/qat_common/qat_algs.c:472: + goto bad_key; + break; Signed-off-by: Bruce Allan bruce.w.al...@intel.com --- drivers/crypto/qat/qat_common/qat_algs.c |1 - 1 file

[cryptodev PATCH] qat: fix bad unlock balance

2014-10-15 Thread Bruce Allan
The mutex table_lock is unlocked in two functions without first being locked. Fix the functions to properly protect the accel_table with the table_lock. Also, fix a spelling error in one of the function's header comment. Signed-off-by: Bruce Allan bruce.w.al...@intel.com ---