Re: net: Remove iocb argument from sendmsg and recvmsg

2015-03-11 Thread Tadeusz Struk
On 03/10/2015 09:02 PM, David Miller wrote: Because of the way you quoted the patch, it looked like a list posting looping back to the list again, because of the List-ID: email header. Therefore your posting was blocked and you'll have to resend your posting in a way such that this

Re: [PATCH 0/2] crypto: talitos: Add AES-XTS mode

2015-03-11 Thread Horia Geantă
On 3/9/2015 5:08 PM, Martin Hicks wrote: On Mon, Mar 9, 2015 at 6:16 AM, Horia Geantă horia.gea...@freescale.com wrote: On 3/3/2015 7:44 PM, Martin Hicks wrote: On Tue, Mar 3, 2015 at 10:44 AM, Horia Geantă horia.gea...@freescale.com wrote: For talitos, there are two cases: 1. request

Re: [PATCH 2/4] hwrng: omap - remove #ifdefery around PM methods

2015-03-11 Thread Dmitry Torokhov
Hi Herbert, On Wed, Mar 11, 2015 at 09:59:57PM +1100, Herbert Xu wrote: On Mon, Mar 09, 2015 at 10:36:36AM -0700, Dmitry Torokhov wrote: Instead of using #ifdefs let's mark suspend and resume methods as __maybe_unused which will suppress compiler warnings about them being unused and

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread David Miller
From: Sasha Levin sasha.le...@oracle.com Date: Wed, 11 Mar 2015 09:39:33 -0400 On 03/11/2015 08:40 AM, Steven Rostedt wrote: On Wed, 11 Mar 2015 08:34:46 -0400 Sasha Levin sasha.le...@oracle.com wrote: Fair enough. We knew there are existing kmemcheck users, but KASan should be

[PATCH 0/15] don't export static symbol

2015-03-11 Thread Julia Lawall
These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on static functions. This was done using the following semantic patch: (http://coccinelle.lip6.fr/) // smpl @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL; @@

Re: net: Remove iocb argument from sendmsg and recvmsg

2015-03-11 Thread Tadeusz Struk
On 03/10/2015 09:06 PM, David Miller wrote: From: Ying Xue ying@windriver.com Date: Wed, 11 Mar 2015 11:18:01 +0800 Sorry, I did not realize the case when I created the commit. However, although I don't understand its scenario, in my opinion, adding one redundant argument for all

[PATCH 4/15] crypto: don't export static symbol

2015-03-11 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL_GPL; @@ -EXPORT_SYMBOL_GPL(f); // /smpl Signed-off-by:

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread David Miller
From: Andrey Ryabinin ryabinin@gmail.com Date: Wed, 11 Mar 2015 23:01:00 +0300 2015-03-11 21:44 GMT+03:00 David Miller da...@davemloft.net: From: Sasha Levin sasha.le...@oracle.com Date: Wed, 11 Mar 2015 13:25:47 -0400 You're probably wondering why there are changes to SPARC in that

Re: [PATCH 2/4] hwrng: omap - remove #ifdefery around PM methods

2015-03-11 Thread Herbert Xu
On Wed, Mar 11, 2015 at 08:44:07AM -0700, Dmitry Torokhov wrote: SIMPLE_DEV_PM_OPS() produces an empty omap_rng_pm structure in case of !CONFIG_PM_SLEEP so neither omap_rng_suspend nor omap_rng_resume will end up being referenced. OK, could you please resend this patch? Thanks, -- Email:

[RESEND PATCH] hwrng: omap - remove #ifdefery around PM methods

2015-03-11 Thread Dmitry Torokhov
Instead of using #ifdefs let's mark suspend and resume methods as __maybe_unused which will suppress compiler warnings about them being unused and provide better compile coverage. Because SIMPLE_DEV_PM_OPS() produces an empty omap_rng_pm structure in case of !CONFIG_PM_SLEEP neither

Re: [PATCH 2/4] hwrng: omap - remove #ifdefery around PM methods

2015-03-11 Thread Dmitry Torokhov
On Thu, Mar 12, 2015 at 08:00:35AM +1100, Herbert Xu wrote: On Wed, Mar 11, 2015 at 08:44:07AM -0700, Dmitry Torokhov wrote: SIMPLE_DEV_PM_OPS() produces an empty omap_rng_pm structure in case of !CONFIG_PM_SLEEP so neither omap_rng_suspend nor omap_rng_resume will end up being

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread Sasha Levin
On 03/11/2015 01:20 PM, David Miller wrote: From: Sasha Levin sasha.le...@oracle.com Date: Wed, 11 Mar 2015 09:39:33 -0400 On 03/11/2015 08:40 AM, Steven Rostedt wrote: On Wed, 11 Mar 2015 08:34:46 -0400 Sasha Levin sasha.le...@oracle.com wrote: Fair enough. We knew there are

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread David Miller
From: Sasha Levin sasha.le...@oracle.com Date: Wed, 11 Mar 2015 13:25:47 -0400 You're probably wondering why there are changes to SPARC in that patchset? :) Libsanitizer doesn't even build have the time on sparc, the release manager has to hand patch it into building again every major release

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread Andrey Ryabinin
2015-03-11 21:44 GMT+03:00 David Miller da...@davemloft.net: From: Sasha Levin sasha.le...@oracle.com Date: Wed, 11 Mar 2015 13:25:47 -0400 You're probably wondering why there are changes to SPARC in that patchset? :) Libsanitizer doesn't even build have the time on sparc, the release

[PATCH RFC 2/4] aio: prefer aio_op op over iter_op

2015-03-11 Thread Tadeusz Struk
AIO interface should prefer AIO operations over iter_op Signed-off-by: Tadeusz Struk tadeusz.st...@intel.com --- fs/aio.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index f8e52a1..389f4dd 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1449,11

[PATCH RFC 3/4] crypto: af_alg - Allow to link sgl

2015-03-11 Thread Tadeusz Struk
From: Tadeusz Struk tadeusz.st...@intel.com Allow to link af_alg sgls. Signed-off-by: Tadeusz Struk tadeusz.st...@intel.com --- crypto/af_alg.c | 18 +- include/crypto/if_alg.h |4 +++- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/crypto/af_alg.c

[PATCH RFC 1/4] net: socket: add support for async operations

2015-03-11 Thread Tadeusz Struk
Add support for async operations. Signed-off-by: Tadeusz Struk tadeusz.st...@intel.com --- include/linux/net.h |6 + net/socket.c| 64 +++ 2 files changed, 70 insertions(+) diff --git a/include/linux/net.h b/include/linux/net.h

[PATCH RFC 4/4] crypto: algif - change algif_skcipher to be asynchronous

2015-03-11 Thread Tadeusz Struk
From: Tadeusz Struk tadeusz.st...@intel.com The way the algif_skcipher works currently is that on sendmsg/sendpage it builds an sgl for the input data and then on read/recvmsg it sends the job for encryption putting the user to sleep till the data is processed. This way it can only handle one job

[PATCH RFC 0/4] Add support for async socket operations

2015-03-11 Thread Tadeusz Struk
After the iocb parameter has been removed from sendmsg() and recvmsg() ops the socket layer, and the network stack no longer support async operations. This patch set adds support for asynchronous operations on sockets back. -- Tadeusz Struk (4): net: socket: add support for async operations

[PATCH] crypto: algif_rng - zeroize buffer holding random data

2015-03-11 Thread Stephan Mueller
Due to the change to RNGs to always return zero in success case, the RNG interface must zeroize the buffer with the length provided by the caller. Signed-off-by: Stephan Mueller smuel...@chronox.de --- crypto/algif_rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/4] hwrng: omap - remove #ifdefery around PM methods

2015-03-11 Thread Herbert Xu
On Mon, Mar 09, 2015 at 10:36:36AM -0700, Dmitry Torokhov wrote: Instead of using #ifdefs let's mark suspend and resume methods as __maybe_unused which will suppress compiler warnings about them being unused and provide better compile coverage. This will not increase image size.

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread Steven Rostedt
On Wed, 11 Mar 2015 08:34:46 -0400 Sasha Levin sasha.le...@oracle.com wrote: Fair enough. We knew there are existing kmemcheck users, but KASan should be superior both in performance and the scope of bugs it finds. It also shouldn't impose new limitations beyond requiring gcc 4.9.2+. Ouch!

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread Sasha Levin
On 03/11/2015 08:40 AM, Steven Rostedt wrote: On Wed, 11 Mar 2015 08:34:46 -0400 Sasha Levin sasha.le...@oracle.com wrote: Fair enough. We knew there are existing kmemcheck users, but KASan should be superior both in performance and the scope of bugs it finds. It also shouldn't

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread Sasha Levin
On 03/11/2015 08:19 AM, Steven Rostedt wrote: I removed the Cc list as it was so large, I'm sure that it exceeded the LKML Cc size limit, and your email probably didn't make it to the list (or any of them). Thanks. I'll resend in a bit if it doesn't show up on lkml.org. On Wed, 11 Mar 2015

[PATCH] crypto: testmgr - fix RNG return code enforcement

2015-03-11 Thread Alexander Bergmann
From 0c7233769665f03e9f91342770dba7279f928c23 Mon Sep 17 00:00:00 2001 From: Stephan Mueller smuel...@chronox.de Date: Tue, 10 Mar 2015 17:00:36 +0100 Subject: [PATCH] crypto: testmgr - fix RNG return code enforcement Due to the change to RNGs to always return zero in success case, the invocation

[PATCH V4 0/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-11 Thread James Hartley
This adds support for the Imagination Technologies hash accelerator which provides hardware acceleration for SHA1 SHA244 SHA256 and MD5 hashes. Tested on silicon, using testmgr. Changes from V3: * Standardised the cra_priorities to 300, sufficient to be chosen ahead of

Re: linux-next: Tree for Mar 11 (powerpc build failure due to vmx crypto code)

2015-03-11 Thread Herbert Xu
On Wed, Mar 11, 2015 at 07:43:22PM -0700, Guenter Roeck wrote: It looks like the perl scripts do run - I see the .S files, and I do see .o files created. But I still get the error. Looking into the object files, I see $ nm vmx-crypto.o | grep aes_p8_cbc_encrypt 0680 t

RE: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-11 Thread James Hartley
Hi Andrew, -Original Message- From: abres...@google.com [mailto:abres...@google.com] On Behalf Of Andrew Bresticker Sent: 10 March 2015 18:02 To: James Hartley Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

Re: linux-next: Tree for Mar 11 (powerpc build failure due to vmx crypto code)

2015-03-11 Thread Herbert Xu
On Wed, Mar 11, 2015 at 08:51:32PM -0700, Guenter Roeck wrote: Yes, this helps. Feel free to add Tested-by: Guenter Roeck li...@roeck-us.net Thanks for testing and the quick feedback. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread Sasha Levin
On 03/11/2015 10:26 AM, Steven Rostedt wrote: There's no real hurry to kill kmemcheck right now, but we do want to stop supporting that in favour of KASan. Understood, but the kernel is suppose to support older compilers. Perhaps we can keep kmemcheck for now and say it's obsoleted if you

Re: [PATCH] crypto: qat - remove incorrect __exit markup

2015-03-11 Thread Herbert Xu
On Mon, Mar 09, 2015 at 01:25:49PM -0700, Dmitry Torokhov wrote: PCI bus is hot-pluggable, and even if it wasn't one can still unbind the device from driver via sysfs, so we should not make driver's remove method as __exit. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com Applied.

Re: [PATCH] crypto: tcrypt - fix uninit sg entries in test_acipher_speed

2015-03-11 Thread Herbert Xu
On Mon, Mar 09, 2015 at 04:14:58PM +0200, Horia Geanta wrote: Commit 5be4d4c94b1f (crypto: replace scatterwalk_sg_next with sg_next) did not consider the fact that scatterwalk_sg_next() was looking at sg entry length, while sg_next() looks at the chained sg bit. This should have no effect in

Re: [PATCH 1/4] hwrng: omap - remove incorrect __exit markups

2015-03-11 Thread Herbert Xu
On Mon, Mar 09, 2015 at 10:36:35AM -0700, Dmitry Torokhov wrote: Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread Dave Jones
On Wed, Mar 11, 2015 at 09:39:33AM -0400, Sasha Levin wrote: On 03/11/2015 08:40 AM, Steven Rostedt wrote: On Wed, 11 Mar 2015 08:34:46 -0400 Sasha Levin sasha.le...@oracle.com wrote: Fair enough. We knew there are existing kmemcheck users, but KASan should be superior

[PATCH V4 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-11 Thread James Hartley
This adds support for the Imagination Technologies hash accelerator which provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes. Signed-off-by: James Hartley james.hart...@imgtec.com --- drivers/crypto/Kconfig| 14 + drivers/crypto/Makefile |1 +

[PATCH V4 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2015-03-11 Thread James Hartley
This adds the binding documentation for the Imagination Technologies hash accelerator that provides hardware acceleration for SHA1/SHA224/SHA256/MD5 hashes. This hardware will be present in the upcoming pistachio SoC. Signed-off-by: James Hartley james.hart...@imgtec.com ---

Re: linux-next: Tree for Mar 11 (powerpc build failure due to vmx crypto code)

2015-03-11 Thread Guenter Roeck
On 03/11/2015 06:23 PM, Herbert Xu wrote: On Wed, Mar 11, 2015 at 08:47:17AM -0700, Guenter Roeck wrote: Building powerpc:allmodconfig: ERROR: .aes_p8_cbc_encrypt [drivers/crypto/vmx/vmx-crypto.ko] undefined! ERROR: .aes_p8_set_encrypt_key [drivers/crypto/vmx/vmx-crypto.ko] undefined! ERROR: