On Wed, May 27, 2015 at 04:01:05PM +0800, Herbert Xu wrote:
Hi:
The only changes from the last version are that set_ad no longer
takes a cryptoff argument and testmgr has been updated to always
supply space for the authentication tag.
The algif_aead patch has been removed and will be
On Wed, May 27, 2015 at 12:10:03PM +0200, Stephan Mueller wrote:
-
-if (ctx-enc) {
-/* round up output buffer to multiple of block size */
-outlen = ((used + bs - 1) / bs * bs);
Why wouldn't the round up for the output not be needed any more? If the
caller
Hi Thomas, Boris,
On 27/05/2015 13:23, Thomas Petazzoni wrote:
Dear Gregory CLEMENT,
On Wed, 27 May 2015 12:20:49 +0200, Gregory CLEMENT wrote:
But is it really depending of the board itself?
I see that the first lines are the same on all the dts, I just remember that
there was a reason
On Mon, 25 May 2015 13:17:13 +0200, Boris Brezillon
boris.brezil...@free-electrons.com wrote:
Sorry, I didn't word it right - the series is missing the crypto nodes
for
the orion, 375 and 38x platforms.
I only add nodes for platforms I have tested on.
If you're able to test on those
On Wed, 2015-05-27 at 17:07 +0800, Herbert Xu wrote:
On Wed, May 27, 2015 at 11:00:40AM +0200, Johannes Berg wrote:
Right. Unfortunately, I can't typically rely on being able to make
changes to the kernel our driver is built against, and I don't think we
could do these changes otherwise.
On Wed, 2015-05-27 at 16:39 +0800, Herbert Xu wrote:
On Wed, May 27, 2015 at 10:15:50AM +0200, Johannes Berg wrote:
Do you think it'd be feasible at all to somehow override the
aead_request_set_crypt() and aead_request_set_ad() functions or so to do
something that works on older kernels
Am Mittwoch, 27. Mai 2015, 14:37:27 schrieb Herbert Xu:
Hi Herbert,
We need to call sg_init_table as otherwise the first entry may
inadvertently become the last.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
Although the following remark is to the previous patch to add
On Mon, May 25, 2015 at 02:45:16PM +1000, Cyril Bur wrote:
Selecting CRYPTO_DEV_NX causes a conditional include of nx/Kconfig but
options within nx/Kconfig do not depend on it. The included options should
depend on CRYPTO_DEV_NX since currently CRYPTO_DEV_NX cannot be built for
little endian.
tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
master
head: d725332208ef13241fc435eece790c9d0ea16a4e
commit: bb5530e4082446aac3a3d69780cd4dbfa4520013 [158/160] crypto:
jitterentropy - add jitterentropy RNG
config: i386-randconfig-r1-0527 (attached as .config)
On 05/27/2015 01:41 PM, Peter Ujfalusi wrote:
On 05/26/2015 05:44 PM, Greg Kroah-Hartman wrote:
On Tue, May 26, 2015 at 04:25:58PM +0300, Peter Ujfalusi wrote:
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. In case of error, return the error code we
On 05/26/2015 06:08 PM, Tony Lindgren wrote:
* Peter Ujfalusi peter.ujfal...@ti.com [150526 06:28]:
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. In case of error, return the error code we received including
-EPROBE_DEFER
Signed-off-by: Peter Ujfalusi
On Wed, May 27, 2015 at 11:00:40AM +0200, Johannes Berg wrote:
Right. Unfortunately, I can't typically rely on being able to make
changes to the kernel our driver is built against, and I don't think we
could do these changes otherwise.
You could provide your own version of crypto_aead_encrypt
On 26/05/2015 10:59, Boris Brezillon wrote:
On Mon, 25 May 2015 17:10:37 +0200
Gregory CLEMENT gregory.clem...@free-electrons.com wrote:
Hi Boris,
On 22/05/2015 15:34, Boris Brezillon wrote:
Enable the crypto IP on armada-xp-gp.
Signed-off-by: Boris Brezillon
Dear Gregory CLEMENT,
On Wed, 27 May 2015 12:20:49 +0200, Gregory CLEMENT wrote:
But is it really depending of the board itself?
I see that the first lines are the same on all the dts, I just remember that
there was a reason why we could not put it in the dtsi.
Yes, because the DT language
The conversion of in-tree users is fairly straightforward.
It is pretty much - but a related question (that you totally don't have
to answer if you don't want to think about this).
I'm going to have to (continue) backport(ing) this code to older kernels
for customer support, and I prefer
On Wed, May 27, 2015 at 10:15:50AM +0200, Johannes Berg wrote:
Do you think it'd be feasible at all to somehow override the
aead_request_set_crypt() and aead_request_set_ad() functions or so to do
something that works on older kernels (and thus older crypto subsystems)
or do you think I just
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Note that the user-space interface now requires both input and
output to be of the same length, and both must include space for
the AD as well as the authentication tag.
On Wed, May 27, 2015 at 05:43:05PM +0800, Herbert Xu wrote:
Tom Lendacky thomas.lenda...@amd.com wrote:
Scatter gather lists can be created with more available entries than are
actually used (e.g. using sg_init_table() to reserve a specific number
of sg entries, but in actuality using
On Wed, May 27, 2015 at 11:00:55AM +0200, Stephan Mueller wrote:
Shouldn't there be a check for src == NULL here? I see the scatterwalk_ffwd
being used in the IV generators where they simply use the AD len and others.
For AF_ALG, those values may be set by user space in a deliberately wrong
On Wed, May 27, 2015 at 05:29:22PM +0800, Herbert Xu wrote:
On Wed, May 27, 2015 at 11:25:33AM +0200, Steffen Klassert wrote:
Not sure if I missed something in the flood of patches, but if I
apply your v3 patchset on top of the cryptodev tree, it crashes
like that buring boot:
Sorry,
On Tue, May 26, 2015 at 01:06:13PM -0500, Tom Lendacky wrote:
The following patches are included in this driver update series:
- Remove the checking and setting of the device dma_mask field
- Remove an unused field from a structure to help avoid any confusion
- Protect against poorly marked
Mark,
On 05/26/2015 06:27 PM, Mark Brown wrote:
On Tue, May 26, 2015 at 04:26:06PM +0300, Peter Ujfalusi wrote:
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. Only fall back to pio mode if the error code returned is not
-EPROBE_DEFER, otherwise return
Am Mittwoch, 27. Mai 2015, 17:24:41 schrieb Herbert Xu:
Hi Herbert,
-
- if (ctx-enc) {
- /* round up output buffer to multiple of block size */
- outlen = ((used + bs - 1) / bs * bs);
Why wouldn't the round up for the output not be needed any more? If the caller
On 05/26/2015 05:44 PM, Greg Kroah-Hartman wrote:
On Tue, May 26, 2015 at 04:25:58PM +0300, Peter Ujfalusi wrote:
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. In case of error, return the error code we received including
-EPROBE_DEFER
I think you typed
Am Mittwoch, 27. Mai 2015, 17:08:55 schrieb Herbert Xu:
Hi Herbert,
On Wed, May 27, 2015 at 11:00:55AM +0200, Stephan Mueller wrote:
Shouldn't there be a check for src == NULL here? I see the scatterwalk_ffwd
being used in the IV generators where they simply use the AD len and
others.
For
On Wed, May 27, 2015 at 01:24:48PM +0200, Stephan Mueller wrote:
To be precise, the concern I currently have are as follows. But I will test
it
later and report back:
The seqiv.c uses the following call:
scatterwalk_ffwd(dstbuf, req-dst,
The patch removes the use of timekeeping_valid_for_hres which is now
marked as internal for the time keeping subsystem. The jitterentropy
does not really require this verification as a coarse timer (when
random_get_entropy is absent) is discovered by the initialization test
of jent_entropy_init,
On 05/26/2015 07:31 PM, Dan Williams wrote:
[ adding Boaz as this discussion has implications for ore_raid ]
You're not talking about deprecating it, you're talking about removing
it entirely.
True, and adding more users makes that removal more difficult. I'm
willing to help out on the
These patches are meant to try and address the fact the VTI tunnels are
currently overwriting the skb-mark value. I am generally happy with the
first two patches, however the third patch still modifies the skb-mark,
though it undoes after the fact.
The main problem I am trying to address is the
On 05/27/2015 04:43 AM, Herbert Xu wrote:
Tom Lendacky thomas.lenda...@amd.com wrote:
Scatter gather lists can be created with more available entries than are
actually used (e.g. using sg_init_table() to reserve a specific number
of sg entries, but in actuality using something less than that
On 05/27/2015 04:45 AM, Herbert Xu wrote:
On Wed, May 27, 2015 at 05:43:05PM +0800, Herbert Xu wrote:
Tom Lendacky thomas.lenda...@amd.com wrote:
Scatter gather lists can be created with more available entries than are
actually used (e.g. using sg_init_table() to reserve a specific number
of
This change makes it so that if a tunnel is defined we just use the mark
from the tunnel instead of the mark from the skb header. By doing this we
can avoid the need to set skb-mark inside of the tunnel receive functions.
Signed-off-by: Alexander Duyck alexander.h.du...@redhat.com
---
The vti6_rcv_cb and vti_rcv_cb calls were leaving the skb-mark modified
after completing the function. This resulted in the original skb-mark
value being lost. Since we only need skb-mark to be set for
xfrm_policy_check we can pull the assignment into the rcv_cb calls and then
just restore the
Instead of modifying skb-mark we can simply modify the flowi_mark that is
generated as a result of the xfrm_decode_session. By doing this we don't
need to actually touch the skb-mark and it can be preserved as it passes
out through the tunnel.
Signed-off-by: Alexander Duyck
On Tue, May 26, 2015 at 04:26:06PM +0300, Peter Ujfalusi wrote:
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. Only fall back to pio mode if the error code returned is not
-EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER.
Acked-by: Mark
On Tue, May 26, 2015 at 04:26:08PM +0300, Peter Ujfalusi wrote:
dmaengine provides a wrapper function to handle DT and non DT boots when
requesting DMA channel. Use that instead of checking for of_node in the
platform driver.
Acked-by: Mark Brown broo...@kernel.org
signature.asc
Description:
On Wed, May 27, 2015 at 02:15:12PM +0300, Peter Ujfalusi wrote:
I have put the maintainers of the relevant subsystems as CC in the commit
message and sent the series to all of the mailing lists. This series was
touching 7 subsystems and I thought not spamming every maintainer with all the
This change makes it so that we use icmpv6_send to report PMTU issues back
into tunnels in the case that the resulting packet is larger than the MTU
of the outgoing interface. Previously xfrm_local_error was being used in
this case, however this was resulting in no changes, I suspect due to the
Hi:
Previously the AD was required to exist in both the source and
destination buffers. This creates a rather confusing situation
where the destination served as both input as well as output.
This series rectifies by allowing the destination to contain
the AD (e.g., it always does for in-place
We need to call sg_init_table as otherwise the first entry may
inadvertently become the last.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/scatterwalk.c |1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/scatterwalk.c b/crypto/scatterwalk.c
index 8690324..2ef9cbb
This patch makes use of the new common IV generation code.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/seqiv.c | 92 ++---
1 file changed, 36 insertions(+), 56 deletions(-)
diff --git a/crypto/seqiv.c b/crypto/seqiv.c
This patch fixes a bug in the context size calculation where we
were still referring to the old cra_aead.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/echainiv.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/echainiv.c b/crypto/echainiv.c
This patch makes use of the new common IV generation code.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/echainiv.c | 230 --
1 file changed, 18 insertions(+), 212 deletions(-)
diff --git a/crypto/echainiv.c
This patch defines the behaviour of AD in the new interface more
clearly. In particular, it specifies that if the user must copy
the AD to the destination manually when src != dst if they wish
to guarantee that the destination buffer contains a copy of the
AD.
The reason for this is that
This patch fixes a bug in the context size calculation where we
were still referring to the old cra_aead.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/seqiv.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/seqiv.c b/crypto/seqiv.c
index
On module unload we weren't unregistering the seqniv template,
thus leading to a crash the next time someone walks the template
list.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/seqiv.c |1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/seqiv.c b/crypto/seqiv.c
This patch adds some common IV generation code currently duplicated
by seqiv and echainiv. For example, the setkey and setauthsize
functions are completely identical.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/aead.c | 205
This patch tries to preserve in-place processing in old_crypt as
various algorithms are optimised for in-place processing where
src == dst.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/aead.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
As the AD does not necessarily exist in the destination buffer
it must be copied along with the plain text.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/echainiv.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/crypto/echainiv.c
As the AD does not necessarily exist in the destination buffer
it must be copied along with the plain/cipher text.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/seqiv.c | 33 ++---
1 file changed, 6 insertions(+), 27 deletions(-)
diff --git
On Wed, May 27, 2015 at 07:16:37AM -0700, Alexander Duyck wrote:
These patches are meant to try and address the fact the VTI tunnels are
currently overwriting the skb-mark value. I am generally happy with the
first two patches, however the third patch still modifies the skb-mark,
though it
On Wed, May 27, 2015 at 09:12:02AM -0500, Tom Lendacky wrote:
The reason I'm asking is because while this patch fixes your driver
everybody else will still crash and burn should something like this
happen again.
A number of other drivers already have similar sg-count functions in
them.
On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote:
This change makes it so that we use icmpv6_send to report PMTU issues back
into tunnels in the case that the resulting packet is larger than the MTU
of the outgoing interface. Previously xfrm_local_error was being used in
this
On Sat, May 23, 2015 at 07:20:15AM -0700, Tadeusz Struk wrote:
The length would be redundant. It can be obtained by sg_nents(reg-inparams)
I don't limit the number of parameters. You can pass as many as you want. For
instance to pass 3 in and 2 out you do:
struct scatterlist in[3];
On Thu, May 28, 2015 at 12:49:19PM +0800, Herbert Xu wrote:
On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote:
This change makes it so that we use icmpv6_send to report PMTU issues back
into tunnels in the case that the resulting packet is larger than the MTU
of the outgoing
This reverts commit f858c7bcca8c20761a20593439fe998b4b67e86b as
the algif_aead interface has been switched over to the new AEAD
interface.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 0ff4cd4..af011a9 100644
--- a/crypto/Kconfig
+++
On Wed, May 27, 2015 at 01:50:12PM +0200, Stephan Mueller wrote:
The patch removes the use of timekeeping_valid_for_hres which is now
marked as internal for the time keeping subsystem. The jitterentropy
does not really require this verification as a coarse timer (when
random_get_entropy is
On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote:
This change makes it so that we use icmpv6_send to report PMTU issues back
into tunnels in the case that the resulting packet is larger than the MTU
of the outgoing interface. Previously xfrm_local_error was being used in
this
On Tue, May 26, 2015 at 03:41:10PM -0700, Alexander Duyck wrote:
These patches are meant to try and address the fact the VTI tunnels are
currently overwriting the skb-mark value. I am generally happy with the
first two patches, however the third patch still modifies the skb-mark,
though it
On Tue, May 26, 2015 at 03:41:10PM -0700, Alexander Duyck wrote:
These patches are meant to try and address the fact the VTI tunnels are
currently overwriting the skb-mark value. I am generally happy with the
first two patches, however the third patch still modifies the skb-mark,
though it
Hi:
The only changes from the last version are that set_ad no longer
takes a cryptoff argument and testmgr has been updated to always
supply space for the authentication tag.
The algif_aead patch has been removed and will be posted separately.
Series description:
This series of patches convert
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Tested-by: Johannes Berg johan...@sipsolutions.net
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
net/mac80211/aes_ccm.c | 30
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text. The
IV generation is also now carried out through normal AEAD methods.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
net/ipv6/esp6.c | 200
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/tcrypt.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/testmgr.c | 87 ++-
1 file changed, 48
This patch adds IV generator information for each AEAD and block
cipher to xfrm_algo_desc. This will be used to access the new
AEAD interface.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
include/net/xfrm.h |2 ++
net/xfrm/xfrm_algo.c | 16
2 files
This patch adds IV generator information to xfrm_state. This
is currently obtained from our own list of algorithm descriptions.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
include/net/xfrm.h |1 +
net/key/af_key.c |1 +
net/xfrm/xfrm_user.c | 40
67 matches
Mail list logo
