RE:

2017-02-23 Thread Qin's Yanjun
How are you today and your family? I require your attention and honest co-operation about some issues which i will really want to discuss with you which. Looking forward to read from you soon. Qin's __ Sky Silk, http://aknet.kz

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Joe Perches
On Thu, 2017-02-23 at 17:41 +, Emil Velikov wrote: > On 23 February 2017 at 17:18, Joe Perches wrote: > > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > > > > There are ~4300 uses of

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Emil Velikov
On 23 February 2017 at 17:18, Joe Perches wrote: > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: >> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: >> > There are ~4300 uses of pr_warn and ~250 uses of the older >> > pr_warning in the kernel source

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Joe Perches
On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > > There are ~4300 uses of pr_warn and ~250 uses of the older > > pr_warning in the kernel source tree. > > > > Make the use of pr_warn consistent across all kernel

Re: crypto: hang in crypto_larval_lookup

2017-02-23 Thread Harald Freudenberger
On 02/23/2017 12:39 PM, Herbert Xu wrote: > On Thu, Feb 23, 2017 at 07:19:57PM +0800, Herbert Xu wrote: >> Harald Freudenberger wrote: >>> Hello all >>> >>> I am currently following a hang at modprobe aes_s390 where >>> crypto_register_alg() does not come back for the

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Rob Herring
On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate >

Re: [PATCH 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-02-23 Thread Marcelo Cerri
It makes sense. Thanks for the clarification, Herbert. One more question: are you planning to convert the ctr template to skcipher? -- Regards, Marcelo On Thu, Feb 23, 2017 at 07:21:56PM +0800, Herbert Xu wrote: > Marcelo Cerri wrote: > > > > I noticed you used a

Crypto Update for 4.11

2017-02-23 Thread Herbert Xu
Hi Linus: Here is the crypto update for 4.11: API: - Try to catch hash output overrun in testmgr. - Introduce walksize attribute for batched walking. - Make crypto_xor() and crypto_inc() alignment agnostic. Algorithms: - Add time-invariant AES algorithm. - Add standalone CBCMAC algorithm.

Re: [PATCH] crypto: Add ECB dependency for XTS mode

2017-02-23 Thread Herbert Xu
On Thu, Feb 23, 2017 at 08:38:26AM +0100, Milan Broz wrote: > Since the >commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 >crypto: xts - Convert to skcipher > the XTS mode is based on ECB, so the mode must select > ECB otherwise it can fail to initialize. > > Signed-off-by: Milan Broz

Re: crypto/cavium MSI-X fixups

2017-02-23 Thread Herbert Xu
On Wed, Feb 15, 2017 at 08:18:40AM +0100, Christoph Hellwig wrote: > Hi George, > > your commit "crypto: cavium - Add Support for Octeon-tx CPT Engine" > add a new caller to pci_enable_msix. This API has long been deprecated > so this series switches it to use pci_alloc_irq_vectors instead. > >

Re: crypto: hang in crypto_larval_lookup

2017-02-23 Thread Herbert Xu
Harald Freudenberger wrote: > > Hello all > > I am currently following a hang at modprobe aes_s390 where > crypto_register_alg() does not come back for the xts(aes) algorithm. > > The registration is waiting forever in algapi.c crypto_wait_for_test() but > the

Re: crypto: hang in crypto_larval_lookup

2017-02-23 Thread Herbert Xu
On Thu, Feb 23, 2017 at 07:19:57PM +0800, Herbert Xu wrote: > Harald Freudenberger wrote: > > > > Hello all > > > > I am currently following a hang at modprobe aes_s390 where > > crypto_register_alg() does not come back for the xts(aes) algorithm. > > > > The

Re: [PATCH 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-02-23 Thread Herbert Xu
Paulo Flabiano Smorigo wrote: > >fallback = > - crypto_alloc_blkcipher(alg, 0, CRYPTO_ALG_NEED_FALLBACK); > + crypto_alloc_skcipher(alg, 0, CRYPTO_ALG_NEED_FALLBACK); You need to add CRYPTO_ALG_ASYNC to the mask in order to ensure that

Re: [PATCH 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-02-23 Thread Herbert Xu
Marcelo Cerri wrote: > > I noticed you used a similar approach in arch/s390/crypto/aes_s390.c > (commit 64e2680). > > How do you ensure the skcipher operation will not be asynchronous? You need to set the bit CRYPTO_ALG_ASYNC in the mask field when allocating the