[PATCH 11/11] Fix ERROR: "foo* bar" should be "foo *bar"

From: Jhih-Ming Hunag Fixed 'ERROR: "foo* bar" should be "foo *bar"'. Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_aead.c

[PATCH 10/11] Fix ERROR: else should follow close brace '}'

From: Jhih-Ming Hunag Fixied "ERROR: else should follow close brace '}'". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c

[PATCH 08/11] Fix ERROR: space prohibited before open square bracket '['

From: Jhih-Ming Hunag Fixied "ERROR: space prohibited before open square bracket '['". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 09/11] Fix ERROR: space prohibited before that ','

From: Jhih-Ming Hunag Fixed "ERROR: space prohibited before that ','". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c

[PATCH 07/11] Fix ERROR: open brace '{' following function declarations go on the next line

From: Jhih-Ming Hunag Fixed "ERROR: open brace '{' following function declarations go on the next line". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 06/11] Fix ERROR: space prohibited before that close parenthesis ')'

From: Jhih-Ming Hunag Fixed "ERROR: space prohibited before that close parenthesis ')'". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff

[PATCH 05/11] Fix ERROR: space prohibited after that open parenthesis '('

From: Jhih-Ming Hunag Fixed "ERROR: space prohibited after that open parenthesis '('". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 04/11] Fix ERROR: that open brace { should be on the previous line

From: Jhih-Ming Hunag Fixed 'ERROR: that open brace { should be on the previous line'. Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 03/11] Fix ERROR: space required before the open brace

From: Jhih-Ming Hunag Fixed 'ERROR: space required before the open brace'. Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c

[PATCH 02/11] Fix ERROR: spaces required around that

From: Jhih-Ming Hunag Fixed 'ERROR: spaces required around that' Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c

[PATCH 01/11] Fix coding style of driver/staging/ccree/ssi_aead.c ERROR: space required after that

From: Jhih-Ming Hunag In this series patches, I fix all of the coding style error in driver/staging/ccree/ssi_aead.c from 54 errors to 0 error. The first patch fixed 'ERROR: space required after that'. Signed-off-by: Jhih-Ming Hunag ---

Re: [PATCH] crypto: caam: make of_device_ids const.

On Fri, Jun 16, 2017 at 02:46:44PM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: >text data

Re: [PATCH] crypto: vmx: remove unnecessary check

On Fri, Jun 16, 2017 at 11:39:48AM +0300, Tudor Ambarus wrote: > You can't reach init() if parent alg_name is invalid. Moreover, > cypto_alloc_base() will return ENOENT if alg_name is NULL. > Found while grasping the fallback mechanism. > > Signed-off-by: Tudor Ambarus

Re: [PATCH 00/13] crypto: inside-secure - various improvements

On Thu, Jun 15, 2017 at 09:56:16AM +0200, Antoine Tenart wrote: > Hi Herbert, > > This series improves the newly added inside-secure driver in various > ways. There are also a few non-critical fixes. > > The series is based on top of your cryptodev/master branch, as it > depends on the

Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"

On Tue, Jun 13, 2017 at 09:52:54AM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in seq_printf message > > Signed-off-by: Colin Ian King Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH 0/9] Bug fixes and ctr mode of operation

On Thu, Jun 15, 2017 at 12:43:38PM +0530, Harsh Jain wrote: > This series is based on cryptodev2.6 tree and includes bug fix ,ctr(aes), > rfc3686(ctr(aes)) algo. > > Harsh Jain (7): > crypto: chcr - Pass lcb bit setting to firmware > crypto: chcr - Set fallback key > crypto: chcr - Return

Re: [PATCH][crypto-next] crypto: omap-aes: fix spelling mistake "Encryptio" -> "Encryption"

On Tue, Jun 13, 2017 at 09:46:47AM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in pr_err message > > Signed-off-by: Colin Ian King Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622

On Mon, Jun 12, 2017 at 11:56:53PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Changes since v1: > - update the bindings with the specific "mediatek,mt7622-rng" > instead of the generic one as "mediatek,generic-rng" > > The series add support of hardware

Re: [PATCH] crypto: testmgr - add testvector for pkcs1pad(rsa)

On Mon, Jun 12, 2017 at 11:27:51PM +0200, Stephan Müller wrote: > The PKCS#1 RSA implementation is provided with a self test with RSA 2048 > and SHA-256. This self test implicitly covers other RSA keys and other > hashes. Also, this self test implies that the pkcs1pad(rsa) is FIPS > 140-2

Re: [PATCH] rsa-pkcs1pad: use constant time memory comparison for MACs

On Sun, Jun 11, 2017 at 11:20:23PM +0200, Jason A. Donenfeld wrote: > Otherwise, we enable all sorts of forgeries via timing attack. > > Signed-off-by: Jason A. Donenfeld > Suggested-by: Stephan Müller > Cc: sta...@vger.kernel.org > Cc: Herbert Xu

Re: [PATCH v6 1/5] Documentation/bindings: Document the SafeXel cryptographic engine driver

On Sun, Jun 11, 2017 at 10:53:53AM +0200, Antoine Tenart wrote: > Hi Herbert, > > On Wed, May 24, 2017 at 04:10:31PM +0200, Antoine Tenart wrote: > > The Inside Secure Safexcel cryptographic engine is found on some Marvell > > SoCs (7k/8k). Document the bindings used by its driver. > > > >

Re: [PATCH] crypto: crypto4xx - fix an error code

On Sat, Jun 10, 2017 at 02:54:33PM +0200, Christophe JAILLET wrote: > If 'kzalloc' fails, we return 0 which means success. > return -ENOMEM instead as already done a few lines above. > > Signed-off-by: Christophe JAILLET Patch applied. Thanks. -- Email: Herbert

Re: [PATCH v9 1/2] crypto: skcipher AF_ALG - overhaul memory management

On Sat, Jun 10, 2017 at 07:59:25PM +0200, Stephan Müller wrote: > > -static int skcipher_recvmsg_sync(struct socket *sock, struct msghdr *msg, > - int flags) > +static int skcipher_recvmsg(struct socket *sock, struct msghdr *msg, > + size_t

Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt

On Mon, Jun 19, 2017 at 10:31:27AM +, Horia Geantă wrote: > > IIUC, IV update is required only in case of CBC. > Since this callback is used also for CTR, we should avoid the copy: > if ((ctx->cdata.algtype & OP_ALG_AAI_MASK) == OP_ALG_AAI_CBC) ... No it is needed for CTR too. Cheers, --

Re: Reply Urgent

Hello, How are you doing? I have been sent to inform you that, We have an inheritance of a deceased client with your surname. Contact Mr Andrew Bailey Reply Email To: myinf...@gmail.com with your "Full Names" for more info. Thanks for your understanding. Reply ASAP thank you. Melissa.

Re: [PATCH] random: silence compiler warnings and fix race

Hello Ted, With rc6 already released and rc7 coming up, I'd really appreciate you stepping in here and either ACKing the above commit, or giving your two cents about it in case I need to roll something different. Thanks, Jason On Thu, Jun 15, 2017 at 12:45 AM, Jason A. Donenfeld

Re: [PATCH] random: silence compiler warnings and fix race

On Mon, Jun 19, 2017 at 9:45 AM, Sebastian Andrzej Siewior wrote: > ehm. You sure? I simply delayed the lock-dropping _after_ the state > variable was been modified. So it was basically what your patch did > except it was unlocked later… Yes, I'm sure. You moved the call

Re: [PATCH] hwrng: do not warn when there are no devices

On Mon, Jun 19, 2017 at 2:43 AM, PrasannaKumar Muralidharan wrote: > On 19 June 2017 at 11:51, Herbert Xu wrote: >> On Sun, Jun 18, 2017 at 10:00:17PM -0700, Mike Frysinger wrote: >>> >>> in order to make tpm-rng react in the way you're implying, the TPM >>> subsystem would need to add a

[PATCH] crypto: ccp - Release locks before returning

krobot warning: make sure that all error return paths release locks. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-debugfs.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/ccp-debugfs.c

Re: [PATCH v2 0/6] crypto: aes - allow generic AES to be omitted

On 19 June 2017 at 05:15, Eric Biggers wrote: > Hi Ard, > > On Fri, Jun 16, 2017 at 01:17:43PM +0200, Ard Biesheuvel wrote: >> The generic AES driver uses 16 lookup tables of 1 KB each, and has >> encryption and decryption routines that are fully unrolled. Given how >> the

[PATCH] crypto: cavium/nitrox - dma_mapping_error() returns bool

We want to return negative error codes here, but we're accidentally propogating the "true" return from dma_mapping_error(). Fixes: 14fa93cdcd9b ("crypto: cavium - Add support for CNN55XX adapters.") Signed-off-by: Dan Carpenter diff --git

Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt

On 6/2/2017 3:25 PM, David Gstir wrote: > Certain cipher modes like CTS expect the IV (req->info) of > ablkcipher_request (or equivalently req->iv of skcipher_request) to > contain the last ciphertext block when the {en,de}crypt operation is done. > This is currently not the case for the CAAM

Re: [PATCH] of: update ePAPR references to point to Devicetree Specification

On 06/18/17 07:05, Rob Herring wrote: > On Tue, Jun 13, 2017 at 07:49:04PM -0700, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> The Devicetree Specification has superseded the ePAPR as the >> base specification for bindings. Update files in Documentation >> to

Re: [PATCH] hwrng: do not warn when there are no devices

On 19 June 2017 at 11:51, Herbert Xu wrote: > On Sun, Jun 18, 2017 at 10:00:17PM -0700, Mike Frysinger wrote: >> >> in order to make tpm-rng react in the way you're implying, the TPM >> subsystem would need to add a notification chain for transitions from >>

[cryptodev:master 77/100] drivers/crypto/ccp/ccp-debugfs.c:303:3-9: preceding lock on line 299 (fwd)

Please check whether a lock is needed before line 303. julia -- Forwarded message -- Date: Mon, 19 Jun 2017 17:34:11 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [cryptodev:master 77/100]

[PATCH 2/2] crypto: caam - fix gfp allocation flags (part II)

This is the 2nd part of fixing the usage of GFP_KERNEL for memory allocations, taking care off all the places that haven't caused a real problem / failure. Again, the issue being fixed is that GFP_KERNEL should be used only when MAY_SLEEP flag is set, i.e. MAY_BACKLOG flag usage is orthogonal.

[PATCH 1/2] crypto: caam - fix gfp allocation flags (part I)

Changes in the SW cts (ciphertext stealing) code in commit 0605c41cc53ca ("crypto: cts - Convert to skcipher") revealed a problem in the CAAM driver: when cts(cbc(aes)) is executed and cts runs in SW, cbc(aes) is offloaded in CAAM; cts encrypts the last block in atomic context and CAAM incorrectly

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

On Mon, Jun 19, 2017 at 01:27:08PM +0800, Herbert Xu wrote: > On Tue, Jun 06, 2017 at 03:44:17PM +0200, Corentin Labbe wrote: > > The crypto engine could actually only enqueue hash and ablkcipher request. > > This patch permit it to enqueue skcipher requets by adding all necessary > > functions. >

Re: [PATCH] random: silence compiler warnings and fix race

On 2017-06-17 02:39:40 [+0200], Jason A. Donenfeld wrote: > On Fri, Jun 16, 2017 at 4:35 PM, Sebastian Andrzej Siewior > wrote: > > I wouldn't just push the lock one up as is but move that write part to > > crng_init to remain within the locked section. Like that: > > We

[PATCH] crypto: fix typo in docs

Signed-off-by: Benjamin Peterson --- Documentation/crypto/userspace-if.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/crypto/userspace-if.rst b/Documentation/crypto/userspace-if.rst index de5a72e32bc9..ff86befa61e0 100644 ---

Re: [PATCH v2 1/2] crypto: engine - replace pr_xxx by dev_xxx

On Tue, Jun 06, 2017 at 03:44:16PM +0200, Corentin Labbe wrote: > By adding a struct device *dev to struct engine, we could store the > device used at register time and so use all dev_xxx functions instead of > pr_xxx. > > Signed-off-by: Corentin Labbe Patch applied.

Re: [PATCH] crypto: brcm: fix spelling mistake: "fallbck" -> "fallback"

On Mon, Jun 05, 2017 at 10:10:48AM -0400, Steve Lin wrote: > On Sun, Jun 4, 2017 at 2:29 PM, Colin King wrote: > > From: Colin Ian King > > > > Trivial fix to spelling mistake in flow_log message > > > > Signed-off-by: Colin Ian King

Re: [PATCH] crypto: testmgr: use consistent format for errors

On Mon, Jun 05, 2017 at 08:33:43AM +0300, Gilad Ben-Yossef wrote: > Fix inconsistent format and spelling in hash tests error messages. > > Signed-off-by: Gilad Ben-Yossef Patch applied. Thanks. -- Email: Herbert Xu Home Page:

Re: [PATCH v3 00/13] ARM: sun5i: cryptographic engine support

On Thu, Jun 01, 2017 at 09:38:52PM +0200, Antoine Tenart wrote: > Hello, > > This series adds the cryptographic engine support to sun5i SoCs. This is > based on top of v4.12-rc1 and was tested on a CHIP. The series begins > with fixes and improvements. The series is available at: >

Re: [PATCH] crypto: algapi: Use pr_err common logging style.

Karim Eshapa wrote: > Use more common error logging style. > > Signed-off-by: Karim Eshapa Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH] crypto: algapi: Use pr_err common logging style.

Karim Eshapa wrote: > Use more common error logging style. > > Signed-off-by: Karim Eshapa karim.esh...@gmail.com -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH] Documentation: crypto: Fixed bugs, added example usage of calc_hash().

On Fri, May 12, 2017 at 05:38:02PM +0200, Kamil Konieczny wrote: > - Fixed bugs in example for shash and rng (added missing "*" and " *"). > - Corrected pr_info() in calc_hash(). > - Added example usage of calc_hash(). > - No need for negate PTR_ERR to get error code, as crypto_alloc_rng >

Re: [PATCH] crypto: glue_helper - Delete some dead code

On Wed, May 10, 2017 at 08:52:26AM +0300, Dan Carpenter wrote: > We checked (nbytes < bsize) inside the loops so it's not possible to hit > the "goto done;" here. This code is cut and paste from other slightly > different loops where we don't have the check inside the loop. > > Signed-off-by:

Re: [PATCH] crypto: mediatek - drop .owner field in mtk_crypto_driver

On Sat, May 06, 2017 at 11:35:29PM +0800, Geliang Tang wrote: > Drop .owner field in mtk_crypto_driver, since platform_driver_register() > will set it automatically. > > Signed-off-by: Geliang Tang Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH] crypto: aes_ti - fix comment for MixColumns step

On Tue, May 09, 2017 at 05:20:27PM -0700, Eric Biggers wrote: > From: Eric Biggers > > mix_columns() contains a comment which shows the matrix used by the > MixColumns step of AES, but the last entry in this matrix was incorrect > --- and did not match the code, which is

Re: [PATCH v2 0/3] Add more algorithms and some misc cleanups

On Thu, May 04, 2017 at 11:34:43AM +, George Cherian wrote: > This series adds more algorithem support for CPT. > Add support for > -ecb(aes) > -cfb(aes) > -ecb(des3_ede) > > Some cleanups too. > > George Cherian (3): > crypto: cavium: Downgrade the annoying misc

Re: [PATCH] drivers/crypto/ccp: return NULL instead of 0

On Wed, May 03, 2017 at 09:32:09AM +0530, Pushkar Jambhlekar wrote: > This change is to handle sparse warning. Return type of function is a pointer > to the structure and > it returns 0. Instead it should return NULL. > > Signed-off-by: Pushkar Jambhlekar Patch applied.

Re: [PATCH V2] crypto: ccp - Add debugfs entries for CCP information

On Tue, May 02, 2017 at 05:33:40PM -0500, Gary R Hook wrote: > Expose some data about the configuration and operation of the CCP > through debugfs entries: device name, capabilities, configuration, > statistics. > > Allow the user to reset the counters to zero by writing (any value) > to the

Re: [-next] crypto: 842 propagate PTR_ERR value instead of -ENOMEM

Zhang Shengju wrote: > It is better to propagate PTR_ERR value instead of a hardcoded > value(-ENOMEM here). > > Signed-off-by: Zhang Shengju ... > - return -ENOMEM; > + return PTR_ERR(ctx-wmem);

Re: [PATCH] hwrng: do not warn when there are no devices

On Sun, Jun 18, 2017 at 10:00:17PM -0700, Mike Frysinger wrote: > > in order to make tpm-rng react in the way you're implying, the TPM > subsystem would need to add a notification chain for transitions from > none<->some devices, then tpm-rng could subscribe to that, and during > those transition