Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt

Herbert, > On 20 Jun 2017, at 03:28, Herbert Xu wrote: > > On Mon, Jun 19, 2017 at 10:31:27AM +, Horia Geantă wrote: >> >> IIUC, IV update is required only in case of CBC. >> Since this callback is used also for CTR, we should avoid the copy: >> if

Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

Hi Stephan, Lee & Jason, (Adding target-devel CC') Apologies for coming late to the discussion. Comments below. On Sun, 2017-06-18 at 10:04 +0200, Stephan Müller wrote: > Am Samstag, 17. Juni 2017, 05:45:57 CEST schrieb Lee Duncan: > > Hi Lee, > > > In your testing, how long might a process

Re: encrypt_done called from interrupt context on rk3288 crypto driver

在 2017/6/23 16:37, Herbert Xu 写道: On Thu, May 25, 2017 at 10:38:13PM +0300, Emil Karlson wrote: Greetings It seems to me that rk3288 crypto driver calls encrypt_done from interrupt context which causes runtime tests to fail. Zain, can you please take a look at this? It is illegal to call

[PATCH v11 2/2] crypto: aead AF_ALG - overhaul memory management

The updated memory management is described in the top part of the code. As one benefit of the changed memory management, the AIO and synchronous operation is now implemented in one common function. The AF_ALG operation uses the async kernel crypto API interface for each cipher operation. Thus, the

[PATCH v11 0/2] crypto: AF_ALG memory management fix

Hi Herbert, Changes v11: - algif_skcipher: remove len < ctx->used in recvmsg as requested by Herbert and verified by the latest test code in libkcapi. - algif_skcipher/algif_aead: simplify _recvmsg error code path With the changes, you will see a lot of code duplication now as I deliberately

[PATCH v11 1/2] crypto: skcipher AF_ALG - overhaul memory management

The updated memory management is described in the top part of the code. As one benefit of the changed memory management, the AIO and synchronous operation is now implemented in one common function. The AF_ALG operation uses the async kernel crypto API interface for each cipher operation. Thus, the

Re: [PATCH v10 1/2] crypto: skcipher AF_ALG - overhaul memory management

Am Freitag, 23. Juni 2017, 11:06:30 CEST schrieb Stephan Müller: Hi Herbert, > Am Freitag, 23. Juni 2017, 08:10:48 CEST schrieb Herbert Xu: > > Hi Herbert, > > > On Wed, Jun 21, 2017 at 10:03:02PM +0200, Stephan Müller wrote: > > > + /* convert iovecs of output buffers into RX SGL */ > > > +

inquiry

-- Hello, My name is Khadov Amir Moh, a former resident of Birmingham UK. Please reach me for the details of an extremely important business proposition. Best regards, Khadov Amir Moh.

[PATCH v3 1/6] staging: ccree: fix hash import/export

Hash import and export was saving and restoring the wrong context and therefore disabled. Fix it by restoring intermediate digest and additional state needed. The hash and mac transform now pass testmgr partial hash tests. Signed-off-by: Gilad Ben-Yossef ---

[PATCH v3 2/6] staging: ccree: register setkey for none hash macs

The original ccree driver was registering a useless setkey method even for non-MAC hash transformations. Somewhere around v4.9 a check was added that failed hash operations if a setkey method was registered but was not called, so during the initial upstream port code was added to only register the

[PATCH v3 3/6] staging: ccree: remove unused function

The function set_ack_last was not used anywhere. Remove it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_hw_queue_defs.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h

[PATCH v3 6/6] staging: ccree: use signal safe completion wait

We were waiting for a completion notification of HW DMA operation using an interruptible wait which can result in data corruption if a signal interrupted us while DMA was not yet completed. Fix this by moving to uninterrupted wait. Fixes: abefd6741d ("staging: ccree: introduce CryptoCell HW

[PATCH v3 4/6] staging: ccree: add clock management support

Some SoC which implement CryptoCell have a dedicated clock tied to it, some do not. Implement clock support if exists based on device tree data and tie power management to it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Makefile | 2 +-

[PATCH v3 5/6] staging: ccree: add DT bus coherency detection

The ccree driver has build time configurable support to work on top of coherent (e.g. ACP) vs. none coherent bus connections. Turn it to run-time configurable option based on device tree. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig | 9

[PATCH v3 0/6] staging: ccree: bug fixes and TODO items for 4.13

An assortment of bug fixes and staging TODO items. Highlights includes the driver passing crypto testmgr boot tests and relying on device tree for various HW config options as opposed to build time configuration. CC: Dan Carpenter Gilad Ben-Yossef (6): staging:

Re: [PATCH v2 2/7] staging: ccree: register setkey for none hash macs

On Fri, Jun 23, 2017 at 7:29 PM, Greg Kroah-Hartman wrote: > On Thu, Jun 22, 2017 at 04:36:56PM +0300, Gilad Ben-Yossef wrote: >> Fix a bug where the transformation init code did >> not register a setkey method for none hash based MACs. > > "none hash based MACs"? Is

Re: [PATCH v2 1/7] staging: ccree: fix hash import/export

On Thu, Jun 22, 2017 at 4:58 PM, Dan Carpenter wrote: > On Thu, Jun 22, 2017 at 04:36:55PM +0300, Gilad Ben-Yossef wrote: >> static int ssi_ahash_export(struct ahash_request *req, void *out) >> { >> struct crypto_ahash *ahash = crypto_ahash_reqtfm(req); >>