Re: [RFT PATCH v2] crypto: arm64/gcm - implement native driver using v8 Crypto Extensions

2017-06-30 Thread Ard Biesheuvel
On 30 June 2017 at 11:32, Ard Biesheuvel wrote: > Currently, the AES-GCM implementation for arm64 systems that support the > ARMv8 Crypto Extensions is based on the generic GCM module, which combines > the AES-CTR implementation using AES instructions with the PMULL

Re: [PATCH v3 4/4] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

2017-06-30 Thread Logan Gunthorpe
On 30/06/17 12:18 AM, Horia Geantă wrote: > On 6/29/2017 7:10 PM, Logan Gunthorpe wrote: >> From: Horia Geantă >> >> We can now make use of the io-64-nonatomic-hi-lo header to always > Typo: we are using io-64-nonatomic-lo-hi, not hi-lo. Yup, thanks. I will fix this for a

Re: [PATCH] crypto: ccp-platform: print error message on platform_get_irq failure

2017-06-30 Thread Gary R Hook
On 06/30/2017 12:59 AM, Gustavo A. R. Silva wrote: Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva --- drivers/crypto/ccp/ccp-platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] crypto: Make hwrng choose rng source by quality.

2017-06-30 Thread Harald Freudenberger
On 06/30/2017 07:27 AM, PrasannaKumar Muralidharan wrote: > Hi Harald, > > Can you split this patch into two? One patch to choose rng based on > the quality and another for not overriding user decided rng. > > Some more minor comments below. > > On 29 June 2017 at 15:33, Harald Freudenberger >

[RFT PATCH v2] crypto: arm64/gcm - implement native driver using v8 Crypto Extensions

2017-06-30 Thread Ard Biesheuvel
Currently, the AES-GCM implementation for arm64 systems that support the ARMv8 Crypto Extensions is based on the generic GCM module, which combines the AES-CTR implementation using AES instructions with the PMULL based GHASH driver. This is suboptimal, given the fact that the input data needs to

[PATCH] crypto: omap-aes: fix error return code in omap_aes_probe()

2017-06-30 Thread Gustavo A. R. Silva
Propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva --- drivers/crypto/omap-aes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 5120a17..c376a3e 100644 ---

[PATCH] crypto: mxc-scc: fix error code in mxc_scc_probe()

2017-06-30 Thread Gustavo A. R. Silva
Print and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva --- drivers/crypto/mxc-scc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/mxc-scc.c b/drivers/crypto/mxc-scc.c index

[PATCH] crypto: omap-des: fix error return code in omap_des_probe()

2017-06-30 Thread Gustavo A. R. Silva
Print and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva --- drivers/crypto/omap-des.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c index

[PATCH] crypto: mxs-dcp: print error message on platform_get_irq failure

2017-06-30 Thread Gustavo A. R. Silva
Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva --- drivers/crypto/mxs-dcp.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c index

[PATCH] crypto: ccp-platform: print error message on platform_get_irq failure

2017-06-30 Thread Gustavo A. R. Silva
Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva --- drivers/crypto/ccp/ccp-platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/ccp-platform.c

[PATCH] crypto: mediatek: fix error return code in mtk_crypto_probe()

2017-06-30 Thread Gustavo A. R. Silva
Propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva --- drivers/crypto/mediatek/mtk-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/mediatek/mtk-platform.c

Re: [PATCH v3 4/4] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

2017-06-30 Thread Horia Geantă
On 6/29/2017 7:10 PM, Logan Gunthorpe wrote: > From: Horia Geantă > > We can now make use of the io-64-nonatomic-hi-lo header to always Typo: we are using io-64-nonatomic-lo-hi, not hi-lo. Thanks, Horia

Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-06-30 Thread Nicholas A. Bellinger
On Mon, 2017-06-26 at 19:38 +0200, Stephan Müller wrote: > Am Montag, 26. Juni 2017, 03:23:09 CEST schrieb Nicholas A. Bellinger: > > Hi Nicholas, > > > Hi Stephan, Lee & Jason, > > > > (Adding target-devel CC') > > > > Apologies for coming late to the discussion. Comments below. > > > > On